From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39EADCF9C6F for ; Mon, 23 Sep 2024 16:02:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6FDA6B008A; Mon, 23 Sep 2024 12:02:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1F8C6B008C; Mon, 23 Sep 2024 12:02:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC0D56B0092; Mon, 23 Sep 2024 12:02:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8AACE6B008A for ; Mon, 23 Sep 2024 12:02:56 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 347E91C6D59 for ; Mon, 23 Sep 2024 16:02:56 +0000 (UTC) X-FDA: 82596471552.21.A5CA881 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf14.hostedemail.com (Postfix) with ESMTP id B79BA100012 for ; Mon, 23 Sep 2024 16:02:53 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=dm2WjIpw; spf=pass (imf14.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.52 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727107339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U7TYhe1rpxxrqplqnvp9IfDZ+pr34hbFyuUI8EXCDkc=; b=M47FtUfW0W5OGpXnmXHkE6yLGM7IFXbja0uraQDS/RV3sz+nqqQLQ3jNOBZGe7HwXPRQKW VPcL/JGXrCEncpJoRYKFidZ7l9dhzYj5/FKdwKnQpLK9yrIQpLIaJh35C9rPfgP0To6HxO ZH1a0Js3NqPqLtFJfrpeopR9MQg1lwM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=dm2WjIpw; spf=pass (imf14.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.52 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727107339; a=rsa-sha256; cv=none; b=h+xlCOP2LdKzWsTMt2YYS8eiEmm2Litmgviqw70V0fJvQjakUeCK5wS5Yq5hIVfLJbrTha vtiLpu8dGKsprH70SSwWZ1vp0ZxEtWkQGvl9I4NikFXYwoSlUDYQQfo9QXkqEtCnp7MCR6 bNbzoiFCDhGf+hEF2vwm9ANnwSnD1W8= Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-82aa6be8457so147747639f.0 for ; Mon, 23 Sep 2024 09:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1727107373; x=1727712173; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U7TYhe1rpxxrqplqnvp9IfDZ+pr34hbFyuUI8EXCDkc=; b=dm2WjIpwfsLcaQpib+UD2xdpqxdoLz1YWfsqP3ZlgiHd9FXpN8IbSDZ9b0DKeF4ZVH MAIjE7IdWwqKuLrR2q7+Ia3q8cr13aXB7kOIpbW1bJSX7Ycb3bQumScr4+JpImPdrm8l XNk46rpYaUYpt81Ae+RgycHFvCv43kW7lpiDU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727107373; x=1727712173; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U7TYhe1rpxxrqplqnvp9IfDZ+pr34hbFyuUI8EXCDkc=; b=JhQUjfO4G87ihO9x8LVI+5bz/3nJgtd17Ntn1yAN9P+YqFbThMP7FlQShfiagKNzTq eMK+sJmmwCykcjvPCxlYkHsMiep0PjE11te7LpltT0WQC65nP17t6hLzz6CEoey4uycJ Kq2DPpkQ7PPgCzYDKOyJTmBQKw5ZEFa99CW+LE097UqMdYdDT8jXG5hZ786muGw3w6UM 60W7oH3lBbfsbheQJBVpl6jyCJ7FCbibvYy2oFQcp5Kq2lrha9TfgxJ0b1heaR9Gtdhy XyQtOQiTh9/7rsDPVbV9JSe+4jNwEngvpMGqzX7rFaCO92InQrWyK4tbJ28Kui2sLs3J gfiw== X-Forwarded-Encrypted: i=1; AJvYcCWPlWjNUoAuaArwdJj7Pl/GqbEo5GF5h1pWWDB1XiJEIz4KV0EIdf96uaZgtb/PJAnXgCRRLBafrg==@kvack.org X-Gm-Message-State: AOJu0YwU5wENrPb//St//0T1bAB0A4hav4sqXqHAY6CVPRLGX59cdsQI VJTd9DvIrHFCfKEzvDIjlCXl/T1leKgs9Wq8jVPBqBLMfDQX09D00GHkGMsLlns= X-Google-Smtp-Source: AGHT+IFbTlKf8TKMANszqjy1yElT6pwu6gCQvDIujsaJntV8C2slJwQVG9f9umm5t1EUKhexryb9bQ== X-Received: by 2002:a05:6602:2c93:b0:82c:f7b1:a9fb with SMTP id ca18e2360f4ac-8323b9df004mr10698439f.5.1727107372503; Mon, 23 Sep 2024 09:02:52 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-82d492b34b6sm560153439f.23.2024.09.23.09.02.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2024 09:02:51 -0700 (PDT) Message-ID: Date: Mon, 23 Sep 2024 10:02:49 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan , David Hildenbrand , Peter Xu , "Dr. David Alan Gilbert" , Andrea Arcangeli , Kim Phillips Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, John Hubbard , Shuah Khan References: <20240912103151.1520254-1-usama.anjum@collabora.com> <3cb9d266-4d4b-4031-8603-da7fd9e3ad47@collabora.com> <0b847784-a95f-4ed5-a0fb-1b7b4023df13@collabora.com> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: hfsprz1exx1ncgq9jr97bbztypyee649 X-Rspamd-Queue-Id: B79BA100012 X-Rspamd-Server: rspam11 X-HE-Tag: 1727107373-534809 X-HE-Meta: U2FsdGVkX19cMZXKeY+eLJkPKXiuJ1g7Z31yZsbd7+hj6pNn7L5GeH6FF9LwGTP646cEeR7CNmNVGC9h9vqEyBzN0rUEt8rAo9R6TaqAHG9TVulTqAVaON6gfmi0kX9TA14OgzOxAVoR087ER74Io4BDpU4Nf6KfG2tzwZTci05ipsIlCDURa7x00GuiG3rOiskIn9wwalEMj6krSQ58PUP3gijjD4QwHgPRdzhaDNDHKLscjzIwkWlaTNdzJmEMXiahP4SifKH0/xXoOaW0inIczIYK/pEvRKxDGwQEobuvyFWUO9sZc6xBiVtjdl4SepXrb1RZs78JevXrkErp6SjpGgZ3f0diTqNqTstp/dsUxx3VD8GpMXyROpVau+/RMIO2YyyqI0xLbShf8N42FxRXkBkRcwHU3SZiptr0XvpLH4DMc0Xh5OVN3x2eg3QzeGuR8K//jP/AD/27haDuqgKDfBR+v/aTWxIMs2xqnfgij6nwGaOVXPWBx9Uww5E8UVU6QGQLudenT0Zh7KWnAjZsWOO9ZuzscAnsiXqJPdCyjg4vkwDHNLW3+0KnPlOi6Yyx6OQOsDfOa6LVHKJXjsJp5mS8dA9NeTzoOFL57pee5tKm0ShUlTi9skn4uvQe4nV0qh5BXq5quHHdMs5+dRpMpvShzYYIcHFGTG4vXxQVvKlNP47XxsGGbT8FVZqqdIcKu4Bn58HwxMqX2DfIX9kX5JYdxrYlWJYHpy39FezMXbjTobE81izlxxOeFeQ2mrIaCH9MFa3kPjDsA1d0OVgNx9RDykcnBExKvWEDYdESzNqPMueNMtmyVIx93pm2KySGhrIjtu6g1t8wL7Gqrd7wwdDtvOGkn8wvooshltgakX2B60u7Kbl72yRKQvmJq6jaHpM0OIlvnfmTnANk1GroVYjoSpz+sepJSOwRQ//N132Tioo8mjcX25B+zArdaE8wZJSctU0i/nRpN/P 6AjdidGk HUJlrjEvq+hiXKptEjUOLAaBX3Yc0ChFgBKgyjxEqtxXMdwnDTXZv8/hXMUf4yX3tI29VIYJOxsnpIL4IXxC/yFCug9LdASqxflb4Tb5zZnpHchJcNNBg/O+wzxi3lI4bpr3vvGzFPo09VRTOTvdScKxOEgH9hbOec5T13Va3fasUKWcdtRAuVlHnnJmWXIpXmc0jngrTV/f3YebCLCbE7+ie09LRVsRjZEeT8LKVc9qvFxABYeXbQAfi0WKy50OVNhvPPU1LW61SiTXNnjWudFPGkq5+T74F01W/dgKu8Osi7C62dgWiU7DYuNeymiPHPw/y/iP7LyFyw9umApIEoP+iws4QeLLagqCTKC6Dn/Im5M68x9Sg6xSpi836Qo9RVwuvfBUKWhmrXmamXQpcgfkL4A/oOIMbVicdPJgny2OPkiw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/22/24 23:35, Muhammad Usama Anjum wrote: > ... > >>> grep -rnIF "#define __NR_userfaultfd" >>> tools/include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 >>> arch/x86/include/generated/uapi/asm/unistd_32.h:374:#define >>> __NR_userfaultfd 374 >>> arch/x86/include/generated/uapi/asm/unistd_64.h:327:#define >>> __NR_userfaultfd 323 >>> arch/x86/include/generated/uapi/asm/unistd_x32.h:282:#define >>> __NR_userfaultfd (__X32_SYSCALL_BIT + 323) >>> arch/arm/include/generated/uapi/asm/unistd-eabi.h:347:#define >>> __NR_userfaultfd (__NR_SYSCALL_BASE + 388) >>> arch/arm/include/generated/uapi/asm/unistd-oabi.h:359:#define >>> __NR_userfaultfd (__NR_SYSCALL_BASE + 388) >>> include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 >>> >>> The number is dependent on the architecture. The above data shows that: >>> x86    374 >>> x86_64    323 >> >> Correct and the generated header files do the right thing and it is good to >> include them as this patch does. >> >> This is a good find and fix. I wish you explained this in your changelog. >> Please add more details when you send v2. > I'm sending v2 > >> >> There could be other issues lurking based on what I found. >> >> The other two files are the problem where they hard code it to 282 without >> taking the __NR_SYSCALL_BASE for the arch into consideration: >> >> tools/include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 >> include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 >> >>> >>> I'm unable to find the history of why it is set to 282 in unistd.h and >>> when this problem happened. >> >> According to git history it is added in the following commit to >> include/uapi/asm-generic/unistd.h: >> >> 09f7298100ea9767324298ab0c7979f6d7463183 >> Subject: [PATCH] userfaultfd: register uapi generic syscall (aarch64) >> >> and it is added in the following commit to >> tools/include/uapi/asm-generic/unistd.h >> 34b009cfde2b8ce20a69c7bfd6bad4ce0e7cd970 >> Subject: [PATCH] tools include: Grab copies of arm64 dependent unistd.h >> files >> >> I think, the above defines from include/uapi/asm-generic/unistd.h and >> tools/include/uapi/asm-generic/unistd.h should be removed. >> >> Maybe others familiar with userfaultfd can determine the best course of >> action. >> We might have other NR_ defines in these two files that are causing >> problems >> for tests and tools that we haven't uncovered yet. > Added authors of these patches. > Thank you. Would you be able top follow up on this and send patches to remove these defines if it deemed to be the correct solution? thanks, -- Shuah