From: David Hildenbrand <david@redhat.com>
To: Zhang Chujun <zhangchujun@cmss.chinamobile.com>,
akpm@linux-foundation.org
Cc: vbabka@suse.cz, linux-mm@kvack.org
Subject: Re: [PATCH] mm/debug: fix missing space in case statement
Date: Mon, 3 Nov 2025 15:55:29 +0100 [thread overview]
Message-ID: <db6d8b2e-6941-4e90-b49d-7a37d4f80959@redhat.com> (raw)
In-Reply-To: <20251103065910.2196-1-zhangchujun@cmss.chinamobile.com>
On 03.11.25 07:59, Zhang Chujun wrote:
> In the setup_vm_debug() function, the case statement for 'p' option
> is written as 'case'p':' without a space between 'case' and the
> character constant. While this is syntactically valid C, it violates
> the Linux kernel coding style, which requires a space after 'case'.
> This patch adds the missing space to comply with coding standards.
>
> Signed-off-by: Zhang Chujun <zhangchujun@cmss.chinamobile.com>
>
> diff --git a/mm/debug.c b/mm/debug.c
> index 64ddb0c4b4be..d860864063be 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> @@ -327,7 +327,7 @@ static int __init setup_vm_debug(char *str)
>
> while (*str) {
> switch (tolower(*str)) {
> - case'p':
> + case 'p':
Acked-by: David Hildenbrand <david@redhat.com>
Surprised that this compiles.
--
Cheers
David
next prev parent reply other threads:[~2025-11-03 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 6:59 Zhang Chujun
2025-11-03 8:46 ` Dev Jain
2025-11-03 9:38 ` Vlastimil Babka
2025-11-03 14:55 ` David Hildenbrand [this message]
2025-11-03 16:25 ` Vishal Moola (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db6d8b2e-6941-4e90-b49d-7a37d4f80959@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=zhangchujun@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox