From: Vlastimil Babka <vbabka@suse.cz>
To: Roman Gushchin <guroan@gmail.com>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Johannes Weiner <hannes@cmpxchg.org>,
kernel-team@fb.com, Roman Gushchin <guro@fb.com>
Subject: Re: [PATCH 2/3] mm: separate memory allocation and actual work in alloc_vmap_area()
Date: Fri, 1 Mar 2019 15:43:19 +0100 [thread overview]
Message-ID: <db6b9745-7e64-6eb9-6b2b-da9d157a779b@suse.cz> (raw)
In-Reply-To: <20190225203037.1317-3-guro@fb.com>
On 2/25/19 9:30 PM, Roman Gushchin wrote:
> alloc_vmap_area() is allocating memory for the vmap_area, and
> performing the actual lookup of the vm area and vmap_area
> initialization.
>
> This prevents us from using a pre-allocated memory for the map_area
> structure, which can be used in some cases to minimize the number
> of required memory allocations.
Hmm, but that doesn't happen here or in the later patch, right? The only
caller of init_vmap_area() is alloc_vmap_area(). What am I missing?
> Let's keep the memory allocation part in alloc_vmap_area() and
> separate everything else into init_vmap_area().
>
> Signed-off-by: Roman Gushchin <guro@fb.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> Reviewed-by: Matthew Wilcox <willy@infradead.org>
next prev parent reply other threads:[~2019-03-01 14:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190225203037.1317-1-guro@fb.com>
2019-02-25 20:30 ` [PATCH 1/3] mm: refactor __vunmap() to avoid duplicated call to find_vm_area() Roman Gushchin
2019-02-28 15:00 ` Vlastimil Babka
2019-02-25 20:30 ` [PATCH 2/3] mm: separate memory allocation and actual work in alloc_vmap_area() Roman Gushchin
2019-03-01 14:43 ` Vlastimil Babka [this message]
2019-03-01 16:48 ` Roman Gushchin
2019-04-17 13:27 ` Vlastimil Babka
2019-04-17 19:15 ` Roman Gushchin
2019-02-25 20:30 ` [PATCH 3/3] mm: show number of vmalloc pages in /proc/meminfo Roman Gushchin
2019-03-01 15:05 ` Vlastimil Babka
2019-04-17 13:34 ` Vlastimil Babka
2019-03-29 22:07 ` [PATCH 0/3] vmalloc enhancements Roman Gushchin
2019-04-17 13:36 ` Vlastimil Babka
2018-12-19 17:37 Roman Gushchin
2018-12-19 17:37 ` [PATCH 2/3] mm: separate memory allocation and actual work in alloc_vmap_area() Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db6b9745-7e64-6eb9-6b2b-da9d157a779b@suse.cz \
--to=vbabka@suse.cz \
--cc=guro@fb.com \
--cc=guroan@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox