From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC323C433DB for ; Tue, 19 Jan 2021 21:25:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 114C822D71 for ; Tue, 19 Jan 2021 21:25:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 114C822D71 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 70DF66B0005; Tue, 19 Jan 2021 16:25:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BE6A6B0006; Tue, 19 Jan 2021 16:25:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D23F6B0007; Tue, 19 Jan 2021 16:25:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by kanga.kvack.org (Postfix) with ESMTP id 45E306B0005 for ; Tue, 19 Jan 2021 16:25:39 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 058DE181AF5C4 for ; Tue, 19 Jan 2021 21:25:39 +0000 (UTC) X-FDA: 77723806398.16.elbow19_270c0fd27555 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id CE296100E6903 for ; Tue, 19 Jan 2021 21:25:38 +0000 (UTC) X-HE-Tag: elbow19_270c0fd27555 X-Filterd-Recvd-Size: 2903 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 Jan 2021 21:25:37 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8626122D08; Tue, 19 Jan 2021 21:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611091536; bh=m2NmUkVbZFqNYxEiipm2cSpkCjD68PKieK6nRK/uEZE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=hyHE3pqxSgelS0zn5RME0voJ8QHAzxRaFLzY5H30Qpa7kCxG8OyBg8cMEvw/dSC1V I+7XvCxsxvsMt/r49nMHePxICOVfl+sTdBrEK4KzAv15ae+3LlK7HWRu6FpGi6Muph VNgBRx3D7rxt46XRREE0gqQ21cZsnBQqOrzJCYPWXsovAN6JOC3o0TAETdAFT63+iS hzW37fS/n9cPCu2v3hW/p0YTmEs4TzgEksy0nSp9HovD8fsWwIcC/iCrvbZoOyivga gzH3qvOlHvhq714BJga/FrHb67LBnLnftKtcOHSA4n/7QJC44vk4nNp7MWi1AY+DvL +wCZkRL/WjvMw== Subject: Re: [PATCH 0/2] introduce DUMP_PREFIX_UNHASHED for hex dumps To: Steven Rostedt Cc: Kees Cook , Matthew Wilcox , Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, Petr Mladek , roman.fietze@magna.com, John Ogness , linux-mm@kvack.org, Akinobu Mita References: <20210116220950.47078-1-timur@kernel.org> <20210118182635.GD2260413@casper.infradead.org> <20210119014725.GH2260413@casper.infradead.org> <202101191135.A78A570@keescook> <29122c86-bfea-2f25-d111-00641cc660ba@kernel.org> <20210119151045.15c1fee3@gandalf.local.home> <184ab5eb-2508-0761-36c6-061d509fe104@kernel.org> <20210119161524.31c695d3@gandalf.local.home> From: Timur Tabi Message-ID: Date: Tue, 19 Jan 2021 15:25:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210119161524.31c695d3@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/19/21 3:15 PM, Steven Rostedt wrote: > When it's not related to any symbol, doesn't it still produce an offset > with something close by, that could still give you information that's > better than a hashed number. No. I often need the actual unhashed address in the hex dump so that I can see if some other pointer is correct. For example, I could be doing pointer math to calculate the address of some data inside a block. In this case, I would %px the pointer, and then hex_dump the block. I can then see not only where inside the block the pointer is pointing to, but what data it points to.