From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71B9DC021AA for ; Wed, 19 Feb 2025 22:44:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEAC2280138; Wed, 19 Feb 2025 17:44:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9B312800FF; Wed, 19 Feb 2025 17:44:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3B24280138; Wed, 19 Feb 2025 17:44:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8658C2800FF for ; Wed, 19 Feb 2025 17:44:22 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 136E9C0308 for ; Wed, 19 Feb 2025 22:44:22 +0000 (UTC) X-FDA: 83138174364.05.45B879F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id B4C1540006 for ; Wed, 19 Feb 2025 22:44:19 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Wstn6d3f; spf=pass (imf11.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740005059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DMvitgvDIjDepeC3+06xX2GwpCGnJs2yXLfJOe51Cy8=; b=HzW5IhN5qAb/x/4U0++CEU4g8W/7+RZWYCotzsptZNSBVhMQiKSKIaZHa8P4uNoRCz+OOS OWSn7clG5rnEo0N32l88m14TN1A6IoH+bCaJIKJMhgJuw7js/cZ6morpvcwWxkFTtEhOwZ vdPvur2QNzPoKjpfVCZosVPcPeT7VDQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Wstn6d3f; spf=pass (imf11.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740005059; a=rsa-sha256; cv=none; b=xvla2gtcMv2azeGZulD929lc8G4SqJCWGuIVUx0UiePnsGhyrClKPQgc5IG9Ri3wnABibv 5hKA0QYN0iw6B1zfxwtvrcnjyvO8wshHKTCFpWojXPzG6sLlHuEAKIInyCuxRGZcKGv9UP L0TSwYAJlxyYCgkwJi0PeevyzpZLl6U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740005059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DMvitgvDIjDepeC3+06xX2GwpCGnJs2yXLfJOe51Cy8=; b=Wstn6d3f+z8SUnvWVQ4tBdGLB5BP/Z+NGDXmIRnoWgaO3ZLUQ6LCHM3OEQfhLDWAQR+Fx9 sQKXplgqDJsAwr1F/HSmX/NqUgA2UsJcPYsMDO1TD04Qnqvc8j2LhQjvf5VdWhzOx1Tr1s A4jPivvYZ+41P2MsnYMG05wnXJG0uGQ= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-Wi6O2rYAOm2tUnoGF-XcTQ-1; Wed, 19 Feb 2025 17:44:15 -0500 X-MC-Unique: Wi6O2rYAOm2tUnoGF-XcTQ-1 X-Mimecast-MFC-AGG-ID: Wi6O2rYAOm2tUnoGF-XcTQ_1740005054 Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7268475e62cso351768a34.3 for ; Wed, 19 Feb 2025 14:44:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740005053; x=1740609853; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DMvitgvDIjDepeC3+06xX2GwpCGnJs2yXLfJOe51Cy8=; b=dz1cAkVRbWoKb0lREleEx5zwmx0nbdTBkKqjBZBOKEPXusDQBbZs7dAmJOC/7CfnL4 mf8kOAKFTRKNcURfDlQQ1EM6CRb6kxki6/S69Jf3SyR+ThUwQdhKKnpEazV1S1N+9ApR bzoXYWAZ3C7Z1A6rYIr52nI6bvoI2y/lQuI5at0VHOM9bOEXi+A6HoJbnpDr1DeCGZdZ dBscGlXB7Fmk/ImAt1qzTv9cs3tAbozrO/k7sWsFIJFstPm7x99fpHZghp/BJYwzNVXb kpNYZsPK6U9SPsZur9XXv0PDSyK0MNQ33buxSrXwUVcI8Yet5g55gRJgCDyiHDjaGov4 YS+Q== X-Forwarded-Encrypted: i=1; AJvYcCURw3OsWYxkto813Bm76BCA94vlrETDIjbbguZ7HIfkdNNMCneb/1I5OQiUEyp8iSOmXOjw0PT2MQ==@kvack.org X-Gm-Message-State: AOJu0YwDjUsEzairLMAuebp1oi0JyjocLiMw2haSZ5Z77LxDvbxUSydb sA1VCIBRUtP/z+acL6hxo1mjvu73cTEIy4TnJlLxFJwUvlglEDzPb4PGXBc0Rat81NMGuaPO3l9 og6BM9rJW99j3HmAjckiFUcqeCkraS96b5eQWB1G0OKWIN49PTQcCwx7KtJo= X-Gm-Gg: ASbGncv7jARl8AInekhcZpYaO9z9Kq4CZAzjosn+SzFx7cP646HjE7Fk3ZKqTsvEeIf XKTIzQT+3b3v+H/I917NQmlnL2tXGEKv8qrQHBzgLNU5NTrVZDi7IqYyi1ZISsU5Uk7RjbOjuyd zsAF1DAGu1PWOmNx9Q9T0tawF8Z1mEisZfEF3cgI/hgJh8+6+EA9as++KaPGhO6UN98wK+wppFA MHHG1kBsF2JUoWce8BqnnRGjBpD6PvSon54StGOjfrkmK2oc0YJm+bWPNCgSEGyLh6TtndMmazH fRT3GRVOzjKFhtCCcSGiU+A6P2J5zksd/nQJ0gjlyB7Y+XpG X-Received: by 2002:a05:6830:6a97:b0:727:2fa8:c0e3 with SMTP id 46e09a7af769-7272fa8c31emr6915941a34.11.1740005053713; Wed, 19 Feb 2025 14:44:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IG6YLEg0w5nPagcW0zAe4o5WqKQSTn3wQrAQr5zobu9Z1tzgyRbtNSptj5SQOAnkE26MH94hQ== X-Received: by 2002:a05:6830:6a97:b0:727:2fa8:c0e3 with SMTP id 46e09a7af769-7272fa8c31emr6915927a34.11.1740005053392; Wed, 19 Feb 2025 14:44:13 -0800 (PST) Received: from ?IPV6:2601:188:c100:5710:627d:9ff:fe85:9ade? ([2601:188:c100:5710:627d:9ff:fe85:9ade]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7272ad5fbb9sm1783536a34.13.2025.02.19.14.44.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2025 14:44:12 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: Date: Wed, 19 Feb 2025 17:44:11 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] hung_task: Show the blocker task if the task is hung on mutex To: Steven Rostedt , Waiman Long Cc: "Masami Hiramatsu (Google)" , Peter Zijlstra , Ingo Molnar , Will Deacon , Andrew Morton , Boqun Feng , Joel Granados , Anna Schumaker , Lance Yang , Kent Overstreet , Yongliang Gao , Tomasz Figa , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Linux Memory Management List References: <173997003868.2137198.9462617208992136056.stgit@mhiramat.tok.corp.google.com> <173997004932.2137198.7959507113210521328.stgit@mhiramat.tok.corp.google.com> <20250219112308.5d905680@gandalf.local.home> <0fa9dd8e-2d83-487e-bfb1-1f5d20cd9fe6@redhat.com> <20250219152435.35077ac3@gandalf.local.home> In-Reply-To: <20250219152435.35077ac3@gandalf.local.home> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JUWRb82bAts6MVt4vVb8VjMZXYgAm29nkUGHtrA6-i8_1740005054 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B4C1540006 X-Stat-Signature: xaae58bs4rhzjuwkcazsdrpcsmywyy8d X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740005059-682072 X-HE-Meta: U2FsdGVkX182Amy6pFz/6t/TCwuiRPT5XJIEiXgHntYJGnO5u6XzEa+tx8C3DCBAO/aoAmtCJmVCvOqm021GEiQC3OlgBlQKpPI4rihMHBkylOthI3pjmySPLdemaWHUGWwGeOxQl//YYfVso7t04RnKGb+i6WBvVt+iRGmEvV79dw38dd8/t8XA7kbVcUzdyzR+kT/qyar0f2G/AURUdEJZXzIcCKJTMxJfmX5drtaMaWqO/oXvRBsujWfxN/hzxxJr/DUWP3Gz8sXy6pjUuOnTEgzNWxDpRQueiy3ZXXyMZbYNF8iML1vBvFAYYLB16cRaOLh16HvRWVyOKiHwhth/rP/bKB6de2qLT0jUsXXeiycYRhwpJeJcVI3goKgLvPEyJbgHltrcnofKBkG37K93kFXHfxgRwZNw9QPVTmoWjC2wN6MEgDPBkVQG42aGMPshfMHskIret/O6WaZwZ/6T31xEeRuMi3PAR9i2ifovx05+wNBkv9qOejQeUXnrNCTgtue1Br1SxXHBxmGWIqZM0HqlVe5MNWc8Km9IOvpvytWkcYTjSgHEVGQt5ZbYBZHK5YHrl6WBkVNgkM2/E3T7mhrV7wTabuJlFV0wXpuaV3rvAckrtv+tK9bysSWMVSGxGEwZdXsJFKnVVPdneM0CTYRuvAEJEWEBiQXowK5LJh2+Dkw2mXb6gy0Se0wO9Mp5yjnOhRu1DPAUjqYcAS2/NcqJIfQVp70PvZbbIvPDEVbUGzjKyfBOSNsgkmM4+neQ0wbZR1+lhhu4eA96pGhriAHN1H57YjD2aMwDhy2oduklJrxyDcCn6+D7W1eU9iri5a7DiSL5GF8KnRFMWQYgoxdCyWrZpj4uEzxCwn7wfsIGl3KmEYIhjAFrY+XpiOcsz0aTk7FhcMm1eTNSNs8tOrMfntuJQPQ0XkgAmTYLPhl0xR9Cc4k77xQWsc4uNBzBIDYP/C5tHo/NMa9 EUf2/70Y p7tsffCkzkuGuxemmBzup0TPXRL/Xq7++a50FA6N08a2tUtRTD4+dA3yNEjHe1MRE702bTtVvtT9sui0HJHHzDmZ4RereJeoUG5M0Su5TWJCDt0/eM2o3qdPnA3ViTptW6lduh6fCEE6L6pd+TyqDJ7rnFoRg/O+QKcgktllgsS+MsSNjBSj/gLn1cOEOAaNBgQ6jtjhCePS/Hk6AxLMVVL841TsuY7HZeIJnomgDWUfSswrAt0HdJ22MgazGLxSO0vIgEMIqbWy/a8LUqR5E47TfxLdVV5q4UYDq8duP3fiznReFlDorezsiIuzlWXr9WXCkjgNigHNo8k6fENajJ2o+5dK7AJYjbFy9SXbiW+vroOn2z5OiXoSXsYGHO9ClKNU9v/w0L0j23AS+xKvsUv6QHWs5nZaQ5izudYTTwoXmsVoh25eqOEXh8xqem9HegNBKICUavhnXSu7clMhtXhDTFpIT4YDUmEc+pgLHlhE29e/G4kJqvepoyvvTr3F8r7nIHj1LkZ7afg5+92O0HJeASQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.019414, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/19/25 3:24 PM, Steven Rostedt wrote: > On Wed, 19 Feb 2025 15:18:57 -0500 > Waiman Long wrote: > >> It is tricky to access the mutex_waiter structure which is allocated >> from stack. So another way to work around this issue is to add a new >> blocked_on_mutex field in task_struct to directly point to relevant >> mutex. Yes, that increase the size of task_struct by 8 bytes, but it is >> a pretty large structure anyway. Using READ_ONCE/WRITE_ONCE() to access > And it's been on my TODO list for some time to try to make that structure > smaller again :-/ > >> this field, we don't need to take lock, though taking the wait_lock may >> still be needed to examine other information inside the mutex. > But perhaps if we add a new config option for this feature, we could just > add the lock that a task is blocked on before it goes to sleep and > reference that instead. That would be easier than trying to play games > getting the lock owner from the blocked_on field. Yes, it could be a new config option. This will be a useful feature that I believe most distros will turn it on. Or we may just include that in the core code without any option. BTW, this field can also be shared by other sleeping locks like rwsem and rt_mutex as a task can only be blocked on one of them. We do need another type field to identify the type of the blocked lock. Cheers, Longman