From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C68ECC3DA45 for ; Fri, 12 Jul 2024 07:47:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6331D6B008C; Fri, 12 Jul 2024 03:47:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E1E06B0093; Fri, 12 Jul 2024 03:47:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 482BE6B0099; Fri, 12 Jul 2024 03:47:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 29BD06B008C for ; Fri, 12 Jul 2024 03:47:20 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D06A6808B2 for ; Fri, 12 Jul 2024 07:47:19 +0000 (UTC) X-FDA: 82330320198.01.0D63421 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf14.hostedemail.com (Postfix) with ESMTP id 5CA8A100004 for ; Fri, 12 Jul 2024 07:47:17 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CGr5Vi6d; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0AZ3GihU; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CGr5Vi6d; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0AZ3GihU; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720770421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7hIVlwHpj2au8z19QwDsamajkaD2KB0pNc7FI8i19LM=; b=CptZAI6hEtldMEDrMCaanqXz1kasWNEKtRmX5eqXyyTma2rwuUpV6ZFT40lXguf5Ef7NyD UqfEy7lghNlOqKnl4VWpij0+iCGccGiJcJI7WMfsJfm/sxASgAgyzEio/eaVx1mE7U0onG +tAPBh9Lya4PkAMv2oGCt9uIjFmjGxs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CGr5Vi6d; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0AZ3GihU; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CGr5Vi6d; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0AZ3GihU; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720770421; a=rsa-sha256; cv=none; b=lQnj42os+VrwrU8t9GTwS4oxirGJab8F+LQ76nTqAUEYSwypsPmc2ZQsL+njd+Tq1apVbx e/3fRXvpeHIeM+CTamlIReaqdkviuwv3IYdb5XvzY+0UPd+EkBYLs11Fr6SZjNdPx6DoiQ 9iekYUDgSue8bkznkkh9Tg+bl+iCcJY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BDDDD21AB9; Fri, 12 Jul 2024 07:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720770435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7hIVlwHpj2au8z19QwDsamajkaD2KB0pNc7FI8i19LM=; b=CGr5Vi6dg4Hx06XERfRHkePTcw1msMHVBCDFd26EX5i920j9sgYJH5LH1hMwFYemO+u7Qg YuvX7vy+p3EkQ6AAUP3dH8+HXjvXTPPJaU58n+XNkY0HWBE9sSziZC8X92amRwswM3G21d OJJKFTXDgQs7J+8ue/2j4zAEgDDRyLw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720770435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7hIVlwHpj2au8z19QwDsamajkaD2KB0pNc7FI8i19LM=; b=0AZ3GihUTgaVPPyIqba329WvLKJsYnoM+lkHw+UERMbUk5BQGwP9vfcLidVvxI/FJ3P4Nf yyrjssE3bn5zAuAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720770435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7hIVlwHpj2au8z19QwDsamajkaD2KB0pNc7FI8i19LM=; b=CGr5Vi6dg4Hx06XERfRHkePTcw1msMHVBCDFd26EX5i920j9sgYJH5LH1hMwFYemO+u7Qg YuvX7vy+p3EkQ6AAUP3dH8+HXjvXTPPJaU58n+XNkY0HWBE9sSziZC8X92amRwswM3G21d OJJKFTXDgQs7J+8ue/2j4zAEgDDRyLw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720770435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7hIVlwHpj2au8z19QwDsamajkaD2KB0pNc7FI8i19LM=; b=0AZ3GihUTgaVPPyIqba329WvLKJsYnoM+lkHw+UERMbUk5BQGwP9vfcLidVvxI/FJ3P4Nf yyrjssE3bn5zAuAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id ABCEF13686; Fri, 12 Jul 2024 07:47:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id nCicKYPfkGY8dwAAD6G6ig (envelope-from ); Fri, 12 Jul 2024 07:47:15 +0000 Message-ID: Date: Fri, 12 Jul 2024 09:47:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] slub: Use alloc_pages_node() in alloc_slab_page() Content-Language: en-US To: "Christoph Lameter (Ampere)" Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , linux-mm@kvack.org, Johannes Weiner , Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <20231228085748.1083901-1-willy@infradead.org> <20231228085748.1083901-3-willy@infradead.org> <624cc2ee-9335-31e5-4177-97fe676b6e76@gentwo.org> <5067a09b-71b5-45dc-916a-d3e7c679bd83@suse.cz> <9d54dab9-64d6-8989-b6df-ca0a28e5cd7c@gentwo.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <9d54dab9-64d6-8989-b6df-ca0a28e5cd7c@gentwo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5CA8A100004 X-Stat-Signature: x1hudzii3y4sndsjjbrgwk7cq56chu3k X-HE-Tag: 1720770437-158894 X-HE-Meta: U2FsdGVkX1+jrw32Ixi4eiVPb43wzp5unRSuzCoA4N/qMCaUM3Etrr7sdDriWEDrvuZrCRjpdXVj9y94bDhoYv0XlA1WcgrdK9iT6kCe5hJUy3/FC8aJg8YjaOW37zKSZ9EnZKrtahJS+zqYSz9mCqalTek9dS1WRBZ2Ne0H58FJDlJQl0cvQS3hL8a9l7ZjrP0Y02bIWlcpJ43C5iKG1A7STlJ1KnsuSoAlpGs4Fz7OJkgwcE4KPBF7cPgVLebzjk8qmT9Iech07Nrds+0WEXvEjirOzK2bdOIrG/3K/SMWegaoWvA0kMVdlcNnpECbXRrSNGm4NzItmjZciz0mbuKNEo/tEw3tU6yYVhpmn3/OwBQk9QCC7BuD7Y7y4b6q7Q/CAPRi/3yxbGyacVe46Ql+qr3o4cKjLEvdc8rK9eEGtEE6JnbScExw1HX651Fl10rOckaEMBeul243a5fgn51zb8ydXAdc2vY6ydld4xL3Fg5INMZN4ybU9G2ZY/gcjxZSDhrGPqmlldLSebs6av9oDPh0gsSJ4BwpEKfJAI0NH95r3u9gGULoHJviPM9FbL1MgqwZ4A1kny7Ap9VOP6tZFLmLZ7Mj6HC5384FaonHrKr1fQZ9BKBBbplbpaAVzHpgqXjj12/W23PlXLISUqq167GzK1Zbf7wHgYXYRihHzitTUN8Nsjt1uMx8tI5T1BKmW3a8jwv1BgVUQchDplM74J/JcXkPTu06o6O5j6qy3i0VbnhTJw9IE0KrTLFp9OGKyX7NQ6cKES7eJeHBCm/e7wE5XK6e+VNfbxIXXHfvsbaNWR/dquiRdywa40xIRGZfY2d3yGljATokbFwoSLItrIrV8XqEz6MdsQ3PutWY7gsCMMuSkVrOG/RHP88ap7yU4mNpGG0mtEzRpWDdktwHFzLVEhG6ilrY34lmQI7eA7zdspfKTY3y2XNyWFcP7shJm1gtxjOcPzghQQK REbfan00 ypTrvmkB5PtGvhlIkCIZ8npH4fXF8XcI8inM3EKl98VuaSJtVx21drSpcNazBmbc1uSGWVmNljWfMVfCK9FspWu5i+H2K8X8SgCW3j0dxqQuWLwj/AAgMl2GZwkWjbn6rU7ye20IXGh6s/fPI6K4vsxtH70x/2RupE6i3I7CpGj6axakngn2FEvhXQ9TuSqn8E3ZVY++O+tyrF4z0Si9Bam5waNRctYiT4g/x2WZ0q39A7/C8R4l7GtFQ/fz6uXqdG5yHGJ3L0KopGq7z1tJnoZlFFo120s4kLoWx8nhxP2Z1tBxjo+bPm+ZEtq3gg8o2VctIoA0Eq1p6GnH+NpXle8Jsd8v43iJB/3x3LoIjJOgQoRxhQQH10dAB6DvKLnmoqC8C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/11/24 8:04 PM, Christoph Lameter (Ampere) wrote: > On Thu, 11 Jul 2024, Vlastimil Babka wrote: > >>> There are also the cpuset/cgroup restrictions via the zonelists that are >>> bypassed by removing alloc_pages() >> >> AFAICS cpusets are handled on a level that's reached by both paths, i.e. >> prepare_alloc_pages(), and I see nothing that would make switching to >> alloc_pages_node() bypass it. Am I missing something? > > You are correct. cpuset/cgroup restrictions also apply to > alloc_pages_node(). > >>> We have some internal patches now that implement memory policies on a per >>> object basis for SLUB here. >>> >>> This is a 10-15% regression on various benchmarks when objects like the >>> scheduler statistics structures are misplaced. >> >> I believe it would be best if you submitted a patch with with all that >> reasoning. Thanks! I still believe that :) > Turns out those performance issues are related to the issue that NUMA > locality is only considered at the folio level for slab allocation. > Individual object allocations are not subject to it. > > The performance issue comes about in the following way: > > Two kernel threads run on the same cpu using the same slab cache. One of > them keeps on allocating from a different node via kmalloc_node() and the > other is using kmalloc(). Then the kmalloc_node() thread will always > ensure that the per cpu slab is from the other node. > > The other thread will use kmalloc() which does not check which node the > per cpu slab is from. Therefore the kmallc thread can continually be > served objects that are not local. That is not good and causes > misplacement of objects. > > But that issue is something separate from this commit here and we see the > same regression before this commit. > > This patch still needs to be reverted since the rationale for the patch > is not right and it disables memory policy support. Results in the > strange situation that memory policies are used in get_any_partial() in > slub but not during allocation anymore. >