From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0FB1C021B8 for ; Tue, 4 Mar 2025 10:26:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 447B06B008A; Tue, 4 Mar 2025 05:26:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F5C76B008C; Tue, 4 Mar 2025 05:26:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26F456B0092; Tue, 4 Mar 2025 05:26:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0A2786B008A for ; Tue, 4 Mar 2025 05:26:13 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A0814A7DD0 for ; Tue, 4 Mar 2025 10:26:12 +0000 (UTC) X-FDA: 83183488584.22.BC84A0A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf24.hostedemail.com (Postfix) with ESMTP id 3E27318000D for ; Tue, 4 Mar 2025 10:26:09 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pZy8j07k; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ESjfsJST; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pZy8j07k; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ESjfsJST; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741083970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DWTJSYkqVDNyFS9bm4Q2lrVmulLaHNzSIa7P1+Vo2+8=; b=1GKLo/yXZvvfvQNDayUx8nktpDAV8VhPB/ui/5DT3TMgYfyusxKa42VZsXtyUKMdev1xHO L7ODcMBePCi5CBe7UT9RgOqhG+1LqEqj9ZKLGvscNNeSZBuI/dKS7S5XEFmeKkOuKsbslo oFxr2BpSdGT15u4Zf297vrGARVF5sO4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pZy8j07k; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ESjfsJST; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pZy8j07k; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ESjfsJST; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741083970; a=rsa-sha256; cv=none; b=o4UCAAmYtj+iuC7nOGyTSuFfYMdz1jpMMfcUxQEnY09UL+1HckoG9wwoeHIKyL1RFg/rDw S8r5W2GaOHON3uQxl2g7S+a57CUVoCmnFHDpKXIl8Ppk6R5TSb9KXE2AT9AkGPrYbLc8T5 lghSn/XDA7Spx+Fgmb0njUJxYlqBO/o= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6961C1F78D; Tue, 4 Mar 2025 10:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741083968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DWTJSYkqVDNyFS9bm4Q2lrVmulLaHNzSIa7P1+Vo2+8=; b=pZy8j07ktSnmKLOQ2DeAd2T2s1vSy0B6iBJ6olsKtHUQtKBl1Xk2pzkCEOKbIB8hVtOnWj LQlrv62VxM+3tfq2L9QRVcIM6Tr575dky98kDP0HtZag74Yw5LvMKiMLBQ0y631NjukeSi nstkAyYbBrNAcsrIQEu6iyRvyMfxJU4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741083968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DWTJSYkqVDNyFS9bm4Q2lrVmulLaHNzSIa7P1+Vo2+8=; b=ESjfsJST/yxlPqvucHVI825Afq9YxQqMq8eMrUgSWm+/Mqz6rVGe1SasB48F+ZrXZ81lTv zyNXQPqG/06FF4DA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741083968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DWTJSYkqVDNyFS9bm4Q2lrVmulLaHNzSIa7P1+Vo2+8=; b=pZy8j07ktSnmKLOQ2DeAd2T2s1vSy0B6iBJ6olsKtHUQtKBl1Xk2pzkCEOKbIB8hVtOnWj LQlrv62VxM+3tfq2L9QRVcIM6Tr575dky98kDP0HtZag74Yw5LvMKiMLBQ0y631NjukeSi nstkAyYbBrNAcsrIQEu6iyRvyMfxJU4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741083968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DWTJSYkqVDNyFS9bm4Q2lrVmulLaHNzSIa7P1+Vo2+8=; b=ESjfsJST/yxlPqvucHVI825Afq9YxQqMq8eMrUgSWm+/Mqz6rVGe1SasB48F+ZrXZ81lTv zyNXQPqG/06FF4DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4DDEC1393C; Tue, 4 Mar 2025 10:26:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MDJaEkDVxmf0YAAAD6G6ig (envelope-from ); Tue, 04 Mar 2025 10:26:08 +0000 Message-ID: Date: Tue, 4 Mar 2025 11:26:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Kernel oops with 6.14 when enabling TLS Content-Language: en-US To: Hannes Reinecke , Hannes Reinecke , Matthew Wilcox , Boris Pismenny , John Fastabend , Jakub Kicinski Cc: Sagi Grimberg , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , linux-mm@kvack.org, Harry Yoo , "netdev@vger.kernel.org" References: <08c29e4b-2f71-4b6d-8046-27e407214d8c@suse.com> <509dd4d3-85e9-40b2-a967-8c937909a1bf@suse.com> <15be2446-f096-45b9-aaf3-b371a694049d@suse.com> <95b0b93b-3b27-4482-8965-01963cc8beb8@suse.cz> <6877dfb1-9f44-4023-bb6d-e7530d03e33c@suse.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <6877dfb1-9f44-4023-bb6d-e7530d03e33c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: enpk8nd8y575q8xfoopqnzda9qxmtj3s X-Rspamd-Queue-Id: 3E27318000D X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1741083969-14644 X-HE-Meta: U2FsdGVkX1827e7d932W6tixIMviYeIpLahAnQjAk7sy/mF89c+8rbq0/f9YXVucP6pyeMIpXoc6SCmlPeDfEcIAkeN/uKWoQfXJMeFcjBbeiQUyNv7EphyZ63FGoRtJiUcydyMnmHCbEU3+60QEcqTka5tIj3piw/RN5ojNeHiD/5JV7/VgdOx/Jf2iTarTofne37H9w5qOFkHfL6usaEvHKmyioLpr6gaawZ0o/nnt0XU9tzE0JFIjuIzeVqUY9B8+fsqt+aZF65bdw/THOmnqsM7FvdNElxaAkHb0vUDjTuQS19bMZOQwRpmaEGaCqmKjcLvEwoJLjOwnNE0y+W02UwI1xQVKRkBKjixeL4LTeCM6QFZbupPM2Ie0TncnYx9u/bJ6QiJsF5FeXkAhn4fWXo7YvDwclFxJzTXtrgtFAsmvdDikN5vzMHnVaZDxOWqB9sljf2jC2U2T4RB5dv0rIV/iFAO1RyxV0MWA5yS7aTcHVRBxoEF1ocJFYVARkJbRaID3RNd1I5N2ST40fcz5Jhsvj4JcI1ms6a6P1VuTE8C9nxZOjDmQUBXyeCVov3R5Edg62YRfrHfc4aULFDVUehgqvT6ggJNfecPuYR63mE32Ee6yi82hFgdi3gjfWuE+ecCxW89SzZ9r7fmnq63IYJgnhWgJvfOwYZKSaEPSiyrIC1ylS33zERnXwiFH7FwdcXNOyC94N2QzE7KC1eMdcxQhYksBpvgYH514j6sGlqgbSM/fXtWSqFp3npfB5kC8inC7QMnHmsYoTja4RvGWiPcO14ijvuJXMQCoLzAD+3zhBV27lI8tv5177n90C+eKCpdsWiTpZQDYCCiXezHHXjF5ByOjH+83dQgXvYFlvwccVdxfkJrzqS71mzUWed2MYh7ZXtGwrSdEubUEd5LyPvtVZcvZqblUOFFkFtPuKrWFODK7ZeWHKABkTt22RDm35IQPF9IwjWT3WVH tYKaExmc 8eSd0Gvv5FqYdi1JNfufj5kYPMvzrG9xniFyxh9PdrP8cN9mXczeXJ0s6Gtkr4GI/qH7fx6llFs3Z6/0wDHoV9AEOgdfqaL17RRxooroe/qkibNCaVudD11xUZpJyoGJRQd5ChLkMyDFlKBhQ711dgywcyYUqs1zwHWGnDIMsBtIQcMrt2XF9d39UloIQGnD6H06Xce67wVsGxjGvBQ32FWAksXXq/PY+4vADZSnOGMK/fQ+7hFIH98fk3vdpRkDiCdW8ZUtlt0c+b30xb8BM9kuHax6oXdGXclCPlpAW/lU2s/ypwr15JWDH69pAx/ymn+WDg2dFarzHPno2szdo0QWBTDS+qIAAHfGdPvO1rAAMDq+QSWeV5yo8IpocQn0jVJ6p7J5f8k0OsxnG6w0O9sYof+0qcwmGB4+TpxKyn4jxWcE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: +Cc NETWORKING [TLS] maintainers and netdev for input, thanks. The full error is here: https://lore.kernel.org/all/fcfa11c6-2738-4a2e-baa8-09fa8f79cbf3@suse.de/ On 3/4/25 11:20, Hannes Reinecke wrote: > On 3/4/25 09:18, Vlastimil Babka wrote: >> On 3/4/25 08:58, Hannes Reinecke wrote: >>> On 3/3/25 23:02, Vlastimil Babka wrote: >>>> On 3/3/25 17:15, Vlastimil Babka wrote: >>>>> On 3/3/25 16:48, Matthew Wilcox wrote: >>>>>> You need to turn on the debugging options Vlastimil mentioned and try to >>>>>> figure out what nvme is doing wrong. >>>>> >>>>> Agree, looks like some error path going wrong? >>>>> Since there seems to be actual non-large kmalloc usage involved, another >>>>> debug parameter that could help: CONFIG_SLUB_DEBUG=y, and boot with >>>>> "slab_debug=FZPU,kmalloc-*" >>>> >>>> Also make sure you have CONFIG_DEBUG_VM please. >>>> >>> Here you go: >>> >>> [ 134.506802] page: refcount:0 mapcount:0 mapping:0000000000000000 >>> index:0x0 pfn:0x101ef8 >>> [ 134.509253] head: order:3 mapcount:0 entire_mapcount:0 >>> nr_pages_mapped:0 pincount:0 >>> [ 134.511594] flags: >>> 0x17ffffc0000040(head|node=0|zone=2|lastcpupid=0x1fffff) >>> [ 134.513556] page_type: f5(slab) >>> [ 134.513563] raw: 0017ffffc0000040 ffff888100041b00 ffffea0004a90810 >>> ffff8881000402f0 >>> [ 134.513568] raw: 0000000000000000 00000000000a000a 00000000f5000000 >>> 0000000000000000 >>> [ 134.513572] head: 0017ffffc0000040 ffff888100041b00 ffffea0004a90810 >>> ffff8881000402f0 >>> [ 134.513575] head: 0000000000000000 00000000000a000a 00000000f5000000 >>> 0000000000000000 >>> [ 134.513579] head: 0017ffffc0000003 ffffea000407be01 ffffffffffffffff >>> 0000000000000000 >>> [ 134.513583] head: 0000000000000008 0000000000000000 00000000ffffffff >>> 0000000000000000 >>> [ 134.513585] page dumped because: VM_BUG_ON_FOLIO(((unsigned int) >>> folio_ref_count(folio) + 127u <= 127u)) >>> [ 134.513615] ------------[ cut here ]------------ >>> [ 134.529822] kernel BUG at ./include/linux/mm.h:1455! >> >> Yeah, just as I suspected, folio_get() says the refcount is 0. >> >>> [ 134.529835] Oops: invalid opcode: 0000 [#1] PREEMPT SMP >>> DEBUG_PAGEALLOC NOPTI >>> [ 134.529843] CPU: 0 UID: 0 PID: 274 Comm: kworker/0:1H Kdump: loaded >>> Tainted: G E 6.14.0-rc4-default+ #309 >>> 03b131f1ef70944969b40df9d90a283ed638556f >>> [ 134.536577] Tainted: [E]=UNSIGNED_MODULE >>> [ 134.536580] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS >>> 0.0.0 02/06/2015 >>> [ 134.536583] Workqueue: nvme_tcp_wq nvme_tcp_io_work [nvme_tcp] >>> [ 134.536595] RIP: 0010:__iov_iter_get_pages_alloc+0x676/0x710 >>> [ 134.542810] Code: e8 4c 39 e0 49 0f 47 c4 48 01 45 08 48 29 45 18 e9 >>> 90 fa ff ff 48 83 ef 01 e9 7f fe ff ff 48 c7 c6 40 57 4f 82 e8 6a e2 ce >>> ff <0f> 0b e8 43 b8 b1 ff eb c5 f7 c1 ff 0f 00 00 48 89 cf 0f 85 4f ff >>> [ 134.542816] RSP: 0018:ffffc900004579d8 EFLAGS: 00010282 >>> [ 134.542821] RAX: 000000000000005c RBX: ffffc90000457a90 RCX: >>> 0000000000000027 >>> [ 134.542825] RDX: 0000000000000000 RSI: 0000000000000002 RDI: >>> ffff88817f423748 >>> [ 134.542828] RBP: ffffc90000457d60 R08: 0000000000000000 R09: >>> 0000000000000001 >>> [ 134.554485] R10: ffffc900004579c0 R11: ffffc90000457720 R12: >>> 0000000000000000 >>> [ 134.554488] R13: ffffea000407be40 R14: ffffc90000457a70 R15: >>> ffffc90000457d60 >>> [ 134.554495] FS: 0000000000000000(0000) GS:ffff88817f400000(0000) >>> knlGS:0000000000000000 >>> [ 134.554499] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>> [ 134.554502] CR2: 0000556b0675b600 CR3: 0000000106bd8000 CR4: >>> 0000000000350ef0 >>> [ 134.554509] Call Trace: >>> [ 134.554512] >>> [ 134.554516] ? __die_body+0x1a/0x60 >>> [ 134.554525] ? die+0x38/0x60 >>> [ 134.554531] ? do_trap+0x10f/0x120 >>> [ 134.554538] ? __iov_iter_get_pages_alloc+0x676/0x710 >>> [ 134.568839] ? do_error_trap+0x64/0xa0 >>> [ 134.568847] ? __iov_iter_get_pages_alloc+0x676/0x710 >>> [ 134.568855] ? exc_invalid_op+0x53/0x60 >>> [ 134.572489] ? __iov_iter_get_pages_alloc+0x676/0x710 >>> [ 134.572496] ? asm_exc_invalid_op+0x16/0x20 >>> [ 134.572512] ? __iov_iter_get_pages_alloc+0x676/0x710 >>> [ 134.576726] ? __iov_iter_get_pages_alloc+0x676/0x710 >>> [ 134.576733] ? srso_return_thunk+0x5/0x5f >>> [ 134.576740] ? ___slab_alloc+0x924/0xb60 >>> [ 134.580253] ? mempool_alloc_noprof+0x41/0x190 >>> [ 134.580262] ? tls_get_rec+0x3d/0x1b0 [tls >>> 47f199c97f69357468c91efdbba24395e9dbfa77] >>> [ 134.580282] iov_iter_get_pages2+0x19/0x30 >> >> Presumably that's __iov_iter_get_pages_alloc() doing get_page() either in >> the " if (iov_iter_is_bvec(i)) " branch or via iter_folioq_get_pages()? >> > Looks like it. > >> Which doesn't work for a sub-size kmalloc() from a slab folio, which after >> the frozen refcount conversion no longer supports get_page(). >> >> The question is if this is a mistake specific for this path that's easy to >> fix or there are more paths that do this. At the very least the pinning of >> page through a kmalloc() allocation from it is useless - the object itself >> has to be kfree()'d and that would never happen through a put_page() >> reaching zero. >> > Looks like a specific mistake. > tls_sw is the only user of sk_msg_zerocopy_from_iter() > (which is calling into __iov_iter_get_pages_alloc()). > > And, more to the point, tls_sw messes up iov pacing coming in from > the upper layers. > So even if the upper layers send individual iovs (where each iov might > contain different allocation types), tls_sw is packing them together > into full records. So it might end up with iovs having _different_ > allocations. > Which would explain why we only see it with TLS, but not with normal > connections. > > Or so my reasoning goes. Not sure if that's correct. > > So I'd be happy with an 'easy' fix for now. Obviously :-) > > Cheers, > > Hannes