From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 484E2CEF17C for ; Tue, 8 Oct 2024 14:20:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C86E26B0082; Tue, 8 Oct 2024 10:20:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C35CD6B0083; Tue, 8 Oct 2024 10:20:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFD136B0085; Tue, 8 Oct 2024 10:20:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 927FB6B0082 for ; Tue, 8 Oct 2024 10:20:42 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B603FA0237 for ; Tue, 8 Oct 2024 14:20:39 +0000 (UTC) X-FDA: 82650645924.06.95160B6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id C492FC0011 for ; Tue, 8 Oct 2024 14:20:39 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728397106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lObETuCdzQZ+hBMNtxrjL8gnWrKykaAc92DmY2qjK4s=; b=s4sMY6dPOtpgLyqqTvmu8Q1UVELVoA6WBDyLCny/3cyeFZx6usGbjIIpdii+2ZpN0b8x/t g8gGJnpr8XCNrxVzEueYYxALe2HTKFAWBL6lJI8MOnnB0pXRdP8j+zbt3JIEXYe6TuDy81 F2Te5CyPA9txf43z3t1bFv14j8slxrc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728397106; a=rsa-sha256; cv=none; b=JuD90QSMYx4RHQK3T6iYUjr3uN79Io8rLeH7By59nHQbUCaDY0UUzNePMXyEgR1zzw/q0c OejLZ46j0AW1cBQuuWE78/kR/WnEBpx0OgmcOPYUpCuLKDDFgTen/Fa75Pq36MKHohgW5S 4IgYwIpOYf8ZtiLtoGiFc8gfHjol3aI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 24311DA7; Tue, 8 Oct 2024 07:21:08 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7510B3F64C; Tue, 8 Oct 2024 07:20:35 -0700 (PDT) Message-ID: Date: Tue, 8 Oct 2024 15:20:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h To: Arnd Bergmann , Thomas Gleixner , linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org Cc: Andy Lutomirski , "Jason A . Donenfeld" , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Theodore Ts'o , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers References: <20241003152910.3287259-1-vincenzo.frascino@arm.com> <20241003152910.3287259-3-vincenzo.frascino@arm.com> <423e571b-3ef6-4e80-ba81-bf42589a4ba8@app.fastmail.com> <87ldyzubk4.ffs@tglx> Content-Language: en-US From: Vincenzo Frascino In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C492FC0011 X-Stat-Signature: zueskqzehkc95fsspcnku7yyqgw6fgxm X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728397239-556145 X-HE-Meta: U2FsdGVkX1+TqvETAvjhoNJ85ErXHQCRCSPpTjvwUEMZKkUo5jQ/PW4o9BoJpj8i+3vPAzuLmb1q80EiZRakh3glBg8s0w6mkoEmcva0ne0BuSsp2bO6tKwgu4higmE9BvhC9gVwdBZu/DMbtILvQAf+yQxNCpOCPeCuk2ZJkKZm0bxvC/GtRi3InJAfiEk5h6by/MI0h5MugnqiO5WnsNslbwLirGTZg15OwBajW0EOyzmX8S7OBejoWkZA74QeRUjKtONT6J4l40kKBgJtpdPb+8l+4jbNzUWSFF6GDku2vl/Jo6oOGFcceAdgDfH2UWojd4a7FJvekhcEtcgRAHYTJkw+NdlAGMOudGSRyPHbYs13M2okL6t7S4O18kV7EIQokPzdhODx8/vAr/1ylJHIFUHxhf2vTr8BE/QFYbX/3MeAJdzECJyJpXA33jjOFUt6Bl8F0CPRMbE0JC7XcV+Y8mVescIThjdBlHLloxzx8XLBcqaWoH6A66cCIl3AYyYv9roTrN8jH18DmOajkSxPjZ4t3ltI18NhFzmX8Mi4k2ZMbIY6RZ63ra6H4n8M0g4hjJKcA2BWZF90Hq8+gV7/bnNbryXo4pcfcbvKOIyBhxACZ4nHyF1i0W9bd8kKzpC6m0Cf+gqS2PfxI6I71aBjsZMLuZrF4cwX+QbwzIfNu6f8KszQ2FgSsRzWX6tgOy/5inxK4FYFd8+4uN7VX7OA4lP+MtaCTSw/Meyh2eH8s41xfSCVomI4sGM/i3fs5CrvL7lL89i7KJUty8UszhXt4qlKiTs1KKty5eOTuGMr8L1Dc3Bml9Dhs1HLEF4B4JGqVml/eA0SrTTi67S4loQlTfiZzoeVj0hPuRtgpaOHDJZBD9O4Y/wi+FrF9bBLpOdxzPM9qQhydRN5PC6tbEzLA9Uz/3XzEBA88KGCEsXRC0SMmCNEPWlGdDhvCD18QdhwnX0+A8cqe1Ok01M QD7cxAXy /tkQ/4kEXcfCB/HqOuauOskey3qpKdaqnkavupfiQzop1ua0VJFqbdCuRWf+WWec5/NKcyq7t94jhIQajiXdNqgZpLd18LhxhmrC0FpAFzuG6c9kT7B1tHmB0JYNYUvU46lD89OzBUt7UVeJr06WHe94C8ZZ1yBbAL4TJe8iYK80KiCf6EGiQbxRE1797QPjjR25nzO7JVd7kLIu6ntb2siDVRh/OCepaKkR3FKaYQs4QWRMsJuzbA8DGEwnjlzWF/30CvtJSu5CMMxRxFbVlOA+kyldhW3+zwhcv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08/10/2024 14:11, Arnd Bergmann wrote: > On Mon, Oct 7, 2024, at 16:23, Thomas Gleixner wrote: >> On Fri, Oct 04 2024 at 13:13, Arnd Bergmann wrote: >>> On Thu, Oct 3, 2024, at 15:29, Vincenzo Frascino wrote: >>>> The VDSO implementation includes headers from outside of the >>>> vdso/ namespace. >>>> >>>> Introduce vdso/page.h to make sure that the generic library >>>> uses only the allowed namespace. >>>> >>>> Note: on a 32-bit architecture UL is an unsigned 32 bit long. Hence when >>>> it supports 64-bit phys_addr_t we might end up in situation in which the >>>> top 32 bit are cleared. To prevent this issue this patch provides >>>> separate macros for PAGE_MASK. >>>> >>>> Cc: Arnd Bergmann >>>> Cc: Andy Lutomirski >>>> Cc: Thomas Gleixner >>>> Cc: Jason A. Donenfeld >>>> Signed-off-by: Vincenzo Frascino >>> >>> Looks good to me. I would apply this to the asm-generic >>> tree for 6.13, but there is one small detail I'm unsure >>> about: >> >> Please don't. We have related changes upcoming for VDSO which would >> heavily conflict. I rather take it through my tree. > > Ok. > > Vincenzo, in that case please add > > Reviewed-by: Arnd Bergmann > > to the two paches when you send v4 to Thomas. > Thank you Arnd and Thomas, I am completing the testing and will do that. > Arnd -- Regards, Vincenzo