From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D3AC61CE8 for ; Thu, 12 Jun 2025 17:36:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 712F06B008C; Thu, 12 Jun 2025 13:36:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BF4D6B009C; Thu, 12 Jun 2025 13:36:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F22816B008C; Thu, 12 Jun 2025 13:36:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A95266B0098 for ; Thu, 12 Jun 2025 13:36:25 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5C4CD81548 for ; Thu, 12 Jun 2025 17:36:25 +0000 (UTC) X-FDA: 83547452730.01.76B630D Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf07.hostedemail.com (Postfix) with ESMTP id BD45740002 for ; Thu, 12 Jun 2025 17:36:22 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=CGSHKJxp; spf=pass (imf07.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749749783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l+Et7RDVrkrD3xSj+ZT9JbsfA8TCXL5kawo+d542qxg=; b=Lyw6WRHNWk4JXkHv9yROGoqcfjFugAOACCKauPRWe2P3gxo2Qf/5e2ZYfY+kfZD9ErLXUm CI7pa/WkJHtu3TXt+WGBNsEAsQJw2nVkWaw4E3NEyGJVxU1WoC2VgSBQp0YzmUScrotL4M RYnvwlfoWQkItwH8J51ed/qQtkxAoJ8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=CGSHKJxp; spf=pass (imf07.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749749783; a=rsa-sha256; cv=none; b=RX/+rqFg4FWP6bsjE5nKlJxQHXOh9mBO4A91sHzti9F8b8i4vQMcdaQ2T9B6LP6si76ia3 V45dOQNzuMEeGr8H86i7PopTTgglTrEvhS4o4V1L3DrKIqrM9kN0oH5xAULJF8sRI12/av 9kl311Y5M8bab2wUwsr90Tb9YAvtcQQ= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55CF7v0W022393; Thu, 12 Jun 2025 17:36:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=l+Et7RDVrkrD3xSj+ ZT9JbsfA8TCXL5kawo+d542qxg=; b=CGSHKJxpAeqSz5W/a/AkSHYJFZv8lW+nh uxHC7vWPjJm4OsnwR6v4hz9f8/GcPwgLyA3qutjEahhsvj2zIAXR15Q620+T14It FHaWO/C+YYyqkGfyKNLYoZRGLnqRlAVl5LmSlHByDnbjBGpbKCvRtLprRYaEd7oh 5J9ogX1eJllyxwgYyjA/mR4IpcpPyUjA36BA3prpqLL3/+jvrBlrXfiW9iVZJm+I zDSfTi4nXZF1qPYg3iaKGABx6nExrmBcci8O63LJ77BZRUe9YeZEYxl2gkpYGfKS I6Y6vUvsUHq1Oogn+ejN/LQkS369JvfdVqa5J6qY7W5de0VsVHpPw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4769x01288-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jun 2025 17:36:17 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 55CHWVMp030657; Thu, 12 Jun 2025 17:36:17 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4769x01286-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jun 2025 17:36:17 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55CE2lWa014912; Thu, 12 Jun 2025 17:36:16 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4750rpdxe5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jun 2025 17:36:16 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55CHaEqc33358430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Jun 2025 17:36:14 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0C91920043; Thu, 12 Jun 2025 17:36:14 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EC12E20040; Thu, 12 Jun 2025 17:36:13 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 12 Jun 2025 17:36:13 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 55669) id A4B20E19BA; Thu, 12 Jun 2025 19:36:13 +0200 (CEST) From: Alexander Gordeev To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Hugh Dickins , Nicholas Piggin , Guenter Roeck , Juergen Gross , Jeremy Fitzhardinge , Ryan Roberts Subject: [PATCH 4/6] sparc/mm: Do not disable preemption in lazy MMU mode Date: Thu, 12 Jun 2025 19:36:11 +0200 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 5A073cfWFciuN2b1brPTe_Vnj2ABgNor X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjEyMDEzMiBTYWx0ZWRfX3cw7ceB7JmZU d6VxfkA70ad39bsJhjQOMACDU7dhR+379Mps/nEMF5/Xm61VZKQveRqbfzXh/DVjMZ0MwShjckH OtM5ElN6pHeKhDxIDWUCD/pMglKXSvoq8imTovo//BpZ6RwUVH9+vjpOGhCFRVt8y8A/4Bl3ZF+ v6CF8HwtyU4JDL9lKBw8F0GK0vxxj4t9XvR5rgBIuku+iqnJzzsphSBS/GReDoCb+rZTnHKWlnq RPWDwzbp3QorzE155Z++H0jAHLpMAaYFuoXsnenF/bqmgRHT1lUWRW1zbgilJ+Wn6BAjRAxFWe0 pbzA/SYKln6jnYz2VhQume3b18VSQ7InP15yZ+oOnDWlKT3nsaNQ+eIJZzYp3cBxB4kIuXOZQH0 iVXVtP4unDNnzh/4Kk90d/VKBbvj+DoHFSQSGh/QOa32UKZrgdVGPB3bpZbuiTPpWKB+gRy+ X-Authority-Analysis: v=2.4 cv=YKGfyQGx c=1 sm=1 tr=0 ts=684b1012 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=6IFa9wvqVegA:10 a=VnNF1IyMAAAA:8 a=Nsn6zn2YLSyj-wdhBosA:9 X-Proofpoint-GUID: El7oGGFj-H4_3nAMfB3G6kQ4auHJ7oeL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-12_10,2025-06-12_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 priorityscore=1501 phishscore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 mlxlogscore=711 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506120132 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BD45740002 X-Stat-Signature: 9cadib6s5m7575utmsq4bc1gs5poeci4 X-Rspam-User: X-HE-Tag: 1749749782-745626 X-HE-Meta: U2FsdGVkX1/oIdc51L/1tkrwn64HINeUoGgxz3wGgnyXB7Y4R5AC2aDGeTu4WZiCyM4tcUVludPd+EhXRA0REgB6KqqsV4Egl1JNxRGUmCBrtwOKAIuJp37Cm5v+TrFCMmh6lQV98Sl4b4+SxGr+so4H/nxAL+OwDGIGw0aeapF7sK1DmPFfFG5A+KgU34/AQ5Sn80/iiF+f05I/+TTjd77TPdIKpXoHgQcE6OJJGIPzAL5aeXlhbAlHPFKdPS7LLpJolMm+WdJmE2d+9StYkWURPsggiObWC3O1ASSEgr0hQGS5QTC38dY8WRJHIxkNZa9iTssWvXe8gREXDEWXoq/4WItxwzwCO8n+DeSaTs9CoKVVeBopdP0dO1Mhf90KQOMaTFOCX6u9F0bznMJBd3a7uKYaDRM53SMxI0PsttuaFlPGnQcRpxVJYNIPrjmdkjdZZj437qOz6VEyX4Gkss5EuS9vA7YV3VX7gFCqeqBNiqTDYduGFWzA8yyOO94yJHCG5SDkbgStiiCSlDowovHOakf+fXREJyGbVkM6VCf/rG6soxcWEiTE7xgiVfOKhvCBfGEsU4WWNzAB8ucYydZxL0X8tQ7aY9BG9S/fy86ODyN8OvEoyEclNz//4cocKBKvDcqskbnalg+r9rtwb5x/BR9aQ2BfZbt2DT4w5o2Uy+VMCW3JmjsYqDecx7j45kresNrhDoow+hhY23AZHr8UEIG3kEVdbgKi4kob+eu6t7J+1uFcCeOdULupsAHxJfvbaFZUtrklEItRPuVug8Sqs+mhME9noFHFQ2UqypA0+chpgF3zgcquUobMxCBwtmnMLKrH2SgB08pNL2NC+4ruDCgYe322FYNZieM3ib3+3m5VcMwhd82QVkWuFhCvtG6gtA9d9yAkrDTTwXzuUmwB2hf//oCeInBANZcJhSyk3yRcbqHCepOXTZ+95zr1Js/uQ1pFMBINNHh7fBI N/Hh4APU uVusMIRzQd03L+CmAjyEkcxbNHakxCB0+/8hG6ZyikASjqE/p1kY+wo50TcfJToX1kowI2/bflcLT/uQve65u7hx1n5io/iKRXOusrb1cJYkaEeHnBKDMa5LSGDpnhRowuwBQbsDJZQ15r7iPiAWRUynuqyVTw1vCC9N0m0+pbXo9zkZ2qqPrtmtVTGol1URbJtK7zPE2jzn/J2U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Commit a1d416bf9faf ("sparc/mm: disable preemption in lazy mmu mode") is not necessary anymore, since the lazy MMU mode is entered with a spinlock held and sparc does not support Real-Time. Thus, upon entering the lazy mode the preemption is already disabled. Signed-off-by: Alexander Gordeev --- arch/sparc/include/asm/tlbflush_64.h | 2 +- arch/sparc/mm/tlb.c | 12 ++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/arch/sparc/include/asm/tlbflush_64.h b/arch/sparc/include/asm/tlbflush_64.h index 8b8cdaa69272..a6d8068fb211 100644 --- a/arch/sparc/include/asm/tlbflush_64.h +++ b/arch/sparc/include/asm/tlbflush_64.h @@ -44,7 +44,7 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end); void flush_tlb_pending(void); void arch_enter_lazy_mmu_mode(void); void arch_leave_lazy_mmu_mode(void); -#define arch_flush_lazy_mmu_mode() do {} while (0) +void arch_flush_lazy_mmu_mode(void); /* Local cpu only. */ void __flush_tlb_all(void); diff --git a/arch/sparc/mm/tlb.c b/arch/sparc/mm/tlb.c index a35ddcca5e76..e46dfd5f2583 100644 --- a/arch/sparc/mm/tlb.c +++ b/arch/sparc/mm/tlb.c @@ -52,10 +52,9 @@ void flush_tlb_pending(void) void arch_enter_lazy_mmu_mode(void) { - struct tlb_batch *tb; + struct tlb_batch *tb = this_cpu_ptr(&tlb_batch); - preempt_disable(); - tb = this_cpu_ptr(&tlb_batch); + VM_WARN_ON_ONCE(preemptible()); tb->active = 1; } @@ -63,10 +62,15 @@ void arch_leave_lazy_mmu_mode(void) { struct tlb_batch *tb = this_cpu_ptr(&tlb_batch); + VM_WARN_ON_ONCE(preemptible()); if (tb->tlb_nr) flush_tlb_pending(); tb->active = 0; - preempt_enable(); +} + +void arch_flush_lazy_mmu_mode(void) +{ + VM_WARN_ON_ONCE(preemptible()); } static void tlb_batch_add_one(struct mm_struct *mm, unsigned long vaddr, -- 2.48.1