From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD5F1C0015E for ; Sun, 6 Aug 2023 07:59:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 562C88D0002; Sun, 6 Aug 2023 03:59:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 513F88D0001; Sun, 6 Aug 2023 03:59:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DA9D8D0002; Sun, 6 Aug 2023 03:59:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2B5C88D0001 for ; Sun, 6 Aug 2023 03:59:41 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EF9C81A0415 for ; Sun, 6 Aug 2023 07:59:40 +0000 (UTC) X-FDA: 81092930520.12.CEB7205 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf23.hostedemail.com (Postfix) with ESMTP id 93CA2140014 for ; Sun, 6 Aug 2023 07:59:37 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=jdD9wc9X; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf23.hostedemail.com: domain of quic_srichara@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_srichara@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691308777; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cs7nSlSz1/Yjrkm/7/96d76Y2+TH3uL8yuusdSW2KAA=; b=3mC33DjQhKpri2/nzKImpMmVtRfkDGNOuZkse1IlWCKwwW8+1uXe7pV53JGTywruBQmGgx aSmx1YaQH3zjRVV3jpr8v71Uk/7vWryyJJbOmryULBptNLk1cAzBa15ys0/7rLFj5/RmTV xL2uEMIr6Hc4s4kMIfOgcmON7Pb7Ww0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=jdD9wc9X; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf23.hostedemail.com: domain of quic_srichara@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_srichara@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691308777; a=rsa-sha256; cv=none; b=5gac9q4Alyg/MLzF3rUPsL33AZhjZEC9Su0LTc5Jz/hKEKH9BZ2xOmxfgnPE3NAm5w/EwZ cuzw4zTD3dRY5rweOuUBzS8gANoCqTirb8WNwYEfk3RcHxRMv0VAY1BjdxBJiWFNU1Z+KY 9wb92ZV5fszT6s1POolBsyUMkmZqTgE= Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3767tD1b014648; Sun, 6 Aug 2023 07:59:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=cs7nSlSz1/Yjrkm/7/96d76Y2+TH3uL8yuusdSW2KAA=; b=jdD9wc9XGYc87rLoEOB8DZfFM3iKO9M3k9SADjDuHyYai8f9sC2TryagUu/Y6r4+PiP0 ugZ6L6vceyDKnnByCP+8QYLn0CWDyMuaweQD9Zp7S7+dc4qOWBi4djPHOD9895Hnm3AB Y78/AfnFZqXF4AGGT/5KQQdAlPI+x3XZA4Z4r/oKxnBI3pcGUhkiyo5bGN/9pSurd6Ze bO5uYrWYjZwBBZVUwot07ayGuCq2mQJsjAHsBI8impNIlhxJwwxqbNgksFxXqPt0VLn5 HdFCpOmH78IpBTdFjMuFlpkcS60IANVrtTfrfaxrxuUekBtlXFi2X3bHXQ+GtrPVexsT ag== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s9dcy9f75-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 06 Aug 2023 07:59:25 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3767x4lF005671 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 6 Aug 2023 07:59:04 GMT Received: from [10.216.26.89] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Sun, 6 Aug 2023 00:59:00 -0700 Message-ID: Date: Sun, 6 Aug 2023 13:28:57 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [linux-next:master 1937/6910] drivers/mtd/nand/raw/qcom_nandc.c:2941 qcom_op_cmd_mapping() error: uninitialized symbol 'ret'. Content-Language: en-US To: Manivannan Sadhasivam , Miquel Raynal CC: Dan Carpenter , , "Md Sadre Alam" , , , Linux Memory Management List References: <7ad1160b-5f8c-47af-a1c5-51b34f656fab@kadam.mountain> <20230804184550.0cb12369@xps-13> <3604e2ed-8d30-4f7b-9e56-7af5b23b2ac5@kadam.mountain> <20230804190750.3367a044@xps-13> <20230805065510.GA18650@thinkpad> From: Sricharan Ramabadhran In-Reply-To: <20230805065510.GA18650@thinkpad> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: xiT3bHTkG0DYvVPnq4Lt03M_P_EB9nIG X-Proofpoint-GUID: xiT3bHTkG0DYvVPnq4Lt03M_P_EB9nIG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-06_03,2023-08-03_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 mlxscore=0 bulkscore=0 impostorscore=0 mlxlogscore=867 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1011 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308060075 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 93CA2140014 X-Stat-Signature: zsr9aqjtrc6ihw1tfc7utqikfax4wyyk X-HE-Tag: 1691308777-534403 X-HE-Meta: U2FsdGVkX1/cg/19ZQhYoaOKMxhEjIss9xpFBiREszGr1aX0lARfB3ksbxItHfDGnWlU5ZApQVnMr7dyyOggx6l8MeTtJFRUqRDF0lSDCEZwEoCN+QZBG0/pMF0rZCioUmiTLCxpoeOL1ycpEOgGd5iVVFQ1uGfaOX2/AX+zOZyNbxegP90A5IJ1TQg/fuPwQQoV/PnQWzLFnlQ2gW0lpYrCE4pq/fNwisn75sPypWTbXarOJGvMkHf9mVmY1CLUQnELTXUF+cOp96z5EutVxxPzkIY0neOuxZiOLOSZVY57e2BH4QqOSU05K1TEO2ryZzoYiPdMYDssQje8MnoH2SndmH3nPBlMUcEDEN/6ViKiElLPUuu9Gv21OeQzaRmhDlwPybz3oVqMvWJpY+tlyUeznqD+QAEYZ41kgrIcNl3dSsrNWQvzfn5nt5kdxcs81iiqzYdB5xwKRAsBZyQ4Wq9R2sMJbWW9/2qjJPiGrsU7xk8BHcJo89cpu5LWxORjWvBUj1bGhDVHXJsATZeXXWOjmMFIHVMJmb8UAXtHG464tk57BmrQQCnW8f2hOFCBsSW6KkYZDZwBkKRVnSJ+rTj16H9Hw6NTLZqe9+VvfSQa7TnDmWzsidBOHI3CnlD7TKbrQPTplIQdD7ndForbTS8Z7HY/pfIYRqX98umU+nRmkLf1xWTPPhLnbZ52TH5uW6rqvKDyUHqXggdOodNlnsH9Pua2D/GARNrGUogtRGArhFWWpU6K5KXpYvwexmGaDTIAbiSugRNYdQ3qsX2+sHu6dHXBvp7PJqeY6eFOKsguFIx7b1HqhvVMIeaaigSDb+Pc7G06Kn9ptqMct50km+k2T9zmykk2FeBw+i+Ari+5uD2z2+uRKjwRaN5uayUSA8eX7CRCnZ9XtH1nsHDNJJpx4rrjfjlsDiNo/hK4SUlBRneP97TdDcrj80bUk0lF4LOhLOSed/IxdLz1rH5 jY/qEftm btuFSf29LBScrf3idHKHOzMDhggDKbNbTYk38Y1KhU+1K7alSbE1MFXZMIyaCS9m1AJIUh0PoVvbrSjdjbp52M2M54Ifec7Cjd1dUcGczOZLDR1rRX+krImEyl3VbKOiq9N05kr1mL3qeOvqTQpDpxmqBqAaBCjjEhnsyTJtuKQVm7LOvpRcPEDsqnhwSNIy4o1KqcfwzOFVaP84y6mRYlu9p3RVf6fPFZS//yKJOW3OJs/nzWreZoULi/ZuBwg8TF55t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Miquel/Mani/Dan, <..> >>>> The || should be &&, otherwise it cannot work, or am I missing >>>> something? >>> >>> Yeah. That's how this bug normally looks like. NAND_OP_CMD_INSTR >>> always returns -ENOTSUPP. >>> > > Yes, this is a bug. > > I didn't get a chance to review the exec_op conversion series (blame myself). > Now I see scope for a cleaup series :/ > > Let me spin something by the end of today. > Thanks a lot Mani for the quick fixes. Will test it. Sorry it was a holiday for us past few days, so just checked this. Regards, Sricharan