From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED0BFC19F2D for ; Thu, 4 Aug 2022 11:01:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5638F8E0002; Thu, 4 Aug 2022 07:01:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 513758E0001; Thu, 4 Aug 2022 07:01:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DB9E8E0002; Thu, 4 Aug 2022 07:01:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2EB778E0001 for ; Thu, 4 Aug 2022 07:01:13 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C8A281C6D80 for ; Thu, 4 Aug 2022 11:01:12 +0000 (UTC) X-FDA: 79761618384.04.FBBAE5F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf31.hostedemail.com (Postfix) with ESMTP id 4341B20124 for ; Thu, 4 Aug 2022 11:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659610870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ja8DJZE704PWhWiVwa+IkYEZUfwBCbT5/nl9Rxcn20s=; b=EquB3sOKNwom08aTyUIQyoH+CAqyYGHyrQlMipNuOi3ovO8BKYxDvjy0UP/qi+VBTTP1mx ARNg01i5ccPeAYCCyo0de7+v/EfvlPCocDSygYt+HoQ755OlutbUT+KIxnjXymS20vWa37 R5BE/QHa7+bHF91I8DIK+6BqmeauNZo= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-216-aIB-ZKPsPKKA6x2jqGhkug-1; Thu, 04 Aug 2022 07:01:09 -0400 X-MC-Unique: aIB-ZKPsPKKA6x2jqGhkug-1 Received: by mail-ed1-f71.google.com with SMTP id y10-20020a056402440a00b0043e3e5a4cdaso3115607eda.21 for ; Thu, 04 Aug 2022 04:01:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=Ja8DJZE704PWhWiVwa+IkYEZUfwBCbT5/nl9Rxcn20s=; b=6NIUTbKM5Fp24X/eqGyJ37NJ7gQFSRfXu1h4NTk22CWxBoSnUmrvnooXf1GiNwVxrT K8QqgMhHVnRqsyHGxVS04TfTHttB5elqGXmmOiR9Q3BVKR25jyXpw/IxQWDELGadlr5s z4gCPD0FOidjGY3KIXgrnBA+jTWs8tBDVJ2Zgi+/+SK+QAnjtR6tHEzKEru8tKgY3sAm FveHdOIIcM3buQRzeLeokX1EfLPb/AcOS7S6RBvSdbEDT2aEDHzb2UYrWid1YKOI8agj MP1sE9Q/clskPAxBCpj2lntN+6Iq9RyX3LV7rVNO1yf0eNMfVvdp2EknZNhff0vUVX6E HPjQ== X-Gm-Message-State: ACgBeo2wzLmnh0XjS1zCUDPDraZZ/ccOcKM8xWaCiv/CcyCHeBF0IuDD SkBpLR2UTRIKZk+K4DU/f52/csuhHUmYZOZKJM0I0b/1k4Ga77C2HYpay94Tx1anqHWTMWM8L6/ MrEfPSX+TRHQ= X-Received: by 2002:a17:907:3e0e:b0:72b:568f:7fa7 with SMTP id hp14-20020a1709073e0e00b0072b568f7fa7mr1028674ejc.119.1659610867856; Thu, 04 Aug 2022 04:01:07 -0700 (PDT) X-Google-Smtp-Source: AA6agR4cIXLgva61l3MByTN1QLsYZYOv8abIXXSRU/VwPQHdywWn7XZbzNgvDk3iuWQUuxjDBy7l9g== X-Received: by 2002:a17:907:3e0e:b0:72b:568f:7fa7 with SMTP id hp14-20020a1709073e0e00b0072b568f7fa7mr1028657ejc.119.1659610867576; Thu, 04 Aug 2022 04:01:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:8900:2c18:b992:1fa1:f88b? (p200300cbc70689002c18b9921fa1f88b.dip0.t-ipconnect.de. [2003:cb:c706:8900:2c18:b992:1fa1:f88b]) by smtp.gmail.com with ESMTPSA id b8-20020a170906038800b0072af56103casm185015eja.220.2022.08.04.04.01.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Aug 2022 04:01:07 -0700 (PDT) Message-ID: Date: Thu, 4 Aug 2022 13:01:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] mm/smaps: Don't access young/dirty bit if pte unpresent To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Yang Shi , Andrew Morton , Nadav Amit , Konstantin Khlebnikov References: <20220803220329.46299-1-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220803220329.46299-1-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659610872; a=rsa-sha256; cv=none; b=WGwQvUIAh7c2X1KDXQXzpTM/NYkQRTVpJdoBTBMc7lwzma4mvAphGSJeE5n5pDggtA3lZA hy8l3nZ5PlOJNaoaw3hie3po+k9Cwh15rWcFV5DHUQozoprkOMxY/xaK4Vt28+4/C6lzYH 67uy8U7cxwXYIIVGo2Ckn+8bB5DAZuc= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EquB3sOK; spf=pass (imf31.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659610872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ja8DJZE704PWhWiVwa+IkYEZUfwBCbT5/nl9Rxcn20s=; b=nytT9xkC7DfXJS2vIXA38ZQN5NWQKO2lUlmLwjXVHYw5c+kbv+DZsms/lkH9EAuCJslTDw b1CXiOdMicqHbmg9dZkfR3UNCPziSHEnGdCZwwtRWYvtO2I2BWFIK3+qElw0KuJizBbpeM IcWG9hcpMjFbGy2zxHeAEre/qXRaeHw= X-Stat-Signature: gewnht485zmos48xe8b1hagf4mmmju71 X-Rspamd-Queue-Id: 4341B20124 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EquB3sOK; spf=pass (imf31.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1659610872-199543 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.08.22 00:03, Peter Xu wrote: > These bits should only be valid when the ptes are present. Introducing two > booleans for it and set it to false when !pte_present(). > > Cc: Konstantin Khlebnikov > Fixes: b1d4d9e0cbd0 ("proc/smaps: carefully handle migration entries", 2012-05-31) > Signed-off-by: Peter Xu > --- > fs/proc/task_mmu.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 9913f3be9fd2..482f91577f8c 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -527,10 +527,12 @@ static void smaps_pte_entry(pte_t *pte, unsigned long addr, > struct vm_area_struct *vma = walk->vma; > bool locked = !!(vma->vm_flags & VM_LOCKED); > struct page *page = NULL; > - bool migration = false; > + bool migration = false, young = false, dirty = false; > > if (pte_present(*pte)) { > page = vm_normal_page(vma, addr, *pte); > + young = pte_young(*pte); > + dirty = pte_dirty(*pte); > } else if (is_swap_pte(*pte)) { > swp_entry_t swpent = pte_to_swp_entry(*pte); > > @@ -560,8 +562,7 @@ static void smaps_pte_entry(pte_t *pte, unsigned long addr, > if (!page) > return; > > - smaps_account(mss, page, false, pte_young(*pte), pte_dirty(*pte), > - locked, migration); > + smaps_account(mss, page, false, young, dirty, locked, migration); > } > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb