From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 289FCC61DA4 for ; Thu, 9 Mar 2023 13:58:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDA386B007B; Thu, 9 Mar 2023 08:58:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B62EB280004; Thu, 9 Mar 2023 08:58:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 967E6280003; Thu, 9 Mar 2023 08:58:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 812C96B007B for ; Thu, 9 Mar 2023 08:58:16 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 32BEAA0EFB for ; Thu, 9 Mar 2023 13:58:16 +0000 (UTC) X-FDA: 80549514192.13.5F69A9E Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf22.hostedemail.com (Postfix) with ESMTP id CD534C0013 for ; Thu, 9 Mar 2023 13:58:11 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AwL7Oat3; spf=pass (imf22.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678370292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=62PJSqqypmKl3sWw6Jk734/lkvxeLFqvlCDg/7dZbIE=; b=J14SAGSK6rotcGRIImOf/E6YUs+BMTmSZPHq6WzJFG6N56vhaU0CrAB5XJIep5+imJ+UOl HbQX2NHNIQxcsfeZLcsfzuG9Ig3DWCAcQMhVrKIp7Dx8LoBnB74k7d1CrXXLtgVU3sWB/o BfcF3nZmmRl8Vb1nJcEGIFkb1zZJ50s= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AwL7Oat3; spf=pass (imf22.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1678370292; a=rsa-sha256; cv=fail; b=p5a1yo56ibgfIWlXNeI4x7a44wWbJ44EcxQfXWt41EGFqbrbvci8/dq33GhC9HmfrnGJVm uSGQT+PEeEmhXjSE+4nwYjdjo/97hVw7nJZ8FuA85LBuzvLmxaH3dx5yNMEfKZ+inpH6sS dLhoNo0THfJDqHFFM8o59fUZBP4F5rY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678370291; x=1709906291; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Mw2cbJhXpZe0c2m/+1zRZNpqmSg4m3L4ehM/eZqvh68=; b=AwL7Oat3VG00a1BBcLInykY8pfHl2+CqanxqS5QOTk59f7vlhyvIrCVZ BVynoAqNItjeTlSxFu9cHfmEeG/tocL4LSUDKJplT5OJDcbiujuZpu1fX lm6xI8h/wqG8H04WuC42xP7x7JebgS9O0HPcXyn9kPHxr3RS61gzR7wtD khGY2ZgXRrKssXhk0yVR+XM9tUQ9qp/YYVqWoBj+Jhgl/OaHYVfYLXPnt arBkE3Uf67wdTrE0fhY6iwwB3UKteQM2GsIkWCfmyPkAmWgfrAYhRdUwz Uds8XI4WuVtO7sw9ycm/VogXo9+8q+0v1fFXdIZXIT1pZZcu5fTHF/neo g==; X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="316841664" X-IronPort-AV: E=Sophos;i="5.98,246,1673942400"; d="scan'208";a="316841664" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2023 05:58:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="923238963" X-IronPort-AV: E=Sophos;i="5.98,246,1673942400"; d="scan'208";a="923238963" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 09 Mar 2023 05:56:52 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 9 Mar 2023 05:56:51 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 9 Mar 2023 05:56:51 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 9 Mar 2023 05:56:51 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 9 Mar 2023 05:56:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YMLQrU5a4Yb022yIT3w9UVFrUMvhAjobJJAnQz6FA2ZUfMIqaH8efwxKBn6c9YIxpWKH893evz+BcknGsZnARhJt3HFkDe27L5c/UCgmcm+61P2nk68DAa/POIqtrlaV4G9KesyeY9EJWnVJugMk2dqwh9KSiJtTNfRcF4seH999HNe5ILjRNSnDArAk5iPtDb6FW/T/5E2CpbQCNvx6ng1R9PoJE5KrnHma6LTjggWov19hPY6mKae1V/jp2mQ4E7yyipL8jOM34aId4QVF9V0WDCmId9Ph301uNLoa9j0kVTV97S1I3j8wpFaTIa5udD/O3Nl2NCLs+7HIuqcTLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=62PJSqqypmKl3sWw6Jk734/lkvxeLFqvlCDg/7dZbIE=; b=I5+0kdjghSBDdifrprtc6zOE12/SCTl6Fb7JcybpmGth9nnWmSz3nd02hFTGMXY819ZHemo5TImLfb7a4O5j3nVkcgEsuTj44Pl0F5zB1lPkayWflaV20qd7rTXStvdL4AIIgm9lEZV/btm63buJiJSV2YbWFJyLhxsF80h0BoCAlHspCYySq2HDSBQzemA3ZMkl06ZrQ4WXAJR4uKxcQ4kyg9RD12VbmFSxu3FOCkJOTCUbwWk/5wHY7ECNAojer7upwlk3qR1+eBrtPVJvMHfNhlTysaTlUqoCDO3kP4jCbJnNmi9PnU8VyIMa7vIxll7a+jEvO8gxIRd0ifC0cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by SJ1PR11MB6249.namprd11.prod.outlook.com (2603:10b6:a03:45a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Thu, 9 Mar 2023 13:56:47 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8073:f55d:5f64:7c6]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8073:f55d:5f64:7c6%9]) with mapi id 15.20.6178.019; Thu, 9 Mar 2023 13:56:47 +0000 Message-ID: Date: Thu, 9 Mar 2023 21:56:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.8.0 Subject: Re: [PATCH v3 0/5] batched remove rmap in try_to_unmap_one() To: Andrew Morton CC: , , , , , , References: <20230306092259.3507807-1-fengwei.yin@intel.com> <20230306131244.6873a02146b3a5b78d86e02e@linux-foundation.org> Content-Language: en-US From: "Yin, Fengwei" In-Reply-To: <20230306131244.6873a02146b3a5b78d86e02e@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR06CA0200.apcprd06.prod.outlook.com (2603:1096:4:1::32) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|SJ1PR11MB6249:EE_ X-MS-Office365-Filtering-Correlation-Id: 63d7d70a-5f32-494e-0212-08db20a61f97 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MmRaxunplKqxbnQCmQjhkXbuUUa0vfipBCXwYLQ0/uzSyQOzNFXNMdvzSF1YkkRDP0XOU85wYpg4vMrQltvksdA+gMqW5uyjn4MGQl4++b+a2wxuAvtXzpx1S86Zd3TwvFXJL0yzPPj/jT9QAxFLjuHOoM1prxeqfRj0nIl0BLrPH7r6iTY++GqO+ZrQ8vbatvNpZCwiMITDOYJdeMRzlrmKk2BfljBKbGDyal1g2A54a0uq2kn8eddMm9XSA+xfIv14BCx5VQMb3GzWCXWbEpXU6tmhU6gwydiq2rPGo73i4Oqi9CB9vXkGIip+dpMS9cjgkETGJAWZtB/xVP1CS0NBosoMQfi/nxx3mYfFtqsGcTgNSCtxdyuxMxYVbFgq1KuEyrGzaBkl24FsKxYVsIVE5iP0/adryocE2wbAfTNt2jdugvHFyJK/LdvjlYSuKJm0yodkC0kBpmeF48C3MwrkaJbpG4prXtN90hNGDBP4Ia1/WpTIvHDbFWkSXHfuxoojLwXHQSflPaSK9eHda0236ull8OrSrtfDQwE+6INGPNBDGbk8TnqsyqrgCKLegBrHA1Sfxud8r5fej9ZNRYsP1uhsk9NFyYoBWxWh2FCm8uxSTl1ZF4fCsjFKyat0a5TOguKV7Xha64r61VSp5GTq0ys7e710Rsw/kYvvpyTlKZCw8PNXgnUqd/Lbn0GJ9pFslwxd847fJTdPEtqj1jmtwroqxTedSSzlmN9Zgzc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(396003)(39860400002)(136003)(346002)(451199018)(8936002)(36756003)(26005)(5660300002)(8676002)(53546011)(6506007)(6512007)(38100700002)(82960400001)(6666004)(83380400001)(186003)(2616005)(86362001)(316002)(31696002)(41300700001)(4326008)(6916009)(66476007)(66556008)(6486002)(478600001)(31686004)(66946007)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWlTNFNjRUtaYndoVkdicXBWZnNtQ2NaREpoRGVJdnRodEFFSEJ2MDhaVk03?= =?utf-8?B?Y1YydW9VdGttTlVDa0h1QnZiV01ET2ppRmlxNU41bVkxQzRGREVvQXJmUVdB?= =?utf-8?B?SVgxVHMxNTYweFFMNldJc2ZGSDlESzllcGpSYTU3c2R1WktOMmF2MVRPVzI4?= =?utf-8?B?Z2c2b2s1TnFNd0RiZGxsWW5reU5ONHk5RmZuemJGVGZibXkyRzJRdVhWYk15?= =?utf-8?B?T0VQc2Zza1VzbTZxWnNraGN0RzlZQUJ5U1BCa2IwOS9aS0g1TDhyOWJIWVU1?= =?utf-8?B?ZDFXVlNaQ2VuVmwzM3lYaWEwKzBmelNHSGFHRDROcDJ4SWVuSWtHTCtTYVMz?= =?utf-8?B?cm0zM3ZtZ3NyWHhLUDloMjJWV0xxMmYvbm5FdFprbW53ZDV1eWN6SkZZeHg3?= =?utf-8?B?U3lJSlQ3c3lLUk9EeGcrQWk0R2lCREJCVjNnc2FPdUNPVjJuUGJ4c3B1dW5w?= =?utf-8?B?YUpMZGFOVnVKVWJEdUpURHdVcHRGaHVianVZTysrejNaY1hiY2hZZk9ZRUlo?= =?utf-8?B?OUpVMU0rSklDZjBrMWdlMjVRTzVUZlZRemJYYzFzeVZSRitOc2YwYmxkeUpm?= =?utf-8?B?QXY0aGFyWnJPTUNEZjNUcXZ1Z0o2K3JrTGtiQ1Z0aWFWdzBtNkZOblVScE9o?= =?utf-8?B?cDhIclNMZzNrdDlOVVMvSVFJa2F3N1V1UzNFK1dpcURkSVFiU2NQWXZaalJz?= =?utf-8?B?QjBkN0FhQWZ3T0xiZk9xZk9VbjlodmJKdWU0QTFQLzZSWncvV1dlWDhFWnk1?= =?utf-8?B?VDd6Q3d2eFhCYURhL1N3U3VUWDNQcmdiTzlPNVRnSXJ0Q3NJTmNTQmJ5Tjh1?= =?utf-8?B?aFZ5ZG5QVHpHNjhDeFNLSk1HbUQ5dkRRdEhOcUp5ZG12RDhlUHc1Wkl6YUh5?= =?utf-8?B?TmhGV0pWMnc0a3ZuSjhPcXdncUYwenhmc0JHK1M4TFV6TFJFZjduU1c0V3M0?= =?utf-8?B?ekRyNVUya3pyRnNzVW5COFJwRFRtRTNsVU00YjdLOVozNVpid1NpZ1UyNEhw?= =?utf-8?B?VlBzN012QVVLLzA1Z2h3aU14eGw0elVMdEpEU1l5TWVpYWhNeXNDRUpWeVRr?= =?utf-8?B?alVxdkJTU0hmbXdpQkNqS1d3dzdoVkFXTnRUVkFWZ1ZYSDV5eVB6NWVvN1Nz?= =?utf-8?B?UjRKU2lMR0ppWG1ycm5YdDl1RS9MTFd1MzFSZUNDMVVKLzVibWJKR0ZnVmh1?= =?utf-8?B?aWN0RkVPVWZRY0NQa1FxV1o5bjZnSVhzV1JtOUxpRjcrd2JoV00vc0UyUTB6?= =?utf-8?B?bVczaC9IYWpFaDIxQkludkJEVnIrUzJiSGNUWXNLYXp2STlJVjAwUTAyRU1H?= =?utf-8?B?UEtlRVVkNGJUZUV6VkZuc1QzVS80aWhLaG9sZWRmQjkxekh0MVpxaGNGeHFl?= =?utf-8?B?U3JoV0JjK2FZKzZnc3pBMHZsMDNNeXZLdVRrM0VaUDA1bVFSVjU3eEhCZldJ?= =?utf-8?B?MjNqbjdkR25yMEdHSHZ4TkhLYzZkdGJwUzBVNzFrNHk3OWVRM21nNjR5QnZZ?= =?utf-8?B?RStGanZuODF1VUo2UlJSdXRDNnRPU1JiazdMVGxKRUhSTXQ2UE95bnRaZE5m?= =?utf-8?B?TkRYTkpzMFR3c280TzdjUjJiUUczUHNnRVV2MTMvTFZwZm1YY0thR3FqVEYw?= =?utf-8?B?ODZpSCtENlNjY1Q1QkpySzcvTTU5SEh5OWo1Umt2TXQ4QkFNQmRTZ3BENTZ6?= =?utf-8?B?bGRHdUI1QTdDMWsweTAvQm5UMG9LV2hWcDRyUFFQMm1tZlVVeG9CUnJJZEtx?= =?utf-8?B?OGZxNFhDc1JiUzR1WDFWQVdMUjhqcmE3SEhjVUxoNTVxSCtabEppbFRKdVE3?= =?utf-8?B?NWR3U0t5R0JoK0FHUGdpbGZHa05RMjk2NGxhS3J2SnBNbUNya2hkZUVrOWlD?= =?utf-8?B?Q2JOVnJMc1YxVjY5MGlZNHZIUlhDT1c1S2p0SU1TR0FLb0RiSGl1NVBYK3g4?= =?utf-8?B?NGV1ZVdEMlVZNlFYMHpyN3E4Zi9telZZeG1BeFBxem1YcXI0UDR6cEgyaXVR?= =?utf-8?B?RFRvY0s3RVRyRmJlVVhmZHEzRmJUNkJ6ZmVySFJFakRZeTBySGswejJFN0w5?= =?utf-8?B?elAwbk9rNU5wUGFMTVUvSWNJZk5BRHZ0ZWJQYzE0MDJzZ3F1ZE05TE9aQWVF?= =?utf-8?B?YzRHZTllTzdPZkdtUVBKUmMzVzIwMmRGdXMrV0ZEQjRhNm1PVHU3b0pNV1kr?= =?utf-8?B?UHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 63d7d70a-5f32-494e-0212-08db20a61f97 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 13:56:47.1738 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R1y9U9kP8Dqg84tGujObRDqyt61oUk2aI+t9uoOuP7BFY/zMuVw6CsQR3LE7waxJP1Aaqnzwc2cU97dI0Mj9Dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6249 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CD534C0013 X-Stat-Signature: wjydx98z6o5e37bgcomok7hin4cr6qc8 X-HE-Tag: 1678370291-151032 X-HE-Meta: U2FsdGVkX1+rHOlkMLWlNAlqjJFMyOSNnhkzstuClKzEUzIXCvd+ze6V2aie3Q6A7PhxqjJz76gDJFgmhVWbeuM8K6z8pfpCdWljqvg/tpEsekrLWISFGZhKh1DxFeXvGMI05s9MgtL1Y8OXMc4l0oiMe+2D5JjL7O4n+VUlKuomnxF4I6TVvPjQZb2Bw2wObho233vFL+DcfxkSt86H7FBcbwDgZYmbmDeIbwBQZuYk64FPzeihKwUZC055MJQJnyBWOq3lqAtTpgpcRGHILVC6ySDXZhqRqS7DBgnke5OUkA4lq+OEVusVXWmUPjBgwKwL6V9LqkeTIV7q/EQ3SI2APpLSQ2713Yu4aKUHlTAZODMN6DtPiPz9PTOZ3tpU3fyO8d9OFdTEK2ZunpvfosTYLItMgMp2j66RT7ds4GCzuYfEorjM/Ixf/MVaZp+Cw5z58n4mXGgrsBChrUyu7Ejgqf2yXKblzcC7LCuH0kjLsvCESJ9Uezfldja/fFd49TTNPtWyQKuzkCjfB2/SYTzmctQiv27gnHOFj6m0fwBQTkr+ftrRAS4glQnkTTSjfQg6elNUDcuVH+MY2fTV+f87QcsqdG4VLwDgS5cRPQ7NpZttHgQZkG34oXLk6/uTPvVxzPz8LnMNZKOgOFZvLIFgStZp3oY9f0sqBTOkmy/JvxbcwAJE1RJWyjHyqbAPTVzPQJ2hYGvFOACSg4t0odBtkxsDvLo1oq9d3KBiM6Azq5wJdRvbJ2gWhj+wI4QUCuDMTUgYukq96/emOVxjrUFVmJq4vS6+ACdOhbHPm+9Kyx0ueriKYfHrdAvVHdjMfYyiQX0XdV3Q+xNyUknYirYBxxvVkXZF43AbwvocryiaDaYdf8S4EX+Xr1pMxjRXTsub07Kp65dSMatyJzhQqB0H4o9PVIzI52LztRACB/GJ3YgbkbGrK5AMoHiFBKB6ljPN7GrYG8MAXFMaJMA L77vI5vp 89O9n1vne3NAC5kOijEJuOWmTyqjtuTqRK1zGr6/LFiA1tv4Y5KyYKHtmCSwttBxvi4uFxutgjQdqbJ86lNQg4ueavqmW2nML3yaNGSyPkylYpqaPjWqQc/HpI0Cwb7JF8nqHzmmpgEMypa5slNdPqTp2TM7BiVyMBck/RN3gzdy8dzlUZ+tbJvYbRXMuIEFWL+cwCkFUtABvHawmqfI9mpDGsP3Xt5Rsz64qsJuNYyTpX5m9CiOIL1uco/TIDQe4p5b1yyLPT8Sgy/q6hsmZqE5BYCR4wbbvzHReXv85znMFCBkwk7MDXnEKr7c+XNhBVzjr+55TZ4N12p8IixQ71QURY/ska1PFIRTGPhIl8SyaAWc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/7/2023 5:12 AM, Andrew Morton wrote: > On Mon, 6 Mar 2023 17:22:54 +0800 Yin Fengwei wrote: > >> This series is trying to bring the batched rmap removing to >> try_to_unmap_one(). It's expected that the batched rmap >> removing bring performance gain than remove rmap per page. >> >> ... >> >> include/linux/rmap.h | 5 + >> mm/page_vma_mapped.c | 30 +++ >> mm/rmap.c | 623 +++++++++++++++++++++++++------------------ >> 3 files changed, 398 insertions(+), 260 deletions(-) > > As was discussed in v2's review, if no performance benefit has been > demonstrated, why make this change? > I changed the MADV_PAGEOUT not to split the large folio for page cache and created a micro benchmark mainly as following: char *c = mmap(NULL, FILESIZE, PROT_READ|PROT_WRITE, MAP_PRIVATE, fd, 0); count = 0; while (1) { unsigned long i; for (i = 0; i < FILESIZE; i += pgsize) { cc = *(volatile char *)(c + i); } madvise(c, FILESIZE, MADV_PAGEOUT); count++; } munmap(c, FILESIZE); Run it with 96 instances + 96 files for 1 second. The test platform was on an IceLake with 48C/96T + 192G memory. Test result (number count) got 10% improvement with this patch series. And perf shows following: Before the patch: --19.97%--try_to_unmap_one | |--12.35%--page_remove_rmap | | | --11.39%--__mod_lruvec_page_state | | | |--1.51%--__mod_memcg_lruvec_state | | | | | --0.91%--cgroup_rstat_updated | | | --0.70%--__mod_lruvec_state | | | --0.63%--__mod_node_page_state | |--5.41%--ptep_clear_flush | | | --4.65%--flush_tlb_mm_range | | | --3.83%--flush_tlb_func | | | --3.51%--native_flush_tlb_one_user | |--0.75%--percpu_counter_add_batch | --0.55%--PageHeadHuge After the patch: --9.50%--try_to_unmap_one | |--6.94%--try_to_unmap_one_page.constprop.0.isra.0 | | | |--5.07%--ptep_clear_flush | | | | | --4.25%--flush_tlb_mm_range | | | | | --3.44%--flush_tlb_func | | | | | --3.05%--native_flush_tlb_one_user | | | --0.80%--percpu_counter_add_batch | |--1.22%--folio_remove_rmap_and_update_count.part.0 | | | --1.16%--folio_remove_rmap_range | | | --0.62%--__mod_lruvec_page_state | --0.56%--PageHeadHuge As expected, the cost of __mod_lruvec_page_state is reduced a lot with batched folio_remove_rmap_range. I believe the same benefit is there for page reclaim path also. Thanks. Regards Yin, Fengwei