From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B41E6CE79CE for ; Wed, 20 Sep 2023 13:16:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5366B6B016D; Wed, 20 Sep 2023 09:16:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BFAC6B016E; Wed, 20 Sep 2023 09:16:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 361706B016F; Wed, 20 Sep 2023 09:16:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1F9C06B016D for ; Wed, 20 Sep 2023 09:16:47 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C1202A06DB for ; Wed, 20 Sep 2023 13:16:46 +0000 (UTC) X-FDA: 81257025612.07.D450FBF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 585FF40003 for ; Wed, 20 Sep 2023 13:16:44 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gCVKgetc; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695215804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4TWOLSo8HNAumxEdXb8FwLPVqXlryu4M1tjfBv1puco=; b=PAOufKGV/tgvT484TGriTo//5orFDcqllqkGKoQOtkrD1go8Df4dRIDMJjKjnZ0xxP493C SwjoYPM9d7Om3M/TGqteHmBCX7eYHHPKz2vzQlylfiGA4G1wsLSWjSRlY/ciX2x+1xxSDi 6as53sNeisDkXBdWGcUehl30aoVaBgo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gCVKgetc; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695215804; a=rsa-sha256; cv=none; b=jHYfDEjnFQN6RTzdG9DsFJJRP6bTr3RgmWTSy1Q2aixyF5xAzGrDeCQctSFRGPgGjccPmO PDj6Dh4GD1k7hodArcdsZWtZQpMWcti9GcWvjWqicB3zgO57VfePT0bHzGGrPI2vv8DB9g rO+jCHqGW1t9DHX1YWvOpYdDfwsPcww= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695215803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4TWOLSo8HNAumxEdXb8FwLPVqXlryu4M1tjfBv1puco=; b=gCVKgetcl7AlGbwMa4aMtD6/dQVIu73C1zvbzXStwdAADPCCF5YW7uxlZT5gZgUcDpIZkn axEDUrArwOFO1QWW6LWsZxCLhgqtfKEKD7dbRP2NBfdei1e8UWJeVOkcCYhhu3d80gan3o j15pHeK8HD2IN7g03lNgzDFT0qu68Mg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-YE3Hr7ZLMVuvtMUpYO1naQ-1; Wed, 20 Sep 2023 09:16:41 -0400 X-MC-Unique: YE3Hr7ZLMVuvtMUpYO1naQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-30e4943ca7fso4527114f8f.3 for ; Wed, 20 Sep 2023 06:16:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695215800; x=1695820600; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4TWOLSo8HNAumxEdXb8FwLPVqXlryu4M1tjfBv1puco=; b=DverUIxQ1Tddhrd2EDYbzS5nZJ8UyzKhFq0MQACMWjDXG2OMjDulFmBUxhdQIRM9GF 2Bl6GhEojduybmWZw1pzw3WrVR16bKGsNetTfDJpkeU64NR2nZNJ/4Chrn5dMzfim8bk Oo1hrH8TQdZMh/sUhahivCNYv63yCVVwJLa/9CXcs7reiap8X3wYn4kGPFEyPrDcLA8v lcRAqzraf07I6h7pwxgXhb3FxN2FbJUvNfyRLK9B7Lq5KXNpTWrbkb4PWKPIZV5bHInA anDn+Jfq2St788pHAbymTlH1ze/PC4W/ZTDiI0Gi7YziQN8+EWyKuZT4bv0Eqrj+S+Kq Biew== X-Gm-Message-State: AOJu0YxfXvAlzdH7+djIq2U+4qs5Z3PgFDCZLvS6WMmVIm9BPIxtxZHK 3Wm5XR+rUKU9uOw+WhesGk0NV/lsXX3MO3YUOt12c5kenOmVfpaPiGrHi5oao0lVTLMjwuGo4JW Sbgehfztf0nk= X-Received: by 2002:a5d:4c47:0:b0:317:5e91:5588 with SMTP id n7-20020a5d4c47000000b003175e915588mr2350960wrt.3.1695215800566; Wed, 20 Sep 2023 06:16:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFoxkH4fJ4IWTtydyWVjX3Dh7sW3UjyelgPeBkHUWrD0hiFoSLYgkFFH/YN+BrbyFmyPjIFXg== X-Received: by 2002:a5d:4c47:0:b0:317:5e91:5588 with SMTP id n7-20020a5d4c47000000b003175e915588mr2350938wrt.3.1695215800071; Wed, 20 Sep 2023 06:16:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:8600:dad5:13bb:38a9:3010? (p200300cbc70b8600dad513bb38a93010.dip0.t-ipconnect.de. [2003:cb:c70b:8600:dad5:13bb:38a9:3010]) by smtp.gmail.com with ESMTPSA id j21-20020adfd215000000b003179d7ed4f3sm15175401wrh.12.2023.09.20.06.16.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Sep 2023 06:16:39 -0700 (PDT) Message-ID: Date: Wed, 20 Sep 2023 15:16:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 2/2] mm/ksm: Test case for prctl fork/exec workflow To: Stefan Roesch , kernel-team@fb.com Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230919205158.1897353-1-shr@devkernel.io> <20230919205158.1897353-3-shr@devkernel.io> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230919205158.1897353-3-shr@devkernel.io> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 585FF40003 X-Rspam-User: X-Stat-Signature: osd9kme9etz71paf8wm4aq1s5mhb16yq X-Rspamd-Server: rspam01 X-HE-Tag: 1695215804-304083 X-HE-Meta: U2FsdGVkX1/10FzWMIYwS6g46fnP3yDuXzJ1jgv8xpOqwofrM1ksqkV8NxhPdf4pKUZAET8rxHik+5GMaspUKaTSh9o58x1Z8ujH+C0wnYFLcPKZTMYx5pqPBuDHHvxZUAYVRUUEiX3PK3rQ26bdtvdezzpUJDqKdmIq0Dh9eL5ma5iLZiGdW/FxTE2mBuw+IKjLhnTCJTt5cavlkFPwXDsR2x2SIw9EzMXgu76SN6MTOm0z7hs4Au6m7aZz01YZ4cWxQsBuSghRqG6Ors+ilDV5NwtZfAwuy8WGzdnIlisc05Yu7HmbwCaFlTkidvQli94iaTpNRtOwrv2YwAxOhiSUeEIeCP5rcBa4jURNHNhe1sDcxnnnKanvqsbg4xEdVn921pjyqTmsbMwa37aVsAP3lch3A8t+wk2BC97oJKFwYFbtj1LUo/WaH6arChHsFM4gmjSvTGFQW3ynDRiHWRGalvpVAIiTE4dypitwQwJ6JzbE60NJ55yo+F8uRsAE6t2iyaGPtstvRZ8DXjZ3m24rDPLLvJQBtGP55Yn0NHTOL5bswOV64r/2RgUAE+7vFwyVaxdARSuzNrFpu+WaxcQKKxSfB+8UiJGPKB9H5XoREO0q/7YSzSLuqg1116lV5k+5ES5aSgs374PeNrWiaItvJnozzRsJdSkP7LNZvcV+caA/J4Eme98e62SEscnP8QaOKHFgsbyHyHjo+CdiD2aqlhRO+hCZoFTsRU62XLV3L33zsZ12LLqKeDvhFi2ZvAuoObYTuBgtCYCLdYoiQC85eFclrjtogjy14oikkt0Shd+gdUmmRMAhUo7eFerTDZMnBqhrQuVtbyoIKyVWgSmrRszs1oheRdey7+55Go+IJcUGYwe9XSSqWOm6ZMHrcLWm4gfcv7RnKPMsk5d8DNll5O+8iFS7fjcqebQp37CwoZvz1THI5meyOjd/wFQFu5VilAgWRZe8q3npoZn YgG9HpwE n0fnciBsT85Sb8EN5+nr309N6g9Cmt2wUxJJ0mjKPrwKHuAiu6Va7rKebt7y309h9xDns648rxitzktCDubfnQm7pc6rHIm+0YxhBC1BgLXK97d9XyJ/gCA20Pfeat/3icUELnAqx8N67v5F0OHs2jo1S1Oxqy3dSszTEL7xg97lfjygOHCcc9y68lHI6acw1PiZipXghLa3j2TQnMePpJlkIKBPlbv4VJZ14AbqE/8tzGmg3FBEM9lrLZfyNJm/A7jJCxfyTpxah8bkxY0NkEk6GlxZmLfpK/tRZIaa888iKqtI7tcwUEkELvxB1iIHqfcNC8b2pdTSkdmPv/Usvi0lcKzpH3uqKc57Rjie0FjcSj4HNHNpsFPCRKXk58b7p7USO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.09.23 22:51, Stefan Roesch wrote: > This adds a new test case to the ksm functional tests to make sure that > the KSM setting is inherited by the child process when doing a > fork/exec. > > Signed-off-by: Stefan Roesch > --- > tools/testing/selftests/mm/Makefile | 2 + > .../selftests/mm/ksm_fork_exec_child.c | 9 ++++ > .../selftests/mm/ksm_functional_tests.c | 50 ++++++++++++++++++- > 3 files changed, 60 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/mm/ksm_fork_exec_child.c > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > index 6a9fc5693145..9ab6aa402544 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -73,6 +73,8 @@ ifneq ($(ARCH),arm64) > TEST_GEN_PROGS += soft-dirty > endif > > +TEST_GEN_PROGS += ksm_fork_exec_child It's not a test itself, so it shouldn't be run when running all tests. See below. > + > ifeq ($(ARCH),x86_64) > CAN_BUILD_I386 := $(shell ./../x86/check_cc.sh "$(CC)" ../x86/trivial_32bit_program.c -m32) > CAN_BUILD_X86_64 := $(shell ./../x86/check_cc.sh "$(CC)" ../x86/trivial_64bit_program.c) > diff --git a/tools/testing/selftests/mm/ksm_fork_exec_child.c b/tools/testing/selftests/mm/ksm_fork_exec_child.c > new file mode 100644 > index 000000000000..298439f0d55f > --- /dev/null > +++ b/tools/testing/selftests/mm/ksm_fork_exec_child.c > @@ -0,0 +1,9 @@ > +#include > +#include > + > +int main() > +{ > + /* Test if KSM is enabled for the process. */ > + int ksm = prctl(68, 0, 0, 0, 0); Can we use the define from a header? (PR_SET_MEMORY_MERGE) I was wondering if we could simply exec() ourself (same binary), but pass a special cmdline argument. Then you don't have to build a separate binary. Just special-case in main() on that argument and perform this check. > + exit(ksm == 1 ? 0 : 1); > +} > diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/testing/selftests/mm/ksm_functional_tests.c > index 901e950f9138..4dc0bb522c07 100644 > --- a/tools/testing/selftests/mm/ksm_functional_tests.c > +++ b/tools/testing/selftests/mm/ksm_functional_tests.c > @@ -479,6 +479,53 @@ static void test_prctl_fork(void) > ksft_test_result_pass("PR_SET_MEMORY_MERGE value is inherited\n"); > } > > +static void test_prctl_fork_exec(void) > +{ > + int ret, status; > + pid_t child_pid; > + > + ksft_print_msg("[RUN] %s\n", __func__); > + > + ret = prctl(PR_SET_MEMORY_MERGE, 1, 0, 0, 0); > + if (ret < 0 && errno == EINVAL) { > + ksft_test_result_skip("PR_SET_MEMORY_MERGE not supported\n"); > + return; > + } else if (ret) { > + ksft_test_result_fail("PR_SET_MEMORY_MERGE=1 failed\n"); > + return; > + } > + > + child_pid = fork(); > + if (child_pid == -1) { > + ksft_test_result_skip("fork() failed\n"); > + return; > + } else if (child_pid == 0) { > + char *filename = "./ksm_fork_exec_child"; > + char *argv_for_program[] = { filename, NULL }; > + > + execv(filename, argv_for_program);; s/;;/;/ Add a return; so you can simplify the code below (no need for the "else") > + } else { > + if (waitpid(child_pid, &status, 0) > 0) { > + if (WIFEXITED(status)) { > + status = WEXITSTATUS(status); > + if (status) { > + ksft_test_result_fail("KSM not enabled\n"); > + return; > + } > + > + } else { > + ksft_test_result_fail("program didn't terminate normally\n"); > + return; > + } > + } else { > + ksft_test_result_fail("waitpid() failed\n"); > + return; > + } > + } > + > + ksft_test_result_pass("PR_SET_MEMORY_MERGE value is inherited\n"); It's probably the cleanest to disable PR_SET_MEMORY_MERGE again when returning form this function, so the other tests have a clean slate. -- Cheers, David / dhildenb