From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE740C4332F for ; Thu, 20 Oct 2022 13:13:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4527D8E0002; Thu, 20 Oct 2022 09:13:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 402668E0001; Thu, 20 Oct 2022 09:13:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F18F8E0002; Thu, 20 Oct 2022 09:13:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 21BDE8E0001 for ; Thu, 20 Oct 2022 09:13:07 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B345840582 for ; Thu, 20 Oct 2022 13:13:06 +0000 (UTC) X-FDA: 80041368372.08.05EDD4F Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf24.hostedemail.com (Postfix) with ESMTP id 2F2F118003C for ; Thu, 20 Oct 2022 13:13:03 +0000 (UTC) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MtSZj3tW9zmVCV; Thu, 20 Oct 2022 21:08:13 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 20 Oct 2022 21:12:59 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 20 Oct 2022 21:12:58 +0800 Message-ID: Date: Thu, 20 Oct 2022 21:12:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 0/1] vsprintf: check non-canonical pointer by kern_addr_valid() Content-Language: en-US To: Jane Chu , , , , , , , CC: , , References: <20221019193431.2923462-1-jane.chu@oracle.com> From: Kefeng Wang In-Reply-To: <20221019193431.2923462-1-jane.chu@oracle.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666271585; a=rsa-sha256; cv=none; b=0DjJ/4DseuC00woDEiCp9hEaneqSwTda+L/sAB0nvLrQGZRS4Tp/SM463YzDBT4ukdEneQ Rg3dNWZRYzZCizFM7jfFXcTYm6PMMvvjniKAiGUtqWyn0Li/4JxSTePmKVQPLDcahPWJRO WTsol5YbpDcaqLQIeGcc0etA0XaBo3w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666271585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cslvDcShfNIZh1EjpBJnEIpVIBkHKqbmMNt8d2AWJyc=; b=WMVDyRB9Q1erIHMakgSXmBaFXwoqhJFC4aaBO7Xi4f9cTMbrkx1YN9A4Rz2dPE/Vo5CbhI ExMoWfcGL3mqZHr6TNJTrPIudkyPwmHRFtK6aY8AV/xXpYyKvZuLYWkFwObkp3PRNUrD6V 60Xd6W/0DGIFUmqzYQd4bAib89R945g= Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Stat-Signature: jjyeiaxguweiiwqbcuna5xfswmdpea1w X-Rspamd-Queue-Id: 2F2F118003C X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1666271583-649424 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/10/20 3:34, Jane Chu wrote: > Changes since v2 [1]: > - revised commit comment for clarification; > - cc linux-mm for expert's review on the kern_addr_valid() usage as suggested by Petr; but this won't fix issue on archs which don't have correct kern_addr_valid(), right? could we call copy_from_kernel_nofault() when it could works well, and skip it on early boot? other options, call some functions in include/asm-generic/sections.h  or include/linux/kallsyms.h? > - cc Kefeng Wang in light of his recent patch [2] > > [1]: https://lore.kernel.org/lkml/288a7aba-c647-b51f-bdb3-99a62449dbb3@oracle.com/T/ > [2]: https://lore.kernel.org/lkml/20221018074014.185687-1-wangkefeng.wang@huawei.com/ > > Jane Chu (1): > vsprintf: protect kernel from panic due to non-canonical pointer > dereference > > lib/vsprintf.c | 3 +++ > 1 file changed, 3 insertions(+) >