From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 596DAC71136 for ; Tue, 17 Jun 2025 13:42:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACB186B0089; Tue, 17 Jun 2025 09:42:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA2F16B008A; Tue, 17 Jun 2025 09:42:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 992156B0092; Tue, 17 Jun 2025 09:42:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8A8146B0089 for ; Tue, 17 Jun 2025 09:42:17 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0FC751A02FC for ; Tue, 17 Jun 2025 13:42:17 +0000 (UTC) X-FDA: 83565006714.29.C561DD8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 70E8020013 for ; Tue, 17 Jun 2025 13:42:14 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MTVMVXA4; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750167734; a=rsa-sha256; cv=none; b=VXSoiJiafQYEgD8g4jOVeCWKrgdKxxF/CxvCwIAvHY9jSFum+mia7kLpCzvTUaNWiz7yfg nYUlGe3d1jLj9EWB/3jOKIq0wxR9OUkhZ1+61LTUL/ty5e7h5LKQlKscA/nEdOXiNbGBZF s9grc8pEnIoZ4GSbWBURp1WOJ0mUrpg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MTVMVXA4; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750167734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IBz/4Fc+xxNxYVYuCY2En4vi6g85xQUlsh+ieL2TrQQ=; b=g75tZeE7PEfU2WGW2w608ZpjSuBdYfbzE/tvzn6/hVc2VMuzzqLLD30aA3JFA4doL0a9ri U3Qej60bUKNlrojcyiBH38sB6spj9HyTmTtQHrqFXFGQ0+xLcnYm8g6lcLjVJ/1miVTjMz KEoFAW+qRuu9cXWQ+qEw5EaWvSLuAGM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750167733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IBz/4Fc+xxNxYVYuCY2En4vi6g85xQUlsh+ieL2TrQQ=; b=MTVMVXA4A7jB5jf6ahNBi80rpIskkSUzAny/dzYPQ4OTPvqFVFZqbP5tWMCcmQh9927PaZ 4tvJxueQUx8hkuJfISFzahFfd/Z9eUKrdhH8UproWLCa29Y251++fdrOsbMop7fvtsYyKf FhCxu/JC/Xk3/QkGtxHY6kr29B19m3I= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-L_sGmkQiOWar5kRuUlE58g-1; Tue, 17 Jun 2025 09:42:12 -0400 X-MC-Unique: L_sGmkQiOWar5kRuUlE58g-1 X-Mimecast-MFC-AGG-ID: L_sGmkQiOWar5kRuUlE58g_1750167731 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4eb6fcd88so3421136f8f.1 for ; Tue, 17 Jun 2025 06:42:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750167731; x=1750772531; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=IBz/4Fc+xxNxYVYuCY2En4vi6g85xQUlsh+ieL2TrQQ=; b=VcHAiOotqOhF6rXjhVKCFX5VS77SfYBPNUC6h0gXtLLzAdZbhrjKHzNBKsLHhKTmSZ mL1MohpSa8OY93C0krLrGUmXicNB6QoUY+YJVcP2TMaHVu8nr49azuUl4FC0qXG95wGE LduEU1WhO8MSCMVqg/nSGAENLRByH7V3wy9IBhsVInYzVJ1AjPvSkh2j8GmnxXA8rhZu nOWs8JFzXaq/SIMErsX4ZHQ/cM6y0JcjCt2vWuTpyCyqqWt72HsCKMPudTVZwVvncfwK xE88AnRTq+iVADMzhR0pAuPMVEMQeM4DE/C3oZ1meUz4pQvXWuzzyPBRT6TzISmM3DS8 J4Vg== X-Forwarded-Encrypted: i=1; AJvYcCVo2//P+jrRgYao+w2icSFCOTRLbfwCREDhZwsagEfKNIf2Y/JFl91Zbux1t9KxYZWfJ6nOqH3y9w==@kvack.org X-Gm-Message-State: AOJu0YwnFbtB+fPMdDE1gzI4EW5qVaLa7nIiTx4DuwiPq7t89cAvhMQY YsF2lnesweQp2tYpW6BxGEZ8QNLkTmy0cHieS4eIiLj7A7h6cJDrAwNQzH2slMr3xmYAuojR2uu Hae1ljclbpRyn0MyEO6MYlHzMmbvCcdlKX3cAAJMpAl1YAn9DSYeL X-Gm-Gg: ASbGnctxTAh5FKxtKhrPFzIQfhhdjsExToCFwdSu8CHx8aoW3fBXeTCSlBDllsdT9dR GnIzWmYEP+vgoXFBWwEVm/Nc8cH4PMsPhI6qf0sqF3SthKA31siaK8y/IfYL1IUcD53rV35u7i6 HEjypTgQ8ac95Oa9GGLt+CriCRLLHc6La9C3ad0DPBhSuiboP7HO46l/Yqj0j73/r+PKnc9U4ow GqqCNlBG5JjvmWqrkJbuv2tB7PJKIsywgJtufYzLCHIYDqz+cMBBwEDnt9xaWjYsTBopRw/IvfF aFtq3pGjP3T8PQHk6iwDLuGGQA4dMKULfKP15c1BlA9X5KsenP/TIqZXFT6WkmIK1PbTMgsGAa+ QwldSGhWOStBeEelHPJNSACdAmm0dOATjqL4ZFsme+lBEdJY= X-Received: by 2002:a05:6000:2582:b0:3a4:eda1:f64f with SMTP id ffacd0b85a97d-3a5723a3b64mr9254889f8f.30.1750167731274; Tue, 17 Jun 2025 06:42:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5D6MGsYdZnB4twmZZsAXJsOylrFYx8+OdI153lho27uAmDXRM/hBZLCJzpTbzu57HtDye8Q== X-Received: by 2002:a05:6000:2582:b0:3a4:eda1:f64f with SMTP id ffacd0b85a97d-3a5723a3b64mr9254862f8f.30.1750167730888; Tue, 17 Jun 2025 06:42:10 -0700 (PDT) Received: from ?IPV6:2003:d8:2f31:700:3851:c66a:b6b9:3490? (p200300d82f3107003851c66ab6b93490.dip0.t-ipconnect.de. [2003:d8:2f31:700:3851:c66a:b6b9:3490]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4531fe8526bsm145099285e9.0.2025.06.17.06.42.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 06:42:10 -0700 (PDT) Message-ID: Date: Tue, 17 Jun 2025 15:42:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] mm,hugetlb: Document the reason to lock the folio in the faulting path To: Oscar Salvador Cc: Andrew Morton , Muchun Song , James Houghton , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1297fdd5-3de2-45bc-b146-e14061643fee@redhat.com> <11a1d0f7-ef4e-4836-9bde-d7651eebcd03@redhat.com> <3eb8e1e2-5887-47ed-addc-3be664dd7053@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: A7mcRPPNLP4WbZZzS2RROSsSL_7GCey8d2tEOjelZDA_1750167731 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 70E8020013 X-Rspamd-Server: rspam02 X-Stat-Signature: rz769gomhx53793if985uw9rqe5pg8qi X-HE-Tag: 1750167734-981702 X-HE-Meta: U2FsdGVkX1/6pNxrc3TwbPCQrzBJH+2hoO/pz5G8TjX04Nt19DPf6N006TtvdJtl8IIUM/Q+1rCC/nwHXoxc2MMEFZHWfYtOmg3BomvJb7JhA5+LAgKqleCeG+YjWl2cfi3qkxw4QRYlwLRkJsmQ/kN9yOsUeN5M+ueKFtUkuLwP4VvYMBSliuCLVpbWvYn8gqJJ0Ic2tn8rJT+FETVj4KymHOItmhVjmL/vmqThFv13ddHfOYrLsXiGZ4h0oMW+0LEGVOzDUGucfphJuSG2dDPhv4ITKIvBWMJEDJYMVsGHuKriamZmn/3BN7gLXAanCSvBHOkNZcomz5NLfygDs77qIr0IgTx9RNIM5NMwwswFpn9s93OTZ3vfJXiWtDy/Ju2Hv5C0RA9Httz93QScXkJG9+YTCopC4scmWgWbPX9XSiM6qqaP2rI84AtVRW2e53nD+T6AfRXfMuNm2rR/1SAlSXHSSJLTzn9GCdLmNp+Xe1R6JUYsqm+mk/ufmOs4BZ7v4ghMhcGG3hOhx7JZp81EIi8A2urDerzolY/C1JBg4Nv+yV1KtWM8kB3i9bNqi2fYIB5lQfFOLqYS9nBnJXrIHY00u2vXsNUTS0brW8ZaoFuB/pAhWuyqU/OOkhtvqGUp19KRxu1LAyNcnK43mxVnw8zEXul1iybKAHeBTai20PwtpJEd/BfRa+G/X9jWLKL+mmrtFLBteC+HGxlNwPUlMpjPLhgtZFMXAOPLFw9CAA16fUK/A0jLKrRzn6jx0Ir4xmKqT1oWbtlbHr/4SFbPZ7qpQaWl1RK3uHW19tsa0ZAbWvX9lhmSlVs5tWU7H7ykN+YzpTH1wGacf2RCm2e6k0Dqr1R9/MZN0riarOk7iTnIVNZcJ64Uh4WLqDE5oHlQdFdOdS1F5Fc9kEWJ+rXDdTBlPNcE3FhAuQfmTF1TjITzKNzbupICfBCYmdA4UcnUPa4qYj6O25q5hFx gLH4u0VC K4yaxFGnZN3MsTsMLhlfuUmm5ngi/iPFil8k0trayiQhCf4yMtLWHQISzWbn1hmA7vSIsp7VMYaSuahDHtCk07fa+FfyOuyVMXlrPLtLXWY5EgNtil9MvhVL7ysXtlyskbMMsp+l0d9zX7ZIWd9EEdTJLSlHURlGkWAQq+2F4IpXfLSLI/7x8uy2CGGk5CkV0q8nFR22jNamqdiLKQ9s7JQShAHJ9YxhBrtvOs1VYv8oubiByAD7I1r5gpGDasncnAAaVZ6CMTyWbsn1WoFCKwvC0M4t/5O2JP0mO1M4zd8ICVL65MpIC25pR7NIoipfuWXcjwnukQuS5IAm9OFPZhHE7RXN/Of/OeSjq2lmJSYrlS1b+NoYwUXQhYKGUKc1xHb/2x6JvmEI40XfwNze/EUqUh9r6Ti2Y1BcTC9cUcoTS9TK43SYpRzdjKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.06.25 14:50, Oscar Salvador wrote: > On Tue, Jun 17, 2025 at 02:10:09PM +0200, Oscar Salvador wrote: >> On Tue, Jun 17, 2025 at 02:08:16PM +0200, David Hildenbrand wrote: >>> folio lock is a sleeping lock, PTL is a spinlock. :) >> >> Lol yes, overlooked that totally. >> And I also saw the comment from mm/rmap.c about lockin order. > > So, we could do something like this: > > if (folio_test_anon(old_folio)) { > spin_unlock(vmf->ptl); > folio_lock(old_folio); > spin_lock(vmf->ptl); > vmf->pte = hugetlb_walk(vma, vmf->address, huge_page_size(h)); > if (unlikely(!vmf->pte || > !pte_same(huge_ptep_get(mm, vmf->address, vmf->pte), pte))) { > spin_unlock(vmf->ptl); > folio_unlock(old_folio); > goto out_take_lock; > } > > if (folio_mapcount(old_folio == 1)) { > if (!PageAnonExclusive(&old_folio->page)) { > folio_move_anon_rmap(old_folio, vma); > SetPageAnonExclusive(&old_folio->page); > } > if (likely(!unshare)) > set_huge_ptep_maybe_writable(vma, vmf->address, > vmf->pte); > > spin_unlock(vmf->ptl); > folio_unlock(old_folio); > goto out_take_lock; > } > VM_BUG_ON_PAGE(folio_test_anon(old_folio) && > PageAnonExclusive(&old_folio->page), &old_folio->page); > spin_unlock(vmf->ptl); > folio_unlock(old_folio); > spin_lock(vmf->ptl); > vmf->pte = hugetlb_walk(vma, vmf->address, huge_page_size(h)); > if (unlikely(!vmf->pte || > !pte_same(huge_ptep_get(mm, vmf->address, vmf->pte), pte))) > return 0; > } > > Hopefully we can do some refactor here, because I quite dislike the > unlock-lock-retake-unlock-blah cycle. Yes. As an alternative, keep locking it in the caller and only unlock in the !anon case? -- Cheers, David / dhildenb