From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39920CA0ED3 for ; Mon, 2 Sep 2024 14:27:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5AAF8D00E0; Mon, 2 Sep 2024 10:27:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE3958D0065; Mon, 2 Sep 2024 10:27:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5D5F8D00E0; Mon, 2 Sep 2024 10:27:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 846E88D0065 for ; Mon, 2 Sep 2024 10:27:18 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 317F314195C for ; Mon, 2 Sep 2024 14:27:18 +0000 (UTC) X-FDA: 82520025756.10.6BA4B56 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf22.hostedemail.com (Postfix) with ESMTP id 102D7C0016 for ; Mon, 2 Sep 2024 14:27:15 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf22.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725287160; a=rsa-sha256; cv=none; b=qYeK8vDES2YV0lmEHICMINmUD9CATJcJZ8NyiBDue55RgQKrg1eBfou5AnsxVyfLblbqvG wboBRECH0IV7RZjAYVA4Pg+KI6hOIxEodRGwk4evYGZ5nemhHl2MH6mdsbzjXQ8oUv18/o Bj2y53wC9zdsgmdpD4RF96K5DWPiwVc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf22.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725287160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D/G9bNo3IpKDItlWrgY5ZqQTM/WhRfaaLxxF7qwCXo8=; b=mdApNABcQp2z94v95tkuS1tTuuRyJSxm8FZaZb9Z0Pvb0BqHKYhlae9ntCHXVxJoV1LVqE DN9LxcgDepLb3MJjA21f2xlzC9YjrSeya/ZSJ1tK7iX4oDevHa6/6BIxtpJJ0M4vbSwZDs kn8NhhLWrF7+DvWJWpi6Hg9MKLPIDAE= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4WyB0d6QXrz9sSN; Mon, 2 Sep 2024 16:27:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AL8egIazKnXh; Mon, 2 Sep 2024 16:27:13 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4WyB0d5ZcCz9sRy; Mon, 2 Sep 2024 16:27:13 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id ADBF68B770; Mon, 2 Sep 2024 16:27:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id Y7uy6imdDGV5; Mon, 2 Sep 2024 16:27:13 +0200 (CEST) Received: from [192.168.234.167] (unknown [192.168.234.167]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C76C28B76E; Mon, 2 Sep 2024 16:27:12 +0200 (CEST) Message-ID: Date: Mon, 2 Sep 2024 16:27:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC64 To: "Jason A. Donenfeld" , Michael Ellerman Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Nicholas Piggin , Naveen N Rao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Adhemerval Zanella , Xi Ruoyao References: <27de70dcc356e56754a03a2887a97597f5e840a4.1725278148.git.christophe.leroy@csgroup.eu> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 102D7C0016 X-Stat-Signature: onwzbmrg1s59cjjyehnqunqdprcg13qc X-Rspam-User: X-HE-Tag: 1725287235-410988 X-HE-Meta: U2FsdGVkX18qkLXdPERbAUzbePKgflJchPDZ1fyCkiOO34Vy9Mt/s27581ANi1OWFu3CMsGjWIiwSWlB1AVumLsoj7ldA2/FPsfWJj2z8dOSyUwoiBydLRW/4n1kcVSeo9z6KYekktpdD8DiRmePz/4+JY4pik6j0C6YVoeQgiQqpL/oDQw19dPappuMA+HLGrwardkG3xW00WOqLdpfEOPcKrlYHte0SenhHcbETwLiLYhL/TsbnCTbYn84VIP/JkeKVGMuaYcG1U/VKDyYjku89NAQURoAKXiC7DM/qlxHPdOD4HoF2KaNxQWOgDf5Al99enzrVA+4Su4oDLiAQKvppXIJjCr1wKWfMVOpyIMTryZ5F5r178Rhb5iBtiqJOgI/BTJK7AtCa4T8TLu4Tg1GSN1O6f73x2C/rKDkftTG3u2hTpo970X7agEIEMAZrtq5XO/HZqr9blsQm5DUtGe89TKr0fNu8a7FeZuZ0LHD4AUGLWcq+JDgNXAAbEXG5o/HXT+g2eKEWUdFQ0QpES9yP4dUkVluG/cFWJvj8RTC6pnsj1RCkvyxCEj+E/5wcYBbwLECGqDyoNpy4xP6NuMtoiG00tCmaDRNwA6C7inZJ18ERKu3sF/uIcKnhdqMlcPB5mWNPNaKEICfmHJhbXPLUVoFQrUB7lTS+SJ4Cz/ZXlefb8jdTklky+a1pLM5Vh/Y8PG/9SKw6nkBYaAhpg1DPL8izA6LqiE7PI/3ChmBXlajOKxDHcwpwpCXhxbKOOiaJAUOE8cT1JkvLs3JCqepiJJDYjk74729cVN6a6JnhqPnXEqbM6JTi5piv7osjl82Awd3c2mz2ytYc7XY4QJ77Qn0cTBTUwxAaMax6WmCkpXnfc0WhMoHSlVhuo3Vrp/5w2zVDZL+0ZFH453nng0f4JXIXwm1S7DQdwVgBqeDi2lnYNXy8HQU0CVgKOph+n0iK5qhsJ1Y7N0yvPH d+2tvi3B +a6E0Vq7eQV/Jgd4bhvLmro9myTvlJCyBBC10FTu4veRuinAVl5QcN73jhqbSG4TzAcJs9mZi9nN1N19FYx8vNrGdQLULmLUiBqlkPtGs687wLaqSkkAWTraRrfBXSZImzkq5I2OqDHduv28= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Jason, hi Michael, Le 02/09/2024 à 16:19, Jason A. Donenfeld a écrit : > On Mon, Sep 02, 2024 at 04:16:48PM +0200, Christophe Leroy wrote: >> Can do that, but there will still be a problem with chacha selftests if >> I don't opt-out the entire function content when it is ppc64. It will >> build properly but if someone runs it on a ppc64 it will likely crash >> because only the low 32 bits of registers will be saved. > > What if you don't wire up the selftests _at all_ until the ppc64 commit? > Then there'll be no risk. > > (And I think I would prefer to see the 32-bit code all in the 32-bit > commit; that'd make it more straight forward to review too.) I'd be fine with that but I'd like feedback from Michael on it: Is there a risk to only get PPC32 part merged as a first step or will both PPC32 and PPC64 go together anyway ? I would prefer not to delay PPC32 because someone doesn't feel confident with PPC64. Christophe