Re: [PATCH v2] mm/contig_alloc: fix alloc_contig_range when __GFP_COMP and order < MAX_ORDER

[Jinjiang Tu <tujinjiang@huawei.com>]

在 2025/5/28 16:43, David Hildenbrand 写道:
> On 28.05.25 04:19, Andrew Morton wrote:
>> On Mon, 12 May 2025 09:13:31 +0800 Jinjiang Tu 
>> <tujinjiang@huawei.com> wrote:
>>
>>>
>>>>>
>>>>> The change below makes the code cleaner. Acked-by: Zi Yan
>>>>> <ziy@nvidia.com>
>>>>
>>>> Jinjiang, can you integrate that into your patch and resend?
>>>
>>> Sorry for late reply. I will do it today.
>>>
>>
>> As far as I know, this is still pending.  The patch does address a
>> WARN() and it's cc:stable, so it's rather important.
>>
>> I'll move the v2 patch back into mm-new and shall keep it there to
>> remind me to bug people about it ;)
>>
>>
>> David (and everyone!), please don't be afraid to grab someone else's
>> patch, apply changes and send it in.  Stuff happens, and doing this 
>> is well
>> within accepted processes.
>
> I would usually do that if (a) there would be a reproducer that I can 
> test with and (b) I would find some spare time.
>
> Given that I don't consider this urgent (no in-tree user ...), I would 
> hope that the original submitter can just ... send a properly tested 
> patch that includes review feedback.
>
> Maybe best to drop this patch for now completely. In that case, I 
> might just send a patch to fail any non-aligned / too small GFP_COMP 
> allocation early, instead of adding support for it.
Thanks, I will send a patch to fail in such case simply.