From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06F54E7717B for ; Fri, 6 Dec 2024 20:58:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5662E8D000D; Fri, 6 Dec 2024 15:58:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 516BC8D000B; Fri, 6 Dec 2024 15:58:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DD288D000D; Fri, 6 Dec 2024 15:58:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 223738D000B for ; Fri, 6 Dec 2024 15:58:23 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B24B41A0AE3 for ; Fri, 6 Dec 2024 20:58:22 +0000 (UTC) X-FDA: 82865746698.21.E448F31 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf10.hostedemail.com (Postfix) with ESMTP id 5B418C0004 for ; Fri, 6 Dec 2024 20:58:13 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=opdIpAAC; spf=pass (imf10.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733518693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M9PuEUd7fHK0twjnpmT4sQ2WiGKSyXN5nPrU+06sRxI=; b=qNTLFYSGGR1awFd+/q1Va3E4mtdG4MEvWBrW7vYrJ2+d/5aiCYDo0Zj6ZDC/og9ycKsxti YdXZvc6Ap4bUue5jhUJXLq0c6Mh/KuBrFaLrnu5yJIYa2tJAMWMpgPa4cj5eADB/zc8h8Y o6kFbsMHZUwYhBFqdrZPCI5mfrUVki4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=opdIpAAC; spf=pass (imf10.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733518693; a=rsa-sha256; cv=none; b=WhTO50NHCPk3ff6gCuC2Ay+jzPc9/QfH61AX4OhJ55Bm1HjlRheL5ct3Tid+r3EovzMeig 7NDsg+SaosYxunUQm35cbXP8ea5AcaG/DHjco04/mCEvZ24jAsmcZWrRNKGKVuTJL0hZ2z RpYDpwh6BUVswl0Vw+17Np0RHgppDZQ= Received: from [100.65.128.154] (unknown [20.236.11.102]) by linux.microsoft.com (Postfix) with ESMTPSA id 8B63620ACD7A; Fri, 6 Dec 2024 12:58:18 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8B63620ACD7A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1733518699; bh=M9PuEUd7fHK0twjnpmT4sQ2WiGKSyXN5nPrU+06sRxI=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=opdIpAACnQeStJ33oACe6p52ZM8f0Sws7Fv8oVZEtnJ34oxYkj2Ifncn0UBE7+8VM /Rer5IHWNKL+Om4cBhthsawIs+kQdevr3ykVw21CBvfVnNLhAZ1lcWLQbVr0aJDoH2 0Lv+tHrW7mbf2ysXMzyMfTT7x/zNVB+cEVkkvmJU= Message-ID: Date: Fri, 6 Dec 2024 12:58:17 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: eahariha@linux.microsoft.com, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH v2 00/21] Converge on using secs_to_jiffies() To: Przemek Kitszel References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> From: Easwar Hariharan Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5B418C0004 X-Stat-Signature: goymi5uhfy33bu4ico66tyen3dkxp6o7 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733518693-729337 X-HE-Meta: U2FsdGVkX1/wN0V5qyrZSTIrEwkoe/++yXXYYMv43zCEfsAM/RAwVkr033b4m1uMs/kFMM4ZCLd2iGvwn6PlRGcEJmfMZJEAL2tV2eca4R6284wk5es0bnPfWRJYBHk0eEIyvzIBe0SwXVpg+f8+f1EHbLtbsLzWELMjXrp6Q+S64IeyEG6WRpOZ+oqrHyVz9J1b/N7xcTOno+XSyfHxb2SpddO8pCiY6HpQQ0yctnpS7KeQZIPpIWkgHJUNmToZxr3FWuKe9EwHt8RTNCZsXcAHmnP4iEMYLgC/YkQv1d39Po2B2US9mHw2gN70LOWMByybAFMxClYRG7V7roup4p+Fgqad8DmVSl0L73cEzWxWk5R62H/4mUvXFJ1IC5N3kumiD9PD6SxUwXOTvb3PxqHFQ1oGfRTGSOKk9G/YQ0XOAffV/SBg1jXuBzesxmwfftBV/MwmFqaPjME0G1Rmz7s5V59n0wws3QJVVGV3t9HSgJLxInSHgiC+a+f6190fRbCbs0QQQh7lGIaplgc1r8tersLCScBImp6zubqWF1WjkNtQw2vvcVYp8m4Ad8tqRy9JfFzce0Y46g9yXDTMX7tzKjBo5maIMqJHRVY0M5gC0WQ+0OESAoiHP+kIJyOLvoaq66r867Vib9PHBDj9xG2P0Pl8jomzuPyw98XWIfLjyk8pRGgHdrvkVSCtE+bjeieMm4zIQHfOtcbn056gEDRvy0MS0+wXSYxTMGpLJSMns2aws7quR+YCXW60j7bpwqYuB3N/8ZT3JeiBaq/nX02AlNIpbrsrtbrhWl/g6LLwCWjWnt/sGD5aHarwlAYUpPzZmug5VpejjuezsuG83thE9ffSbKdyU3rX5OMpBJAygz7Ajfw3lP2Hd1IDk+iynPxeVNOL0pI2OlGBfrGVEnVo997gqmD77QLxXuv3GRFVZlfPpVWv/676VfLC9IspdaMO5ycvzN0st2Gpnmn hnNmW7A6 phkUksLxlmt+bbf9VJHnRMqtg1wbgRfC+I74/DWd1P4qRTfe1wsqSZTk4onUM2XE1+1BcMgue7vEbtwTwgy8GFBo7gNixf90o3gNjk1Y+HJeDb3chTvYvmZgtynqLsT4zWDMsXUdEmpQWJqnxxm0x6q6ggsW3yn4cwbSsiEP420dayNsnl3qK/vDcTL881TZD/JqtMaRP8pNgfRdkeoAzX2Ex0Z4puWg43yl6ooCfvqpxSHPj/mUONgr2plm/7uJapegjtToc42KGj/mjhBV15gaMMgfVNnNrKlmrhngalt9ZeV0IWWr/aK0YVMeSrRQxCxnGPr81EamjK/vdzYEaQjhG5BHJDsISKeEhw6mi2liR80qow/U3Py8tXKvlO3Gs2GuMymtM+lbyuUYuZYIzcGLAKjgaE9jsXJpE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000062, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/29/2024 4:57 AM, Przemek Kitszel wrote: > > [removed most non-list recipients, it's just too much] > > On 11/15/24 10:26 PM, Easwar Hariharan wrote: >> >> --- >> Changes in v2: >> - EDITME: describe what is new in this series revision. >> - EDITME: use bulletpoints and terse descriptions. >> - Link to v1: https://lore.kernel.org/r/20241115-converge-secs-to- >> jiffies-v1-0-19aadc34941b@linux.microsoft.com > > that is not a proper changelog, you were supposed to edit those > placeholder entries; please look around for examples > > There is also just too much recipients. Please split up your patches > into smaller pieces. You will also learn the process on a smaller > sample. > > And definitively please wait for 48h before reposting such big series. Yes, sorry, I sent out a v2 in a moment of panic on including the already accepted patch in v1. I failed to edit the changelog in that same panic. I'll try to not panic and do better in the future. > > Regarding code - you could also convert msecs_to_jiffies(const * HZ), > there are 10 that are greppable. > Those seem to be mistakes. const*HZ is a seconds-denominated timeout, being passed to msecs_to_jiffies() which will treat it as a millisecond-denominated timeout resulting in an excessively long timeout. I suppose that's better than a too-short timeout, and apparently it's been working fine all along since hardware responds before the too-long timeout expires. Half of them are in drivers/scsi/arcmsr/arcmsr_hba.c and the pattern has apparently been there since 2010. Thanks, Easwar