From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84272C3ABAC for ; Wed, 30 Apr 2025 19:54:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 211726B00A3; Wed, 30 Apr 2025 15:54:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BE536B00A5; Wed, 30 Apr 2025 15:54:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8CF26B00A6; Wed, 30 Apr 2025 15:54:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C855C6B00A3 for ; Wed, 30 Apr 2025 15:54:46 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 62C6ABC821 for ; Wed, 30 Apr 2025 19:54:47 +0000 (UTC) X-FDA: 83391763014.17.DA678C1 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf05.hostedemail.com (Postfix) with ESMTP id C9AD5100003 for ; Wed, 30 Apr 2025 19:54:43 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=Fv5wHf3o; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="x1v6/CMN"; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf05.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1746042883; a=rsa-sha256; cv=pass; b=u8r4VJi+1T9Gq/ovpu881sUugfaIJsD/FrBlrtb2ZupRggk46r3yf3Mv2GCv7XAlFVPzI8 WK/DXz2bsXtlJHpJpgNlBq0mEd9g7XArqXmC8L2j7C8+RbLTOok8VfWjvMlR7qsvAJOhwJ 7iJ9aud4Q8DlpyfXGrcR+CLSFTxAK2A= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746042883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/I/HV1cnAxwHYKohd0J7clXbAg05cRUgE8nyzc4Lvms=; b=tHWfOOeUFU2+DQ2x+63iH+bwdpaSdoONm6w4PNb0iJP4ymDfmB3RdOS8NjKg8OD+qtftRa 4vjqUzARO7RD9gYxgkEnrwETTXGa5LAUAJKX31RgUk8+U8a/xbZCjWqewvZFN3s1LzenYH M/lBp5YhCP3PRxBtkegd8c2Rzf4xM7Q= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=Fv5wHf3o; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="x1v6/CMN"; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf05.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53UHtxdY017065; Wed, 30 Apr 2025 19:54:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=/I/HV1cnAxwHYKohd0J7clXbAg05cRUgE8nyzc4Lvms=; b= Fv5wHf3oKRsyv4SJbl15yPrmYU8G0b316A5e3PbytvpBYJaCJcO0slgSilRhLz5i 7o5dRTSJRont8vgh+Es5TutPIUEBQTDVcg2p2EcYIIAl33CIC/pjxxVzhvG+sSnU +6g8p2585zWJwJ9bvU/ZgzGNRc+mVUTpodEFuF8EiUVSiAbmQcrU+O+Ka7cL0S53 Iuun4UVDhjnf+sPvxn5yyU5f66T9U0gaUoDsTdg8AEj4hbeKFnJ+mLk+H85HyvVL dZKjy+OFpeT+h7tHl7+fGo7hBsyoVFzUduVym35IjWQ5wowtvNqyBsBRItlyzSS+ u5iTmY94h8Hm/jL+3dbKdg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46b6uma01f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Apr 2025 19:54:39 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 53UJIC28011981; Wed, 30 Apr 2025 19:54:38 GMT Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azlp17010006.outbound.protection.outlook.com [40.93.10.6]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 468nxc9snk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Apr 2025 19:54:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AqaJ5Ud+jdWO3uT5UQrDqYSkQKzEI9oKWXrK7i8KWwwwqZKkEnjkVayVB/6NsLklM63iKLhFNPHuXDZoz5hhSt/AQK9xFmg6iH+GGmrOJGK7ayABTGwMxnTfNyp3+RP5gYmfmraDWb4g1/yofwetdEsWocp4+2dzAVHIfGRbdyTf1ynY9IxC7cAd6V/h+Q6dz1gpP8zgwGof/XI+swoO3RvyMlnhmafHqtPDDk5xJGqC85Yh4qi3h9fFac9CTUBTOQn0qOXEqVNvHo3mK/WJtBR9ixkEBhCo3Tz9npysTXZDBnYT2Fo2w/Dq+MAFRX5PtFHUEDgndzrC/Wge9v9SLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/I/HV1cnAxwHYKohd0J7clXbAg05cRUgE8nyzc4Lvms=; b=wxx9XW6Rv5acbF2+ZNVZhjc+hg5Ma0KWm0RvvXgW0gN75Tk6I0pCMfDTTP0Sn2oJTfQP9I9v43rDTYMxccXDtUE28+keYyPJRcXeM3bkN1tfqWzBjlsIf+QGN+au+79S1mrJIFafF95SijTw/QxgCrxJqYag0nGqBpcg1Y94cR2pLyv6oVqpTDf6KztwwrMBlPKHYsdcO/Mt2fWn4pP8zHUbFn1IISvElzQEDWUpame9jHIgmBh7sFC6YxHan1fzWhqlBbdpO2A1orC25zhExdE2BVY018ZW/9S80Z0Zniy2Jv0AnqRRSotADZJC8nXnphd4BHbf/fvea//CFK/9kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/I/HV1cnAxwHYKohd0J7clXbAg05cRUgE8nyzc4Lvms=; b=x1v6/CMNabNczSdvE85CbChwoghbL04Q6ZMCP7sSilINvneWa62zEKGhEbuoykqtzMUevAiUh7fgRadoCzXZl8d4lE6KOhFwWfACkHKIugKytv+U2AgdL3jKw0nOe02+Yz74cznduc1VoKKX74U3f9dxBL0hv9MC7fSEwfVld0U= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by DS4PPFFE8543B68.namprd10.prod.outlook.com (2603:10b6:f:fc00::d5b) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.20; Wed, 30 Apr 2025 19:54:36 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%5]) with mapi id 15.20.8678.028; Wed, 30 Apr 2025 19:54:36 +0000 From: Lorenzo Stoakes To: Andrew Morton Cc: David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan --cc=Michal Hocko <"surenb@google.commhocko"@suse.com>, Jann Horn , Pedro Falcato , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara Subject: [RFC PATCH 3/3] mm/vma: remove mmap() retry merge Date: Wed, 30 Apr 2025 20:54:13 +0100 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0648.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::19) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|DS4PPFFE8543B68:EE_ X-MS-Office365-Filtering-Correlation-Id: 98f4382e-be72-42b6-d90e-08dd8820d5c6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?WWPIc02pM/esGcfsS66spUzocHWPGEzAbX8Yr69wNV15LLFm9QF4bTzFP8N1?= =?us-ascii?Q?MZAkOuvfx77Ar8AmmeShQYmoCwMCqZbwteZ4pQAvNahuubY9GK0/QfwOIEmm?= =?us-ascii?Q?eQNICI9YJyShtqe7QoF6DV2dfw81NydkfJQ5HSBtSYJ+KvMzfhnF1+MzYzJQ?= =?us-ascii?Q?qKrCCylqjDT0Yq/C4sL2gopLU8qZaRsxaPOBue2qQ33Mdo0Dw3UYM1xt23eS?= =?us-ascii?Q?GgS61BpFu6jcbdbzxzwu0CGBBxNjUIvjBUZNy7OO10O768OPHgoARubAa7tZ?= =?us-ascii?Q?CTcaE3oJk7VoPRUhljO9LA4i2cVld8DVzjLgoZWO5t6DthU5w6vjm8+w4n+z?= =?us-ascii?Q?jvxM1dErNcfERWebRXapEZN3eKknVY/029UPiMIy8VZDvZeteElr0MCPLNJa?= =?us-ascii?Q?GZXt1gbx9q7Pfd8o6ODLEDVt4g7KD31LOMRK1ijRi/HBRDfw21fJXCTywX9g?= =?us-ascii?Q?cnEk50a6QOgmRNzrsPrVHCOh+S2EefjUurPf10ODykpzER8RbySbUgJG5HDK?= =?us-ascii?Q?0A7gUrPNRDbzRcab+4vyr8MCZBF6KlkFzUlpcd2LH8J3sp4LUpaMxhoXRaic?= =?us-ascii?Q?DseCGyVHJcaNxJkD2i/Ya3NmMbfP78yRz757iajZDdkRXDA9cYg7qwE2DPvQ?= =?us-ascii?Q?47sJ5i7w5toqzpcq0T7D9qE47HE9wDNVbkx64jCqxUwzWUM4BJiI5ppZHefV?= =?us-ascii?Q?9XV8rJ3xiMmTStypEbxX7EoznUCWqAhOJYk0JlQmjRndn8J8k9Wuk/MRFF9C?= =?us-ascii?Q?V2vanFGJ2YzNaGcNoWhNL1IIvZi2iOH3PsVSH6QVdrXu1gmtnMKdUBogvWqS?= =?us-ascii?Q?TBOJ2P+GMAmQUErbJKAdnmpqKMAgVsbtWAHNGlpJL0CpXXYL5QJafniqRufa?= =?us-ascii?Q?cZ1vpNz+XruXKxLQkIYRZltakNoZ6FtKF16nQstNvhTqEDC5zNvjbpvcgtcg?= =?us-ascii?Q?EIboXJxIy7LDqHB5Yw5G151glrTnAVvSsSjVLSrdVZsjnDWFmDzVBFqFtBuB?= =?us-ascii?Q?WWbzDV/IvVcfjyCKzCpOSDaS8vNjCCHuk7P0bKphkbNekiGvXPbKvRMKG41k?= =?us-ascii?Q?AKgNZPSlteM9o0SqPRjP7WFP7mU3iuLQpV4PxxoH5e6wCYDKfNTBC16JsQQy?= =?us-ascii?Q?+QrN+oAmNIrCmZ7gr9CANFKXv0zx0xsxpeqYngPpI9qI/gx+67ziGEn9E1BG?= =?us-ascii?Q?A6oxKSXsvODpIeU1WFudQ6O8ytQdMNXQbohjklJY9EcBaK9fr4AyVsiIGtSU?= =?us-ascii?Q?o+7O0AKdHY9thhBnxJjC/QCPmfOguL1SHPFlnRhZK209Ef+A3TfDnXBwUnQn?= =?us-ascii?Q?lEd4UxCBNZqeal6NT8s0VIce2zeYM+zzjFJIawSThklS3d3eUWyr0G61s8ji?= =?us-ascii?Q?WYTbPxYXU54T5ox+gHP9KBFzi1DZa6KN24/H/dp2/hhVdJcTbYU63DP5FYV8?= =?us-ascii?Q?ovgqh62T5Ic=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PxZnCzSkWMWjAw3ortcnMafYiI7T5sc6Hn4fUejzK/J5XA3fjsTSZjiReHbs?= =?us-ascii?Q?8bvzgRKxBWW/Z4k3e8dyPztgEqTdGaZkxsX1NOgKXdG/BQTH/T/WOwD9P+Yz?= =?us-ascii?Q?3HxSpVDMmC5GrrNHolTZ0Q4oCIEHtAqfFUBEYGMu5uyWUGuoNW+jGT3uFeFk?= =?us-ascii?Q?YIOy3lLRMSypywSBfF/+PvTO1VXCKNaX7DYjehqFq7hclFEoOPgJg9RrjDc3?= =?us-ascii?Q?jrcec7XRB5yzo76AjBJn5Sb4K5w28FU5jSeAf6qSdrjjm+2QMfEBvWuotjcq?= =?us-ascii?Q?Lv8zc3aZNnLt4FAnW8Q+umTVDbZV7J+vpHvmQK78/b/xBkYTA11NN1hlCZf6?= =?us-ascii?Q?6+Iy7GiebE5infv0Uuerb60q+RyPwNLVCw7/sQe1c7DX0hQXdtCS9NSZFJRs?= =?us-ascii?Q?wWajlYLzO55NKRLlD0lEpab2/mrelGElq42hvJm1YpDQsY6wOxB4dxFZJotG?= =?us-ascii?Q?yjn7ysRvakC5S7QQeco494o8k0IQnIjj7r1iP5r9GNapfD+ivUL8qEVMyeN3?= =?us-ascii?Q?DrHOKrl4O9a2RQsKLMuJm9htVshkRMlc8HuR8kmnjf5W2awkzrBdL45JRYBO?= =?us-ascii?Q?VfImVSV5VGokiS08oxCGnLV/wTFDHlRIM4diViI0qVFiV/ki45gabyctR3rx?= =?us-ascii?Q?2HeUP5xpwiY5dXwF8rounLj8/HIpXQWkKuNYriDEADkMBvnwHo3VDdt6k+vB?= =?us-ascii?Q?oDirry2FUji4slAsWlJ8eQHo0uYwqCNCL+5nlHl2UAET0oxoCGV+UqOuX7fV?= =?us-ascii?Q?DKN5VDvl+4egtBeJIE7DtN/YhpS58eHAvDSD+qznUEjEU+Rsa1CRYm4mpK2P?= =?us-ascii?Q?cO03ZuQdX+AdTsJh5xncy/3ityOBIHNQknYxdzhKmoPxxKjLwLw3kDAGR1cJ?= =?us-ascii?Q?yn+JVjz72RPhhbwW8N90l13hiEjWWdfTmu3mAFmDQTeF7BxDrE4tmlwnnjCF?= =?us-ascii?Q?h3WeG5CBPG/gBgo5/a54mi9naGyPv7nEsl2V7yfTlk2rkfUmmD2p7xjst6lP?= =?us-ascii?Q?Xw8c9cHzRHlLV4+MxlRVtKlqL+jKD7eEKcw1JOrLbY1jCTKqLTPiVpDFnr1L?= =?us-ascii?Q?bFZXWp9cnxuYylD7Qz6JTjal26RqPU/5L6KgqfB+FBLhzdTkZ6SZAcq+58fK?= =?us-ascii?Q?Zi0jf5iO6nQB8mnbIElE/sWi5PFboO9vSBnd6utvzmvz9oR0jgfHI+X6iBEj?= =?us-ascii?Q?+8qOIDPMkVhu7EoiTyhO3SvXwfTbgrKrFhxn/wpDv+61XT206qKWugs2hJZW?= =?us-ascii?Q?xjwLoaoy8nWrO8IiBmGa+1wdtPnGxfS3HW8x/jOqBnht3CjZ2GwifVAujXyY?= =?us-ascii?Q?R2cER3QLJlamLHW260J+i8rUPdGGS/CcSq0Oat3kWkdZ4lBKy7UX6CGmN5dK?= =?us-ascii?Q?g2FkncmiBXQqjsRq0U+kRRNiG2YaosgP1JIvKa5GzPqNZcAjpK8MIS5sffQV?= =?us-ascii?Q?vJ6rjrDz/0XGXb1OCW6HzSv2SVtikI6oSmsGcbT6+BRL+T38KJwQ/hR2UmDQ?= =?us-ascii?Q?vEu7Vdbff5dzJzSvmafhvucO2RoEwbiHh3UFzkVpUZJNcyOoeE2biH/mbxxe?= =?us-ascii?Q?rzUX+Ec8ynHHR1HF/0c5BGqmBXdFgJqLkcS0XzH0E5AyD9A3VLJSI5VWF/qQ?= =?us-ascii?Q?MA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 00cxG58O9BQ2m0Z7moYPciIehnT/PN9tZN6SesHRigPVJ/l3Sq+Bn3RinQxisOVdWLIZnqbaX5asEYqa729lvSsOZBmwaC5zUH7oAwRGMokxKgA4H1p1NWz/yOSf0Dd1W07Dlivtd6+6g1OaFBIzynnQT76JrbtsaFaIk3MRF1+0PkJqF/Fy2VBO8Cg05GgoummNWO5c+fS1E1UhF4vl1nxBuRk5oZ0qiZQtKawTjVk/OWkI+oBU7Y5LSJaNhGXRPldOfT0m2hlkaZYrC5m/wZD7GTbXJpfgG23J1j8C0Iem32LQqIZJ+VVA4otCvhBIoJIt2hdeu/K3HH/cOlTILoUEccMDlj3wTSs/PsevJtao5/5IjeIYzKtQGAbMdEpNyA/GXt3DnTU947M7ceDphVdHLErezzrC7ig/78kYRmFertdxGAA83ceAML08aKSmBNs58C/pMFankqoqlJU4As/p8aAS/ZbennwDQiGqZXKIN/++QaVJk3x/u5dkhOtmaYLM5eYItYIHkzqYb/hAsd4GsrumhxfFLtccWy2d5LN58BOYIJ/LKOtMso2j9uWGSWDk8kfCpf0PBJjQSuYkGfeTJcRDu+PA+XUA/UvqbME= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98f4382e-be72-42b6-d90e-08dd8820d5c6 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2025 19:54:36.4200 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CVjZ8LXj7Yen5ymlerm+CpXUytTVr8nrVUSF9vtrUZWA6LVE+XdspFiKvj75nFoL4PtTm5ugJZR4K7CaP6WAhupWzJEkmkVyXOdW1xe93qw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PPFFE8543B68 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-30_06,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2504300145 X-Authority-Analysis: v=2.4 cv=dfSA3WXe c=1 sm=1 tr=0 ts=68127fff cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=XR8D0OoHHMoA:10 a=GoEa3M9JfhUA:10 a=yPCof4ZbAAAA:8 a=KWrF3PiNL9PbMbJVJAMA:9 X-Proofpoint-GUID: dSnkcayLPEKJDfUGpRwvIlTNL5Medaol X-Proofpoint-ORIG-GUID: dSnkcayLPEKJDfUGpRwvIlTNL5Medaol X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDMwMDE0NSBTYWx0ZWRfX9SUIM28TrBvl wKOaXtcaRABWgdLhrdwqSgqk0I7iSq7tGGxhbSQlRGFzuIClKggH4KJ0RjOWE8Bv6UAQhY4cCAn aLkrRFPu80RPJN00s18s2jS/mjPnGRYR8iitUD3JfkwcyX/L5nUrEmv7Fk/fv9fLeFqpYdwxxo3 Qdwayp3SVTBFgL6Wa+B1FtyP0cESUPsge0LF/OqVZeLXVnGR/qo85lnVpRHqKl/7t9i+x6Err0n qot6ihkEunL8vVPsYwIqMc8bHgaYyyw7cQRqvSHgQbLvGOcBtEJDO+eIzr48a8sd+BuUYI7KYhh qw2GNckscmZ5Wheg+zNrlMiYPvmRHI/VxDinZR75lPHNG0bHMV7midCFwqnVd8w5DL5fnoM/K9T k+7p7YkXouJTtSJwjBl8r903JZGajKknG6n+LqTftCvED0PCZJoOsKs7I4+NeQYA62n/idp+ X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C9AD5100003 X-Stat-Signature: sbzejgwk3osa438oo15nch7daxfx7thu X-Rspam-User: X-HE-Tag: 1746042883-196244 X-HE-Meta: U2FsdGVkX18BC//AdFBb1PGeUcNpyntDHGy5ExZIHH3iMPNbao5TIacB9Nod6Wvgjh5wCrNBrrwaNwOdbqjyDxv/qJZViaEE5JCODshHxPuUM21Ajv/15nydWgaU1FPGjYBan3V1l4ZM8xfijSq1Nqz3ERZR6pmxYbDHI4BnvygG/NrmQ6q6DRJZjRlo4SCfraElgy9/g8wjdgthoxkksKsjh4aYBIcyP8kTbvCOzRNrQCSSvP+Nx0LSgH500XKju6rgXAb/JyduTn2sbGsQCno6gOD1aH6Ldhq8ai7mC6s4j5+6Gq50Brkg6PlT8+czIrWXfE09PArTWscHsNVflNPFFhZWWyG0qSl/gbpyHIemv4VwPyZL6x9Xwp8E1sivxmM0riheUm20BsNh1MAGs9e1hwKajuM2XovceP7vTDynp6whTxdVDdKFNbr0boeK+LJumX+WsLZ5JLm/Ja6hVLb1Crfg/G/ZscUeS86kdr0eaYHAQXWznD3w695WwDn9YBozXIQHvBUKKjD3puc2QP1ytfZRjaWiz/oC/LV8CLmsDOTuIVV+0oy28EqzxaQVG4EOIs2LTxmMcB37+tY3/F/1OGcNLnVkkzmxzaWcSgVupph635Z8UEWsfFmJffUhynwLonJWrEckXVxMYeY4LBZTs8jepGCWdUPPrmWvhD5nzui47UKS9Z7Exs/vA/HqsIDFpC9IHvjAG0t8o8riOiS67M/+VxmxOjrPPeDyMPvs5ab2VvbhY43ZN+x0/K/iXC2dLuzjiMKKXHrWXKptHFLekNjMa/EJ8SlU6arzvcRY/uxDOOzI/NQO7KLoGTVMbaP8/DB/+wdH42f8mYxJTvTkw3+sX7PTpaJ8GffZqDRSZBFN+VYBowSoQ68Ak9uQVk+9IvrMsn77/CnZdBGZfCAP3Qsj9HKR+0vexv0ykwQAOdQOLkAgdmcXb6c8VbkCf3AblV6iMuDuayDkrQd RJuxVKlj 06GLA/R5tymE/BPsbuPQMfCUmi5emE3H2X0rfqhedtgjW8I/2KMBfVk3cnjXCmweEx8wnER+3iKEatxrz9HPGF3SRKUzGSTzHUr6s8kpibAT4MAB91ZoD8MIWKIbJ3BiaEKpOwYVP3VArJPHWDbeKvIOOMgG5F7UqLzc548c6He9bO6SRZu6cY4fG0B3k50smu6eqf+8yd6RcAxVnLgK2MeczbDXK/mn/b1qKN1cYLUCLWmKY74yyYk9UGScGrN1AtYNdHRZ+AaUkoBPKRn6rG7CUhmK1m/6y632TaOGQmQYGaa/rG3fuekgC8YOHJeF2aMcvQWvyLpOKjNAyNa3f6p76K04LPUq/N2XcywNjZwerP7fZM/3vsm0r7CaxgPQ2KjV+fuWMK4nYw6g2f+NiP764KRqU0c6HUDZ6crw9+u5OssgSrkalfc8SK1fbHqPQYkIpa+3GYNx7U9BjGw1iH0eFuer6CoFVvsVJwIfxn0U0PhuGnYFwkmGknVi8qOvx6iLsXOtCBPSaiqhcj0UeOa3plR4/JMEkypV5PBJxdk57DzRZmvahTUBDAu8BJjSikmXfKQy+OLo6W97yYIk4fNbeOx9Gsj6zIQd9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We have now introduced a mechanism that obviates the need for a reattempted merge via the f_op->mmap_proto() hook, so eliminate this functionality altogether. The retry merge logic has been the cause of a great deal of complexity in the past and required a great deal of careful manoeuvring of code to ensure its continued and correct functionality. It has also recently been involved in an issue surrounding maple tree state, which again points to its problematic nature. We make it much easier to reason about mmap() logic by eliminating this and simply writing a VMA once. This also opens the doors to future optimisation and improvement in the mmap() logic. For any device or file system which encounters unwanted VMA fragmentation as a result of this change (that is, having not implemented .mmap_proto hooks), the issue is easily resolvable by doing so. Signed-off-by: Lorenzo Stoakes --- mm/vma.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/mm/vma.c b/mm/vma.c index 76bd3a67ce0f..40c98f88472e 100644 --- a/mm/vma.c +++ b/mm/vma.c @@ -24,7 +24,6 @@ struct mmap_state { void *vm_private_data; unsigned long charged; - bool retry_merge; struct vm_area_struct *prev; struct vm_area_struct *next; @@ -2423,8 +2422,6 @@ static int __mmap_new_file_vma(struct mmap_state *map, !(map->flags & VM_MAYWRITE) && (vma->vm_flags & VM_MAYWRITE)); - /* If the flags change (and are mergeable), let's retry later. */ - map->retry_merge = vma->vm_flags != map->flags && !(vma->vm_flags & VM_SPECIAL); map->flags = vma->vm_flags; return 0; @@ -2641,17 +2638,6 @@ static unsigned long __mmap_region(struct file *file, unsigned long addr, if (have_proto) set_vma_user_defined_fields(vma, &map); - /* If flags changed, we might be able to merge, so try again. */ - if (map.retry_merge) { - struct vm_area_struct *merged; - VMG_MMAP_STATE(vmg, &map, vma); - - vma_iter_config(map.vmi, map.addr, map.end); - merged = vma_merge_existing_range(&vmg); - if (merged) - vma = merged; - } - __mmap_complete(&map, vma); return addr; -- 2.49.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 165CEC369DC for ; Wed, 30 Apr 2025 20:00:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D89D6B00A8; Wed, 30 Apr 2025 16:00:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1874B6B00A9; Wed, 30 Apr 2025 16:00:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF7E76B00AA; Wed, 30 Apr 2025 16:00:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CA8EA6B00A8 for ; Wed, 30 Apr 2025 16:00:11 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3C66DBEECF for ; Wed, 30 Apr 2025 20:00:13 +0000 (UTC) X-FDA: 83391776706.02.C22B67B Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf30.hostedemail.com (Postfix) with ESMTP id BBB608000F for ; Wed, 30 Apr 2025 20:00:09 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=YgUY4MU+; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=AN5q0jEZ; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1746043209; a=rsa-sha256; cv=pass; b=1Yhp19IWQa9+nFAnc742eGqMZtSvMdeJc917xiUmPjTPG8mxrI+hCB0sksOmgZJYSyFnEh FEmdxOhXvNXzfZBVKlHqF5J6caBShS3ZyFGXirb4zHvIyXeQKhzj35RAzQ3vzzY3XVw177 iY4ok1g44Gg0Yy/wzQzDjpmeRsCrUko= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=YgUY4MU+; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=AN5q0jEZ; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746043209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/I/HV1cnAxwHYKohd0J7clXbAg05cRUgE8nyzc4Lvms=; b=HnV5w0tL+LvqQrsMElxMUCpC3h7U1CZvPekw6nerXTfTsk7uTICNQsNVtVcKTO5fD3FLpE Yf9RQZeOxYfCXxb1y+QxAid8THiswTcdMe46Ro8dvvgSB6k51+/87aiz1YAvmibYVI+yLC VVoEGDp1vRtSxOALyz7aPmC2n+JEhuM= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53UHttEM008802; Wed, 30 Apr 2025 20:00:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=/I/HV1cnAxwHYKohd0J7clXbAg05cRUgE8nyzc4Lvms=; b= YgUY4MU+93qTGggnC1xgWXZLFRtwgTGJhSjNicO3nxBHKeGgNOGxm2EwBc0EttTz tFF53uwaV/olpqouwPrHaV1CRy1d+fwjN3YViN9uSVS8/kAhayN4fwX58U9j4YcQ eNF5DvVQ1sFw6ZA+zabb/y5n4ODbAeN7TzQXEH8oLkTZEqdIl5JLHtWobZyinycc teaOwyC8i+3FzeKFttzOpuNJTLQ5Tqribo0MJ66reGOxO8XlXgm3CPg+OylRKIdH HKDBXmqAmPxrLNN+MJ9nNozOmdbjO9lAFAKv10Rk62lhck4C935T6z5w3e2kKOdw +HRJqJMr4V16HG84spMK6Q== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46b6uta19f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Apr 2025 20:00:03 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 53UJtLZn033518; Wed, 30 Apr 2025 20:00:03 GMT Received: from cy4pr05cu001.outbound.protection.outlook.com (mail-westcentralusazlp17010006.outbound.protection.outlook.com [40.93.6.6]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 468nxbsguy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Apr 2025 20:00:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AsdCKb/ZAjXb2s3cU+pZGHjIMHA3uJvAmbmR3+fEQPZx/vu1HEh6kIN8NrOd//OwMwBDTqIGfnSPzy9kMjl24Pd4rP55fTtFfGcJ9CuEX32gUUruXkAw1NyMhX7E/GjYETfJg1XceZHBrbeabviqVInm2PocKIm8vfE/PLo98ld7znG/Z9Tj8vNhEysMze8fQOXgelDfY7qII2TBwNOny6AHBhReZxGPBWDLy44InvgvKJ1xSEuLQroT7Ewy+AyzO1531ejALnwZWrjJo6/uT8nZKfylOgI1SasuAklGLW8Cg41JNxMHgsv2Y+L6sw0C5XBh+r1Be/DlsLuxqFo+FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/I/HV1cnAxwHYKohd0J7clXbAg05cRUgE8nyzc4Lvms=; b=Ma4qIdd8zDQWypWgcLTCv5s27HDRzEdDDE/GxFRC3rlHfx+guQATZA2ooc8jybYmmauHwe62FOwi/sG5QJ2z4jwls5iYG96zZ1bUTjrDtrQEd5CV2pJGCN2JvK6iiw5/39oS6pNhSduaUtYs0VB+0BB1A95oRCyLdWWlQc1B+3x0QuMQ+LFMH0cidXDB4J31npnkSsJJ25t8AE1C2PPGGh7plaVdwDXm0HqadV/Gx9jh37K17qiFPjAf6/M9nuHVxLZ3U8pQD94r0mKoJQOM+IelC2hB25FwaY9ga7jdqSirltO6ntrh2gGl5gMgM5GBgm0fqcN1ewifxvkFvCYPkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/I/HV1cnAxwHYKohd0J7clXbAg05cRUgE8nyzc4Lvms=; b=AN5q0jEZIrgHpGbP72c7yNlaXKfy/za0GwngimfB82QPpMchOaqXt623CXrbGqNp4LTRZ7SDS5GoMhQnF4sp7DYM6/9362NIds9Y/41lHnyghWMWLUmLvqwiWDwQ/8cERer9AbjwjHev1/bz7pHTr4zEeH5n4ADMrYJwd7w3L3E= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by SJ0PR10MB5629.namprd10.prod.outlook.com (2603:10b6:a03:3e2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.19; Wed, 30 Apr 2025 19:59:59 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%5]) with mapi id 15.20.8678.028; Wed, 30 Apr 2025 19:59:59 +0000 From: Lorenzo Stoakes To: Andrew Morton Cc: David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara , Matthew Wilcox Subject: [RFC PATCH 3/3] mm/vma: remove mmap() retry merge Date: Wed, 30 Apr 2025 20:59:37 +0100 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO6P265CA0010.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::7) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|SJ0PR10MB5629:EE_ X-MS-Office365-Filtering-Correlation-Id: 041c0e10-212d-44c5-be31-08dd8821962c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Q6T58HZVQbE2Egh57CIGZrCwW2zMl/cINwdAJs0peOs1oozaYvWoJXwbnaGd?= =?us-ascii?Q?RG9gZxDeLD5ea8CpNQUCS/jRg3vJheL6Jgwj8kvpqN38fW0YgHb4KPkGSHXi?= =?us-ascii?Q?toOqBbQnJVbvLtEgRLth1q63qq/HyLNdlJZVPbm3GlENgHtLw0G9AuNsF83D?= =?us-ascii?Q?HaYbban6tb03aC5GHt1UlrcfiAHmtBXDZIr99lDXEGPMibbLhqWhx6eixLSU?= =?us-ascii?Q?/onqTLVEB597AmTJThmDqv+FFxr/B5AP9a/8/QpR2QNBFiN7M/So7rPXmnPL?= =?us-ascii?Q?05b01RiunNJD/DEydj6BeNrEZGa/+6q/U38g6wIDmwu0b/oWRq1/aWrSzMzm?= =?us-ascii?Q?Ql0n2K0HIIzUN0shQ9mmSuvaI55tGnoQdLIL63igTLX4xXOZxdnxvChIvmUA?= =?us-ascii?Q?vrK+N6UBuB0MiabvogYmsA/VCl9iJfDr9xaLe2wcfSWuw8I8nTUOIHaSPT4f?= =?us-ascii?Q?jtgtwBZAO7cqwaO8trMsebCCSOxSLhSzG9NkYgC3yktSXKTv3+4wjMiEnvPz?= =?us-ascii?Q?m/MgS69te1jvC/2ZulTMV8on8xJCYQtltOX5X7snMHDfEPMCR5gUmeof1ouI?= =?us-ascii?Q?IeyJKfpW0XCHipKqQ4TI09HCtYXhUY9pI/uk5d9uBancpv1fCYP3+QYLnOvX?= =?us-ascii?Q?0VmVk1BJhZqnySR4rgDQUDHoGmvaMTmCy+FRCrIhmtfwq0RiV8GXI+xbGB8u?= =?us-ascii?Q?4Jv0DPsLGScIMMKCQ/XskcPWyHPEKftZX36a8AC57XRkIcgQFhbnNovFLtAs?= =?us-ascii?Q?BVm9aLraFeJMMxjaB1912YUyHK4M3smYo7Rv2AtE9JEQyUiDdlsB+gOYEaqQ?= =?us-ascii?Q?ZzAM9a9+woEotQ8K/ZcT5ufvWta9Go+vLhR3BwqrSUjIdCw3FMJjQhJrIxKh?= =?us-ascii?Q?6wLjxiqi6+Rd1PZrVVHnrfMWXmOrX/b0HYPBMo1pjXRzE/Uavqju33ukeKyy?= =?us-ascii?Q?pVEHSvmHzcKnW6F5hhtJNaL+H/lj23m1EYVZxNOZD+rX2IsKJQLf7p5Bsc5G?= =?us-ascii?Q?k+WI2PnXj8q5RV9LKVGhrkCq+Q/rZKziiJflczpnOSG2wgjXoEjIhbhSwvTf?= =?us-ascii?Q?Z6Oj6STKBPaWg2AJInnLLX1XnrEqkzGF7AXfxTA89PKqwqRBU6dd88KkvBV8?= =?us-ascii?Q?Ni8DSluITF/2YtK//uwa5hcDGA7zcW63j/LOBDFk+MhKTxDnZxUglOe0cZ7V?= =?us-ascii?Q?4f9XuUL4nmnwdKhq1Z1+sqPH6RBujgFgH2HJtoMrwDDPGQcDh6FiYq/yTB4C?= =?us-ascii?Q?VqHBc3cZFoCOBqiG+q5Kma9htVRwDWJzKBB9bM3XTl+OJm+KFBLr8VsdG5DX?= =?us-ascii?Q?zSPlhxDSaqU91wOakcK4AeVy7g+tcI0rLAmF8LdDc7GW6EJcZKDlx6eakM8R?= =?us-ascii?Q?tCTWitkpcZKoUR+yWtntXT8+wX3cFxA7NslqxARBmG2L8c0WtA5BEF3G6LvQ?= =?us-ascii?Q?owpqtsnzCx8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?chjx1wACKY3gw+Y+0NXb/xqO2IQeQ2WJh/oBgJsarGvU5yEBv5neGyl5qD/P?= =?us-ascii?Q?p4VZBysLBGAq8zv+JhsbpKJycjZAmxKjXodJwbswRdFxJfqx6AgNR4/PmcqJ?= =?us-ascii?Q?m/r0IkLIXj3u9m0OIZRLjY62bogmBvF4OXVgpF69dblbQCzTIJTpLJ/P3F8L?= =?us-ascii?Q?P+ygkPXO/tQLSSeP1K+NJUh/YzEu0Bvlf7C+FjiL/iFBn19ArxYsEGNPYDfJ?= =?us-ascii?Q?+i0H0h94vZDjpsuXjtBueuVC08WjJXOINoXOZCh66XxGADYjnj304EHucE0V?= =?us-ascii?Q?473HhWtmqUubWzVu/l92JYADX43OIspn5E+3CILooWn/SG2zRWsmXJj+id8O?= =?us-ascii?Q?JHPT0NHwo9h0h4quATdpqpguJj/r/gReyszb3Gj/lC3mhipDEyegAULEwz2q?= =?us-ascii?Q?GTR6ikmPwnC4in2lcGdt6Csl73g8OMCSYItsWJQhVSkBw8OUR5Ogufeul7BU?= =?us-ascii?Q?DVeMhE6kfpL968/PLT4zki6CspnbvKF3GxS6xp6OuphlKdQjC62x3JTAHIXJ?= =?us-ascii?Q?PplgyPPtW3+qSLXQeScqSZyI0GnZPLmW1WbOhOwpcOk7/tJ0jLfbs5AkY0hT?= =?us-ascii?Q?Frd805JloEG7l314eQpLXoJD5xRQcdzA3bLuErg1TZ1uJW4ljPepcJevb7FP?= =?us-ascii?Q?fdlgDeIRfODc3JX9wEN/hXZEoCuxKnz76FiGU09ofbzjtfSSiB62EgYJduwL?= =?us-ascii?Q?QIk+2zuqoc8vJgfQMWjjfkysRGdr7p98LkoOgKqgSclk641vySpcog1n/8jV?= =?us-ascii?Q?12zqVsbUCqcmyPimMRDJRVsH0urdJfSJVUfWx7sl/u+lH88uXeow0vf+j2ml?= =?us-ascii?Q?EJWGQOSC/L/V2Lizpsr6OkgVgFBu6pD165QjOGeFa67VwglkaNZc3uI47tSY?= =?us-ascii?Q?sbck2aaKxXlALAc8Ia9RpR7kso8/z3Ag2ktBnH3ThDAYVAURru+NBeu0hH+U?= =?us-ascii?Q?4wmMpVqHOxBGLMdAz5HFncEEZbkMhkEL9O8TB5fkN2vZnLuZwHJdTBbQ5ZlX?= =?us-ascii?Q?4XqiXzzYcb5Lobd1DjED0d7T48VNDhiGk46vUOX/BhYX8V1W5Vgcpzw416Od?= =?us-ascii?Q?Th6oTgjMSKhIENxjHAmaXv9v46AWhUm/O1GYFQsddXDao7jV4XLrJQRTtqpu?= =?us-ascii?Q?H26G4w5jJLers9zXxlGzsVtQmG5UbXBxbXVjnK0FKMyRTkMbd/739/0URg6L?= =?us-ascii?Q?6HXpMJ5zdGXZ9f+T4NYXre4FL5lgxSB5vuRyacXKF6OaLx563JGojidSF0a1?= =?us-ascii?Q?lK1V490zTOx2olkAmaFYH7OL8DranUJPGRhNCqXlkwi09bkxuaGVSWX/DtTZ?= =?us-ascii?Q?1UagsYZ/FIB+1mqAICnO1bc71FITe/tiIGG+hqHIpKkmOLoDV7siYslHLt7X?= =?us-ascii?Q?jXZc6Atz4PK2+uQ3CB5cPhygOy5+WGpKlCpUs5Ljq6DXnAPrZuDOhLmO7xfY?= =?us-ascii?Q?ecUI7krbS8+FQfJ4DOgWBqAkHsFZd+pPtoK6RBaqJVkvN7eQgKPmzXPyDVsc?= =?us-ascii?Q?vOrNHJIBSzqcC1f7jlDYeDYw4Wl0VYNydg5wqxiCILriYSNNZpUXG1YvB+ax?= =?us-ascii?Q?3EAQ7upCn6BvKrWGwPmQXPDtbHTOC0+jEmnlH+RCmYlpg2ORZMpx1J448gbO?= =?us-ascii?Q?zw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DZXLI5mlDoOi0f8lbCBTLY1XfbtqdjhxIGIDK6Y6imlJxWaqeof5pL7cDwcYdQTY0YX7azRfubA8VI8je2EfjFW+wVWg1snFk7ibB4DZ9+z363TtxJK3Lg0RFoC/3fldnpymAQp4iJVEfcwU7r7G9IhO5oCgoQWHQyMIlpKFX6RU+MJVENbrezSPt9j1lCs+qp8e3g+1lG3HdO0BfKk4bV7pB49zDHizhxQuyXcrwdjyv9q6jWQ8yOr7UUC/PQPq32zKlD8NjJOLWa93YqMK7PafIkw12duMa/af1nDBicGVER8BE40j6mLGgZ/Au0UyLZtibMHB1uHBjW7hHNTlzUxcmaLGQu8Y9KgJ/s+0Y1Vj6PI9u1wS/J514xalsxs5zM8bbymIHtao+Jy0x9/GEDEjz2nZFMPfWvQlHMMtJOiSWr79U4x9MqGYBlFqB0L8znCNTHjNNxpdclLqcl20u27l/CyqoxGWDKG03SdHKc4IuwBCyQCCNW/GkAorDNf1RT8X3G1DParCfo+W9pMLmRVBzJdbq5DI3LSwkFj0WdBHNOZehwRJU2GmYSV99YoBTac7Hu07pTkAQIMnmW87zESTpdKiR2c/1nnGPYEPsKo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 041c0e10-212d-44c5-be31-08dd8821962c X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2025 19:59:59.2195 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: USSwzum8QxSmDIdQuxbsbQnqHmcwUesziNiAAq/oOu9kk0zOCGnX0RliGAZ7DeIrLgo3zdrOuggKg/TtsmpsOz6Glv6Svxk6WIrbOJHcJ48= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5629 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-30_06,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 malwarescore=0 mlxscore=0 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2504300146 X-Proofpoint-GUID: DCyUSUOCadg4aovaEH7MvkbqKGpP6Dry X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDMwMDE0NiBTYWx0ZWRfXxfFzXd9/96k/ rDXqknLnqBJo6Kj9B5R88uzOKsvbmtFi391OsW53Ndi39EoWoEMOnmxWtZDUIVM5jlXEMCk5zJ0 LhcwdDUW1QLtpR3exW5aJ1eBNE24CgxnWBvJzFY5Uu2gWMZf7oG9t8dnSWnGukRetqJgRAAs5tT ke58wlmCRhFw8OTU/f/h+QgLng8XGXAY6q5Cf2pgEaoiGoOJMG1qeN8zBRo2b2UPTPKas7BYhgX kFVfPsQ6HIbNP338r6OCS+cCIezQzcNX0bWi96IWoSDz/jLcyyPCDU6t9FsZF3r2sq+X9vhDHob fTiwv/lpy8Bwqb/Li3RCQTfpLOahD+Ao2CEySKThLxwD5mgxBpdQNw0Y0ru5X/9Wt9DrqMcchGy n7UfgTRTheIB9eQuz1lqZI1oVTQlwwatqwoDY0DOf5nom8ZRtbyNvL2eZPhgtDyVCWmAcC/A X-Authority-Analysis: v=2.4 cv=ZuHtK87G c=1 sm=1 tr=0 ts=68128144 cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=XR8D0OoHHMoA:10 a=GoEa3M9JfhUA:10 a=yPCof4ZbAAAA:8 a=KWrF3PiNL9PbMbJVJAMA:9 X-Proofpoint-ORIG-GUID: DCyUSUOCadg4aovaEH7MvkbqKGpP6Dry X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BBB608000F X-Stat-Signature: sbzejgwk3osa438oo15nch7daxfx7thu X-Rspam-User: X-HE-Tag: 1746043209-853579 X-HE-Meta: U2FsdGVkX1+RPpXUdAo/4P4qP9vLRwLUmSZ9Fi1bqQdVSay5FCa8fL0eHsiU+R526RGFjEMKZKHdGgEL0rdN4zK2t3ZRgJTVGVXrnPkYC511XXLZcT1/QVZRVe+6+hyZQpDNcE000wISi8HUt59uQ1oPNHWW8D3xbGawhpR+g80eR9AOoDf0DEAQ0YZUd4LGg+ZZJM8dtfQtJxi5iaVl0m7j/S/59gTQZyJwSxcU8WlhwburPoFz+M28Tj5apErm2jnArO3icKYzlSrPJS5CDGyP2mlHnSaIxG9nCgrPWdyEN3SIzP5nvHSpJs7FJMBpAWFOg8KDE6j7BXR2meak/nJrlI1YvL18t+/4ZkdR0sBr5OhVJStpT0pmfEHVpdmFErjW76Poi61hS5/CpdbR3HMFcN6CAhqJhHnCd8BC2/5xJzAYEeQrIVXq7A8ryntm3GE6pOK7jgiuwub+IF5HtJPnQIwBwH4APeSCzkklA9VNqYniF+pQ7bWyC1XVNsr3vH7jnVNLoZQU8enjcfaIEN+0kaLTL8WLp5dQ3TUwDEF7tQrnPB2ugpHaeJP9ePoAUmSgaopRLh5ZdSaahAz5/QZ3PHfOQvyO7wvT/6AK1aRRvql2M4zqIj+d0AtrKWXOKpOaPdO5N7QXBoaUpZOg0kkc1hWI2XM3uackEh5n7IFGsqjh+vmDzJkyVdiHHXrUHr/SJu2Ix6MD2owYQb3rvehxAFYACHMJcJrFjqdvBeErlcI0hOFzcLl6lOqwZyYPEQ+ZC6D0fmjtcLmhozTv9kv+9RDLt8aPk/1aVavpbisQQoS7c+C5mjGjrW/BLEDt3IsJVBRB1x6T+NpdjFxs3HE1mpOglZKflg4Kwq6cRfx4AtVVY27LMHW1FUMqnGcRlv7HyfG15m7q0eZrXmkm5qula0gZ1gN8v5DXhWRpyv31aPI5U5E6mI/tqCtI8uU/NHEr3U0T1EWxrkXBh3Q 1JpaGU+M 1mDSoKvI7QKL5lyEBbmeEJcxUPuqi/T07l1edJFxsJ6A3BPehWtUTRvzSd5c2dV2R7yjdyloA2S96kEPlKWmznoB52uLepk6PeoopAFCcHkMyr1JVoUPqFv6URQIngQkiVfpYBunswt6spgxaUUX2URZuK0orcJjhMaKzExCtKNnYetVcUTp58nmDNjidz4fc65NL8I9rPmArqnBo4hCADI6ccwGLYrXV1vIVFUrWAg85bzbN5JDF+xW+qCGw9y4CL1+O+aem0DQSelCLwNUNbyhbeGMTsN+7pJieNzQ5qVXciSojo/6rFvHDa8CHr1IDCF3ePlVc6driE8E7NYKxK81E1FwWHhMNkjYQ4vU1RurfD8jzqBGjSKDP/dN2GS4OwY6kvkVQsOoaW+tKUVVsB5NpLIDvbeyEwvTlKI4CoA/1vdLgpqS1sCW6MgnJiznWiS8M5K9elJUo44/XzRzqkN1KKmQjF2NBnoIMeo1JTrrrgD+JdI9EDEix9R86MctkMUkAQugYFg5/SxPoeqnoIQjiY6cOHkiAroCzBVQv+hOllDSWlCVUNuE/dwjfA94EMHgnamWuH/aGkzFNohK0AMXy+ScM+ROa8Z3R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Message-ID: <20250430195937.l2ozacC8x4PEYsttHWws4hHv_l1LdiUdbB__lEwg1Mg@z> We have now introduced a mechanism that obviates the need for a reattempted merge via the f_op->mmap_proto() hook, so eliminate this functionality altogether. The retry merge logic has been the cause of a great deal of complexity in the past and required a great deal of careful manoeuvring of code to ensure its continued and correct functionality. It has also recently been involved in an issue surrounding maple tree state, which again points to its problematic nature. We make it much easier to reason about mmap() logic by eliminating this and simply writing a VMA once. This also opens the doors to future optimisation and improvement in the mmap() logic. For any device or file system which encounters unwanted VMA fragmentation as a result of this change (that is, having not implemented .mmap_proto hooks), the issue is easily resolvable by doing so. Signed-off-by: Lorenzo Stoakes --- mm/vma.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/mm/vma.c b/mm/vma.c index 76bd3a67ce0f..40c98f88472e 100644 --- a/mm/vma.c +++ b/mm/vma.c @@ -24,7 +24,6 @@ struct mmap_state { void *vm_private_data; unsigned long charged; - bool retry_merge; struct vm_area_struct *prev; struct vm_area_struct *next; @@ -2423,8 +2422,6 @@ static int __mmap_new_file_vma(struct mmap_state *map, !(map->flags & VM_MAYWRITE) && (vma->vm_flags & VM_MAYWRITE)); - /* If the flags change (and are mergeable), let's retry later. */ - map->retry_merge = vma->vm_flags != map->flags && !(vma->vm_flags & VM_SPECIAL); map->flags = vma->vm_flags; return 0; @@ -2641,17 +2638,6 @@ static unsigned long __mmap_region(struct file *file, unsigned long addr, if (have_proto) set_vma_user_defined_fields(vma, &map); - /* If flags changed, we might be able to merge, so try again. */ - if (map.retry_merge) { - struct vm_area_struct *merged; - VMG_MMAP_STATE(vmg, &map, vma); - - vma_iter_config(map.vmi, map.addr, map.end); - merged = vma_merge_existing_range(&vmg); - if (merged) - vma = merged; - } - __mmap_complete(&map, vma); return addr; -- 2.49.0