From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFF84C05027 for ; Mon, 20 Feb 2023 11:38:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31F476B0073; Mon, 20 Feb 2023 06:38:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CF006B0074; Mon, 20 Feb 2023 06:38:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 196576B0075; Mon, 20 Feb 2023 06:38:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0AA456B0073 for ; Mon, 20 Feb 2023 06:38:25 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C0740140F8C for ; Mon, 20 Feb 2023 11:38:24 +0000 (UTC) X-FDA: 80487472128.21.371CEFF Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf11.hostedemail.com (Postfix) with ESMTP id ACDF040004 for ; Mon, 20 Feb 2023 11:38:22 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="J+Vq/Y68"; spf=pass (imf11.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=reject) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676893103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BYib57Q24PNa1Tp8JsjmDDkZKbWyNxjyAtUltZoYIIg=; b=T3JeOkaIzwfBpj7r4PTWpG/yC1USVpvYkt5qD8SLQf86jhL0e67wPxiLlWwgZ2HZy8AmQM ZVkPcRnqDGGPoplvvNaJbefFlRxhhQRMBPWjmgockP9Y/pUHToxL43fSMP/Lxi/VthU7AP F5FRFpLHWqz5zJ5WJWGvTuPDJ5z/MiY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="J+Vq/Y68"; spf=pass (imf11.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=reject) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676893103; a=rsa-sha256; cv=none; b=bXAdjbzwoYhZvyGaMOs4lPYndlRzs7EHr+7Q2c8TDda5Ynll1qRdNdulWxxEq3rNssV2Bg DdIOGSZquRSxFD5E+rmXEInuvEoYszrZ2GLf+xIgTMbv9geO+wMgieT10ZgRNUC4xd6a5m Qs+NJIezO351sA+LgWDIHDVk9ztSFOc= Received: from [192.168.10.12] (unknown [39.45.217.110]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 55780660213E; Mon, 20 Feb 2023 11:38:14 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676893101; bh=ndUssL4D1NSI2lJLSJV36jCT/BCfVQI0pK6z5TpTdQk=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=J+Vq/Y68W1ffVfJE823stvVS/Jvb3F21LdI7gG43d65Iw7HY0JniN8cd/FPpNjn13 GNhFn5rzaJy0D3jlUFAVVLIUkJv7STQ4SlYmG2ex4CZW0d8kXRtpgydJ9sL4HOGXbQ fNE11J0kxAin8LpX5jpmthIdEnRaDyRfudVjARxnQ1sIJXHfpekHikfsBqxE7/cOMC eWtwOwHVsb0rqUg1Zeo0wkS/CssID6Ok8n9PmBw5AQPiuUoRBTUihOuf0v6ogd4d54 1nyYIdaRdEGSlTTxCK2lPRgPrAlN5Uahrv+XWUPLIVq79/ymr/GLTxuaehbBOqlkpO GPO2MNx92epTA== Message-ID: Date: Mon, 20 Feb 2023 16:38:10 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Cc: Muhammad Usama Anjum , Peter Xu , David Hildenbrand , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WC?= =?UTF-8?Q?aw?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Nadav Amit , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Subject: Re: [PATCH v10 3/6] fs/proc/task_mmu: Implement IOCTL to get and/or the clear info about PTEs Content-Language: en-US To: Mike Rapoport References: <20230202112915.867409-1-usama.anjum@collabora.com> <20230202112915.867409-4-usama.anjum@collabora.com> <05962e92-9d14-eaf9-2e0b-d683986c9d7f@collabora.com> From: Muhammad Usama Anjum In-Reply-To: <05962e92-9d14-eaf9-2e0b-d683986c9d7f@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: ACDF040004 X-Stat-Signature: djeb6969ni15b8nty3ggqyyikf89kjba X-HE-Tag: 1676893102-432884 X-HE-Meta: U2FsdGVkX19TuGCU/DvVso0HDlnMc5t1M2ywUW1tXBEAO4zsbk+xrfKFX8BiMcWrpAnHp4gZn2XBbpvalans/TY48Ga2TdZcp8l+qbH4BLftR3EryE74by0XxtNugniuM4wswI5p1o0yaWzCmcpXnhryJieXofB+HDUYf5fwU9ezHWPid4njOoGYa0FD4WOkygIInyUsoYhDG1j9OzehH05QsFIuX1EHrV2iMERpk+1OCgAtKZdFMHYtkM+S8+cLJORG9WBvlapB28aXIhmh1XXzLtxBE/GytCCmmxO8X+c7BBiJoXouQGS5jxQu3lMqy+HkoBIME8aYUq54zFUh92tiH48qDsu+MobjpojohZJ5x0ojV/0al6IZk3CNz+hJ3ZiQ1iQURf/buiRoRLecKtrR4gEV8O/CJO/6+0EEXEvUTiqct0QjjTOM7losgQjFI93BCtWV5gNMNCCEgdwYbWTu98nBfFlikAeSTJJcr7allpCjBRfM6RdmJSNNno10W+Ba/IE0lURndjIkFRjFky0C9MIEvBUB1OSJ/wH6z48Xe2eNubCYmTq0w9O1pCyE1LuVrb7EteRAwn6TO0WqWGHQLfViltO0om4tcGI6r7kVB+/CK+Qm2wgvbn6gwDF/oOZj4UdUyEGTLCwPmaxmwOxpliZ1M/EV3nOxCxEaJhQUCz8gJTAkijOxuecyghyT9+L+iOic80FLo2ruMRNMXbwPooQe/V2WUPZh7t9blUSCyZfVPvtWoU2rmXhgq8Df2kqCMR3VjybiVp4Rsb6n9rc3wSOZmZpfsQhmc1kzcpaPpsUUFSZbEw3Zq0bO1yX4jEF7bv6B8nTtXdYpTGhgSBmuEuN1g4DALnQ1w35xp+krGMB+azyRlnDkB5QyFsGNr2Wd+e82TI/LiPyrw0/Chu9n0jsOFard9MSIpzavkXN6AnBmr81wfnfUGV3xYU5quC4Vi9v2iCAmFMTn0sP Bz6L+b8+ aNo9YwhbMVHKI7nniZDAH23CcN5VR6JIBxKhEPa2IQNlmsxtfhQ+ex7x8jEp91OE9/ZDDD1lSFtN/1j5tyMr3BYrSGNCsRv5Qni3l70sHzJX1z7PktULoIH2DcmgQ+asKyZgX6t7QrTGrXo55xbRLzYH/muWTikDLcrSsRyu6eb3GKJmA42GU7DqTU8WRJvzgN5+ikirpgX0Pj4ToY0AUt7QtMDToDjVmcVZXtcmwa6n2tiTmQzyvv4oo65hllRzFUqKEuZMAg4Wd/og= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/20/23 3:38 PM, Muhammad Usama Anjum wrote: >>> +#define PAGEMAP_BITS_ALL (PAGE_IS_WRITTEN | PAGE_IS_FILE | \ >>> + PAGE_IS_PRESENT | PAGE_IS_SWAPPED) >>> +#define PAGEMAP_NON_WRITTEN_BITS (PAGE_IS_FILE | PAGE_IS_PRESENT | PAGE_IS_SWAPPED) >>> +#define IS_WP_ENGAGE_OP(a) (a->flags & PAGEMAP_WP_ENGAGE) >>> +#define IS_GET_OP(a) (a->vec) >>> +#define HAS_NO_SPACE(p) (p->max_pages && (p->found_pages == p->max_pages)) >>> + >>> +#define PAGEMAP_SCAN_BITMAP(wt, file, present, swap) \ >>> + (wt | file << 1 | present << 2 | swap << 3) >>> +#define IS_WT_REQUIRED(a) \ >>> + ((a->required_mask & PAGE_IS_WRITTEN) || \ >>> + (a->anyof_mask & PAGE_IS_WRITTEN)) >> All these macros are specific to pagemap_scan_ioctl() and should be >> namespaced accordingly, e.g. PM_SCAN_BITS_ALL, PM_SCAN_BITMAP etc. >> >> Also, IS__OP() will be more readable as PM_SCAN_OP_IS_ and >> I'd suggest to open code IS_WP_ENGAGE_OP() and IS_GET_OP() and make >> HAS_NO_SPACE() and IS_WT_REQUIRED() static inlines rather than macros. > Will do in next version. > IS_WP_ENGAGE_OP() and IS_GET_OP() which can be renamed to PM_SCAN_OP_IS_WP() and PM_SCAN_OP_IS_GET() seem better to me instead of open code as they seem more readable to me. I can open code if you insist. -- BR, Muhammad Usama Anjum