From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEAA3C3DA49 for ; Sat, 20 Jul 2024 07:50:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C51556B0082; Sat, 20 Jul 2024 03:50:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C00256B0085; Sat, 20 Jul 2024 03:50:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEEA36B0088; Sat, 20 Jul 2024 03:50:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 90FF16B0082 for ; Sat, 20 Jul 2024 03:50:10 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CB3F51C1E54 for ; Sat, 20 Jul 2024 07:50:09 +0000 (UTC) X-FDA: 82359357738.27.D36B9DB Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf25.hostedemail.com (Postfix) with ESMTP id ED482A0008 for ; Sat, 20 Jul 2024 07:50:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721461773; a=rsa-sha256; cv=none; b=8Mp/kUfSTWxiEVW3ooetVKGm8OZjHv63LYjymyJpIC1N59sV+DeFPH+A4bopoovLFd1Gc6 nJV6+VwDcnVXsuidI7xpXuZfgDgkWjHuIOKEoXwRioJHPEEXrtHRDad9XBytpDDo6wTIVA ko9C+1v7nqfNvVBLB5jgT9Zni2FqVSA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721461773; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gu2eJUEcVmQeXIsDEcOdAUb4MSBFrCbOExMUtO4OAUg=; b=DVrAildp8ZuCco/jP6TVN/fq6DTu35p6Maf51x5bgBSvKLDG4ipX8tm4UQPVawe2JNgC9b rb5QUlak7QD55p76kLZMHO2+L1Q6Iyx+cQz83igc6/yTvvCAEtYvAEd2uHQRhqayaUBiEL NGpDbptFHaMiQYNx9FtuhGwSCZpgwYU= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4WQz8y3t2xz1JCmH; Sat, 20 Jul 2024 15:45:06 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 1C54D140427; Sat, 20 Jul 2024 15:50:02 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 20 Jul 2024 15:50:01 +0800 Message-ID: Date: Sat, 20 Jul 2024 15:50:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] memory tiering: introduce folio_has_cpupid() check Content-Language: en-US To: Zi Yan , Andrew Morton , CC: David Hildenbrand , "Huang, Ying" , Baolin Wang , References: <20240719144306.258018-1-ziy@nvidia.com> <20240719144306.258018-2-ziy@nvidia.com> From: Kefeng Wang In-Reply-To: <20240719144306.258018-2-ziy@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ED482A0008 X-Stat-Signature: ydk3ab58dtdokhaed57ge4zb8xzhjn8p X-Rspam-User: X-HE-Tag: 1721461806-633877 X-HE-Meta: U2FsdGVkX1/qSVP/ksd+hfCsd8s9e4Y6ZXvYrVIvkqiacUZV1r+a1Wj0V28hdfPmHVz3Gv2mCi4/U0MKpbHJjN+nexUqUKmtH0RrInbPEhDtzHNf3WfBryWKlByNyVgD6B/XGcln23BXvNkiMh1qwlyCVg4hKik/M5aRYdr4S6/ir7NgNct6rEHdBzcIJDc8em4AsCZ7pI0s74gM//5i8dJeQuxQHqMR+5CbzibKjijyySNnjXosf8UXbefaRqnNV9InLCqhE1wdW27TfqN+osJiHZCu0N0UMVeFhUcduNQd1jDdy0RtpfILNCXgH3Kj+QK+ZcS7ZMpjbfhLBArWRxvNVnbSmmyEiHWInjLRCAgV3FcCOk/x4qkGaLGNMMrvzXWdX5JBW6K5ABsu0lv6U7jvmBvYARsEQ8vqElw/oVJbWJUeDZfPcuB9InEyDcMKgjc7HPyJE9lvho48x9pVSaUm+0qiKGIgPW3/YGC9+uXbTYMffb8Rgrvhxp1vyxvLNarxcwS6UYu+dzKqTpoc51bneWojGltwAdhsYc0stlkJB5H9+wdHggVY3KJyKnbzXq/kOIfp//jW29r/5b+Y+btFlLJPjLA4ijUzP3qu2XXm4VpUcBvXtBpYOSjFGwuobWWBlT038YgVejkgEPbiAFxs6AnI1VSD/biy+PTfe3d3Ksiz2cX/s8yHUluBv/dhyvH983HH2rcjKDQPndlQPkPIWbkeGQVqd+VVaouNeYDl1BHQYmE7vBnA517FzYRJG6GcKv3Kmrp/t0qFiovY/7y6C5enfaREURUMNRKxuctH3vJ6egSpqRIPEvpn0GisL4UvMLf6Nb5QponymHCtEdfO6YShNdDaXiJ+qWnwcmPU9PgRYP3yV1ZA0dNdoyFuZEqES1MxM2ZMPvRpeuuS3R+Hn5rFy9Gr5SSE40pSZpk1Vf7E7NaQiICP2tdtN9Au0TseHrJ4vv9I+cJsn7M 9H6077Us UtqoJAXzBA1Ph5+zVwsbOvyogwx4gy09dnKGLbF0GpLHx/EXOPr1qoR5Y2jicFJ4e1I2frz3cBYJA2myAlozZc+K/YvGGYP7TSD4HvQoA3u+LJZ2NyNhpLNlXujI/KUZTX2Y3MOawjAO5aHa2OHo3L8rktyY9bwJcWGOFAZkr4P4vzf/MeSP7H9B42eSZvXaGuwJD4IyZF6Qggp/zcqJFq+0K92f6r00euP20AcHFPMKq8T2Q+oFJgdpB27OVSv7cYNDE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/19 22:43, Zi Yan wrote: > Instead of open coded check for if memory tiering mode is on and a folio > is in the top tier memory, use a function to encapsulate the check. > > Signed-off-by: Zi Yan > Reviewed-by: "Huang, Ying" > --- > include/linux/memory-tiers.h | 8 ++++++++ > kernel/sched/fair.c | 3 +-- > mm/huge_memory.c | 6 ++---- > mm/memory-tiers.c | 17 +++++++++++++++++ > mm/memory.c | 3 +-- > mm/mprotect.c | 3 +-- > 6 files changed, 30 insertions(+), 10 deletions(-) > > diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h > index 0dc0cf2863e2..10c127d461c4 100644 > --- a/include/linux/memory-tiers.h > +++ b/include/linux/memory-tiers.h > @@ -73,6 +73,10 @@ static inline bool node_is_toptier(int node) > } > #endif > > + > +bool folio_has_cpupid(struct folio *folio); > + > + > #else > > #define numa_demotion_enabled false > @@ -151,5 +155,9 @@ static inline struct memory_dev_type *mt_find_alloc_memory_type(int adist, > static inline void mt_put_memory_types(struct list_head *memory_types) > { > } > +static inline bool folio_has_cpupid(struct folio *folio) > +{ > + return true; > +} Maybe better to move into mm.h since most folio_foo_cpupid()s are there?