From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 846A9C3DA4A for ; Thu, 22 Aug 2024 12:17:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A717A80029; Thu, 22 Aug 2024 08:17:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FAAB8001E; Thu, 22 Aug 2024 08:17:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8733F80029; Thu, 22 Aug 2024 08:17:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 65A538001E for ; Thu, 22 Aug 2024 08:17:58 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 19C5AA15C6 for ; Thu, 22 Aug 2024 12:17:58 +0000 (UTC) X-FDA: 82479783036.06.0703EE8 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 3C673140006 for ; Thu, 22 Aug 2024 12:17:54 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=gtr3NN0l; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf23.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724329016; a=rsa-sha256; cv=none; b=ZcWVZx4Co4uxh/2rREdkGMWcSL7q3qUsp+lRhyUp9LdR8bfsTvIYHCHGw1IxNdyUBG86PY s8QwzxXQxTb1mmnVitpnWltxuM2e5hTp8Bx5QAbQqsHqf+gtPhDvsJyUI3IiJ8BrDl9fN4 fIpsRR3lUauJfIcy8vvaVK2BDE5WLZU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=gtr3NN0l; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf23.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724329016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yx+C2U4iF94VXeDjm9C7FkXz5nA7V9VNqSYF9OlMlok=; b=7EmI5d0fh5haFYDd+aHEbu5wbIgPrmb5QshOeGsU7h26Gful+6VYUZdyAd+r7cEvTAxoW3 Z6Y3Ckccc9ligutY4YDNS1eRpVd4PeGZi16tSkO/C1klsDS6zbE62KMdseBsRsJ59PjYWC bgUvqyyRKCYNzAYJkqgEgKts9VG3Rjk= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-201f2b7fe0dso6391585ad.1 for ; Thu, 22 Aug 2024 05:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1724329073; x=1724933873; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Yx+C2U4iF94VXeDjm9C7FkXz5nA7V9VNqSYF9OlMlok=; b=gtr3NN0lt1Z37xR3BfxpVp+KUqsH2zpSVdJNQnvSNw8G7GWgnZvP2bFdIKK6MFafGK Lrn6lREGzKnGODhgSDsMQHdz5jF6/K+d/hwoA8JNF4j8RJ2rTr68rfuMK8C9T90pvFwu IiN/xsGRbpOHotpK29EyLawA4N/vLSBQRzgwkIEH9IX/wQlKHvqPcowxTUiqn2uJII20 4LQg7yuBskz3Kgz5NDlq67KX2JCtPjsVRv7QWLUQ1Afl7HoICWP8TCz3AlvpqmFm8LUF a9RjMWO7mwHQwYqRxxMptySmbnTIDGSGCD6PuqGhxAXBPjJfxEHQixqjuiUs6uHKlzw6 m/Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724329073; x=1724933873; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yx+C2U4iF94VXeDjm9C7FkXz5nA7V9VNqSYF9OlMlok=; b=Y1ncdTl0pTU8vhUaJmJR3vCjlmJxYRN1iU5OQiV+41bZUaIgGedttnLT+NjtQgQkPD tV98DRkfIVnhUOx+MLYtpDovuGspH/qTkQ6PvbTgbM8AT5g3cp86B4Pad28X/dPhpcIc 07mUP8kR13mVYlbkGU9RXNK3nBnOiVoL/KnjTTBXtzqkC3EvGkKfd+s67xSg+IYmvSCZ uoeWsoY0xyYRQZ985f21Ln+lrK4yIOHbArgf7FeRgYlO/heWFUwyhv6bMFvgMOH3w4hj y1SeclUyeYyHelXpYQtDVAOkKVNGHqqAzUdQwEWzCJQBqUrfBKodWTaARa2iYwfsG5ev SjQA== X-Forwarded-Encrypted: i=1; AJvYcCUvKI4Hg7SsM0uBcWDwOtbHExTc0oi+qedMQAazj6jLV9yDr6iYPHiEdJGuZVTwZQCiL/X8n9bu1w==@kvack.org X-Gm-Message-State: AOJu0YxEr8icckNeBOE3fvRUT6g7MBoj2C944Og1HfPHdSQeb5Jxp+a0 pF10U5P/MbZVoBXp8JS/hRtKpk9nez+Z70sZyq5EC9pCq3WmTb70lm66rH+5nWk= X-Google-Smtp-Source: AGHT+IGQCmIxIo4n5wGGT5nxKPt1EKhdUohcyrEN/h8veL+3fxj79HNkDhzIeZh/LJSzH8gYmwu90A== X-Received: by 2002:a17:902:e745:b0:1fb:93d6:9fef with SMTP id d9443c01a7336-2038890f96fmr17992995ad.38.1724329073509; Thu, 22 Aug 2024 05:17:53 -0700 (PDT) Received: from [10.255.182.243] ([139.177.225.253]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-203855dbed6sm11386985ad.172.2024.08.22.05.17.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Aug 2024 05:17:52 -0700 (PDT) Message-ID: Date: Thu, 22 Aug 2024 20:17:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/14] mm: handle_pte_fault() use pte_offset_map_maywrite_nolock() Content-Language: en-US To: David Hildenbrand Cc: Qi Zheng , LEROY Christophe , "hughd@google.com" , "willy@infradead.org" , "muchun.song@linux.dev" , "vbabka@kernel.org" , "akpm@linux-foundation.org" , "rppt@kernel.org" , "vishal.moola@gmail.com" , "peterx@redhat.com" , "ryan.roberts@arm.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-arm-kernel@lists.infradead.org" , "linuxppc-dev@lists.ozlabs.org" References: <239432a0bc56464e58a6baf3622fdc72526c8d57.1724226076.git.zhengqi.arch@bytedance.com> <6a586524-5116-4eaf-b4f3-c1aea290d7c1@cs-soprasteria.com> <4b867535-8481-4fa1-bed1-ad25a76682f0@redhat.com> <61c05197-0baa-4680-ad24-5965ba37dc35@redhat.com> <83142dc8-edcf-4e47-8215-8b359a2b7156@bytedance.com> <04dccff9-87dd-4e97-a712-b62fa51b32f7@redhat.com> From: Qi Zheng In-Reply-To: <04dccff9-87dd-4e97-a712-b62fa51b32f7@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 3C673140006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5o1d37eqor8uw9wwjdiqa54f744ixsct X-HE-Tag: 1724329074-271673 X-HE-Meta: U2FsdGVkX1+jvUKgQwYGtCjQ6Crw2w9dW2kCMfXnRbXNTm0hro2Sm2eZoraAErwkOPP3Xxiw/zq5u8Pm6goh2oJ08UcpA33EGrT5WnezhfGIF8VY+RDfSF+GFvLzBYLNGUNj3FoHoFTnlrVRgS8pCksLsYs9T9iQqBmzZaadjAcefQrflx6ykkSIJc3RZ/S/L2bb2xUKXaz62I7r0CTVX9tGLgkPFD4IrkEY9vkgaEN9gC1dnKoaMvRptvy2TgU+OJsPritEJ/8CIrTSG3BV2PCxEznysuYzGB4OXPMbWL1sk8RWwGCeut/WyRX3K9vhRVJz3Zl5UJ62T4fWL5I/WsANFYkvGT7RMTD+34zkzQtkK2G3irPYNlS/4eBhXCibn/HQcG5uUL+av2V4BbSwcmGXc6ErdEf5qtESHAdA7ngym02uMxqKXy/hJYlZ7KM1ZgfvsqCYF0MHbqxRvDxpXrAhovY7hNJUf44E+o/v+kP2ylPAdSIyzmFDdan3/+wjPYmbkMbOduFRDHWZwckYsWSSDeJGDfclRfd1dQd/m/eSPmZSDMqYY1WRrKNucy/sCLmxHGnnAsusKbTH8UOjfB5y8w9XaoVsuW/USkPs4FxGeECy2joyojH7ehwdBbyo7tNuVZfiduLoK1sLrW2P7/gNALfKEezc3Njj+N5IfL/cBXNshls+NFSauZl2H6e0311kAcfRxCZS65bs3dPY/cQQmnSeaBdVENuWxc//S705Nna8uKwJ0nuxePAB5l0BbJfRnZQEtDGa25LK/4Dj69jNEjQGOL5A61d8setP4GTrsV4QN4YptjH1czM1sj01Hhlu4oAzQuiMRBR4PqkG0q3HCQdkpTGk174jseMKhGfuoxwY/QZl5o5eKnwYSHubo1r1TMRH/p5TXz9CI9+E1E7CNj7VbLNy63WwQjnSfSeHfD0JLVnpcW3gt9At0DTmohmYTpVkAvLWmaOwZIf yzYfnqhN qNJmJMmk9uohX1JvnseeKx5fTkK6bZTDAibQktxBb32KMrtvxSRpVDkvKLK4YYEZ37yjzq/c8jGa+oGxuF8poom/0g9mv6tfdqckOnFALToY2Z1X41zvmNCI0fKJ/mzEKG6BwgpnGUgNEPpb9V9kSAHx3ddEuJYDZtN1q1f+SX5mnvisG3kmrg/WBvVwo9KzGJNH1RrwaAmRA7EZH6zuSaxChGd0uBtrtk1Z8u7GWZSaHRSZ28H0b9nXaZ1unHJ6BFvWCemk4h2nAqUKvdpqvT4aMOQxoV1/AaQl3YdFYl4zrIcaqX2ZgkPWNinWT/Uq0yTdmnG9QsmFwsjhcA8mCrmQOOeCoDfvVLIkann1Wb7hvjZMyP3/DnEnOkO9hm8THtWPSgWNnY6ec4sMBwQ5Ilkdbxia/nQsHtC8wFTY1NHK7mnaAb9jn8+xIXG2dSOKZUd+Jw/l7VdVvYmjSJCoNP4HFZwVFypzhUKsVX89fY6LrDgEKmBQH9Ug2CYhi0Php3ZsdUb7M3sX6zRL0YFd6ro39eVmA4kFj/zT/fGiJLT/qJeVpAtuC+LJXYcvZePlUVB2QsOYqvMutwx9FnbZuYKC4rXeJIrQ8+7scOsNCquazEXA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, On 2024/8/22 17:29, David Hildenbrand wrote: > On 21.08.24 12:03, Qi Zheng wrote: >> >> [...] >>>>>>>> -        vmf->pte = pte_offset_map_nolock(vmf->vma->vm_mm, >>>>>>>> vmf->pmd, >>>>>>>> -                         vmf->address, &vmf->ptl); >>>>>>>> +        vmf->pte = pte_offset_map_maywrite_nolock(vmf->vma->vm_mm, >>>>>>>> +                              vmf->pmd, vmf->address, >>>>>>>> +                              NULL, &vmf->ptl); >>>>> >>>>> I think we discussed that passing NULL should be forbidden for that >>>>> function. >>>> >>>> Yes, but for some maywrite case, there is no need to get pmdval to >>>> do pmd_same() check. So I passed NULL and added a comment to >>>> explain this. >>> >>> I wonder if it's better to pass a dummy variable instead. One has to >>> think harder why that is required compared to blindly passing "NULL" :) >> >> You are afraid that subsequent caller will abuse this function, right? > > Yes! "oh, I don't need a pmdval, why would I? let's just pass NULL, > easy" :) > >> My initial concern was that this would add a useless local vaiable, but >> perhaps that is not a big deal. > > How many of these "special" instances do we have? We have 5 such special instances. > >> >> Both are fine for me. ;) > > Also no strong opinion, but having to pass a variable makes you think > what you are supposed to do with it and why it is not optional. Yeah, I added 'BUG_ON(!pmdvalp);' in pte_offset_map_ro_nolock(), and have updated the v2 version [1]. [1]. https://lore.kernel.org/lkml/cover.1724310149.git.zhengqi.arch@bytedance.com/ Thanks, Qi >