From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 423ADC678D5 for ; Wed, 8 Mar 2023 14:34:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F2C46B0072; Wed, 8 Mar 2023 09:34:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A2916B0074; Wed, 8 Mar 2023 09:34:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71D9D280001; Wed, 8 Mar 2023 09:34:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5E35A6B0072 for ; Wed, 8 Mar 2023 09:34:37 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E4264A044A for ; Wed, 8 Mar 2023 14:34:36 +0000 (UTC) X-FDA: 80545976952.28.3F8C016 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 988C11C0021 for ; Wed, 8 Mar 2023 14:34:34 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a+xkSXNM; spf=pass (imf18.hostedemail.com: domain of dakr@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dakr@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678286074; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oTHYKj0ENiayYQrvquAcd+pJGNNUwvGn3+gkRMCFauE=; b=YQdPzMqWoBijtDmY5/D/JJuZL5T4geQ0jKfO21H5VbquBfBTTXzwfD2ffB9kI/Zh6ykYIg jqM5Vz9dHj+d6fHyruPoD7eJAvglUyTyqgfY+7dfgVLUAHMKSYwPy2kau4/qzFfpffshC4 5RSVsRG8IM1eXcd3DoEQh1Po1TJOGGQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a+xkSXNM; spf=pass (imf18.hostedemail.com: domain of dakr@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dakr@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678286074; a=rsa-sha256; cv=none; b=1TbsiBGMFl3OMY2pzvwl7tWxWWcV4LpZSEDM7G+cOz+2oX5F37jObROoo6pbMEgA/a/goZ o3wpxKRr3MmqePKqTbBANkBWL/Re7gOTXkrND1yWACUj9zP15eT7E18jRWGlPVMSVRvz+F 9uDLPxAXd+a/z1t7icUNJTkP9J5N6V8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678286074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oTHYKj0ENiayYQrvquAcd+pJGNNUwvGn3+gkRMCFauE=; b=a+xkSXNMi2Hzn4kNyrbR++ZPx7tM7F8FQywVUcM/8J9VXt2R+8TwhsDBr0W+qNvql3VTJx 77EtMyPPSLvxFkSSXeYEPslMO3aXa637t56IT9l83mmuMnxr5ikXKdDhl2pXVxw+wY3aIF qKa2BhVIdFnvNGugPUAfLgzdkgXbGfs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-401-PZyMy_BDONW715W8bj28AA-1; Wed, 08 Mar 2023 09:34:32 -0500 X-MC-Unique: PZyMy_BDONW715W8bj28AA-1 Received: by mail-wm1-f70.google.com with SMTP id c7-20020a7bc847000000b003e00be23a70so1035318wml.2 for ; Wed, 08 Mar 2023 06:34:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678286072; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oTHYKj0ENiayYQrvquAcd+pJGNNUwvGn3+gkRMCFauE=; b=Am8JLgwFfcT97Ej6KOHw2O88h6QmRLT089X0HFWMJDfxnCy5hqBQ8zqe6qe2rHzF8G l0WrJpGFwGUDbOyYtCmb4F8bOgQI0/4aUl2kgvXjnIrTUVT5Lui00+RhiaxbpXLoe0hu uU0rPcJ2fQaY5uv2gycszp1BXvZuoJSbaElaVavvYCRlIBvDm1a8G1YNy+dy088nyJt0 NcsJpQGgB6jKxLPH2/RD9uRRaWW6S95Cfr2fGvZJcli8tFQAsQ7QZPC0/fhxKXH5fVzL VGFYBH/KnJ9UG5MrNLwoYoZ8lg25rkRmEpgZoKMzOi6luI3gyFPafDDP65nkKJP9VkoO Pv3g== X-Gm-Message-State: AO0yUKWIt+0ozmBs7O2BE28QBe24UdxUZX2Hi+H3hWXrfkkgSeCjinsI KxIOSYwndmHv2hWKL/7jh+HKcg0Q7+N+hJxrAi8xHb/DKp8IHsTSR/oTXK6b74kISfedhtirOBv bz4BjgRsOedg= X-Received: by 2002:a05:600c:a09:b0:3ea:c100:e974 with SMTP id z9-20020a05600c0a0900b003eac100e974mr17395236wmp.26.1678286071801; Wed, 08 Mar 2023 06:34:31 -0800 (PST) X-Google-Smtp-Source: AK7set9D/blJuqN12Fj7TihHQyymDZzJYzQDkbph+1hZqLl9Hnb58NBvT8CIu72bROPuyM0oQPJdeQ== X-Received: by 2002:a05:600c:a09:b0:3ea:c100:e974 with SMTP id z9-20020a05600c0a0900b003eac100e974mr17395225wmp.26.1678286071556; Wed, 08 Mar 2023 06:34:31 -0800 (PST) Received: from ?IPV6:2a02:810d:4b3f:de78:642:1aff:fe31:a15c? ([2a02:810d:4b3f:de78:642:1aff:fe31:a15c]) by smtp.gmail.com with ESMTPSA id v12-20020a05600c12cc00b003de2fc8214esm15563649wmd.20.2023.03.08.06.34.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 06:34:30 -0800 (PST) Message-ID: Date: Wed, 8 Mar 2023 15:34:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] maple_tree: export symbol mas_preallocate() To: Vlastimil Babka , "Liam R. Howlett" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org Cc: Christoph Hellwig References: <20230302011035.4928-1-dakr@redhat.com> <20230302015242.xi3y53okc4skmonn@revolver> <9abef101-3a9b-0bdd-7139-ced7d5e28ebe@suse.cz> From: Danilo Krummrich Organization: RedHat In-Reply-To: <9abef101-3a9b-0bdd-7139-ced7d5e28ebe@suse.cz> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 988C11C0021 X-Stat-Signature: ej7p93pkwaaaajzir1iag5h7gqrpa6h7 X-HE-Tag: 1678286074-394880 X-HE-Meta: U2FsdGVkX19gVXUI3O5qY6JNz5V7pgT9e5R22bvprA0PsP9UVIcKxQ7KJt3043dmoLRSpwDUFz/2SNqU67lblFYkdu2tYpft/xdvoWRAls4yUnZTcZ4c1yDgDCEa5chJEUR3ES/e3jING9Uew6MAzwKqyuNZwaBOy/IdjJDAjZggjURRcTNwtSPvP956kZkl81pdpz5Ofp/PKclHWH1WtmNxa06iy1WyZV/vn8hSAAuwTrguxbZVgECIEsP71DY/ogLs552bxF8z+Ph2gWfsGO6Z3rpvCax4Rton85nfoO9AUvvYZI3HXcKgDoLnv3lyozvMGOZ83WdzLho5y+bAbfmpEMwq047+y8n9Yt/AsG9bn1l3EFQY9cn5yPTyl30vAHr8BQgnw+gnrnmGgWHqKIxCD5MJdINkkHgj5upeQV9cpjHzfvjLzvtAuk3bPHqk240u0BPmSt6nBnkLSYnqxN1/D3Ck0J2CVtCqH0aC1kcg1BFIsu/OJEKHJYTFtDe6nuOhwSMPMBkyJd36IvKLpi43V1IpTOzXPP8qRe+KFm3RdjUDrSl/RUdWKRQcp/2DmR4djDIjppQ8eJPCy8T+Il5M5BNm4TDruxGYrrfv3Za3i9qQTYCr+BcLpM5+lTJcfahioXnJmIYhtE94y1gx1221sBRyXtfFjqA5Vk4IG8iMMndzC3jfADzmiTYucquYwfJZ4nfBKtGXjgad55s7OGN1oKH5jSEH2YrGTqwlTl8YmOsNxjsN/cSTE+NunGk92BW83TA+P/VPrFY0xlYNgIR3X3p+bBpKFvUzNY3v6eeNIRo2drLIjamKR3MO5bUMaZdZMVsndaptckTjcV5Fxn5Kn5BOnwwpa8rXjWMOw8YXVO+E9BKMSYDWFm78JquNv9Pb/ghUYfW7aUy4Hg+yJadF4Y7+qgjan8FouQzXMHLCUTVbTtluZDKBeJp4nbSHTRH01bni6HsOWRPFq1S Qouc9vi0 eQi7r9wm6E1FkeFWIzudhoKPG58WHXNZXLokJX0IotJ8o+y2kjQu0a50rQj4A5JI+m1lU50rOzyml18BGH343HEs0PMGmSGWR1BJWZpllmL43/uR+IdsM6LtvPgzqGK2tkF2BGUv9TOLfXopiWsFWZLFSiS5bpnb9O70C3pbr8CwHkKUEo2uoNdw37pl7M1ZSgU6celH7CPgA/nb5W2ffvqJk8qq8XMHqzImrN8Iswagt/gQ1wnHBwp9+at0MLo1p/bt4DdTsXrPZktn8Og9DY3cyUt8jeaf+1JYjyp559AqGFefU5Cyrss3R1KPZTZfaeEI/kntllQxQtxQo3Nv2N8OxrH9tmR5ja+4ffY+zepasvGrsG+rpM12BjD18h37YZIuLb8Fij8M9kuSW+Le9yN1MZbWp7GqL4Dq7pMbNV8JsMA3+vWdz9gJ9sJQy2g8M9TR9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/8/23 11:59, Vlastimil Babka wrote: > On 3/2/23 02:52, Liam R. Howlett wrote: >> Thanks for the patch. This should indeed be exported. >> >> Reviewed-by: Liam R. Howlett > > What uses it? Don't we export only things used by in-kernel modules? mas_preallocate() is part of the maple tree's 'Advanced API'. All other functions of this API are exported already. More specifically, e.g. mas_store_prealloc() is exported which doesn't make a lot of sense without mas_preallocate() being available too. I don't think it is used outside of mm yet, but as a generic tree implementation maple tree is pretty likely to be used in code built as module, e.g. drivers. > >> * Danilo Krummrich [230301 20:10]: >>> Fix missing EXPORT_SYMBOL_GPL() statement for mas_preallocate(). >>> >>> Signed-off-by: Danilo Krummrich >>> --- >>> lib/maple_tree.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >>> index 26e2045d3cda..3bfb8a6f3f6d 100644 >>> --- a/lib/maple_tree.c >>> +++ b/lib/maple_tree.c >>> @@ -5733,6 +5733,7 @@ int mas_preallocate(struct ma_state *mas, void *entry, gfp_t gfp) >>> mas_reset(mas); >>> return ret; >>> } >>> +EXPORT_SYMBOL_GPL(mas_preallocate); >>> >>> /* >>> * mas_destroy() - destroy a maple state. >>> -- >>> 2.39.2 >>> >> >