From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1FF2C6FD18 for ; Tue, 18 Apr 2023 15:45:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6749F8E0003; Tue, 18 Apr 2023 11:45:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 624A98E0001; Tue, 18 Apr 2023 11:45:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EC2F8E0003; Tue, 18 Apr 2023 11:45:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3F4948E0001 for ; Tue, 18 Apr 2023 11:45:13 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A68791A0326 for ; Tue, 18 Apr 2023 15:45:12 +0000 (UTC) X-FDA: 80694935664.20.77ACFAC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 256E91C000C for ; Tue, 18 Apr 2023 15:45:09 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CDPJWjw7; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681832710; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=27YuiGTc/1Ayk3pIwHwifC0cK9cQSm41NYDsP6qMI7E=; b=zS8HXUC8WiP8M0pUpAMKJ1sv4Fyrmm3I3MmvnUukn/wO0EmxzNo2iPUV1T9vhJEjpwbNLu iachD7JI22LMQ61W5HqnoDSlWFOf8cKaBtNnjtC/ASkv015PmYjgxXQ7Y26prCuNpm9tbl TyrfkUQqpSw5n3DdtnVGjonQb1IUYzg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CDPJWjw7; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681832710; a=rsa-sha256; cv=none; b=jW27Gl7NdlzUBzgy9hppccMq7YgfrL/EtvB7alXXjJnoiAHzUC77wF1ZtH5z6tK+TP9pVJ sjkhlCC6yViO8sTibNPLqSk7+lV69mltJqtfVQg9jHlSN+u7kgyQoGBR/tXAAeQSn4Gh8Q 9tZtEOR40eI431SreCRv411uxqzWjjk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681832709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=27YuiGTc/1Ayk3pIwHwifC0cK9cQSm41NYDsP6qMI7E=; b=CDPJWjw7922+HWw5MqXWuotkaTCG5XVEvGU1OSihcrxAc9NydIVybPt59TN32MBRtuA/5m UFxuV07/YeaK2h96WTHKE4Xc2Lrlnzyri5go6ZXhcHvV4A47wf/QxXJa4YP8FT4DCwQ8QM +Mu/7eMO8xZc5VF/cbvXjIiEcZcwDkE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-524-zRdJosABN5i9FyyfDOj0tA-1; Tue, 18 Apr 2023 11:45:07 -0400 X-MC-Unique: zRdJosABN5i9FyyfDOj0tA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f0b0c85c4fso42470585e9.0 for ; Tue, 18 Apr 2023 08:45:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681832706; x=1684424706; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=27YuiGTc/1Ayk3pIwHwifC0cK9cQSm41NYDsP6qMI7E=; b=dvzUry71os0uALs2E5KMLktXzgceIqJ+ernypj+Wh9rY9TxFnG+E1wfCr2D/DDzWAc 7nejL8yi0FF8d79nBTXroZf3GWzcfNVYlMOKqmfOFLRHuUf4ENI+tF/X0VJr9w71Ofvy 2rku79D+WFHdOW+cl5TLByK7o+SdDro3dhTutdjnasOnrtOjObNgZJwAHJJPXCbPQSoo yms2Rnqt0oXDmU4sR0Peuw1wJ3RgzoajPdPT29zmGzFFvwY5mmbNdIRTrRtC8BVDOt+y +CaIsFdnl/e67+18zo1tUZlffcMAfHJUedrOk2HRTNApeODyS3Tmv7wrSAJccrOfQlJT 13Hg== X-Gm-Message-State: AAQBX9fYb2WhWwlwVn+vscKFRVDZREkxe38nvBfDox/dPM4xqjzpeMMl 3jeWjboUi1XNNzn+bZcLAiJoxwcOccK/J7wSuMRNzsrU3pTYZeeNEJMw8N1GbfkKoNNTmrbjX2n sb3sL/g6Pv5j8CFiNPB0= X-Received: by 2002:a5d:6dcc:0:b0:2ef:b8ae:8791 with SMTP id d12-20020a5d6dcc000000b002efb8ae8791mr2341927wrz.10.1681832706618; Tue, 18 Apr 2023 08:45:06 -0700 (PDT) X-Google-Smtp-Source: AKy350boD2pgyaTgtT87B/OGZT/ZiXFytTcP4U4+Qx8x/yMODSTgYDG7+n20ySQtuSYJgFc2NPKTdg== X-Received: by 2002:a5d:6dcc:0:b0:2ef:b8ae:8791 with SMTP id d12-20020a5d6dcc000000b002efb8ae8791mr2341904wrz.10.1681832706235; Tue, 18 Apr 2023 08:45:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c715:3f00:7545:deb6:f2f4:27ef? (p200300cbc7153f007545deb6f2f427ef.dip0.t-ipconnect.de. [2003:cb:c715:3f00:7545:deb6:f2f4:27ef]) by smtp.gmail.com with ESMTPSA id z10-20020a5d654a000000b002daeb108304sm13380984wrv.33.2023.04.18.08.45.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 08:45:05 -0700 (PDT) Message-ID: Date: Tue, 18 Apr 2023 17:45:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 01/33] s390: Use _pt_s390_gaddr for gmap address tracking To: "Vishal Moola (Oracle)" , Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org References: <20230417205048.15870-1-vishal.moola@gmail.com> <20230417205048.15870-2-vishal.moola@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230417205048.15870-2-vishal.moola@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 256E91C000C X-Stat-Signature: adanhyuf96xrbmjy4fmeg89365wsxzch X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681832709-869217 X-HE-Meta: U2FsdGVkX1/LB4eEVFq+8AvYmCXaxb4P1QgZe7rJZI1+H8dTOvvWuAUUFt4mMiBJ2a4vzGZdCF0kb0BefC+fS6SLTLTKJFn5jyJVlQEeHVld3pCHGZtl26QzFJXgF1r/Pecb0ilomZ1Gjxf/1w1P+Kz+W21K8Nbd1PWZypF/hdhgT4C3I/8LjUJLJ76gbOkULL6chLWa9pcQm4r4XXv6AAQevhu6xhw9kwTZ7CSrZGdUNQAShsayeWMvfjXYX97jkoulHKfXnQFWsSBrYuWm4OgZO4ceFY8sVKrien7XGnk/gvMLxjTJ5K6JeJFUE4+h/84piPUFhkPSD7cfImcWmHDt/fBtfFHOmGVpOvTzIHQRdc2RkfOHJ/1BsdZDxxv85V4HRSEDsi/bfsf55145vDAJ5FuY5nZEbP27kv+nJiT52XCSeuffvfu5QSi27Frsx0HfJ71jgG91Vo8voA/OHc2wMLybKqnNyDbjqcsLgNbj1Z58qVEK3NY3TEuZ99HgfV+d8Lg6tn81IumsGth9XJQ6mb2xg2qjr/eLwbM52lqzjaDBXYlkWlpOxob2jRwwhDRMJosMtPIFxU23GTB8DlNQiqbx3lIjRPiPN9BL6SmdRFA55jYNvfmTm4jfn2WkaOPRbXyrz1mL8psogcJII2GON6abdx9FqxJDlni21a5Mh8zRhhNiYep6pJxNFbhsSybw5Aun28kJRMhaKQ+6v4f7z6XHRhfATY4MnJTMIc2Ey2gaDcFVzC+f/XLp3K4I284YaCeWUNIc8Kzq2SBXWMPxulFjF2po5DaTeWhdOMZ+MuiQOvhVJNWf303VMjrJseI6yrOmkekzgipn2ZDV4IKKJ7c60gAWK7/ZztnH7Swu2OOaWKEvtsql/OlJ2aXqtdcCnDENKTz/+mqcGdb+ZsVmz5V7RmdAsJU0SMXRbN1lhZRSG8dQA4XQ2oFDytHGlCmqglL18MPeCVqOutk rYpDYyXA d9D3m6uWfqV7JtcZ5dhht27SmfVmHuVbwO2JqQebGO8LzCvTw1EvR15dEtwMJWUqfJ8+FzpU3nHXEWn9a85gPgy361+qo1SvNm8TjGd9GGqUVdHnk28JoszbxlJBpM18wmnJX6KbE8n3CNOCG16ooiBHc++ncpdok8aH2IuO676U9Nl5gfm6qx6YQBUA2qYEX2ReGGO4HJqYqAfX/zTbBh8hYObJ6xTcjsg/jXO+VLkEKU+APJp8b4BA1LxFNtmS5rXxPEan6YdbiljcoPCflG78fzIlXy9h+mRs3CtTOvG2PyiDFThr1xLbAj/PaFSCJWxyoN2CzRo0VwaePHYBJFnyzOoyzx8MTAvvrLOcjpi3uloMbmqqKu7thM0Lmjinr/XYOBXK1AI+Mpxv61toS5g/38HWC5nl2IiCFy3i02tg6VD4lNE6bPNjXGT0Vs7Gc5jqiq4kOtKJBGtC3sOnnqKwYbSHhW9RQW7XYglvq+tJc797qgpCHpbLLsNurICNCOuC2TzjuVbC99Z01wd4zda62X8s8aPkIq6Qg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.04.23 22:50, Vishal Moola (Oracle) wrote: > s390 uses page->index to keep track of page tables for the guest address > space. In an attempt to consolidate the usage of page fields in s390, > replace _pt_pad_2 with _pt_s390_gaddr to replace page->index in gmap. > > This will help with the splitting of struct ptdesc from struct page, as > well as allow s390 to use _pt_frag_refcount for fragmented page table > tracking. > > Since page->_pt_s390_gaddr aliases with mapping, ensure its set to NULL > before freeing the pages as well. > > Signed-off-by: Vishal Moola (Oracle) > --- [...] > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 3fc9e680f174..2616d64c0e8c 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -144,7 +144,7 @@ struct page { > struct { /* Page table pages */ > unsigned long _pt_pad_1; /* compound_head */ > pgtable_t pmd_huge_pte; /* protected by page->ptl */ > - unsigned long _pt_pad_2; /* mapping */ > + unsigned long _pt_s390_gaddr; /* mapping */ > union { > struct mm_struct *pt_mm; /* x86 pgds only */ > atomic_t pt_frag_refcount; /* powerpc */ The confusing part is, that these gmap page tables are not ordinary process page tables that we would ordinarily place into this section here. That's why they are also not allocated/freed using the typical page table constructor/destructor ... -- Thanks, David / dhildenb