From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECCDDC83F1B for ; Wed, 16 Jul 2025 15:24:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E43F8D0003; Wed, 16 Jul 2025 11:24:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 894098D0001; Wed, 16 Jul 2025 11:24:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75D788D0003; Wed, 16 Jul 2025 11:24:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 62F598D0001 for ; Wed, 16 Jul 2025 11:24:24 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 117861A03D5 for ; Wed, 16 Jul 2025 15:24:24 +0000 (UTC) X-FDA: 83670499248.02.CCC6508 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 77DF11C000E for ; Wed, 16 Jul 2025 15:24:21 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KGCpCRn8; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752679461; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SNFlWBNpt9SYbkpdkC3AxTClHyrZUSfwmCSW8R0rlhI=; b=xYMYdtzN99/tfmfE4EzK9L7BS1kf1EsgSDAxexnoQhoZxJ4O0uDHzvfoUSWjjgNbmU2VMl fDtTtupztvmlpbrl6aRR/ZMKTPP+hh72XoB6iBGsAJFlsXVvoX9ftjzPXsZB1eAhtCAMLM kBJvQEYb3a5g3dykf8Icsj6Y5c1yoFw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752679461; a=rsa-sha256; cv=none; b=61Uhulv59lzya1KvevgYmkrbQ6WbEtHgfriCU5oUIscdehh7ziYvYkWuKdhny9fzC69d3H cSC2ptlBZ6ntUMOWIbgQziCGmeVu9iLcslMfJBdbvHUvy41OGFMF7BVWLQ61IM5MKTckHa E41zfFtLvridZkTfty6LUbRG+8SZeLw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KGCpCRn8; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752679460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SNFlWBNpt9SYbkpdkC3AxTClHyrZUSfwmCSW8R0rlhI=; b=KGCpCRn8FvxFJdeHPeVcd992rliNvWCvZTYBrqSA0pILBva7I/MvC0RqOebRjspG6Tyn3D r8f/+n+m8EBOOsXhiBxgdLot6ZT4ab+o40Pe3pXdA50AudbX9UEB8iQTc/fYPVbApxRCxO 8HLQ7dXh8OJueGhRybMMQ9d5kseyaps= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-73-GBDblpLHPh2ggmdt9qGxcQ-1; Wed, 16 Jul 2025 11:24:19 -0400 X-MC-Unique: GBDblpLHPh2ggmdt9qGxcQ-1 X-Mimecast-MFC-AGG-ID: GBDblpLHPh2ggmdt9qGxcQ_1752679458 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-451d3f03b74so39629065e9.3 for ; Wed, 16 Jul 2025 08:24:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752679458; x=1753284258; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=SNFlWBNpt9SYbkpdkC3AxTClHyrZUSfwmCSW8R0rlhI=; b=fn04N4guaVE+jVSCHMfva2QZo+uVP4JEm8Yd3zmOTajCmbbpMYCVjDp3xm9Hjv0uDG 3soYF4M4TZae1YAmu+pRerOW05Fwxxl4Qf3fp+HI2gbrmWi41MYhE87omY5MiaaOlCkW 1kZj9LNrXVER9qBSha2TgPwWKIHr9GrIRSKAw9xbi3rjX5/BHwlIueW9lrT8PfFHs1B0 koD+n6oaxOz+kwJIYWf1R/ZfmpsRAKYQVyXjoXPH6agbgeWbF4qXl2Helu6UACXWeBxh Ca2zZyWrngjqw2kJWXZ1cUatA+x59rzswWak/HmdltZ1Q7qbH+Tj835rHCUDdrSq55Bo S2lA== X-Forwarded-Encrypted: i=1; AJvYcCUIazOG4EGD3qq4QrZmbqlrqNQq1RBHMKz12Xb73r36ZvB3LQaiIB/S19A1DF8qfo8+SHooAgNQkg==@kvack.org X-Gm-Message-State: AOJu0YxotSSJy1tXDN9m3lx6yVowt5Ywq2gDEvZ4oaOcUpU+k7URINv9 H4MWYQ9rO2TOcxX2LOIdE8xKHOG/cDtGJOUN4hq8WODqvU2mxJZmB6XGeEGbAMzY7luKzafPi5Q Qj2hQgVL1i0W4cPdVpxjqcA46tkF3Vvq2bDkAhjBWAj/oeT/AEetL X-Gm-Gg: ASbGncsrQYaHt31/uGo0HBRxOvHSqB0Ugfjr+7Wu19FiUfn4aCCIw3AKPb9BXuQqYiV dYzlRO/r7gq1MImKQb9kQIDw5Vacphx93jY3TMr3JmqT05s53gI2Teo3LaN8Xls/7Tg8XmWhx5Q kp9gjhx8oL8WNotPfjWgYQuUVU/GtLUZqxelzMzTcar5GTjcuK34toHaZE9NanxgBMTpGvYZZkB 57pjz0eHEKXFtTYhGYpexXObh7v6qbTMWtnkhO1YeIPFd36J2M5+XpvnAPkrfvr8MaQANKKjJyG F4lw3s/fVEJp3Frfbvoq23Zg+XxYSo5paOLQT4s7Ejsx2W1FjrS9utHWx+URUIlMepNxYm7atA3 uD0DsSjWoINcsqa0YdvYgiaT5G2SPFxEugKICnyASRJfP6+fLvC/YjUixatQZSkb70Jw= X-Received: by 2002:a05:600c:1987:b0:456:12ad:ec30 with SMTP id 5b1f17b1804b1-4562dfe73c0mr37112635e9.13.1752679458463; Wed, 16 Jul 2025 08:24:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFxuqbrkcZx4M5Xzniv4108zBNJL/oqX3SoCcALdEHsTatmbIhhC93lstqiOhvQonpy37IcTg== X-Received: by 2002:a05:600c:1987:b0:456:12ad:ec30 with SMTP id 5b1f17b1804b1-4562dfe73c0mr37112315e9.13.1752679458022; Wed, 16 Jul 2025 08:24:18 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:ed00:1769:dd7c:7208:eb33? (p200300d82f1ded001769dd7c7208eb33.dip0.t-ipconnect.de. [2003:d8:2f1d:ed00:1769:dd7c:7208:eb33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc22a8sm18558624f8f.34.2025.07.16.08.24.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 08:24:17 -0700 (PDT) Message-ID: Date: Wed, 16 Jul 2025 17:24:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] mm: move huge_zero_page declaration from huge_mm.h to mm.h To: "Pankaj Raghav (Samsung)" , Lorenzo Stoakes Cc: Suren Baghdasaryan , Ryan Roberts , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Vlastimil Babka , Zi Yan , Mike Rapoport , Dave Hansen , Michal Hocko , Andrew Morton , Thomas Gleixner , Nico Pache , Dev Jain , "Liam R . Howlett" , Jens Axboe , linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, x86@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , mcgrof@kernel.org, gost.dev@samsung.com, hch@lst.de, Pankaj Raghav References: <20250707142319.319642-1-kernel@pankajraghav.com> <20250707142319.319642-2-kernel@pankajraghav.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AM8uNWk6jq0mGf8il-A_fQL-f3CHiLN8hfCaECtn0Jw_1752679458 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: aa7gebpxqphf1pnbnjthgn198wjyujjm X-Rspamd-Queue-Id: 77DF11C000E X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752679461-725543 X-HE-Meta: U2FsdGVkX1/vJtWTFs6k0Yv4pGTsNmuLMT3PDv9B1Mn4ixFm+UvcvgHzOp8HxhxmEj7ThSk+kk2LFg9xUzNc1MhMXEaQ25sW7Gr5xaowlcfxrHpAf+EJgOATghgX5ic6bo7GzM6cMxxJOtOBxXdMk2eHX1gHVEo8PFQouuE2loZF2JaiJOsT2gcfj2f4W1uP9zKzWlFtBS02zMKLp1rL4bT0YDFGK4A7lLBimQFCzXXkhSokzqqrYmEC5MVvlvwWDgBl9mkVtYQzqBZ2eeWy1TICU0ldZlGOKtbVrmriB1GV1hZdojUZBiDZE/pUEeKw8V/f2gIkzbTdQvsBKwKk0XAXfobzBY8bxWi6E+uRSjIJSDWiiBsGArsirUPtsNRFwKHjAdVO8tqFJ7eupQ+JJEYWoZdzzga6o60BuzSvSAj/90LL6u6ZJNRrVkD/I5cK5F5zLRV7ESc+njEyhzyEEA+F9wWg6yJsk2cn66Sgo1kwH32TAQ3aVnaB73N/NGtPoQw+yX4vk0vEX6+jf9cfnOkJxDwGaXp502dGOcABXJrPylp+FNE13K6dMwFEnZJpfVuV8oSvnSkq9WxdQu87gxvrueyVMtGTByU51he3EUl4SB7qHBAD7WybW1VLmd9cEtegSVdWc0nUe9lcBUMG7WL8IrRchjL3z3u47y9TNIVG9iBhpJaMof/9b5U/3EZXF9wuUjrlk4lRa3WKi2IISWM/KTNQKK/BLzqDcQjaRIls/4QuVA741Na8ukWEXV31eGYBTbsNPPriqcWmm2n7SntiWP9Qvw9bw48MvA/dXm2FapxZGFElcZdLJ/plVgbfqODK3YSiG4Uj2A9qG/qvFxPNtOrjn9ZUm62XJu1nwF4W7Z8etScNslGhbespNDqkpOfnkWpsUeHOuyKIqkXTtCt+JEhZWspXt1cIl/ODMHNbnXJmn3LHt5CyQ5SK1VhCARsqC5rbzcGPgXgGYHN XFxjOwI1 eSPJePgNVDi9xhKMIZcgblz/TRiw0HUJmOplsMI6AvEf7thfOQTBuUCewsCQWeDRXvvyl9iFlrK1zWz5cdQehto1AH+c+FZMNWlvJdgvzyo8sjNlOGU4I4jSwXFztdbnzhGXzyHdWvrgzbsWEjP1SEDvUbYLwBkdgjN5Iw4q/nKPsaNRsYYNYs0CzGs7UlkjboY4bXfFmdMW2HevqCX7/RHNaX5DhmDkyZJHNcgQEReYkt28+hj3lDX+iz+hqrrGtscHlwTUrKMb+ixotinCbVm36nl7IpmQ2Y7sdp4AtR6F0rlmXoFVuVprzNzYiFW5YXhVenJ71c4XalQ4R8OGxqk7j890CC0T9lQG67YmSiw18O0hABjnORX9sK9SyElsV3GLYIuBIiygKzaL4xEmoFW2oiKgrtCN10r7wNbf36ASgNZolcoo/4A1Ff+i19iE1hAgqRZtnkvLSCSLNhsIc6VEfzbmp2DN5l+khW9rcp2Kp5bNvGoRAbLzuAdbLcDI6kdqMpoB5NGcKATjjaF/XX4lSsCnSj5oPkZ7T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.07.25 09:47, Pankaj Raghav (Samsung) wrote: > On Tue, Jul 15, 2025 at 03:08:40PM +0100, Lorenzo Stoakes wrote: >> On Mon, Jul 07, 2025 at 04:23:15PM +0200, Pankaj Raghav (Samsung) wrote: >>> From: Pankaj Raghav >>> >>> Move the declaration associated with huge_zero_page from huge_mm.h to >>> mm.h. This patch is in preparation for adding static PMD zero page as we >>> will be reusing some of the huge_zero_page infrastructure. >> >> Hmm this is really iffy. >> >> The whole purpose of huge_mm.h is to handle huge page stuff, and now you're >> moving it to a general header... not a fan of this - now we have _some_ >> huge stuff in mm.h and some stuff here. >> >> Yes this might be something we screwed up already, but that's not a recent >> to perpetuate mistakes. >> >> Surely you don't _need_ to do this and this is a question of fixing up >> header includes right? >> >> Or is them some horrible cyclical header issue here? >> >> Also your commit message doesn't give any reason as to why you _need_ to do >> this also. For something like this where you're doing something that at >> face value seems to contradict the purpose of these headers, you need to >> explain why. >> > > In one of the earlier versions, David asked me to experiment by moving some of these > declarations to mm.h and see how it looks. Mainly because, as you > guessed it later, we can use it without THP being enabled. I assume, in the future, most setups we care about (-> performance) will have THP compiled in. So likely we can defer moving it until it's really required. -- Cheers, David / dhildenb