From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64C07C2D0CD for ; Wed, 21 May 2025 16:21:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3ED36B0085; Wed, 21 May 2025 12:21:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF3066B0088; Wed, 21 May 2025 12:21:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADEED6B008A; Wed, 21 May 2025 12:21:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8DBD56B0085 for ; Wed, 21 May 2025 12:21:33 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3E598140B0F for ; Wed, 21 May 2025 16:21:33 +0000 (UTC) X-FDA: 83467430466.26.E4542C3 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf05.hostedemail.com (Postfix) with ESMTP id 42920100006 for ; Wed, 21 May 2025 16:21:31 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m1WyVfjl; spf=pass (imf05.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747844491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oL/6WGZ49yisoo8P60FKnpsWqxjc4g3Ax8sW2bJwTIo=; b=gfqEtDUVnx9HoAgqmrCLWsuWPI+kWHIg1Lk22GYaDAuG6b16lfQWqyeObwGrMggNfriFXg 2ZFV7HFJ4IcUN5m3l8U8wjfwy89NWOC9/Cy70iDR+TWQMC7suALmO8N08i3L7EE1Suek1o ByaYh9PcBHR2uzYKcraihTTJuLms5Zw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m1WyVfjl; spf=pass (imf05.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747844491; a=rsa-sha256; cv=none; b=FMrox3RZLcm4UlYJ/3nCbO8IWUG6QE4iyLAQPPJJGz73vL2IC9RSsqDKBdsvbUjeQeak5Q R+DR2h0CtI5A6ibdSCukHz4fQvGAVUd0UlPtIRPUOrp+UNnaDxsa1a0ECRUsVL1TO0/MXS vCi0uYBQ9OsRQ4wEWgD1+zCLQ3XQ9+w= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-ad51ba0af48so1111288166b.0 for ; Wed, 21 May 2025 09:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747844489; x=1748449289; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oL/6WGZ49yisoo8P60FKnpsWqxjc4g3Ax8sW2bJwTIo=; b=m1WyVfjl1WJO3K0N9dtnbQ0KexWQ4MPwgFtyVQaAxH0bp7Y0QqmBapIMZv1TossLBg zwRixdIYQ/qeXzR2v6FCOc5SbINcAkgZ9yW/M3LpEJcdfrtnQ72r62PCyxfZN6XCFXie RCacYLqLw8KsKGq1ywOehkAlvFyLgTLSMReZoN79pGi9hZTSA3OLl5eXZJte4DTFeQhC 9SupxJugbZcUpAflLmjdOgLs8nklawHZEjQKRHryyji/MsiChO5YLqZdTnahXR9Fa3QU 85lIOuf9f+CsGI6/F/5aG5UQO0ZDjvCtO+GyLVfonwgdmOtrLBLWBPncopL5/kluKERB XPrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747844489; x=1748449289; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oL/6WGZ49yisoo8P60FKnpsWqxjc4g3Ax8sW2bJwTIo=; b=WTEsWKdJFhYoT43Jfm8172p+o8KGEcykn6LQXU250cgXMMBSRU/eZJ+ukIqOJ6SCFc zo0K1uyxiNa2c4NNA/aW+EZuxyjIWXVkfnR9QgU3P5wFSal8N6D/K3zROwKDu+bel0Bs +nPgm1+kXUSSHUT6CXsTH9HFKNiYVj3h9TOLZXqL0R10ZRtzt2mHuemoGz7+isLEOzZo zLKIEMFmN317Am5tQqxifn1z5GZWQcz6MMrZhLCUMh7fbHp1Vrw1pD6UV4yTbw2zlfhf 3zC64xrQODxxykyapUdbwPXxeRUW8r4ZC2pdIVHgzEYAsQ7sK9gvpf1WN/w2O5nNRVA1 eY3g== X-Forwarded-Encrypted: i=1; AJvYcCUjI52SCiZdHRwgcOZY8wu7KaXmwfLoPG810UZqI8pusdTjy7dZkZrmIqcxvbjNWkUhuYMqzzOF0g==@kvack.org X-Gm-Message-State: AOJu0YyjVsHrJFsFAPKEmDn7cnr4IQ/PJKZTqVpZdQFvLvoMkzPg+Siw jFI5bQFveFDI236oVJtcIDYPbHxASc8uh0hLr9TRidNTpRgMsRJ1Rlao X-Gm-Gg: ASbGncvsps/t3kYH3gBS9O8DrgP4Qvg1F7JwkCutf0LJXpLJfEGcqCgdL4VRjSEfNmd n/cO+OgBI3AoGKKreXgEqIHIumTRhdQRCNebA7ZZn1LhCz4x6e0xcr4KtGtisgEUFNNQvGS59Od EuhpLlFcaCHWuQ7yKIIN9OdOhbTBTqQy2wAaUrQnaQ9PSKzQ6mPgxzpztBKA/HZn0I07n9IszCL 2i91BoO+kiF6Fu7FTiANNYI/RiaOtfxxahy/cRUX/KKF8+Rfz12yx0LtVL89bqM3yprLVIzGgma tATbGDkf6bxUs9m63ygA5Ztns4yrwe95/s9d2FKGKFRn1CXPSaAWLSEINmaC2oeA6XfDZ+WRUcz trGpZiAwD9lbAn+2/fbQSloPgAQw= X-Google-Smtp-Source: AGHT+IFgErTuQ6iVa4p/cBsI+I3rxvv7DCD4bCdYsQzl3HjHX9lB0i5S5P6ETzecZn2CKa7Fkc7jiw== X-Received: by 2002:a17:907:7ea5:b0:ad5:61d1:d8ac with SMTP id a640c23a62f3a-ad561d1db3amr1503300566b.6.1747844489208; Wed, 21 May 2025 09:21:29 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325:8d0:f08c:4e6a:b32f? ([2620:10d:c092:600::8a7e]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d48ff8bsm917492466b.124.2025.05.21.09.21.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 May 2025 09:21:28 -0700 (PDT) Message-ID: Date: Wed, 21 May 2025 17:21:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: slub: do not warn when allocating slab obj extensions fails To: Suren Baghdasaryan Cc: Andrew Morton , hannes@cmpxchg.org, shakeel.butt@linux.dev, vlad.wing@gmail.com, linux-mm@kvack.org, kent.overstreet@linux.dev, cl@gentwo.org, rientjes@google.com, vbabka@suse.cz, roman.gushchin@linux.dev, harry.yoo@oracle.com, linux-kernel@vger.kernel.org, kernel-team@meta.com References: <20250521142521.3033264-1-usamaarif642@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: oetartmihxm3m3r4f4fz333aanyrqs3u X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 42920100006 X-HE-Tag: 1747844491-634409 X-HE-Meta: U2FsdGVkX18vHbz5PZZfm/tfnLs+frKmUXnCO/p5Fgm4je6d+xupEq2B2gW2506+JicetJmwvfAx8QFTPLHPJQ+MEYDELR8ixHei/PAKC9L1Vp9nkRbG6aGN/bcRFR6qHp3p0Y7fW3EqpCmnBCgsugqvLq25OdUe3FGeF1EEwB8Bduu8GoeNgcv9goyGZWFvVfo3lPKCz+pI3KQA9KIAGzWiUTxcc5EYPXFb5kiQ1K52kat8A7+Aw77lckf4qF9QU0Kk20cZb0lqkwiUkgpfB+6PAjVXRx+3f1EXPjhAzSMhkRWMjXg/29RXmvaj8rxl8yyDwNzDvIZ8mW28bJv9jkixk1BRNy7kPCMeRycnYIvWLO4oPs9J4TEoRd+oPiwyweaqAGbOyNwH/0CdW0xqFl1Kv/I68AsQcfoXwFWKf+Q7/PrSgGlzgHiccvpTFIFUFNVOrbU4sb4UFZNYBEKdA6h6SKVzUJqznfsB75+hohVCva5cX8ugrCtRFmrnLBo0Xavr89cpTYZ4jfTEd1qG+w7Gwf8QsplFPseJOwT43S9UD84aB0ov1Ygm0H3k9rSaQDh4UB+2wTKVC3p/Q0JxkEXCYf1RtW3hMdEjc2ZNAfE3toS4aCwLa4MakLFJ6JhNXccW+J3NBVn9A/85sq/qGJ4T9emgxGdN7VrKyJIC8cAbngz3K+rXxQKUMxm8ocpEGl8HCPcopGYFpp6X6DiQ+PVDPuFSF+S6ZvFnVfy/NSKX0QJFPVJyCWT1J0TDM5Fh1irV/Nb0CTE5xodHLkvANPaYF2s0m43p0jfYy9iCLYiu9bhDjKw9fETsdSX4rmHzuBnCnQBZIDT3zp6HweDv5EHt/L1OSQXJezpJPu1hDjQfxwmBU5zJViEjKOfa9G0DCA4ZqMfy66xXA1YjzYfN9GUrLRkp3ZJG5G9Mgzs1MVyQlfqDIP7uhOuO/hNKxy01XoEMWVPTTuEEPObBplP NwMtCj5y chfLyaVMEA7tnxPdpCArTvPFtqLJcwpvU2al1FAt0lDya9Jn15EVQVjXFRi6p525JHMX+5ZHWnPzqO7KOnjimdPYQGsZ6ntHW8spyVohwU0KDS/QO3cn6U7x7VJq7dsxCpVaf9NO8JVreByy9REsk3S0kURdSqFvNirRmo02+wf9G7h6oPrlx0zgB2SByqo1mdtaCUrLxDs3TuBNl3HmbwL9UQJMoROnUptiufNT2HhOrjbr50d/aWsZV05lu5CSUFI/9FsMg8SzbiSltPGcoFOSB5NFAEjH2UtNtArvUtEMWlxhY/Lp0GT7PD9XLsgAvla/QAp6APsAzOcyO1QngJCxmvVRHVaPGerZQ4Z25GjTih4MV+NssC9LhBfl1mr9iWrE6WFZxy8IGMIm6VtqhAs1vHTmjOhjEaRwS43iOyLBEZTz3AFV1yNDK3G+Hjz7OIq3fbvXdEouWwck7j/JroIdXhDmMhX0nHpxgiQdsUNbZQv7m6GVUVIEmXx/O0IKwO5dVUwvM3euXkqqmC1L/LkRVpfUp9/hK5qlazF+cbfn6pGnumbk1YHCdJy1WtboRaa/wtKJxOE3zPKwJRN+imIdmrzWxUNEafKMF2vnpk+BwXSNEhP2Hn+bVrmSUS47Qo2wu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21/05/2025 17:02, Suren Baghdasaryan wrote: > On Wed, May 21, 2025 at 7:25 AM Usama Arif wrote: >> >> In memory bound systems, a large number of warnings for failing this >> allocation repeatedly may mask any real issues in the system >> during memory pressure being reported in dmesg. Failing this >> allocation is not indicative of a bug, so remove the warning. >> >> Signed-off-by: Usama Arif >> Reported-by: Vlad Poenaru >> Closes: https://lore.kernel.org/all/17fab2d6-5a74-4573-bcc3-b75951508f0a@gmail.com/ >> --- >> v1 -> v2: >> - remove the warning completely. We will have a way in the >> future to indicate that the mem alloc profile is inaccurate. >> --- >> mm/slub.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/mm/slub.c b/mm/slub.c >> index dc9e729e1d26..06ab9a558b73 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -2102,9 +2102,7 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) >> >> slab = virt_to_slab(p); >> if (!slab_obj_exts(slab) && >> - WARN(alloc_slab_obj_exts(slab, s, flags, false), >> - "%s, %s: Failed to create slab extension vector!\n", >> - __func__, s->name)) >> + alloc_slab_obj_exts(slab, s, flags, false)) > > I thought we agreed to having pr_warn_once() here. Did I miss something? > I had [1] yesterday but I saw Johannes's mail [2] in and Harry mentioned in [3] that failing to allocate the extension vector can happen during normal operations. So I thought maybe there are more votes for removing it. I am ok with either pr_warn_once or removing it completely. I guess the question is, is it considered OK to fail here? [1] https://lore.kernel.org/all/64b19c8f-e02e-490b-b987-9a996f36be21@gmail.com/ [2] https://lore.kernel.org/all/20250520171814.GC773385@cmpxchg.org/ [3] https://lore.kernel.org/all/20250520171814.GC773385@cmpxchg.org/