From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF710C001DB for ; Mon, 14 Aug 2023 08:13:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60C3E8E0002; Mon, 14 Aug 2023 04:13:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 594F98E0001; Mon, 14 Aug 2023 04:13:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 436718E0002; Mon, 14 Aug 2023 04:13:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 339758E0001 for ; Mon, 14 Aug 2023 04:13:13 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 01248140317 for ; Mon, 14 Aug 2023 08:13:12 +0000 (UTC) X-FDA: 81121995066.08.0D74F2B Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by imf08.hostedemail.com (Postfix) with ESMTP id 4201F16000B for ; Mon, 14 Aug 2023 08:13:09 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692000790; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6d2fio8+Mc36X6CW3/yWAc+fP5hCiMBhzd3xQJcidbI=; b=dg42p1HWhWgNPgeZjl3to2dhFNy8MzfSI1XbbqxBkhHRRjGJEAWBpeiW5vpBMZdtEA4RQQ GnVkH9riky39ksgbHPOkD+3za//XuQkLJpY7BT8/euY2Fi2uCrlwnC36eOz6sbHgr/7Gw9 mVKHUjSrXmmpvKqIYIzH3I8VkfC/3mI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692000790; a=rsa-sha256; cv=none; b=LyX24eKGDCFruAqwH4OAbMb85VQjxhGorGQxfMEDhds5qlD3xZyjoWjgMWtZdVM/BFjHtp dx7iVGGjqwmCNOKtjLc4iUp+DxAQamQC5RrwlyFvj/b2oq4Tf5nQb2cxiHacRTGCgoRcqR p8aafnfGnAFw9c8WOJ8FI2KYnmwHRVo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-72-b-sFahrIMv2qrldd8e66mA-1; Mon, 14 Aug 2023 09:13:06 +0100 X-MC-Unique: b-sFahrIMv2qrldd8e66mA-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Mon, 14 Aug 2023 09:12:55 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Mon, 14 Aug 2023 09:12:55 +0100 From: David Laight To: 'Andy Shevchenko' CC: 'Petr Mladek' , Marco Elver , "linux-kernel@vger.kernel.org" , "kasan-dev@googlegroups.com" , "linux-mm@kvack.org" , Steven Rostedt , Rasmus Villemoes , "Sergey Senozhatsky" , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: RE: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Thread-Topic: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Thread-Index: AQHZycNoqz0YrpkIvk2kVFpZOdRD+K/hpuuggAHNtgCABgRJkA== Date: Mon, 14 Aug 2023 08:12:55 +0000 Message-ID: References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-3-andriy.shevchenko@linux.intel.com> <900a99a7c90241698c8a2622ca20fa96@AcuMS.aculab.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: obt64fszg5j1bf4n6ayohb1bj36ueymf X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4201F16000B X-Rspam-User: X-HE-Tag: 1692000789-652869 X-HE-Meta: U2FsdGVkX1/cUQDcC36rWn3/KgveFUPrfmMIUvklLCHjvo6g1CeQE0013LRTLXNFcbsW7P9oCWIFBZaaX1MQKKqWf5n1PxheF96/V9Sj6Sp5HKZOxvyz5NVCuWM1qLmpM/qU34p1g/Z3nVMXldUv8ydEVc+zv048fyDqokYh1PdX2i2UCumH6hTob85eAo5u/EgTwK5YKoRGdyBN1isGRSDO97r5EOW12lPcMtzqIPxt8ItmZX9A0kdmDV7VpldYCwuhSQZSdX7FsHgeRLyM+loGcxefcH7Bh7E1IYMJlUSTpt2EzH2hRg42lpf0VxYRO6JyyqXIOc8FfIqbu2U9kLtUiiuhjT/V1JjAEEXTxG27yoCI3mP8BckmoxBXb+MsDgvAi2aYoa6/cy0sdWPsuswraLvRQ9xDjJ0wTlOGjfZFT6MDszgL3Fr3pppZ/T1uUdbTSVU1KYzCHk07LOlaF65myw1V+7S3uFL/DJwsDkz4NGLKbrV6Vfp0p6V+nrSE//VSDJGgpdLKycDSmRDwgEIMtD5MD9J2nFONa4KYH+PUR+o6JZlqBaw49LBxZkJ2yE1qdMvDYCo7eEN71+JkvsGVn7z+3crFMQJ0RJupXcRQoCF7ea6MesMz9lyxOftZIUmRW65P6NEyjGosYQ7OTXa3ZJHeJP+oFJCTkRe23IvxjKIIyufIS0MAy1q1a6SHsX5xNQ2cpe+jyOiWn06LDwjF7CNGC5AhK8KOE5TileWhMZpcI3k8SVJyPVnZPyLMfeFFr+IkAMDzmTesyhYkg5f3A0ZtvB/C0MlFjE+vG77OL+kRK75lCqbrvHSXiUedojXOVmHjMEVgIbz4rYnHZajhzU/AXgUNOzv/53FmW5NAAeVRm7DF+P0vvzlO6d6gxkVV8hunCz//XlZL3Dtm9kkrc/quHW3X2Q4ger1HnYZ8HLNr9OkhpKPah4pVNROby17joatN27ywJX+6Vt0 tQBg7Eq8 O3XjQFLOGX9EcfEpEYz8lyMNRVifbpsUOYEInje0yjiwF2Kka//KcccjJsbAYka2bGq7hZ+ED8S3GFVI2A1XH91i/lmHDm1GHE0dE//cbxD9uPmT8KIzm5riOIGdd2z4PlYwKzAoMdZtps51UpDQYXsCa1qnveSLHWVV11yAn502sn1a53/bKjZOAcUhfFh2pydZLgT96LEdqp0/a4KrtiS6+OUBYgWttSqdyiQ4XAqZEGqE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Andy Shevchenko > Sent: 10 August 2023 14:14 >=20 > On Wed, Aug 09, 2023 at 08:48:54AM +0000, David Laight wrote: > > ... > > > If you split headers into so many small pieces then all > > > source files will start with 3 screens of includes. I do not see > > > how this helps with maintainability. > > > > You also slow down compilations. >=20 > Ingo's patches showed the opposite. Do you have actual try and numbers? The compiler has to open the extra file on every compile. If you include it from lots of different places it has to open it for each one (to find the include guard). Any attempted compiler optimisations have the same much the same problem as #pragma once. With a long -I list even finding the file can take a while. Probably most obvious when using NFS mounted filesystems. Especially the 'traditional' NFS protocol that required a message 'round trip' for each element of the directory path. =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)