From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mm: leafops.h: correct kernel-doc function param. names
Date: Mon, 15 Dec 2025 05:57:41 +0000 [thread overview]
Message-ID: <da50f1b0-0466-4a59-b5ba-f75117de6ef2@lucifer.local> (raw)
In-Reply-To: <20251214201517.2187051-1-rdunlap@infradead.org>
On Sun, Dec 14, 2025 at 12:15:17PM -0800, Randy Dunlap wrote:
> Modify the kernel-doc function parameter names to prevent kernel-doc
> warnings:
>
> Warning: include/linux/leafops.h:135 function parameter 'entry' not
> described in 'leafent_type'
> Warning: include/linux/leafops.h:540 function parameter 'pte' not
> described in 'pte_is_uffd_marker'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Yikes my bad, thanks for fixing this! :)
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Hildenbrand <david@kernel.org>
> Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Cc: Liam R. Howlett <Liam.Howlett@oracle.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Mike Rapoport <rppt@kernel.org>
> Cc: Suren Baghdasaryan <surenb@google.com>
> Cc: Michal Hocko <mhocko@suse.com>
> ---
> include/linux/leafops.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20251201.orig/include/linux/leafops.h
> +++ linux-next-20251201/include/linux/leafops.h
> @@ -133,7 +133,7 @@ static inline bool softleaf_is_none(soft
>
> /**
> * softleaf_type() - Identify the type of leaf entry.
> - * @enntry: Leaf entry.
> + * @entry: Leaf entry.
> *
> * Returns: the leaf entry type associated with @entry.
> */
> @@ -534,7 +534,7 @@ static inline bool pte_is_uffd_wp_marker
> /**
> * pte_is_uffd_marker() - Does this PTE entry encode a userfault-specific marker
> * leaf entry?
> - * @entry: Leaf entry.
> + * @pte: PTE entry.
> *
> * It's useful to be able to determine which leaf entries encode UFFD-specific
> * markers so we can handle these correctly.
>
prev parent reply other threads:[~2025-12-15 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-14 20:15 Randy Dunlap
2025-12-15 5:57 ` Lorenzo Stoakes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da50f1b0-0466-4a59-b5ba-f75117de6ef2@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox