From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41856C3DA7A for ; Thu, 5 Jan 2023 08:45:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B80378E0003; Thu, 5 Jan 2023 03:45:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B30888E0001; Thu, 5 Jan 2023 03:45:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1F558E0003; Thu, 5 Jan 2023 03:45:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 913978E0001 for ; Thu, 5 Jan 2023 03:45:05 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5EFEA120243 for ; Thu, 5 Jan 2023 08:45:05 +0000 (UTC) X-FDA: 80320110570.11.D0402DE Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf29.hostedemail.com (Postfix) with ESMTP id 925FF120003 for ; Thu, 5 Jan 2023 08:45:03 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672908303; a=rsa-sha256; cv=none; b=WQ5+i9xbh3fw5rG5YFR8LlHSBNbeL8EPa42rMrcuTXhkVHCHZnJVv+HBmQ/6ylozP2K8JS aBBxWQI0GPvAeCDVNrEMGA+7Y4+Dhzx0DYRybyuq74SfUsZZp9J+cnizy+FJFVfdmMVHyy n9ng/xI4Xo8D2IfO+QrzfTIUbP3XvQo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672908303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wnHZaGZvrsqQkKhqGfXyDW5X5UD2yPjTX0jBqVTtQZM=; b=vBaSD9uEWH+LjP/0I4XcZhGGsMa2z1ZSOR5fVfVeSlXSzTkmbIo8HhIjR3aubbV4Z4p7oS SQEtQb5GZ58ior1DizSSQaiydD/X6JB3PoGYSl/8pLqtlVJwf63eUuf2qsVRjYPA3Sxw09 zfTz9RVTCd72Re/E5fL4QnAk1Yt8g4E= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 74DC91063; Thu, 5 Jan 2023 00:45:44 -0800 (PST) Received: from [10.162.43.6] (unknown [10.162.43.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1D55D3F71A; Thu, 5 Jan 2023 00:45:00 -0800 (PST) Message-ID: Date: Thu, 5 Jan 2023 14:14:58 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] mm/page_alloc: invert logic for early page initialisation checks Content-Language: en-US To: Mike Rapoport , Andrew Morton Cc: Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230104191805.2535864-1-rppt@kernel.org> From: Anshuman Khandual In-Reply-To: <20230104191805.2535864-1-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 925FF120003 X-Stat-Signature: yzzrzmgiyub1ophghzhznx7zdd65jjny X-HE-Tag: 1672908303-989398 X-HE-Meta: U2FsdGVkX1938DPDfW3ZHxJeGOIZGRlp+b3k2j6lMELinegOv0lRZkLJbAGL3S1GZH6GLNTYCLtaKIVoSmsUKFZPs3pzLhE+XnqZuSbgrVpu1y20wP9dW95WrhZihpQLSpDytIvIDIzgrukZS0HaDPOBaumYcz5uBZ7Ltcp+kOXQ7IH0OAq7Rf09rULTKtZqrUOFEaYx35RDRGRBxNlYlkPWn3793iD/ohTwnICcN33z1HiCXkwCA7it5pykVmQVfMf9+u7ikCezK4G1ERxV00G3RJxSbYliq4NIM+/jekOk/rIRsFpOVcubTsGt63bZzjje/Y/V2kuCruPZWfXKFhNd1zvH2sFnd3RyUmE8oP/Rm110FNaAHRgJIoVk1POQXGN+QqYA6ozpExBV38Y0TyVlPIFN4Igxcbm0Ro1JH0I4Ot7blgHC4lClHHE32NrGJr8qtJ9EiKuXGRR4aNL0sxnXS/4cXlZUbJxODNTvaDrQi6iquUmuAnBzS3qkND74Sti/972ozVwVAEA4kLnKAsUic23uakW7qfSBEuz+1BfktTVXjgHIvfmpRD+PNKqSLVARHsBxf4e9heySrlJkF3azW6UBZ8C7E1c1p0OJGBWWdpLcn8OKvZ62Lb/USYNKFBcyTQjU1HFr6Kxr80mRud81/Z0xtTerDSYJSOaQ4YAL91jZAHMuDf17Q8+1ZZvbqJ+6+wCB4DHUTQ6xQ/F5aVpP7gFM2Q1t10UFRhxGPHJfU0pCBZaRiR1yPgW/RCKRNK+Ht+bGZmRRj+gDzbF53wdzGc8CMNixIV7bAD65PlZMNAc+NlJqD4noBfmN54g1k84w2L53NERE4RbGVes1PFzJhkLCEoD1QEDp1URY4MZsUfqw4Q2JzA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/5/23 00:48, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Rename early_page_uninitialised() to early_page_initialised() and invert > its logic to make the code more readable. > > Signed-off-by: Mike Rapoport (IBM) > --- LGTM Reviewed-by: Anshuman Khandual > mm/page_alloc.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 0745aedebb37..a881f2d42b2c 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -443,15 +443,15 @@ static inline bool deferred_pages_enabled(void) > return static_branch_unlikely(&deferred_pages); > } > > -/* Returns true if the struct page for the pfn is uninitialised */ > -static inline bool __meminit early_page_uninitialised(unsigned long pfn) > +/* Returns true if the struct page for the pfn is initialised */ > +static inline bool __meminit early_page_initialised(unsigned long pfn) > { > int nid = early_pfn_to_nid(pfn); > > if (node_online(nid) && pfn >= NODE_DATA(nid)->first_deferred_pfn) > - return true; > + return false; > > - return false; > + return true; > } > > /* > @@ -498,9 +498,9 @@ static inline bool deferred_pages_enabled(void) > return false; > } > > -static inline bool early_page_uninitialised(unsigned long pfn) > +static inline bool early_page_initialised(unsigned long pfn) > { > - return false; > + return true; > } > > static inline bool defer_init(int nid, unsigned long pfn, unsigned long end_pfn) > @@ -1641,7 +1641,7 @@ static void __meminit init_reserved_page(unsigned long pfn) > pg_data_t *pgdat; > int nid, zid; > > - if (!early_page_uninitialised(pfn)) > + if (early_page_initialised(pfn)) > return; > > nid = early_pfn_to_nid(pfn); > @@ -1804,7 +1804,7 @@ int __meminit early_pfn_to_nid(unsigned long pfn) > void __init memblock_free_pages(struct page *page, unsigned long pfn, > unsigned int order) > { > - if (early_page_uninitialised(pfn)) > + if (!early_page_initialised(pfn)) > return; > if (!kmsan_memblock_free_pages(page, order)) { > /* KMSAN will take care of these pages. */