From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80677C25B78 for ; Wed, 29 May 2024 02:19:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD7F66B00CB; Tue, 28 May 2024 22:19:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D883F6B00CC; Tue, 28 May 2024 22:19:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C76726B00CD; Tue, 28 May 2024 22:19:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AE8476B00CB for ; Tue, 28 May 2024 22:19:31 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5291F804CB for ; Wed, 29 May 2024 02:19:31 +0000 (UTC) X-FDA: 82169826942.03.4E09C8F Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf11.hostedemail.com (Postfix) with ESMTP id 81D984000B; Wed, 29 May 2024 02:19:28 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716949169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QUytDNiNoQAXoBg2CsaY5un5cDLcLFIVPGcfhlFOlDE=; b=chGqLpkAsIBMd4BO1qZIHQiwhCQHjA84A6SFXEs5lC4u9oyTwGC5w9rfBDt9Tz2Aig9LM8 CNvzJVX7D201ROrVePT07Lk9kWzPYZf1qqKe1lfBqvRCVz0dTPu47/qhqnZSJaQwyDdtLX fBGoRD6ir3dlWQeSRAWF/3suu4RKoCA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716949169; a=rsa-sha256; cv=none; b=rPvQ7XrPglF8RMs8RWtK9PfNVX2rRgUiRDklYIOjYE4rXwRRB5xMP+VckRQ2omsSmS1i7z XeJZOK0jRANpwtE1PzAXcnPKB/QFmT+HcARBsGBKNhYdPAAseztAldEVjk+NRT9hWmqjN8 eP/lO1rWVX9PMVr7HPsYNkWi93xrQJ0= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4VptKW3JLcz1ysj4; Wed, 29 May 2024 10:16:15 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 628E11A016C; Wed, 29 May 2024 10:19:24 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 29 May 2024 10:19:23 +0800 Message-ID: Date: Wed, 29 May 2024 10:19:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/5] mm: migrate: support poisoned recover from migrate folio Content-Language: en-US To: Jane Chu , , CC: Tony Luck , Miaohe Lin , , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , , Zi Yan , Jiaqi Yan , Hugh Dickins , Vishal Moola , Alistair Popple , Oscar Salvador References: <20240528134513.2283548-1-wangkefeng.wang@huawei.com> <20240528134513.2283548-4-wangkefeng.wang@huawei.com> <9f0fbc29-b61a-40cb-94e1-eb40e6542e59@oracle.com> From: Kefeng Wang In-Reply-To: <9f0fbc29-b61a-40cb-94e1-eb40e6542e59@oracle.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: 81D984000B X-Stat-Signature: jfep6mkdo5hcdcqd7q5kgfqzxozue3ez X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1716949168-905364 X-HE-Meta: U2FsdGVkX187Ha9Gr/EWluR0urzr7J4Tnsk4mUzf7E8+xytFIahHEpLLjkfPmWJJsKGlOLyv1+dOXTdIDVX2+Q0uoYpRHFuR2Ck+4MMijqDqp1NYLWdY384ljqc3N+el9tEFiFRB1EWEBhLOm0pbfDkcrNAW8R+viF2GM5FDdYMAuSq40pK9AWuLnOcelYeIJSeTT8N3PTU60nwJ8WJqsY/YlTcXyl5anB2/5lL9PZqroBTiUem9cFplCuM9GWMhqUCluWadtY3kwdgX18RxZmvjemPrT9Dnw05gm4GK5vlfdkNgW1RHoJv4QLDYBb0LX2WwvYYGF4ymvxU9/aNj/64N2KrrEhHNmlXL2qRGnmt+AeDmJt2P0eOb1LN0hnyf53kIeiS9DDWzBrSKPYAonIlGTTaE7jyUZrolK9ukbnDmgMLQaUhOqZz4hIHNZ370035gfqwEVEoyp5/cAF5u3Bqh3a0boV/M8CcnN2vU3SE1dL+fMuL/zCpNiOWoddAcs2jeObsvAt1UYicDxyhIvy+t2Mr361l12YIWwEYvcVF+OAEqkr7osNI8E79Qa7M81sk/meXs0zE8vaVLlGzaZMGjuLJbwgKNwlKrsYIB8WUr9phzUnfN6IKCD+eq3MxahPSgXv2/3Ba1fMZOjCVlpjavYFxscxYkQBERKGGLYEi9XxumTFJ4O2dcbJMOu8zZHZXv9HUeamWXndUqFhz5ZQFDXJON+5ASzy8F0OP+8djzVQ3Lnpy/8VXLtF0zNWXQ85SS82oCJXjecH5Xs31917W8cFYe3uZQSiVJV7CAWtXfgJeA8foeFtnI2IRC1LZTCwkZo+5nH6IK8toePfmfh6K6yu09xDO/OQYH/RmoB28vh+fQCYWRkfoCX5wTpUWCCtwTT8d8WY0rWQfruQSHrqlt8mE8VfI1rufM1wfcorbwcloyzUOOsMvfH3qZAyghSQt1iYcedzNoTQmuKZE vorBn+r7 MzjQt/cTc7jUjk/+DatRMz+Ml4D3n8fWvDTOi8viyQm/h1ha9SKmuxqZBrDoIZnv5SZz6WHA732ocvsSuFIYZa1J0fSHbawQ5VhIh7LMEiId44cHlno/4IaRfQHhmCC5aZmAcf1jYdOASAvgrA5TNcPXNRggDgszBCNqHsdmRgXc2l8ugBnHalNiosyqznfULmEnRxg3FKMZD+IubHoyoat5arJZohltWt6622My4DmDg3ewz5IXnyhiWRTsPWV+nOWLsf4ZpY7J5aC0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/29 4:15, Jane Chu wrote: >> + >> +    if (unlikely(folio_mc_copy(dst, src))) { >> +        if (mapping) >> +            folio_ref_unfreeze(src, expected_cnt); >> +        return -EFAULT; >> +    } > > Why not return what folio_mc_copy() returns? The old version has ret of folio_mc_copy(), but omit it in this version, no strong option, I could add it back, thanks. > > Similar comment for patch 4/5 as well. > > -jane > >> + >> +    __folio_migrate_mapping(mapping, dst, src, expected_cnt); >>       if (src_private) >>           folio_attach_private(dst, folio_detach_private(src)); >> -    folio_migrate_copy(dst, src); >> +    folio_migrate_flags(dst, src); >>       return MIGRATEPAGE_SUCCESS; >>   }