From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28DCBC3DA42 for ; Wed, 17 Jul 2024 11:57:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2BAD6B0098; Wed, 17 Jul 2024 07:57:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DC4B6B0099; Wed, 17 Jul 2024 07:57:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F1A56B009A; Wed, 17 Jul 2024 07:57:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 727226B0098 for ; Wed, 17 Jul 2024 07:57:08 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 18AE41C1A1B for ; Wed, 17 Jul 2024 11:57:08 +0000 (UTC) X-FDA: 82349093736.20.3647BB0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 5F80520002 for ; Wed, 17 Jul 2024 11:57:05 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721217386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZG6USrE4lMlEdmbEidb6AN9HCgHHtoUJHWMVae6Yrzw=; b=UKhACjypYhdHZHajOiBxP6KWumiiUklnyyqwBmz2S19P5/5ZHl3H7NNjc8PufieMPCwxC9 D8C5PNv7jiihqX88pc75Yl6ZiZW+hOig+rNYaSdAxPQLvXgYmCXztflzTBIpHnjR+tyf73 pty/FbDNG3BOGQViBw2yLO8Zqr9533M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721217386; a=rsa-sha256; cv=none; b=g47zTwVd+hBBcW+P3PJQyySPpUvKgXNbQn758NMJ2yV+dSKdfzwgOxceV6W1ku2yASNtqq OwE1gvwZYiH4nG0H1huFaUaj2Jj1qhgkkFjHFTsbsd4eFVtkhhRxQUtH69+lpyiwpEGuw7 ouBKGtFnVhpBa12ucpODVJvcA5KnRvc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C41531063; Wed, 17 Jul 2024 04:57:29 -0700 (PDT) Received: from [10.57.77.222] (unknown [10.57.77.222]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D9FCB3F766; Wed, 17 Jul 2024 04:57:02 -0700 (PDT) Message-ID: Date: Wed, 17 Jul 2024 12:57:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Skip test for non-LPA2 and non-LVA systems Content-Language: en-GB To: Dev Jain , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Anshuman.Khandual@arm.com, broonie@kernel.org References: <20240717111011.316037-1-dev.jain@arm.com> From: Ryan Roberts In-Reply-To: <20240717111011.316037-1-dev.jain@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5F80520002 X-Stat-Signature: e9m8urmg8jbh48oubknm3o6dgijgt59h X-HE-Tag: 1721217425-841294 X-HE-Meta: U2FsdGVkX19ugkDHhHNJwnlhNiYhgTQgFiWBifV8lK3nTTSD0s2JQPvff5TEUoTB4KPEjn1ea/tuTq7Ao6T9vrt+62qr7dM8bJAFluF0cveJf8+SpYwCYYlJjOMqkJ/CTbG5UXI7+GEk989yPFouLkDyRk5Iqmc1Pt4N5RXGHW8Z3YK+YTiJml8GkMiCWkUG+DRgjbnl3ZhaXYNX8cDCkVkEAOgQLde3zn8kmUTULBN3tBdF+CutWkbduaQpUywopbTJ7s3M/TXMwRURnDpb3a8XYMr9riHR8Xxo6tlJ2A7hzT8C5d3YWxjPq/ZJjwhwpYZf1Y1+suE/aUIzPfABT4LlKPnkQ+ZzBvGuqvenZZTacDFpdUzCIOT3jAYpF+vtDIj0zzsb1TimuesCq7iyVk7adtf0YIW2FjWFuKRvpfkNID4665Vm9uqv5TN2uEcJ/Gmyfr1XYrYtx+IdXTgL32X4IE7vUzN4LUaRadk3f2usl4iYFqQyMCUm2cq0vhF226B3M2xIZG7B9uruSrBe+QJA5QW8DoFg2nYerQ48iL+GXGopCBGq1TrAZRbg00gKxzf4dfZTpTdX2VHVuD1tP9qexNf7d2effc6qgNGecAo2TWArz2jHp28OJhZAf0ZffPDQCfIVRGOUzxMz48yWY2NmpSJsj5ezDAlteEk7wLswHn0VmrSnGfnE2Al+zNjv/cIUSXRPQYNRP8CUnjndpU8b9obksEwRbd0PYzdjHVdjPGFp315/Kxfky9j5WTqcUbaNsUnY3usk/88Z5yHENraHKXZv7phHqf+RmzrfD83enPAdzSVbwSOPj7rDt3/PU9U87/eeOkJANkQuI1AJYnKFfw5vmSc0rTTxA8Tv8Pz8Z4irY90hHyTBfVIU8rIxog1b1LdBeFFQ0oONXqX4lB3oKMj1KIhRFBkxEluDabFgylChe3ZN+q9iAuUJJ5rw8oFPAiySxxQeCPTiWM8 /JSh1EbE BOpBoWgzJEBycG/IwLqXTtz4dSSkh/7XgzJNF9SmyLGbX0wlqKZ4QVwK/7hJLPNTlPaA+l5Ef/VqNK5aURtXVAnoMlaOH/jxEbKTX3HLuwx0bQxo0UBWm1QGCbpPaa9gVZuKyqA30oKkziI0Rb47CGPGdqnJsZZFG+Bu2e9v9atxsrmq+jd5Btd5xdlzhsVA/jl8jqTnhjB/KEJHswUUlPbIFAqODDMAwMYzSYqN7BvAbOCB2w8LZm0312BCXVq6qgBXBPj6ramJscSE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17/07/2024 12:10, Dev Jain wrote: > Post my improvement of the test: > https://lore.kernel.org/all/20240522070435.773918-3-dev.jain@arm.com/ > The test begins to fail on 4k and 16k pages, on non-LPA2 systems. To > reduce noise in the CI systems, let us skip the test when higher address > space is not implemented. > > Signed-off-by: Dev Jain > --- > The patch applies on linux-next. > > tools/testing/selftests/mm/va_high_addr_switch.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/va_high_addr_switch.c b/tools/testing/selftests/mm/va_high_addr_switch.c > index fa7eabfaf841..c6040e1d6e53 100644 > --- a/tools/testing/selftests/mm/va_high_addr_switch.c > +++ b/tools/testing/selftests/mm/va_high_addr_switch.c > @@ -293,6 +293,18 @@ static int run_test(struct testcase *test, int count) > return ret; > } > > +/* Check if userspace VA > 48 bits */ > +static int high_address_present(void) > +{ > + void *ptr = mmap((void *)(1UL << 50), 1, PROT_READ | PROT_WRITE, > + MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0); I think there is (very unlikely) possibility that something is already mapped at this address so it will be replaced due to MAP_FIXED. That could break the test. But the only way something could be already mapped is if ARM64_FORCE_52BIT is set and in that case, the test will fail anyway, right? So I think this is fine. > + if (ptr == MAP_FAILED) > + return 0; > + > + munmap(ptr, 1); > + return 1; > +} I'm guessing this will cause a function-not-used warning on arches other than arm64? Perhaps wrap it in `#ifdef __aarch64__`? Thanks, Ryan > + > static int supported_arch(void) > { > #if defined(__powerpc64__) > @@ -300,7 +312,7 @@ static int supported_arch(void) > #elif defined(__x86_64__) > return 1; > #elif defined(__aarch64__) > - return 1; > + return high_address_present(); > #else > return 0; > #endif