From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D520AC001DF for ; Fri, 14 Jul 2023 01:36:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA4D48E000A; Thu, 13 Jul 2023 21:36:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A54F68E0001; Thu, 13 Jul 2023 21:36:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 943AA8E000A; Thu, 13 Jul 2023 21:36:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 88AF18E0001 for ; Thu, 13 Jul 2023 21:36:23 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 43C35160409 for ; Fri, 14 Jul 2023 01:36:23 +0000 (UTC) X-FDA: 81008502246.23.A6E650A Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf11.hostedemail.com (Postfix) with ESMTP id 0D81D4001B for ; Fri, 14 Jul 2023 01:36:19 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689298581; a=rsa-sha256; cv=none; b=kIHci9zVD9utCIdDqlcu9DsiDTmnW6UhLhrjhjLvWeDnyT6rxGBxBCZO/N07WbvjoFck/n YTQy+yyVOS7SFcG1Mw3UX8xizyG5WTsLyTXi0oh+J5rxwlBi9EFVwpaW4zzw3R4kVF2Za+ 7z0Wxa64G8Dpi5wIO4iGApVOjRuvi10= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689298581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CVCeFUJc3BBwmWUPrgOHr+MVMMuOHf8rcsqau7Z+Rfo=; b=kQLAAzo3S55yECLiBmP8sELRT+1nQVtEFrHzx6n5XxB9KCecLELQVp0diaGHrFkRcO1+0Z +BSlbKbn4ADF1nkUAGV+ix1nFKVFRgmqwsIB+wBp/sug71U5R/mATgLiP2vn2jfcln72jQ 2zBi/YspwIdXVqaiIyvUJ5C4OqEKuEw= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4R2DYc4m6NzVjHn; Fri, 14 Jul 2023 09:35:00 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 14 Jul 2023 09:36:15 +0800 Subject: Re: [PATCH] mm: remove some useless comments of node_stat_item To: Matthew Wilcox CC: , , References: <20230713114915.74671-1-linmiaohe@huawei.com> <55c255df-9c7c-744f-e1a1-27602fcb5509@huawei.com> From: Miaohe Lin Message-ID: Date: Fri, 14 Jul 2023 09:36:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0D81D4001B X-Stat-Signature: n37cdxi5pt8pf4z3cwkbgucqmjcn4ccy X-HE-Tag: 1689298579-556869 X-HE-Meta: U2FsdGVkX19tRruQcw7RjnNqhs+gdqA3ZSSSHIIDLQDSGl32k3H1yXfNGUTtLCzFv5N3I6WcWAOTcNWK9kxEzEV/huGYg8HyXm7MM2Y9Pqz4YVeUa1hfZY0grFSpl/R0f0Ki25DgCxtNmwp/i5qQTUBFr92Gh9cr/kSnDH7tdEIaJBi+QIFHtZhMdSqOLiwcpRC67LFXHuaa5DMR/JtIkGi0BWlXxygUx3YRzeEiJtJ7v1ihFZDpBNPC8Yks6qntVShNnUthB1lyLL/+TVufg1t6OzFf/lHaZASOqj25bCB5rjgfn6h+DDH7PxPFi9Le7xq4MDGXusNC88vlbaZVtPgDE2yFtY0J+tMfJLPosqJnvAtSp9GmmCmArpS/CIXCzwrbzX22Lij+W9sZGZSwL3vpNX0nU6RQGialmAkNY40Pky4NGOCEnfy6WtcFqej7zN5/Fn7BCsMVuOfo0CbsBqPjVDTpw2rSMRKwCIvNvfh5UBuvm4B+KkRVipRO3fbX+fRr15bRkr8dh8ctlDyuSUOwwqRZToxxjnsr6uj+vr2ONVQc7yrxeqQzHx0xxFhbNSz5hvtpt43WDPF/dwUlktw1elRyJSO0Gq+1cpU9XSWkZoJ7xX09yezXgkLCDBJmli6bZa1SJXTx+Ss1D0vAH63mKyfFutkpDkNeuaEIKRnePyBpAGYee0LUE8/q7VkfyearQflx/WOPPuNgNTGNo3igxjaNm9NUSPNQc+lKU81EXZjDxPLRcrGLqkUWeffIdAFhWtnn11UDl2jLYraSNb6CX8r0V8Md5B0Uqcz6oC+HlKLwvHDaYwf8PfkYPtjU50RC4QjmoAhzsqZ8sGHmU73uQuPlSpQJLnQmUs0B/K/wEH2HaHND8C/0hz0UHiJkQb8ie3KjXOl3AMJZjSJMANynIEWEetEsTLvYuWWhMAts8bSIl2VdsE8p3ArQCtRb1mnztbjQTUnmoBzmA0a xHy/FWWt ZLzW4uGV9Ri2OsO7xqCmzXcQU5tOygtF0ikut9CksFnOVO6ncP2aFhagzL5ZGsYrQqbEug4KQ+x+IGNKEyqYzq60EWdX4WkPcW4jxC0kba/3MLKggY6+tXm7Qto0nQ3Eu0HdenO3oUHXdclDXHC1MfYVWOb9uWN2mxgWIbhiVmPvswO5MwNNUeZwjkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/13 20:31, Matthew Wilcox wrote: > On Thu, Jul 13, 2023 at 08:18:29PM +0800, Miaohe Lin wrote: >> On 2023/7/13 20:10, Matthew Wilcox wrote: >>> On Thu, Jul 13, 2023 at 07:49:15PM +0800, Miaohe Lin wrote: >>>> Some comments of node_stat_item are not that helpful and even confusing, >>>> so remove them. No functional change intended. >>> >>> No, that's very useful and important. Why does it confuse you? >> >> Thanks for your quick respond. >> >> I just can't figure out what these comments want to tell. Could you help explain these? > > Don't snip the thing you want explained to you! > > NR_INACTIVE_ANON = NR_LRU_BASE, /* must match order of LRU_[IN]ACTIVE */ > - NR_ACTIVE_ANON, /* " " " " " */ > - NR_INACTIVE_FILE, /* " " " " " */ > - NR_ACTIVE_FILE, /* " " " " " */ > - NR_UNEVICTABLE, /* " " " " " */ > + NR_ACTIVE_ANON, > + NR_INACTIVE_FILE, > + NR_ACTIVE_FILE, > + NR_UNEVICTABLE, > > What this is communicating to me is that these five items > (NR_INACTIVE_ANON to NR_UNEVICTABLE) must stay in the same order with > LRU_INACTIVE and LRU_ACTIVE. By removing the ditto-marks from the > subsequent four lines, you've made the comment say that this one line > must stay in the same order as LRU_INACTIVE and LRU_ACTIVE ... which > makes no sense at all. I see. Many thanks for your kind explanation. :)