From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC7E4C25B74 for ; Fri, 24 May 2024 07:04:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F2B66B0093; Fri, 24 May 2024 03:04:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 379FF6B0095; Fri, 24 May 2024 03:04:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CE7E6B0096; Fri, 24 May 2024 03:04:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F07E86B0093 for ; Fri, 24 May 2024 03:04:57 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A3216160935 for ; Fri, 24 May 2024 07:04:57 +0000 (UTC) X-FDA: 82152402234.08.A011641 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 69F7718001D for ; Fri, 24 May 2024 07:04:55 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mi2UNKKC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716534295; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NkZj75EFLaQBFYfelEFxSPNdCTwZcFmz5ibsjes1oxM=; b=1Oay/2chdLBhXqhgwMiD5etjIh/QQLlYS0jDtcl+wk1BoN83G0g9PxYTL2ysynpPg/+A+S 2Y0YHUNJ41P+jaFS//mc7JnNVrjJ7xSPamNOD9ZGxC126ysEEe87W0hM65IqSbSSpk2vwL 3EESYyHOhXk8ohfhwto8PL9p9VyQ3u8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716534295; a=rsa-sha256; cv=none; b=kop0r65Xe49UUr1/ZwpnSNIkrVoZbSgNFo3vgdesacOYr7RIQ20Yab62e/YDqroPpIYlLT tg/aLTLoZ0CdEHt6IvZfFlCJeWz5eQjPvKzJR+mTbzKm6cmljxh0R51QM+higXgcCNPn5y Z1f3pryN4V6qRrOuyWB6tT22hiDcDWA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mi2UNKKC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716534294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NkZj75EFLaQBFYfelEFxSPNdCTwZcFmz5ibsjes1oxM=; b=Mi2UNKKCzLBiEu33tnSifLjBl7XDyBP29Pg9lzdhQhHCbpRRWSTZLkTLG/Lh6CtHYUxWxj xWLguxnxefo2ulNOHSmLK0rpdogaAzUK6lFY7X9f9g7d1gp5XuOuRCK/U/XeMUAAu0+s2S dtAVO1c1ATJXmqTKLAKZW6GtGjiLi4U= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-547-FtdayP6wMpKIuKf_8k1b4A-1; Fri, 24 May 2024 03:04:50 -0400 X-MC-Unique: FtdayP6wMpKIuKf_8k1b4A-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-41ff6049fdbso81023885e9.0 for ; Fri, 24 May 2024 00:04:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716534289; x=1717139089; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=NkZj75EFLaQBFYfelEFxSPNdCTwZcFmz5ibsjes1oxM=; b=pnQcZDhTkx1CkcqZsi7k87Ye0y7EPdC2GRYj/oSKSYxCsIP+pKBH5g9RkGBA2l43Bz kvWled+BuDqARW5xOG/FzX41/vQse5k29zkABovABgUZqOF7663LBKRBZysVrg9mSIOr Ae2Xug7uHAat4AdKmSgXDnnA7zUgHg5sZxvYOp8mXUEEq3hyXlx12LDJWaaIKo8ooEki slKuW8J3d8rPwgbnk867OlWObyMoflcsGCp9dzD1QSKxsz419eIni+j1c24DpIy+8CgU 7bR0S/nIkl9pqEM/FaqhkdTMG0k3MY3359FiXakKz+w76Vl7/GEaHExQrj4YC2/ewQAK wCaA== X-Forwarded-Encrypted: i=1; AJvYcCX55hWp4eX5JnUlRVXj4oJl9J3vtTJ1c6bomU5Lz79WrCj8G3kSIO/p+r/39fdb23lcduJtnGslB/HrL7jLDGnjQHI= X-Gm-Message-State: AOJu0YykCpXjWLQsAkO2N4144lAxfS8qBupCWHwPbvDouWaGvgWhpl9X yvtBv4R2e/fXLdENJmEMKj4Tjk9mAc6hxxwiUv+dXZh20Sul/TGdPJwwJnu0cY+p1BuB8sIWw5F opo9pu6vkejVY9Txd7d2ZCPFUlcCH9PJJpyDEQ6xpYT5IoDay X-Received: by 2002:a05:600c:2187:b0:41a:9fc2:a6b1 with SMTP id 5b1f17b1804b1-421089d4473mr11403965e9.22.1716534289501; Fri, 24 May 2024 00:04:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbANVVttmPhRy5gHlbyox8+DZJn76ujulbq5P67qrxVc/eZb82/ecPtVBcBLTUTWyIKsHvgg== X-Received: by 2002:a05:600c:2187:b0:41a:9fc2:a6b1 with SMTP id 5b1f17b1804b1-421089d4473mr11403675e9.22.1716534289058; Fri, 24 May 2024 00:04:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c724:bc00:e919:27a8:d431:782a? (p200300cbc724bc00e91927a8d431782a.dip0.t-ipconnect.de. [2003:cb:c724:bc00:e919:27a8:d431:782a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-421089ccb10sm12101655e9.44.2024.05.24.00.04.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 May 2024 00:04:48 -0700 (PDT) Message-ID: Date: Fri, 24 May 2024 09:04:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: arm64: Fix the out-of-bounds issue in contpte_clear_young_dirty_ptes To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Barry Song , Lance Yang , Ryan Roberts , Jeff Xie , Kefeng Wang , Michal Hocko , Minchan Kim , Muchun Song , Peter Xu , Yang Shi , Yin Fengwei , Zach O'Keefe , Catalin Marinas , Will Deacon References: <20240524005444.135417-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240524005444.135417-1-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: cpa1uqois191q6p49yc5ajwpf83gwxbp X-Rspamd-Queue-Id: 69F7718001D X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1716534295-569792 X-HE-Meta: U2FsdGVkX18FXPOjzpAhdIMod5qWumVEcl7L6jY7Cvz6Q+7KWtgS69WPUWwpEZGV0GYuKvkvVA6Xv4Q1evZi5voy5vwl+Avi2mK66+Llau0BDxPc/YAVBA680RI9fVCIIVeqqkRUvbRlwlWqfyQXyMRRoLKusszrOy2bOnDYqHEoBawOB02wZllAy0Q4NxhgSGAvsyJFKgVkKn8RA47A89cnVYboQ+R7y2QYCOKRyh+Idxf9RjN7h5XkJDDe3Hos+R/O0MDFR9xxxhD6iRqRywRwFOTXzcmPnYCj6Uagor0Q3UOjeIQan7gp0RAPgMRiffGufAdGIKj6MrcO+oHTTnVCUTWlMkqIrM2V2deRFO/7IOhcJZYpplHxlx2FmjDrkzMZNbjcRF75R4NqJdTd/Dz4ECo/JvPeVzw/AuhdADQCyPMktsQNBhIUi/p1HSEN03aJwiq2zBg1cwHj00w93vVNoVt7TtKujj3f2IZRVZNt8KjcYO6Fs1DO4CgTJ22b+p+J9Ce1x4Uz4n6O1OwwsTWFVIRy5qNZShV7lg8V5FV0cdSjnpwWuM0t4mPprobFyFwu3Hu8RcG2xeQO70cT0mTEjs7TsHKujNgqU5bVyV0fYarkj3baxZ2Cen4WILzUYomHtm/94hv/ZfLYOWr65/xGYgtPxARosOUUfKq2RlD9ZqbzSjV83rG/MYP97W2TOlCw/3vatKgM9ea83wzxRq/Yzxti5jNVdYIB1YnlhG+iobkaJyMohdL9kscCScdhYLMneOQAddpVgSdVm12Rmf3SVEllqSCrfY+W83dZxSu1AlTQarwD7dp3AEzjKb8kTowT3Kw5xKptT6qNGCRb7OEeOaFyrRnof8ffQ+vBCpUG2tATxRHP8o6qagkQG7RJdfQLTghKAk3oAvf8K+9KnSmMOdLIUWQNOqlRPAi6DhD0JLopwqZ+EDJ0yh8n6A9Q2ureWf1ozhlUIY7yzSD jDBrlOJR 6pG0cwAZH/+rWlDQef1Mqqn1Wtc2R1t6r2ta1/OjmQqJuYD6YspJBS3o4UHWrssIbkZuexPlgoKvBbE5pmSec9jEo72UjXO2/g0Qf3qPdd7nUyOPZ32/kcUR6buvDujbtFhjVDee3twKrpHveLcQGStIwPWyCO/uKLvsQZefBnRLZD4umoIq5y4sJT/giHUHm49HhpSWnyQcdiCWfrdXqqkY4ZxV3FgoZYOvH85JNGVA5EYJUFlpB9E4lOskxDwMoKiYHf8seMcrDlN8A1lkKgvD55/lhVYcf/paYBC6IMJrWmQMtFp3PXwYY3UazmlTvoPNjBnJymVFZTnmgoyl3i/0ABa4FumynAjh1pBAuJhYNrXN0KkSwUiGGu681kgdpKX3b2S+EJBMcmnRnxswy+66fFi6GEnZc/3T272MyBP9j+1m/hNAZcL284Ji+2LzNCY1ZDD1cGU4UeRuJQkibcGZIx0zHfxHhaoN66gn0ZsgPykr462ca2PAwU0JWI9yO0SE6iagar59VJuKfov8nAUwmoj1WskkkjNbC0tS2lVlLUH9bJFMAy5D1+el9C0oDvU2gmKjIU4PuNLQK7tw2Gk318dwIYlslXit/UGEa6sSkbdGMiR3OS1gDWrvGWxD8wWg+3VKXQTiH3IfSSRWU2xo6C8TeUCYiN2o+kfsGbiHF23zEInmQ75Qqu2/Nv0XbKEpUI+MdT6owBgPWBk2/zLkecAvNficiERO4HQpxMjhidzkTmQnIMGHhNPBQ8nTdOqPpHSUng4f7ONIDDAtwUMP3tbdwIaieWh1vZZ2hAFTrJ0aK5Cwjh9DUFIy+kcM5QnrEMt/InKT92tY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.05.24 02:54, Barry Song wrote: > From: Barry Song > > We are passing a huge nr to __clear_young_dirty_ptes() right > now. While we should pass the number of pages, we are actually > passing CONT_PTE_SIZE. This is causing lots of crashes of > MADV_FREE, panic oops could vary everytime. > > Fixes: 89e86854fb0a ("mm/arm64: override clear_young_dirty_ptes() batch helper") > Cc: Lance Yang > Cc: Barry Song <21cnbao@gmail.com> > Cc: Ryan Roberts > Cc: David Hildenbrand > Cc: Jeff Xie > Cc: Kefeng Wang > Cc: Michal Hocko > Cc: Minchan Kim > Cc: Muchun Song > Cc: Peter Xu > Cc: Yang Shi > Cc: Yin Fengwei > Cc: Zach O'Keefe > Cc: Catalin Marinas > Cc: Will Deacon > Signed-off-by: Barry Song > --- LGTM Acked-by: David Hildenbrand -- Cheers, David / dhildenb