From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A71D7C54798 for ; Fri, 23 Feb 2024 11:02:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12BAC6B0072; Fri, 23 Feb 2024 06:02:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B40D6B0074; Fri, 23 Feb 2024 06:02:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E97BA6B0075; Fri, 23 Feb 2024 06:02:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D37386B0072 for ; Fri, 23 Feb 2024 06:02:08 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 569E640D2C for ; Fri, 23 Feb 2024 11:02:08 +0000 (UTC) X-FDA: 81822779136.18.494652D Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf26.hostedemail.com (Postfix) with ESMTP id AA50C14001D for ; Fri, 23 Feb 2024 11:02:04 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=NhqUlZIm; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf26.hostedemail.com: domain of liusong@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=liusong@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708686126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gl112MpuWzCihqKFsR6Lqg9e1BT7tdysa1K7nxLWwoU=; b=atkxlhPTtEsG6r5+fw5KAeZVcin2tf6lMkmZvOexpBLoEc8E4dBAini1zjQNtmN5UnJcxY lMAjHKTflTi5749gy2hDVE+hvxQuIILRZ9P23EkSA7LkqouPwRfy7ClxxTxyi3C04IFl5v 0/orwC4j5DoT8co24pi9MmGxqx6wlHk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=NhqUlZIm; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf26.hostedemail.com: domain of liusong@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=liusong@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708686126; a=rsa-sha256; cv=none; b=elpZ9e6YWGtmLstgcfFfVU1XXq/AQ36uqhkRwNnPwWqoNfiaLEjVjEFZdAmhJC1rQz1btK TmEf6Ux7Z1JxzHhQk/sHq8iM+PfyLKqv1vY9Nh+gFeXry6IVyDOuC2un5WXZuoZeaVORlO vKDDh/opMVgQ1qor29JXGseaxJ2HWPA= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1708686121; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=Gl112MpuWzCihqKFsR6Lqg9e1BT7tdysa1K7nxLWwoU=; b=NhqUlZIm1sGhIrkASSu8s+1/olPqSEyjIGKdLTnmsL9IEFEB3zNW6s0BoeRdY2wWMv7SN+6uIbppc0/e7L5vK60Vs4L9WH6OjIjlYgrEWLgnXc+6f8G0KkLF0xNryKrDf8DO1oXA09Ozw2GYOBUsx/EA07fkgAse8owYrNLt7Es= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=liusong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0W148c6n_1708686118; Received: from 30.178.80.102(mailfrom:liusong@linux.alibaba.com fp:SMTPD_---0W148c6n_1708686118) by smtp.aliyun-inc.com; Fri, 23 Feb 2024 19:02:00 +0800 Message-ID: Date: Fri, 23 Feb 2024 19:01:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm, thp: display [never] for defrag when THP is set to never To: David Hildenbrand , Yuanhe Shu , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240222115323.4925-1-xiangzao@linux.alibaba.com> From: Liu Song In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: AA50C14001D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 1r467oph1qywk38ooueuri8tdgi7c8cf X-HE-Tag: 1708686124-735558 X-HE-Meta: U2FsdGVkX1+aSIpnjYXizXBzkM0p2rGxpIOBZkF8Nih85mJSHNZErRsoxI0cKd4kDN9foTfKfAJj2Nj5zgwCz68H6uN4OZeaTUYUjQY2bnujyD06P5fYTpeOFRz7ImXXUJ+weJhmet4MjaXPkTMCtWthN3mhdpK1FSNCuv6LOIE8WW2KP7YUcVvUaizrTYNqMfrmNMEOmN6/7+MhFdm+At5qwTqKQCF1f2Ogs34gHS/7ePssFP/AJ5Zpp+mVQ4AELyN7ffkrbLYpQjJ+PC1svNhF+/hTgnu1yTwVfDSP/orC7GMKjCRxkYOW7d8bbSYbw72Qm3JqxySGkaOyxIJAQ3EBI9S+gRi5zHinn0b6uDmiO/KQwK+gtu23W1Jbr2ERLHoAQAWZNbo52x+83/ltnwA9FU9BVOJWcFLkh4/jUU+US86iXIQxGxkvspQq6M/JpszKCym6JonbF0CqQ1y7VVc31lbL/m9tBIgqPRPiNrg2XHDrFxu4elRzghKtikfEy7F7cE06PDEEHf1HspQQR3mc5mbfUTaeuIrY53Em1RXrKPQmf3gVt5eWOYTEM9DVlQr8w2NF2Rik+ZQhhXJ3pYd0IgbbEXY+xDA8ofRQ1qYFpOKlW/Dm5Sr4TxmACocBl4upGw8FcyTfZvgpZyf6lw1ifpUatj/CyYPVkn8AEev1qwmWXcNOqJAOEsRXhw0GYwoc59byaVjBndCo9HyfoThN/HfI2u8gc6Xesq91+9YA7RnYv7dmJiXT9VVhmhJJWaazevMnRvswaWDP4JeH7DeFp9zFORqsBsyOnmfGQvOirfP/dmYG8LyG/ViY/I3AjYHXwFGbmDJPu3IORYBKwqlueVRW4AMw/t/UrVnaRLJje+1e1p0pwPKfwRpWSOJwEo9XIjlARfX7Mnmj3jFUGu+rVuv4jvb+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/2/22 20:14, David Hildenbrand 写道: > On 22.02.24 12:53, Yuanhe Shu wrote: >> When transparent_hugepage is set to never by cmdline or echo, defrag >> still show what it used to be and can be modified which makes user >> confusing whether defrag would take effect. >> >> Actually if transparent_hugepage is set to never, defrag will not take >> effect. Just Display never and remain unchangeable to for defrag when >> transparent_hugepage is set to never. >> >> Suggested-by: Liu Song >> Signed-off-by: Yuanhe Shu >> --- > > No, I don't think we want such a dependency between both options. > > You might just end up breaking existing scripts (enable defrag before > enabling THP) for no good reason. > In certain situations where khugepaged_thread is NULL, it would be more reasonable for the value of /sys/kernel/mm/transparent_hugepage/khugepaged/defrag to be 0. The patch should include a fix for this case. Thanks