Re: [PATCH 0/3] mm/rmap: small cleanup for __folio_remove_rmap()

[Lorenzo Stoakes <lorenzo.stoakes@oracle.com>]

On Fri, Aug 15, 2025 at 08:49:40AM +0000, Wei Yang wrote:
> During code reading, I found some small places where we can improve based on
> the knowledge we already have.
>
> For example, since base folio is handled in another branch, we case use
> folio_large_nr_pages() to get the number directly.

I think this cover letter is pretty weak, please describe what you are
doing clearly and why.

>
> Hope I don't mess it up.

Please don't put this kind of thing in the cover letter, it gets reproduced
into the actual commit messages and this isn't useful for people reading
through commit messages.

>
> Wei Yang (3):
>   mm/rmap: not necessary to mask off FOLIO_PAGES_MAPPED
>   mm/rmap: could be partially_mapped only after no entire map
>   mm/rmap: use folio_large_nr_pages() when we are sure it is a large
>     folio

I find 1/3 and 3/3 ok, 2/3 I don't like, so please resend series as v2 with
only 1 and 2, propagating tags + improved cover letter please.

FWIW, I build-tested each commit and ran mm self tests + VMA tests against
series and all passed.

>
>  mm/rmap.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> --
> 2.34.1
>
>

Cheers, Lorenzo