From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 475F4C4332F for ; Fri, 23 Dec 2022 17:09:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7E82900004; Fri, 23 Dec 2022 12:08:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B2E74900002; Fri, 23 Dec 2022 12:08:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F67D900004; Fri, 23 Dec 2022 12:08:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8E556900002 for ; Fri, 23 Dec 2022 12:08:59 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 277031602B2 for ; Fri, 23 Dec 2022 17:08:59 +0000 (UTC) X-FDA: 80274205998.08.F5162D2 Received: from mail.cybernetics.com (mail.cybernetics.com [173.71.130.66]) by imf02.hostedemail.com (Postfix) with ESMTP id D390E8001F for ; Fri, 23 Dec 2022 17:08:56 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=cybernetics.com header.s=mail header.b=Bkz25skA; spf=pass (imf02.hostedemail.com: domain of "btv1==3566bacb5f7==tonyb@cybernetics.com" designates 173.71.130.66 as permitted sender) smtp.mailfrom="btv1==3566bacb5f7==tonyb@cybernetics.com"; dmarc=pass (policy=none) header.from=cybernetics.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671815336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2uSPinO9LfjKWSohiabUpBnrYS2Ywe9hn8wsUKvRf8U=; b=SURzREVnt1f3c3Vim1RWnFmKOQ7+LgO7TNt9ZtR7hjEsF4TYFOU+M7zU7u+vDNrKblbzzh 93IlL6yLol4qZlmqd53l+u/EZf7NWZiEHabvg79lw6nZmzDFHdm6IcMYE3Hq+CIqRYQFw2 ae4ztW4Cxc8ol0sOSe4prUoFxmUdhpw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=cybernetics.com header.s=mail header.b=Bkz25skA; spf=pass (imf02.hostedemail.com: domain of "btv1==3566bacb5f7==tonyb@cybernetics.com" designates 173.71.130.66 as permitted sender) smtp.mailfrom="btv1==3566bacb5f7==tonyb@cybernetics.com"; dmarc=pass (policy=none) header.from=cybernetics.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671815336; a=rsa-sha256; cv=none; b=vz+pzrrq6+/hxmAE8ITytLZuNmV7F2FF3k1NHkY453DPukWMEc3X94CngZr8AgmU4PpSaw nXMraJjBtJqju5zUpfmWA3W81SaYMluceXUdQCBuPJulWoqWnn31KrK48si66t2niu2/eD +N/apN3wyEjQjdd0Shr1AsJU2qVJ6Og= X-ASG-Debug-ID: 1671815334-1cf43916c2313940001-v9ZeMO Received: from cybernetics.com ([10.10.4.126]) by mail.cybernetics.com with ESMTP id f1OYys6DHxrGcjq4; Fri, 23 Dec 2022 12:08:54 -0500 (EST) X-Barracuda-Envelope-From: tonyb@cybernetics.com X-ASG-Whitelist: Client DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cybernetics.com; s=mail; bh=2uSPinO9LfjKWSohiabUpBnrYS2Ywe9hn8wsUKvRf8U=; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Content-Language:Subject:MIME-Version:Date:Message-ID; b=Bkz25skAKWS2qQL/Iynq TFGIpgI5/ATPC3Gtx/D3DJUnzJaw48v3n+A5X6OhMoWST7CCLtQpzR5ZNQ0mZFfaWXROel+cvJ1xX Am6fZvt+kSEaGJ74RgwAjCB3PRIn4jWxH8QB9SM79L4xT8kkAEgcV8s0cDyYxElhcDJUYlemLY= Received: from [10.157.2.224] (HELO [192.168.200.1]) by cybernetics.com (CommuniGate Pro SMTP 7.1.1) with ESMTPS id 12383131; Fri, 23 Dec 2022 12:08:54 -0500 Message-ID: Date: Fri, 23 Dec 2022 12:08:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCHv2 11/11] dmapool: link blocks across pages Content-Language: en-US X-ASG-Orig-Subj: Re: [PATCHv2 11/11] dmapool: link blocks across pages To: Christoph Hellwig , Keith Busch Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Kernel Team , Keith Busch References: <20221216201625.2362737-1-kbusch@meta.com> <20221216201625.2362737-12-kbusch@meta.com> From: Tony Battersby In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: UNKNOWN[10.10.4.126] X-Barracuda-Start-Time: 1671815334 X-Barracuda-URL: https://10.10.4.122:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cybernetics.com X-Barracuda-Scan-Msg-Size: 698 X-Barracuda-BRTS-Status: 1 X-Stat-Signature: 4iek9x15krbxzbjuyuf5hsnjyeu7hrhp X-Rspam-User: X-Rspamd-Queue-Id: D390E8001F X-Rspamd-Server: rspam06 X-HE-Tag: 1671815336-164139 X-HE-Meta: U2FsdGVkX18AR1JCWwW4P2yMp4iRON2Wg5bKcIlVWsGQN7ybsniswTEGx0Tn8Qqfs1mMnDgZnT+tZisRvS10YSIBHU1XW2imL4YbACw/ADbzog0LtxkPdIDQbcwywoihY37eq9Gj/hd7xo+GoPdbVXz/t8Sbcd8uZ3whWEStIPawoUTQPKYjRulLs//B9E1wQYXTtg+TrKGr/v62+OXxL2Vx7mcbFyA6iSXvwr6q1O6HMkvXfk3hFZ0Ts9m7f3U8ZMBXZmhDt+rZQRc/yr8oBdNtGvTfd7fv81rp2ZevnI/72lpUg+ynP3jYtLuwgI9YMzc0Xz//hoQGlaBHal3JMklCxQGTWvHPyX93dRfoNfiyPKu8zqOCgZ6OQo7P+aFrt1tlyarTb5AEw7c7aoE0fOSXPmhcg+JDVyNXfCQIn4tsIgdMT/p+pue2WRrYwyy6ilIEz47uO+Xskk7f53/9u9h6raepeLu0QvwSCEACZ9LBDY9zqHfX7+Ty4l5LVbNasv5V21fIWccCwvxoivjM2YwQn1FV0yqROWLTaBIKvNktNPeq1PbvMBamN9hIPwx/VBPQyODttEUjpK/KKdZysCP+gZq1+CfPQcL5r1ue67XxKHtdZ2sXDIABXNZmQdTJyXw4kOIL1wjej9rb2le4sPhfLwNHcyTHQgNCN91U3F8s+ct5D9QsD9TU3m2NtzYqexiRsxMHn4DcLUK+oeTeK9z40eEs7RaEKr2DAJjjaq3z7D2ry76Z8BuV4VAY9f3x9DIgFVcwKkLrtwkgSCnUt0Its0DOVSmVa3E9JO5BGvkBrar46j3s8fVXN2p320LdIKi6+rUTjwEkWbi1kgLqlfdsY0SJP9KgnG9XFUyAzD6C0Pyf/VKh63uz2kqphIKWluzaOS5TkzRC+xw8tbpygcgCGsiJC1ly4bDddryRjd9JVrUoDFgaidPfXxPSe0AUzYK8jCkRTxLLjkNArIr 1tPdiQIN 9xnR54OuamcR408NTiSoJck13mCUriIda4e16ud5AKHOD2zuDBeuSkJNezVzSraCAVMaBh5utewubQn3c9tg6ytXNU99LifG9xmSMObjT7kohEUk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010826, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/23/22 11:58, Christoph Hellwig wrote: > On Fri, Dec 16, 2022 at 12:16:25PM -0800, Keith Busch wrote: >> unsigned int size; >> unsigned int allocation; >> unsigned int boundary; >> + size_t nr_blocks; >> + size_t nr_active; >> + size_t nr_pages; > Should these be unsigned int like the counters above? I previously recommended that they should be size_t because they are counting the number of objects in the entire pool, which can be greater than 2^32.   See patch 4 "dmapool: cleanup integer types".  However the kernel test robot has complained that some of the printk format specifiers need to be changed to match the size_t type. Tony Battersby Cybernetics