From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F0AC001DE for ; Mon, 7 Aug 2023 02:37:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0FD96B0074; Sun, 6 Aug 2023 22:37:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABF356B0075; Sun, 6 Aug 2023 22:37:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AE5F8D0001; Sun, 6 Aug 2023 22:37:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8D5B26B0074 for ; Sun, 6 Aug 2023 22:37:01 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4D3D7160599 for ; Mon, 7 Aug 2023 02:37:01 +0000 (UTC) X-FDA: 81095746242.08.8040AD5 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf30.hostedemail.com (Postfix) with ESMTP id 4452F80005 for ; Mon, 7 Aug 2023 02:36:56 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691375817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Mvv3ZGcdEkBpaDvWze/IMbo/uLEluIuhS04EYYwMAA=; b=UrZ+uoBeqvTGjdICZn4TGimoN5QN42CwZms8h1vl2R0BWTCGP4oNJLOyiJgE9r+gFoRdAU itBDIYxI2OZTOv0koIUmtm3Lhg/2T1uYcYCYkWD2b8iRZl0sLlMOeRrY1ybyRyndwHDkyH bQYkurdpVpSsVbCM6bdq5cKeu8QQLHY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691375817; a=rsa-sha256; cv=none; b=qz+e5tX7b4DH9hA2WOcNXPX1CiPZg0516RCTtoEZ8fFoLtatDKjLPnPYlQDmqv2M4PRKXm 94ZbDK5/MLQXKIcRx2aGVznmWc0py396dZ3i79P8bSc9+AG9qcODTTjqRyHjBfl0SFFFBd 59G+hVCQ31+MD2FV0FRLnf+zZk7goeE= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4RK0mc5Hr8z1KCKd; Mon, 7 Aug 2023 10:35:44 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 7 Aug 2023 10:36:52 +0800 Subject: Re: [PATCH v2] mm/mm_init: use helper macro BITS_PER_LONG and BITS_PER_BYTE To: , CC: , References: <20230807023247.308414-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Mon, 7 Aug 2023 10:36:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20230807023247.308414-1-linmiaohe@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 4452F80005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: jmog76usutrgbqywfjagfexiaydyhgqo X-HE-Tag: 1691375816-998195 X-HE-Meta: U2FsdGVkX19WrGmE1SZIGF5kE9lTjD9goyvwere+1u4p+6pPcR6+P/Dgiq1/38RVGv36LKhnLQMFuixoxDfXpexNdnz4yI92thnghF8qlA0edkg3OjE0E9Q40rCsQr8Au9a94fkqjOSB64nE1kHo+IDg+9xkzVh4H9xDfhsm8BMjIgeM5+C3Lo8iO/KFn03HhJphUkm/OfpYYLl0XdFlKgKtiyjQl9eqPsTYEOivHG7t7vT7uLnBYfkJnBOInNyvJywrguKRPXL1kvApnKnQbo6DWTzegTSLqM7bFOASH5xQ0G5NjDt0XPDZzBKcyMRzE5Wj4KnJde4PdpsduAtRhAD4tpAO4m4H0oi031yQ0ByVTPyWzcYILNtOvxC5YU4By668Lyh+NqgMRqNbzOyzcIWH/YyOLMvqN9GFyDrOZcdpLSVEXT5MJYRBfEghYaQM9ZNrkfckIV0GRGZuFjMb7pXqVLAFOPm1kVkOXor+PECRlb41dbxex7QPvWUDjPtLqWNonvAnNMYSPjVIlVPKc8uOblboX22VAHjuwwYaZR0LrsoKI60UvFE9Zs9uBnszOoy8chotuTD2ZNhvS3WCV3CdXqkEenqW/wNiurzI6drB88Ty5t0Y0JWO1OFJhuUPk/qbQ/2Gs3IiF1G+yfhBG2naUN6wagEc6Hd1X9+tH5ynJ3vGxo1AsHs/bBmrrVB3mYwqYA1k7negfarypcgMRH2gb4ZpSbLej76NicqBuv5acUuNMBoJ8FiF8HaSQS4Dp3FvJ+UWWDjTBBB/Eh1+UH3vD7tLsOQv1BKScsyKXuteiqjbpZ7aZHX1rPzIhYW1fomWgbqfnUcmAezTXTOrUBFWIbOfmp0fpQX9v4Zn5TPhYkcDBLcDMB2x6RmArJT/nX5ZggdDi1f0P0jEFVoK19iWuBjQ9alPZwnGHdZvkkoHJt0oB8lRFxpFZJvpUcmnTG+YlOtiywyCHnHViaR rY5K27xJ IEuFjbelBO+9HCfOPNwvWDEMxCurskucKeV3l5gKJSsnbjAVqPWHMoyXRvfpji2/cDVQgYXYOW4UrYlLs19tY4x9eyHNRdvPUCsUzDIHmrSYrrBIVsLS+94VJIhxO70+gu0cyDAA7wPnwmnyb6cYjG3wzynyElVOHfVAC6SNGvK56xnAbH+I2Ko7PHAKkNEMLCBNigeXRTss7+q4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/7 10:32, Miaohe Lin wrote: > It's more readable to use helper macro BITS_PER_LONG and BITS_PER_BYTE. > No functional change intended. > I forgot to collect the Reviewed-by tag and resend one. Sorry for make noise. > Signed-off-by: Miaohe Lin > --- > v2: > use BITS_PER_BYTE per Mike. Thanks. > --- > mm/mm_init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 66aca3f6accd..93b1febd4a32 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -79,7 +79,7 @@ void __init mminit_verify_pageflags_layout(void) > int shift, width; > unsigned long or_mask, add_mask; > > - shift = 8 * sizeof(unsigned long); > + shift = BITS_PER_LONG; > width = shift - SECTIONS_WIDTH - NODES_WIDTH - ZONES_WIDTH > - LAST_CPUPID_SHIFT - KASAN_TAG_WIDTH - LRU_GEN_WIDTH - LRU_REFS_WIDTH; > mminit_dprintk(MMINIT_TRACE, "pageflags_layout_widths", > @@ -1431,9 +1431,9 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l > usemapsize = roundup(zonesize, pageblock_nr_pages); > usemapsize = usemapsize >> pageblock_order; > usemapsize *= NR_PAGEBLOCK_BITS; > - usemapsize = roundup(usemapsize, 8 * sizeof(unsigned long)); > + usemapsize = roundup(usemapsize, BITS_PER_LONG); > > - return usemapsize / 8; > + return usemapsize / BITS_PER_BYTE; > } > > static void __ref setup_usemap(struct zone *zone) >