From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33339C7EE2A for ; Fri, 27 Jun 2025 17:11:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD8FB6B00BE; Fri, 27 Jun 2025 13:11:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C89D66B00BF; Fri, 27 Jun 2025 13:11:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B79496B00C0; Fri, 27 Jun 2025 13:11:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A74416B00BE for ; Fri, 27 Jun 2025 13:11:01 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 746B01A0280 for ; Fri, 27 Jun 2025 17:11:01 +0000 (UTC) X-FDA: 83601820722.23.E2BC596 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 21B048000C for ; Fri, 27 Jun 2025 17:10:58 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GAqT3dcv; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751044259; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/X+AKBkaWVdCb7p9EK8v5QepC+OkISpdm67SbSFG9vg=; b=j1yy1vXMEgYJRBYBGM0mMzWSyrtZaGO9qN8cddqyLliqYclby5G1Z9j+uCeETkz9sLIJBB CcOPiPomVEFZvtyiRXnW7TkcjQdyg2m1fNETTvw7zCtyJ+oaRYYvJHpYFt+TBWK3xrX0al SwZ0sJiyIXDezZu4t4QqF6FDg1wj9X0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751044259; a=rsa-sha256; cv=none; b=ws1WEJq/B8rcUwpeOv++sXrMFjlNDQfaAOIfvy1TmAujs5vC+B1DhQl+G6nZoWXPv3do5u RVzz7n0mUrPIo55xgGSMF8+wkeiGwNZCwfrBHvRHyWerzAg5xlD1/viGOycRCszK3z2k6+ 0+QNxj4XnLWoCkrwv5c0BO/Cqk5izh0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GAqT3dcv; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751044258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/X+AKBkaWVdCb7p9EK8v5QepC+OkISpdm67SbSFG9vg=; b=GAqT3dcvER31JhLDMKdEFaHPae0wvg6ZobFgCSjqG+VcPSxGGBFHhpgBHgabColtMkl2OG FcPBWxe2eGhc4oUP+4eIS3DLnUgGab3Alpf1CIGfCeXA2u/xl+tMH2uNfasAY9E6sVyC0t Gto0wDvaKC/sds7RYMZb3gQ/u4GlxiM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-0gpym3XKMni1P1QZboSDTA-1; Fri, 27 Jun 2025 13:10:57 -0400 X-MC-Unique: 0gpym3XKMni1P1QZboSDTA-1 X-Mimecast-MFC-AGG-ID: 0gpym3XKMni1P1QZboSDTA_1751044256 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-453691d0a1dso622755e9.0 for ; Fri, 27 Jun 2025 10:10:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751044256; x=1751649056; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/X+AKBkaWVdCb7p9EK8v5QepC+OkISpdm67SbSFG9vg=; b=WJXhhgNkPamA4P/YLhyTa+3X+sWo3ljvumje9vVfGLArorse7/wRkITtCQPz5Rvc/Z XQAL+WQs5LTss86vK0pCKRTmzr6F3x8aAihCnwu/YKz3awRX1ieLPvb13uvLbhFWMSBL XovJSOgc29tgBXa/KLsXzmNvfBp+l2isZ+CwAvULoS/8vZAaToYSGGYUrrzEmKBMtYx+ nooOw2bWYa1cC40jQ/cbfnC+fTZ0Pe/vUiYnCRpx1eQKeKYFGzail+YtQYmTIM5fbesW erEk7TMJ/cOexQV5n2nhyRuHGsHBsEDPkyCqR3JgRcKOIYvS7x4hoqT5Tw4a2rcQbanJ Q6DQ== X-Gm-Message-State: AOJu0Ywca8SvoNGyYUpDU778o+UDaLG/+aWycqSSeFYgPhKtPOuC9ueo 1bJHmNOVh88uP67CaWFacGrwVCF0oHzmtWydpr9jJHTlyvfqMWBrGXPJRjc93Ex0lJ5Z9CETx8v yOI+m8TWgMCalrK/vMi691m5nxpPlNSrT5ohaENkZZVx1tZK7scSp X-Gm-Gg: ASbGncuSywan4oQNs5PBkrZeyq/7hFKpBhB0wSQ9MhflLsgF1sOtqccnqSNkOeRRTbN yzQ5qGNqpxmMBRRbOHlgA/E/B9UZchU+ikr3X/qpFEbql6wb+LpZl70HJLVVG90d9DyM4YVGJKo BtGeuGZXeN+bz8WC1EoZU8puVSrw/jJZquFtTJSKG03sDLo8KUBUzKpP2m967jp2L3eZAlFllCi riX97pGZwnqQ22lolXy0AFX97mQ/zel+7rV+OqmHKm8pTe/K/zZPBflpGyttOr0fyvjA6S1Ym5f o77D9ajiQXBl+ooP8PYMMNkxX1b6iKrD6iPDGfGg39cx+lDJXAjyJMTwi6rgc8sad6bf6WvgVvB IQhwOdXYtojUwXC02ecY0mksGN6R1iZiMCCvT2VS+hdX8bcqqbg== X-Received: by 2002:a05:600c:698c:b0:441:b076:fce8 with SMTP id 5b1f17b1804b1-4538ee5db08mr46589095e9.14.1751044255827; Fri, 27 Jun 2025 10:10:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEh2ESXOjU1CmPc52Qv0VaXvQCkvie0Ohsfur5dXFrY/Y9dP4x9y2V6YYTYfYfX6mq2S75HcQ== X-Received: by 2002:a05:600c:698c:b0:441:b076:fce8 with SMTP id 5b1f17b1804b1-4538ee5db08mr46588735e9.14.1751044255343; Fri, 27 Jun 2025 10:10:55 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2d:5d00:f1a3:2f30:6575:9425? (p200300d82f2d5d00f1a32f3065759425.dip0.t-ipconnect.de. [2003:d8:2f2d:5d00:f1a3:2f30:6575:9425]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538a3fe592sm54710645e9.21.2025.06.27.10.10.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jun 2025 10:10:54 -0700 (PDT) Message-ID: Date: Fri, 27 Jun 2025 19:10:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm/vmscan: fix hwpoisoned large folio handling in shrink_folio_list To: Jinjiang Tu , akpm@linux-foundation.org, linmiaohe@huawei.com, osalvador@suse.de, mhocko@kernel.org Cc: linux-mm@kvack.org, wangkefeng.wang@huawei.com References: <20250627125747.3094074-1-tujinjiang@huawei.com> <20250627125747.3094074-2-tujinjiang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250627125747.3094074-2-tujinjiang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BK1azkMfUyurO_a9GT33mJHIiLBrquJ9QLNZCZy8Fyc_1751044256 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 21B048000C X-Stat-Signature: 9kx1jt9ffifxpby9qiyq4oea8ixigtza X-Rspam-User: X-HE-Tag: 1751044258-919178 X-HE-Meta: U2FsdGVkX1/mZ7bIGLpSQrpY/GpX5vHL2d1mZ6OU7wC70vYq7NWsnXD9RVT+V7WjfNYsPI6wPO51cORf6AkXktRlaNP+5s3pDsrUqAg0vOpsupdRlD167TU1XfOA6JUEbg3gDhPaggtADfYRpju2AMW73ywPOokWlI0Mr45kkM9liVAx0ueBFRt9PW355rHgTir/NoARwUq84BIQ8dqOuzXGFqACKgWf+KzOrG6WRMn5j3wukLmimwsKrmtEkVOpujWDuuAKZ/CnukUUVdizNQnama+M5qSseeRaIThKNVSiNOR3pH9mOG3d9CgsSrcbRitgmjOtsLYvaiN7BQkayzVh/fXdysF/ITTePKRsnOrfe5EF2E1h5yqOE9ilATvkMBGgZ0CSVZuAEo9cAWx7tFbcYSM4iJ1HngVaXRRR6xB3xhfqCE/BvgswbEjBpROty1hn1ne6EcPH/jXi4REPA21ou7IOgG2as8Cdg0qmViI0G0Fuv/TOz7kOBsaWMPt6DVNvKM88UNSvt9/NDoadmpvkpqTy43UtR9m/v3GNION2F9BbwfY7EAUlMJ1n/pf/fExhgUUxNkO4edNQ86+He6gkxnGFncTyXIJGgv3twxmJyAuyLrC2jNs618hYgYxGA7qCKYQ1W89XdJWPW5Im/8WeDndtJ17QXNLSP0YObITofb4+gc1jbTpNHWnZ8jpCXDuoey6Y9D7HfQeSJ5AIP36UqsT/jyNkTIfJwOLRFUwtdaszrq32zZhx8StuLo+WGCoEO9BURUvQl/RYm7f44v9o+075UClA2+oggWIdgbFpAMvKO9cPz8K9SADp/KKmdR2unTrLKI5buIhcntyYguxbWyZoFgB0sV7yMXxj5L6MDBZOcoGsf1JcNXfGzpRzsT6bHe00dNVhqr/l7q6dTLqy3GZK3uR3R+pIf1MqOZo/a9c9SVknGucdfA/demUZV0tk8Yy8ye3bND8P75D EWm4k7Kk gIglWeMIYXOGP6vIoebwGh9VA9j2ZKDZs1tRjbjCXIdu/lQJgKeeuIjKo0K0LmBG/GIOf8V/Mirab2xxrAaOkZOdwwr5BSGi1F9Fn/LJ4TiPTDyyfBzRs832Bisuft/85k6/Hcp4KC1EjX++Z5A8NVawf8POGY51ZZLljhGHN0LAddDREhNtYtVV6IcQZQnZLrptb2TjZtdoWOaJpTqhvBJUaterr2Da8sN0g7unEB2DZF6QXC9es33/tbcNVL17vId960onbKb3oS2YGsE7myrQsjcNdWy/QI7we6LJ3jOKjiPUjIFN1oydszppXDGraxz/v5efsJOLbnSUxJBvTXwgoN9SYyVbH6nxnqUdjQqCcEFFL1+CJhfTPzxYs6wiVNChIeg8sLNPWK40Fe9ACBQ2VD51ImJFqpX9/H/vmQDtCTJiuAKR7x5Jsvp9oa7kdj8CNxmEoTiWvwHaLaQwoKy70BWR5eRzB0EoxA98HhT78Mv3D09gDe1gX6tyDqMG5KN1u+2fTG1HzMlHWJCcYLD6YG3q8Q8OVybBTtcdAA5Y7JZWe4+ZuJGZoRcNQs1L1aj2s8dwCWT/9d9eYw9qckNiSahn0EorM7scsr/b+aTl7gq6HSi9DLEPlR9NvrRj/8b6TxFlWqYTZ4ZYIfLSORe2qSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.06.25 14:57, Jinjiang Tu wrote: > In shrink_folio_list(), the hwpoisoned folio may be large folio, which > can't be handled by unmap_poisoned_folio(). > > Since UCE is rare in real world, and race with reclaimation is more rare, > just skipping the hwpoisoned large folio is enough. memory_failure() will > handle it if the UCE is triggered again. > > Fixes: 1b0449544c64 ("mm/vmscan: don't try to reclaim hwpoison folio") > Reported-by: syzbot+3b220254df55d8ca8a61@syzkaller.appspotmail.com > Closes: https://lore.kernel.org/all/68412d57.050a0220.2461cf.000e.GAE@google.com/ > Signed-off-by: Jinjiang Tu > --- > mm/vmscan.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index f8dfd2864bbf..424412680cfc 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1138,6 +1138,14 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, > goto keep; > > if (folio_contain_hwpoisoned_page(folio)) { > + /* > + * unmap_poisoned_folio() can't handle large > + * folio, just skip it. memory_failure() will > + * handle it if the UCE is triggered again. > + */ > + if (folio_test_large(folio)) > + goto keep_locked; > + > unmap_poisoned_folio(folio, folio_pfn(folio), false); > folio_unlock(folio); > folio_put(folio); Acked-by: David Hildenbrand -- Cheers, David / dhildenb