From: Joe Perches <joe@perches.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] mm/memblock: replace u64 with phys_addr_t where appropriate
Date: Wed, 04 Jul 2018 10:22:32 -0700 [thread overview]
Message-ID: <d9bc90af283e03226bcc632e5c8bdf3b5d654b63.camel@perches.com> (raw)
In-Reply-To: <20180704070305.GB4352@rapoport-lnx>
On Wed, 2018-07-04 at 10:03 +0300, Mike Rapoport wrote:
> On Tue, Jul 03, 2018 at 01:24:07PM -0700, Joe Perches wrote:
> > On Tue, 2018-07-03 at 12:57 -0700, Andrew Morton wrote:
> > > Did you see all this checkpatch noise?
> > >
> > > : WARNING: Deprecated vsprintf pointer extension '%pF' - use %pS instead
> > > : #54: FILE: mm/memblock.c:1348:
> > > : + memblock_dbg("%s: %llu bytes align=0x%llx nid=%d from=%pa max_addr=%pa %pF\n",
> > > : + __func__, (u64)size, (u64)align, nid, &min_addr,
> > > : + &max_addr, (void *)_RET_IP_);
> > > : ...
> >
> > %p[Ff] got deprecated by commit 04b8eb7a4ccd9ef9343e2720ccf2a5db8cfe2f67
> >
> > I think it'd be simplest to just convert
> > all the %pF and %pf uses all at once.
> >
> > $ git grep --name-only "%p[Ff]" | \
> > xargs sed -i -e 's/%pF/%pS/' -e 's/%pf/%ps/'
> >
> > and remove the appropriate Documentation bit.
> >
>
> Something like this:
not quite as you either need to run the command
multiple times or use
$ git grep --name-only "%p[Ff]" | \
xargs sed -i -e 's/%pF/%pS/g' -e 's/%pf/%ps/g'
next prev parent reply other threads:[~2018-07-04 17:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 17:05 Mike Rapoport
2018-07-03 17:22 ` Pavel Tatashin
2018-07-03 19:57 ` Andrew Morton
2018-07-03 20:24 ` Joe Perches
2018-07-04 7:03 ` Mike Rapoport
2018-07-04 7:23 ` Sergey Senozhatsky
2018-07-04 9:04 ` Joe Perches
2018-07-04 9:20 ` Sergey Senozhatsky
2018-07-04 9:43 ` Sergey Senozhatsky
2018-07-04 15:20 ` Mike Rapoport
2018-07-04 7:54 ` Sergey Senozhatsky
2018-07-04 15:21 ` Mike Rapoport
2018-07-04 17:22 ` Joe Perches [this message]
2018-07-05 7:12 ` Mike Rapoport
2018-07-04 7:02 ` Mike Rapoport
2018-07-04 13:05 ` Michal Hocko
2018-07-04 13:24 ` Mike Rapoport
2018-07-04 13:29 ` Michal Hocko
2018-07-04 14:04 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9bc90af283e03226bcc632e5c8bdf3b5d654b63.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox