From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05BD6CF9C6F for ; Tue, 24 Sep 2024 12:54:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EFDF6B0083; Tue, 24 Sep 2024 08:54:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A1166B00A7; Tue, 24 Sep 2024 08:54:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7676F6B00A8; Tue, 24 Sep 2024 08:54:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5EDB36B0083 for ; Tue, 24 Sep 2024 08:54:50 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 07B64141A3D for ; Tue, 24 Sep 2024 12:54:49 +0000 (UTC) X-FDA: 82599626340.27.CAFB120 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf14.hostedemail.com (Postfix) with ESMTP id 8029E100010 for ; Tue, 24 Sep 2024 12:54:46 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727182356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SEVoHh70TiHdbb9D1kQW+zZnmEJW8TaCU36wh7YxOlE=; b=5rBI2BM3UFhbROidxm5h8Ni0ix/7IIr5aujI6HIailpqFA/vDeY4qeF68XZrXrOlCFZKxI iIQjloTFFx8fa8P9e7RpCMhDC3AvgpLfxn9Lhr3syMXLSmi9VWSVMUb6uwqOIS6LWDoSiz FubhLTYdbzxywbEOv9+bcNrGr7NXqJU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727182356; a=rsa-sha256; cv=none; b=Ir9P1Ba+dsC0ZHFiClnqhrHk0QSAAfxvlzsjjN1LvBmk0W/nP6iR5MNW77FgEPs/m6+uNy sSjbl02iEvlQd9cQjlBNAmeUml1SFE9O1WCW7sE/gmVLeQU4Btb/7CmYSiufKWGAyx54zd uDw8+Of9T9AzBXazS8XR0W33FOfP++Q= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4XCftq6vcJz2QTtw; Tue, 24 Sep 2024 20:53:55 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id EF060140119; Tue, 24 Sep 2024 20:54:41 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 24 Sep 2024 20:54:40 +0800 Message-ID: Date: Tue, 24 Sep 2024 20:54:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] mm: Abstract THP allocation To: Dev Jain , , , , CC: , , , , , , , , , , , , , , , , , , , , , References: <20240924101654.1777697-1-dev.jain@arm.com> <20240924101654.1777697-2-dev.jain@arm.com> <61b16640-49e0-4f84-8587-ae9b90a78887@huawei.com> <91892582-1063-4757-9cc6-664d57b9d828@arm.com> Content-Language: en-US From: Kefeng Wang In-Reply-To: <91892582-1063-4757-9cc6-664d57b9d828@arm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8029E100010 X-Stat-Signature: 66mb89dzngm8147fcib34bs7exezyty5 X-Rspam-User: X-HE-Tag: 1727182486-568733 X-HE-Meta: U2FsdGVkX19ItiJgM32/AaFB+7spzR1mwEU2a1VukSiII2MEiQbQFjbCWuPAn0jvpwfrrfEo+ik/fz36lYn11tA4jVWwbuc+t/ZTHI70TLefp7VUNzgWxVd7ZmJ32nUsbGcddki+hiaQ0gfI4NWuuBRIvU1hZ6I1r/AEShpgf0X7RyAR0UDhLrbGBKLCMYNTuBYW6y+MSL6ikoGXe0x0No8Mo40K7Rkan1hfe0VAcurUVUKll9O/S+XNmqhjjCIsn1Cba2ektdFAbZt93Qc4Jna97S9QaCTe0yO3XhRONRNTqkdGUl5QdCgwp9H00pWSG50K5L1nU97HZeiQSHGG3KPClVwMh9rf6u0o34+yG5MxIOh+Nwk6w3MUidZ4jVC88UhG2PChNZvzQv5JnA0LDyhwDk9E8CJSf30rRApPEQG1dbvz1PWR7pdmmsxyEEdwMByc5Ggr7gWKOTFCiOO+eAmxpkdXluTEx2gRsyIeaT0glGhYrj/oZG6aflzzdDPdFocM/rigkXwfS9KyIosTx0BU9o1EAgMpVP6/THANkFt+C333Qn3HvJSgBfh9auoeedTmR4pYRa0+o8yx5bvwY5eK22IuEJNj1ksddck9vsEXaC/gQ027J+FGoy3XEzZv62QMz/MSIj3bwCmLciHUYqQbEzNc58dLDVEh35/10xPcoSejb+D/xbLAclfKqC2iFKF0ilnChLo2zXrHhPRjOdKeZbVqPogweCZFASujUkPULLfUvCr/qDGt8EcWmcowTkCPVmUdszY6pvit5t3bZE6H2HzQcBtTmwSCKQUHJaanhVwE12l3+cEZZhnLeyTCzxKZk45P1hXBx6kjXpuVHiSTBXcfGywPRvdA8vFvW+L7u+yHlap3yvyrEtWlyIsVVdoTE2S+x1Ef7CXMjK1aWVASURyl2qQGItXs4Gk+xXPfgO7lGQ9G6gck/CX5tSb5y2KbbiYNLYXkAv2JuDx x5hmshuH 4QvMiBtQjuEOMjFkS7mHeAYm6SX2SQbDIzf1pzWGv8k3f62vv9kirMhnANccgXLjPES3TKNWJoG5EIZvgY2OQqzbp7kkSqH0IPgX/Gfh2E7vegwXEvCEOI09W//ud4FPvhwUFGRlidfWDFM4VKikAp4JVWlwUCc0C6gMs4XWbqwhUzIaCbXmHg36vgipoxhngrHbsjrzrShvP6hszy0rxacwDlg4QSrmqRMny8A94tEwIYfgkJOG0i83p3e10Eaq6hwdPp8Y1aVztxo/hSocD3IBLIbc++TbxwAY7UI18MTiuHpg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/9/24 20:17, Dev Jain wrote: > > On 9/24/24 16:50, Kefeng Wang wrote: >> >> >> On 2024/9/24 18:16, Dev Jain wrote: >>> In preparation for the second patch, abstract away the THP allocation >>> logic present in the create_huge_pmd() path, which corresponds to the >>> faulting case when no page is present. >>> >>> There should be no functional change as a result of applying this patch, >>> except that, as David notes at [1], a PMD-aligned address should >>> be passed to update_mmu_cache_pmd(). >>> >>> [1]: https://lore.kernel.org/all/ddd3fcd2-48b3-4170- >>> bcaa-2fe66e093f43@redhat.com/ >>> >>> Acked-by: David Hildenbrand >>> Signed-off-by: Dev Jain >>> --- >>>   mm/huge_memory.c | 98 ++++++++++++++++++++++++++++-------------------- >>>   1 file changed, 57 insertions(+), 41 deletions(-) >>> >>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >>> index 4e34b7f89daf..bdbf67c18f6c 100644 >>> --- a/mm/huge_memory.c >>> +++ b/mm/huge_memory.c >>> @@ -1148,47 +1148,81 @@ unsigned long thp_get_unmapped_area(struct >>> file *filp, unsigned long addr, >>>   } >>>   EXPORT_SYMBOL_GPL(thp_get_unmapped_area); >>>   -static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf, >>> -            struct page *page, gfp_t gfp) >>> +static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct >>> *vma, >>> +                          unsigned long addr) >>>   { >>> -    struct vm_area_struct *vma = vmf->vma; >>> -    struct folio *folio = page_folio(page); >>> -    pgtable_t pgtable; >>> -    unsigned long haddr = vmf->address & HPAGE_PMD_MASK; >>> -    vm_fault_t ret = 0; >>> +    unsigned long haddr = addr & HPAGE_PMD_MASK; >>> +    gfp_t gfp = vma_thp_gfp_mask(vma); >>> +    const int order = HPAGE_PMD_ORDER; >>> +    struct folio *folio = vma_alloc_folio(gfp, order, vma, haddr, >>> true); >> >> There is a warning without NUMA, >> >> ../mm/huge_memory.c: In function ‘vma_alloc_anon_folio_pmd’: >> ../mm/huge_memory.c:1154:16: warning: unused variable ‘haddr’ [- >> Wunused-variable] >>  1154 |  unsigned long haddr = addr & HPAGE_PMD_MASK; >>       |                ^~~~~ >> > > But why is this happening? If no CONFIG_NUMA, vma_alloc_folio(...) = folio_alloc_noprof(gfp, order), it won't use haddr.