From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E6AC28B20 for ; Wed, 2 Apr 2025 15:01:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C89F028000A; Wed, 2 Apr 2025 11:01:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3A3F280006; Wed, 2 Apr 2025 11:01:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B012728000A; Wed, 2 Apr 2025 11:01:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 93463280006 for ; Wed, 2 Apr 2025 11:01:03 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7C4EABB872 for ; Wed, 2 Apr 2025 15:01:04 +0000 (UTC) X-FDA: 83289416448.18.DE2D48B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf30.hostedemail.com (Postfix) with ESMTP id E61CE8001A for ; Wed, 2 Apr 2025 15:01:01 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=O24XNBs8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6Zrpjao9; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=O24XNBs8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6Zrpjao9; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743606062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vT8nPzlOT1lU8ebYpJie/X1Ap1hIbW88MbUW9YrYAqU=; b=eRhK8/3b97iczgbLGlOxPVDKWj8MOnL2qdA2WqibRr5kQjDlyVpMnlSaAkno3Z7BvjKDye wNKX1fr5+zd66R8XAJa0kV19XaZ+n2GuoK4IsiA6yw3/Ng8VtBPisXqnC3y5XzTY8xD4YC Ii0KgnD60dEDzB1jlziFCKQHaYeQ8Tk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=O24XNBs8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6Zrpjao9; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=O24XNBs8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6Zrpjao9; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743606062; a=rsa-sha256; cv=none; b=AcskeE1pLtT+qqs+sKmwB/ZTG5v9QG2jLX0AetgTGG/XjpAtOqZDzBmpb9q0V4i+OwlzkJ aRdMQaGd27P4/yufcuUkL4DfMm3nhN3VezKQ7QDjqszuZ1gKQTEwW8IjusgJth2hBcA0vB QQGfSSbscsIA1fb02aS2FsOiqhOubU4= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1B20A1F38E; Wed, 2 Apr 2025 15:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1743606059; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vT8nPzlOT1lU8ebYpJie/X1Ap1hIbW88MbUW9YrYAqU=; b=O24XNBs8UVVAi1baqmzIhyKkmFifqnUFRf34CmLjNWAicmj7e4mNJ8ccK9YCpLaBL8puBr ZvwmEWUvipAaDaPke6Ggr1mtwYRWeo7cocARoCdztZu3EyEZz/qjdJ86vMdr4NpnasHb98 87vQ9Wvu0qknpGjDB4wTCrb8Lg+f74I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1743606059; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vT8nPzlOT1lU8ebYpJie/X1Ap1hIbW88MbUW9YrYAqU=; b=6Zrpjao9YnlzRAbXvGetaQjcD6SMITwZsedpMtKk3jN6oGXQxWY6JtJdgE++rWa+BPLF+X txEm8gBRpFzVnoCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1743606059; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vT8nPzlOT1lU8ebYpJie/X1Ap1hIbW88MbUW9YrYAqU=; b=O24XNBs8UVVAi1baqmzIhyKkmFifqnUFRf34CmLjNWAicmj7e4mNJ8ccK9YCpLaBL8puBr ZvwmEWUvipAaDaPke6Ggr1mtwYRWeo7cocARoCdztZu3EyEZz/qjdJ86vMdr4NpnasHb98 87vQ9Wvu0qknpGjDB4wTCrb8Lg+f74I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1743606059; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vT8nPzlOT1lU8ebYpJie/X1Ap1hIbW88MbUW9YrYAqU=; b=6Zrpjao9YnlzRAbXvGetaQjcD6SMITwZsedpMtKk3jN6oGXQxWY6JtJdgE++rWa+BPLF+X txEm8gBRpFzVnoCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EE190137D4; Wed, 2 Apr 2025 15:00:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id tEPBOSpR7WcvOAAAD6G6ig (envelope-from ); Wed, 02 Apr 2025 15:00:58 +0000 Message-ID: Date: Wed, 2 Apr 2025 17:00:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Ask help about this patch c0cd6f557b90 "mm: page_alloc: fix freelist movement during block conversion" Content-Language: en-US To: Carlos Song , "hannes@cmpxchg.org" , "baolin.wang@linux.alibaba.com" , "ying.huang@intel.com" , "david@redhat.com" , "mgorman@techsingularity.net" , "ziy@nvidia.com" , "akpm@linux-foundation.org" Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam01 X-Stat-Signature: d9sm4mxwpmjh6j1w1rdmgykckb5i61ki X-Rspam-User: X-Rspamd-Queue-Id: E61CE8001A X-HE-Tag: 1743606061-953800 X-HE-Meta: U2FsdGVkX1/8ZqzXykTUlWZp9AON0s7g2xOXiZe74Q4PVkRTkzw1poebEf6yIsQZbYTDd8STgQJn7TGhR+TKPPh4s41zvm3V28zzyppE0+R29IJUXSOLp37xKoEDbU7An/dtQjz2Q17Ol1X/IV7qPDmMZ9ejYUSlGbGOJqdwwrwJYJI7Hd8j1IvYayGw5SOG+/uihGfASpB1uZP9LE9DNqxOF3waGIi8U0kXQCUli40LlyAhkNLiTRrjEWPhBR62VMP9mh4ZSlOsGDE9Ik+H0R+N7ZNzjvVOnlDTT2kxKpDeIiYFN6Crhy/Orh3NnxgWfiVCdh1ouDjP5dn0gwccVfYq7y8jly0CnaikRev4TZcjVOxsS73hmyNaOi3E65JWCIpVsb8mIdOnAuZIJ7XmV7kDVdMTIzLCXq9CIfqQYjV+V3HaGRMDgj7OCkL2dtKM/JELj/tx01MIMfjYn+1poubQVWYJhrEgV77HaPpqG9vZGQ85Hu2ap5LzUTLbxPywawwkpN9h3M9mU2A2jPIZaCyGo+w0mEmban/R/hhalDDqi/Avx4+sUyiF0e19TdS57wYwSVpxTFb3jySieFrhGYtpUqjVcLWFceVzkc523sUoc+EXdAOcagJqchEHoWKfKzS40Pp4zF0XBHtyeJek9FuEBOoSUFnT8pjacO/d/ZMx8UKFDzzyEWsfKyRyfVoT+7M1dNg1z2JsdjBTFN3eAi7XaNQjiKVF/K7mFnGM4rsyd7g4joS1B4xU3AoJN3wfrUozcqdK2tom6EagbzDUE4NCL4deuOWMICALcOsKY+nZ7adOuBPmEn7OYKK+gduTZhAmEQT4L0ERZqrXnsWmr1G2N/ZpmMLK8yolYq2842SsqSasCR23JQs5aB2tcH9vlhfjGPbrbIm9XFA9v6nVUDoFc2OIlfr9chmSJ391zWBzkxnI/PeJIqfoqMa/r2OF0Qmv4oYizamLwA6hpU7 PhXGoliN ZQyg9afN4N0HQ1QeRf/G2GSQ6oq30Qe8tnhuj2N2xEAocArQeWv958J+Pa9uIeYL0/q9vpsOpwm0CCxFIGB6XvFM6dwt9MN/FNmou2UODZnCdCiSSvPsdO9+qTCcYVvFKrxqBP1aRmivhkUuSr4FMBMJuANoZ/krvLvgRTAaRiF6fZhratYf38Oi++WSUt5fy4BwOea9upukE8vDZk0q7Gdc4bFiiskCFcc/+YdQ3B3GtT2GUt37UKF1oYHfvukzkNKOyKkaQiQzPwU85xm0jfRZ0sWY088EYgtpBTwIZK+gtws1PSs8hh9gX98mGMQbK53hh0SzgYPlDQBxFqovlF/1i5MhKnSDMb9mYXlMmjnWt5j5x8ikNlMvDmvWv5nVuj/DNgfrhE0jcQaX6YOLeuMfz2MbkA6a93uN93nkD04pLTPA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/2/25 13:31, Carlos Song wrote: > Hi, all Hi, > I found a 300ms~600ms IRQ off when writing 1Gb data to storage device at I.MX7d SDB board at Linux-kernel-v6.14. > From this discussion I find the regression root cause: > https://lore.kernel.org/linux-mm/CAJuCfpGajtAP8-kw5B5mKmhfyq6Pn67+PJgMjBeozW-qzjQMkw@mail.gmail.com/T/ > > Before add this patch c0cd6f557b90 "mm: page_alloc: fix freelist movement during block conversion", this longest IRQ off time is only 1ms~2ms. > After add this patch c0cd6f557b90 "mm: page_alloc: fix freelist movement during block conversion", this longest IRQ off time is only ~100ms. > This patch is added in linux-kernel 6.10. > In the same test case and environment. From 6.10, as other PATCHs are added, the spinlock time gradually increases. At 6.12 the IRQ off is ~150ms > and at 6.14, the IRQ off time is ~300ms. > > Run this cmd to test: > dd if=/dev/zero of=/dev/mmcblk0p3 bs=4096 seek=12500 count=256000 conv=fsync > > I use Ftrace irqoff tracer to trace the longest IRQ off event. Here is my test log. Do I trigger a bug? > > 4 Ftrace logs of irqoff tracing on the same environment using the same case only with different kernel version: > 1. Not add the patch 2. Add the patch 3. At 6.12 4. At 6.14. > > Log is here: Do you have CONFIG_DEBUG_VM enabled? Or maybe what's the .config in general? I guess we do more work in __rmqueue_fallback() now under the lock but it should not take *that* long, hm. I'm not however sure if we can split the zone lock holding here. Guess we could at least optimize account_freepages() done as part of __move_freepages_block() -> move_to_free_list() as the migratetypes are always the same so it could be a single pair of calls on an accumulated nr_pages count instead of pair for every page moved. And the loop in __move_freepages_block() could have an extra struct page * iterator instead of pfn_to_page() in every iteration.