From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D2FEEE644C for ; Fri, 15 Sep 2023 09:41:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A375A6B032C; Fri, 15 Sep 2023 05:41:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C0826B032E; Fri, 15 Sep 2023 05:41:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 861F76B032F; Fri, 15 Sep 2023 05:41:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6FB816B032C for ; Fri, 15 Sep 2023 05:41:46 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4958340F89 for ; Fri, 15 Sep 2023 09:41:46 +0000 (UTC) X-FDA: 81238339812.13.9B90ACD Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf03.hostedemail.com (Postfix) with ESMTP id B6ECE20002 for ; Fri, 15 Sep 2023 09:41:43 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694770904; a=rsa-sha256; cv=none; b=Cb3q36q6kODkylGnrG1dj/L0jvGvvxUO2igulGemKEe7Y6T5fuba7G6Fy9cNm21dH9n6fv z5KgupMJH8JXeXx0A965M6U3MWiSGBFfsysHLAvqRun1r0BnsNmvGVDXyR6u3Gd2JN7oFw QAhQ1XC1EIlWG1FfiJ7Th7UDUCUCElA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694770904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ryJX4mCnDrhdpwid1dvScIUvBz+OA+XQGYdwpw/kAoE=; b=3+XDKE506d27jGOeV1Hse9R3zJ8ZzzfpVCHZ6B+FpFsFlWpqsTAvW56LQzQz/G6Qfo5kBe YjscXwTJHM6b1F2f82nStdC9RMTvTI5WbHzQHwtUyAvBhGzFKVSp3ywKToxrKEZkvEitmC WvOX+8o1lc44SLgfvYT0/Zs3RmQtizc= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=17;SR=0;TI=SMTPD_---0Vs6lww._1694770898; Received: from 30.97.48.69(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vs6lww._1694770898) by smtp.aliyun-inc.com; Fri, 15 Sep 2023 17:41:39 +0800 Message-ID: Date: Fri, 15 Sep 2023 17:41:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [RFC PATCH 4/4] mm/compaction: enable compacting >0 order folios. To: Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , Johannes Weiner , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , John Hubbard References: <20230912162815.440749-1-zi.yan@sent.com> <20230912162815.440749-5-zi.yan@sent.com> From: Baolin Wang In-Reply-To: <20230912162815.440749-5-zi.yan@sent.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B6ECE20002 X-Stat-Signature: didxe1ezu1qjrmktjqxd3ziapqtm5bxr X-HE-Tag: 1694770903-471238 X-HE-Meta: U2FsdGVkX1+beJnTovcLH8/2gSbnwZuHBZGimPksW2NlQRdc6iiw2P9sW6XECb9sD47/HJsq2xBAiaC4CYaHdtHNxDBPDj62f1CNeV0q34k3YxcCZez0u+toCvkSkUyFKl8eMo6T0x2Q1/6Noc8e7uFU637/DEudlhiAhbkdyXzDG8S4TxW/iZ/8hX64JwHQOvXqToda104x9VdsFb7T9vm5/YG79GeVdMV/nKBKZ5Vemlops5jy6txAT6wWB3A6mwp+7/a85U9MYgTtagjwS6szStIZ2xbzN6IpXxlQeauG3NMZm5gm/NOIWdIqq97zkRwtMV7OsPxwUNcn+PhEn4UnAMKiNNjsV5QdFYTb+IyYEyTgxDlR8fq/y1OOLdBxmbYkbuTm1uYmYHeq4Ru1Rvdfs4lD1QlF0+brsew9N1rd2n0zwkRfzcrbMeysrhIEkrRhgdJOO0l9k+CLt4ZH0MrR0jAn9jjSfX2x/B3qJUQxnRKH9BDiRfUs9HXU6CKoURtNP/C4u8cEGbVnpC7JT3PtbC6cGUwg7Fq0TvjwdhLta3UgDCZ+zEK0hi6RmsjPibNaRVJAhRncHLjZQyiz3E5TtQALm1aOuRMIC2XgOzGMQoOCaZ5DcnvnP+uVHi/beX08WT2MTktBRkMOyrotgREjhrlin+wMy/yOJh1+11wBpT2sV17os9RyA5dY0TGz7zO0jei6itSqRNsoRjlbFh2b0N9d5TfNQYaKLRCsz/B7rejRiPwTsV8Uyhk1rDJYL3cgTaQt8bqwwPHyoC/tuqq8ocGFwJO4drn7rlZuGV3ePYZhyOUVbySrOYdFtzA1ZbC7uG3lyExQGV/Dp5mWWgwOmtU+83jn15JGyzi7iaFA5kCucksdzn09RMydfQPyV0aJNgTieYDpjWrIwJ0cYYQ+7PkZsh5RW8/opDwnsiPkeV41SD+JKMs29KjgdttSnHlJkYKOA6VU/aeR3cH 52WkMpgt ER94b7NDqxrzAqjI301DWQGGRND35LmHO8R+Kh/l9dIw+tKmR/lkNGkjKjKnL48+9HY1Z2k7xQZ53ox8d1OWqR8PstBa2xMsobRDAfEKvzfly87Pl1cI6euRVM9wrzY7SjJ/2DHXFk02SyvZK9uLcd/1ZZDEtyhT1fYknhBCeBu3XDIp+uy4Bp3gaWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/13/2023 12:28 AM, Zi Yan wrote: > From: Zi Yan > > Since compaction code can compact >0 order folios, enable it during the > process. > > Signed-off-by: Zi Yan > --- > mm/compaction.c | 25 ++++++++++--------------- > 1 file changed, 10 insertions(+), 15 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 4300d877b824..f72af74094de 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1087,11 +1087,17 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, > if (PageCompound(page) && !cc->alloc_contig) { > const unsigned int order = compound_order(page); > > - if (likely(order <= MAX_ORDER)) { > - low_pfn += (1UL << order) - 1; > - nr_scanned += (1UL << order) - 1; > + /* > + * Compacting > pageblock_order pages does not improve > + * memory fragmentation. Also skip hugetlbfs pages. > + */ > + if (likely(order >= pageblock_order) || PageHuge(page)) { IMO, if the compound page order is larger than the requested cc->order, we should also fail the isolation, cause it also does not improve fragmentation, right? > + if (order <= MAX_ORDER) { > + low_pfn += (1UL << order) - 1; > + nr_scanned += (1UL << order) - 1; > + } > + goto isolate_fail; > } > - goto isolate_fail; > } > > /* > @@ -1214,17 +1220,6 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, > goto isolate_abort; > } > } > - > - /* > - * folio become large since the non-locked check, > - * and it's on LRU. > - */ > - if (unlikely(folio_test_large(folio) && !cc->alloc_contig)) > - low_pfn += folio_nr_pages(folio) - 1; > - nr_scanned += folio_nr_pages(folio) - 1; > - folio_set_lru(folio); > - goto isolate_fail_put; > - } I do not think you can remove this validation, since previous validation is lockless. So under the lock, we need re-check if the compound page order is larger than pageblock_order or cc->order, that need fail to isolate. > } > > /* The folio is taken off the LRU */