From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B046DC4167B for ; Tue, 28 Nov 2023 22:34:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25EA48D0007; Tue, 28 Nov 2023 17:34:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 20EF58D0001; Tue, 28 Nov 2023 17:34:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FF9B8D0007; Tue, 28 Nov 2023 17:34:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 007138D0001 for ; Tue, 28 Nov 2023 17:34:04 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C8D4BA03F5 for ; Tue, 28 Nov 2023 22:34:04 +0000 (UTC) X-FDA: 81508817208.21.1D3B5AF Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP id A6383A0012 for ; Tue, 28 Nov 2023 22:34:02 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of robin.murphy@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=robin.murphy@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701210843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=05MQrSEiJJ4PwIrUIYIoHAAbIyjUh5yerDu/CuNJjIM=; b=ut+uwS7ZRdN+qNkdlEUg2SCMDmMbHJXaSQt2ve29vR2I74dWzBt+9hf4pflHY8JcinoWxk JvYfx5savPFzBVKtgnXdRS0+Z/bTDI41K8JdoH0DzP+BEWGkFtDmHvCmI5LUvd9vhLxGDi AwjIlBJ9TkFQdxEOWikkbxZJUJRV9O4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of robin.murphy@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=robin.murphy@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701210843; a=rsa-sha256; cv=none; b=UgFQ9l2qPdzwtQbS9uwZLcBb0qAoZX2R5GTjPU17MRe9T6kfJqL5tC+q0BzQHvGC3KHmom DFqjxWERE/eICJ9XJjXJXhqIQIAp7KSgNw5U0/0M4+Jy0bES7TxFZfpwljI9h/Engv7gYd FOPFNNLM4dA0psZIUs8nmA3Mv9L21UE= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B808B1FB; Tue, 28 Nov 2023 14:34:48 -0800 (PST) Received: from [10.57.71.132] (unknown [10.57.71.132]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E2B473F6C4; Tue, 28 Nov 2023 14:33:44 -0800 (PST) Message-ID: Date: Tue, 28 Nov 2023 22:33:42 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/16] iommu/dma: use page allocation function provided by iommu-pages.h To: Pasha Tatashin , akpm@linux-foundation.org, alex.williamson@redhat.com, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jasowang@redhat.com, jernej.skrabec@gmail.com, jgg@ziepe.ca, jonathanh@nvidia.com, joro@8bytes.org, kevin.tian@intel.com, krzysztof.kozlowski@linaro.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, mst@redhat.com, m.szyprowski@samsung.com, netdev@vger.kernel.org, paulmck@kernel.org, rdunlap@infradead.org, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, virtualization@lists.linux.dev, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com References: <20231128204938.1453583-1-pasha.tatashin@soleen.com> <20231128204938.1453583-7-pasha.tatashin@soleen.com> Content-Language: en-GB From: Robin Murphy In-Reply-To: <20231128204938.1453583-7-pasha.tatashin@soleen.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A6383A0012 X-Rspam-User: X-Stat-Signature: fw1y6rajs4sgwf9atswpoxxr3gujf7fm X-Rspamd-Server: rspam01 X-HE-Tag: 1701210842-776648 X-HE-Meta: U2FsdGVkX1+jATqIfBlhUcxtdD4ISp1w7Ae1l9TouDsxcP3XhW9Dn6VQxJ0T3TIuISdz6l8I1pBqJoUtdfRinPzIPAbYikM5lDT9dhIU3PsMdVsGYnuqDzZbE8EDor5NQqhfgSBgoTEZUfZyHBeAK2jBIJkxsmfR8Q/zNjvtIsodM6YXrHW9zDGmhF+zhiyyYK1ZHqGh3utLIo0fPJwFac2nMA/9cPpfgQy+PI+saeoO2I51ml3tCjAmYZ0xnj+pClMBPZeXoYH79tupgo9kiNzEVHL5B/6NVKlko3NvgijxEU71z8GBTeglRSmtSOpeuaNMFnSPGKrjEdGEWlNqlEzFNSbKqHwUvU4Y0S/7plwO/JMeBun0oOhEKgjX6T+2p390TgLcvjniRlMI8gHS4c+gZdwxFe0MqsH+d0vEVIDdrBfybFo66Viw/I0fjbTtQowbCnxHMdsI88Qc9+dXu6B6uUwQb02a24kFMzqRHy4KEue2F1Py2tVZA5YkfKvDA7GPnyw5wlTVaw6iGV0BdBOhrk18ARbivrp3BkLL3ZxgWVjv73LQCeiMBtJHPibA5expIY5bRZwCz2ZwuiWGwvxfPV7+tc7ddLcDIh9QQ1DuCTgF6LaaCdkUt/fcrtUkKzmI2mXF4PwxHd6iWVFO/5V+RqKcgIzIoK6F/Da9I/UQwF5qLVS5BJ2rqu8Fe9EOlX/lvnGS4/b84QTxilo43aKi70mKi+mXhXhXULugDi4It4llmUVhi8a4cWnjNbZtjilcRjY6dKts5SOgEumFkoLP5T5w4sWTiEKpCi7j4zbv/Q329V59eWaWLLMegWwgbPsu/HH2PVvJVBv52bfv9cP1TPLq7dnwDm8kJa/RaVgw2HcBfSLHBjepL1+cDfuSup96wqCjuhby1qhtdg0f7WvwySsbRpCkkym1aWQMbR2Dt4Hx3JooeJgO5QA8f1J0eEg/yyCxR2K1tKea9It P9kwsuUB Eyin3wkcCUQrdHEfmYnukgkaXv/AMa4uING7m2ZkB7BPJcQOIvN0X5zgwlJYFt5CaVYfdsRJVcoPDoOwwVHKKHd3eY5uLNAPxpsbBDFRM7GKuJ61xkYiSvuwCSSX7q+4Bn7rMB5mFykFuvwA0T0v6No1etGIFsEA7hWS9ZzBSOc/ED30roQ7aifR21+vbNdM3vbHsB3eo1+aWa/vzxXd7mnLyL9IeEhPXJG1JXQTE4XjlKDiIr3Yg7Ij98FI2DDwywOlR1Do6IHDtWkHFu5Ujn5hZHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023-11-28 8:49 pm, Pasha Tatashin wrote: > Convert iommu/dma-iommu.c to use the new page allocation functions > provided in iommu-pages.h. These have nothing to do with IOMMU pagetables, they are DMA buffers and they belong to whoever called the corresponding dma_alloc_* function. Thanks, Robin. > Signed-off-by: Pasha Tatashin > --- > drivers/iommu/dma-iommu.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c > index 85163a83df2f..822adad464c2 100644 > --- a/drivers/iommu/dma-iommu.c > +++ b/drivers/iommu/dma-iommu.c > @@ -31,6 +31,7 @@ > #include > > #include "dma-iommu.h" > +#include "iommu-pages.h" > > struct iommu_dma_msi_page { > struct list_head list; > @@ -874,7 +875,7 @@ static dma_addr_t __iommu_dma_map(struct device *dev, phys_addr_t phys, > static void __iommu_dma_free_pages(struct page **pages, int count) > { > while (count--) > - __free_page(pages[count]); > + __iommu_free_page(pages[count]); > kvfree(pages); > } > > @@ -912,7 +913,8 @@ static struct page **__iommu_dma_alloc_pages(struct device *dev, > order_size = 1U << order; > if (order_mask > order_size) > alloc_flags |= __GFP_NORETRY; > - page = alloc_pages_node(nid, alloc_flags, order); > + page = __iommu_alloc_pages_node(nid, alloc_flags, > + order); > if (!page) > continue; > if (order) > @@ -1572,7 +1574,7 @@ static void *iommu_dma_alloc_pages(struct device *dev, size_t size, > > page = dma_alloc_contiguous(dev, alloc_size, gfp); > if (!page) > - page = alloc_pages_node(node, gfp, get_order(alloc_size)); > + page = __iommu_alloc_pages_node(node, gfp, get_order(alloc_size)); > if (!page) > return NULL; >