From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB480C5B559 for ; Wed, 4 Jun 2025 16:26:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2455A8D002B; Wed, 4 Jun 2025 12:26:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21D108D0007; Wed, 4 Jun 2025 12:26:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 133C48D002B; Wed, 4 Jun 2025 12:26:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EEEC58D0007 for ; Wed, 4 Jun 2025 12:26:50 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9EC8E141BB3 for ; Wed, 4 Jun 2025 16:26:50 +0000 (UTC) X-FDA: 83518246980.20.A5A3F06 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by imf10.hostedemail.com (Postfix) with ESMTP id CA167C000B for ; Wed, 4 Jun 2025 16:26:48 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LMuzPCvW; spf=pass (imf10.hostedemail.com: domain of hughd@google.com designates 209.85.160.47 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749054408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ll3GQZZx1aAM5fgTmVcrO9i0nGXI4VPhhW9oOfi4ATE=; b=wf7sPh/OuI/Go/BVuDGwySjCqvpKBnDaDBEywLnUN0cIlML6LNyHdyb/ixulHnxOrTiQQN DtjPW/d0+zu/fJJM7CkAnEcO0SJTkJgV8OwKdMXV0CWAKr3WtDQ8OMowZZqmfBINyOaMZq EYS8OLAOB6nSuctrqAFMPJhRL7VVFCg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LMuzPCvW; spf=pass (imf10.hostedemail.com: domain of hughd@google.com designates 209.85.160.47 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749054408; a=rsa-sha256; cv=none; b=3ldcYcfHt/a+H1DqdMVucPpRtvTh3x72rHGVn2t5sFWVfNwTowiCLXAslRTp5Mm2Tad4WP +I/qFjD6c9dhgTj97ZVFmcWRUJWhOP0mqWC2ABGRF6qPwQx38AE4II1RScEo9Q42ts99w7 A/ltzCUVQvvlT0dveJphRiGi3OivSJc= Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-2d0d25cebfeso68461fac.2 for ; Wed, 04 Jun 2025 09:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749054408; x=1749659208; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=ll3GQZZx1aAM5fgTmVcrO9i0nGXI4VPhhW9oOfi4ATE=; b=LMuzPCvWPXA1QQYPUgHuT9UUwGAJKWWGdu73ZUmiH0kuWGpEvmujg9TPtCZMqEGB+E VChaXaPAvglMe1ABPAEafcQBqTVc+UW6jAK7oFEXMAczKAdy6UujboEvHbPQupQYuz7V hj0koaCa9izAZDIeiqlr6PPYC7gPZhxPUxMJcWYxoA8TW7ASz3/5hxGnV/ILrAR+3L7b C12HB+15atWmsO5kySonUxs1a5KzxX1Ppgr/R6J8ez2zmRUp8nIrwKDPeEKJa2woq4Kv WNkUzlJk5U6PNM/uSzyPXYAtvNVJup942GtXBnFUiP6NsaiFzXyMiRDGSVEbM4wyrFIX UDnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749054408; x=1749659208; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ll3GQZZx1aAM5fgTmVcrO9i0nGXI4VPhhW9oOfi4ATE=; b=ZVBp/trt61zjNhmg7UHKM9KhfsZcRCK22blf+nMHcsBj6zlqddp2OF7Od1nn6nsCe4 a1RsLokm9omcj4GG4Ib7XLp4plddSzK5/k7fmLtlM96N9NnCgvFzu1EKNLFNPHQHScAV l3RGiFkQRpy5c5sDIhfSb5WwPafiIhXUJPT7AeBAjhtUeTeJ7aT5XJh48KUl7iaR/0cS lcIGEJjPwzUjX+9nXvjfJGoIWoou1fwohF6iMKWCDBS/7elSgDp+11oXnfHphzLTnBu6 +jO2UMps81ZpPYw/cKjxJ72L9pyWZcRoMzDoye6j7SEo/EwwM6Z57KmmMONht8qfUdf2 RQJw== X-Forwarded-Encrypted: i=1; AJvYcCVg4dG/cErWphZd5FMIUCB9U/KpJ5JygA9B+uBjijF41mcdkBLtfOzSLm7vQs+Ra6GfMfZYY6bBSw==@kvack.org X-Gm-Message-State: AOJu0YyiJv8TzALgGhyZgX7ZZpkwCDjRCjZ81PUexMlqyD6DCj/4o6Rd JhIscm6nfxUHNhFX75xf/6PwA3RDtaxFfgHVRTqFdv5kPocszuC3oUZWSx7/EkEgw6b2IpofsUw QlTMIbQ== X-Gm-Gg: ASbGnct2CUFmSsN55gdUbXED9sG1wnjqfsN9xrvtRSxwwIdZ2znWuU5QaavzRlj4R/8 xFBGqmaGusIFbXY4dxaXCqZycSHzj3eME5U+TnxwQlob6dbLblyOOdNKZS3Gk4tmlJ8R0AStmBz KGw8Ryld8CQEk02M527s/bD0bU164w1Y7BYBONQfCMuMwJhkaeVtevooMlzRQKmLAPKs8yeayz5 RQy3PojLFgv2EENZ5Mte5xT2kWPIRu5hi6mJAkwCyoVWeXgpyYhHn5RN/caED25G7NG/+D5oTIy f5kVIFZGBPeZSes1B5h1lrpsyKw0kTXsFupQboMt4pkeBPjnoDHkWrBU0pCeydquQSaGkgaLmih q7DKoFhKAWmokGCFVB+/Zg0MzJ0fd7uICq4CH/eTCiGDsXY9qyaThWaVo X-Google-Smtp-Source: AGHT+IGSJuYZ5PsSec3GKgHBhYBIFvpgIeA062k15kkewiYaZixAYmRU9waq5Y86IJBjw0vOZ1huZA== X-Received: by 2002:a05:6808:99a:b0:408:e711:9a8 with SMTP id 5614622812f47-408f0f68e39mr2160313b6e.15.1749054396518; Wed, 04 Jun 2025 09:26:36 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40678d038c0sm2244681b6e.46.2025.06.04.09.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jun 2025 09:26:35 -0700 (PDT) Date: Wed, 4 Jun 2025 09:26:21 -0700 (PDT) From: Hugh Dickins To: =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= cc: Steven Rostedt , LKML , Linus Torvalds , Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , Christian Koenig , Huang Rui , Matthew Auld , Matthew Brost , dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: Re: [PATCH v2] drm/ttm: Fix compile error when CONFIG_SHMEM is not set In-Reply-To: <6b3a37712330ec4b17968075f71296717db54046.camel@linux.intel.com> Message-ID: References: <20250604085121.324be8c1@gandalf.local.home> <6b3a37712330ec4b17968075f71296717db54046.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463770367-1698767313-1749054395=:6218" X-Rspam-User: X-Stat-Signature: cfbe7fk4q7pkqndwoeyhdpwfrd65y1es X-Rspamd-Queue-Id: CA167C000B X-Rspamd-Server: rspam11 X-HE-Tag: 1749054408-328719 X-HE-Meta: U2FsdGVkX1/NBshxblMsuyusGfMPmJUnogOo5JD7q8iSSbHP8YzBNeeW6XGS+18mGCW3GUVlTZ+TluUyiX0opKbHouOUMs3n4HmU1ez8j/7FltpIgMhNU+aYJgfvdN3AJA6Pk10OG3H/cULosgIDL6mW+22qlNwy4vU42pc1dXMbsUxWOVimnbbwhbguEGmtXXZTGZwzm0fZv1HgHX9xJ2FE53Jc3Sc/STO3lju7mfa3aH53ZAHtNO4KO2qzvT1TaksXPvKLqBIs1wdD7RBDeTcyh/aV0E1m0mHqKZtye3Z5G8uGObgxKfrKFeiODTw0JVZZ9s3yaIXygfff6jA5iP/j3UIN2L/b1zc6k2oEzkuSwRznBjQ8jIood6DCkcUurtptBrYQfqc7w4UsNXve79Ew0HDLGYmbJisfKXHAe7VLHHF0tp0Z7VfLqSvQG044YRahrhfNBCugWl2G2Ngatgud6XFxyh9kwyY9AyrY2++7VfOCMPmEMZVg5rjd9WnlD+fgSz8Tj1d8jn7oXJh6++HOKiKKRlei6ExAc8sGvrDWp8PcrGjtgdJ3PhPJj9AMHYMRR+iVRi3OtRbYzbNq8Roh9as1BCJwqqsbH4U/YejYAcf7BXeYz4pEfvllH4wpfm42eRsE8XAGKQYXa9GocafvY9eYR5TBwo7Lv0uCnSFlaY4xuD529cKwgzpTYsHSQ3EnR29MIQqJixImVn8x5VI0dK/62mMH8AeKAo1bLNL76OVfMBmPtyMw6QigWfRveTN917dJdW6TJxsQNbBtkIdMxLx36ER9Ndpcu6zZ9Eg7F8S9ON96XNB3fC4zuCSBQzSt78cuY7eh1P/4VbBrQaHelSw3OhVCaUB+LQC/PHaAJUG6O+Zyv2oeqjSQJr+5gQFR2nGy05UpflPgzEcXbzSDfJ0xaW7+7lSQqX3SRAW9Zz6wqlFMFUlJw0nka4SMsRv/9QLU6uV8Awn0qzn 3L3InjeD LzJ1puqo6K4SotDDG+CAhiaV52j7N3JxEy4udJ+XfQy/6iWvTQbCbl0fS/3JyfSwxKlfd8z6iMooYFJPjUebp7f9DkJZoTmilCKbHVnZhomZ7GzpO3D8iqcIQJ+t/I4bNGX83fhRok8MTy5sayOR6bWUJXmpMHN47HAl1Ts5qxHASazRcBNbSERovnrPe3LCQHjdDPsTbWPBbKib1ATsaKy5GXHkGFxS7nXR+Lg6wf5RwooVz6PKbu+n98vNJaIsMuVCo7rzwBkKqqfNUDpDlhp3jSzivx3nXXzKu5OideCVHBDX8+LRd1hQEJ2eOqT7fK1s5pQMGc5MxJkjpzua13mTqB0rVlFWS2g2TEG/bPEyZsclAa5qMDXDeaPY3tpSY51lhsdrZ+uHZn/2HABYDa/+NzLPSV7dAhfRa/YLleXxoaaHm2724b6J8Ot1K63B++6K+aj/MoZl/SYzpTJfP6iFdcS6cBb+HuUlqffYDrsR0+tcfjlZmnKP9OV23JqUrHmWF553tMNtsiMt0dUJcpoQkjOAEYYsbGdhSycym7o0FSXednvq1NQ5o2yMYfpPMHXR/G5rHJuoBKws= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463770367-1698767313-1749054395=:6218 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Wed, 4 Jun 2025, Thomas Hellstr=C3=B6m wrote: > On Wed, 2025-06-04 at 08:51 -0400, Steven Rostedt wrote: > > From: Steven Rostedt > >=20 > > When CONFIG_SHMEM is not set, the following compiler error occurs: > >=20 > > ld: vmlinux.o: in function `ttm_backup_backup_page': > > (.text+0x10363bc): undefined reference to `shmem_writeout' > > make[3]: *** > > [/work/build/trace/nobackup/linux.git/scripts/Makefile.vmlinux:91: > > vmlinux.unstripped] Error 1 > > make[2]: *** [/work/build/trace/nobackup/linux.git/Makefile:1241: > > vmlinux] Error 2 > > make[1]: *** [/work/build/trace/nobackup/linux.git/Makefile:248: > > __sub-make] Error 2 > > make[1]: Leaving directory '/work/build/nobackup/tracetest' > > make: *** [Makefile:248: __sub-make] Error 2 > >=20 > > This is due to the replacement of writepage and calling > > swap_writeout() > > and shmem_writeout() directly. The issue is that when CONFIG_SHMEM is > > not > > defined, shmem_writeout() is also not defined. > >=20 > > The function ttm_backup_backup_page() called mapping->a_ops- > > >writepage() > > which was then changed to call shmem_writeout() directly. > >=20 > > Even before commit 84798514db50 ("mm: Remove swap_writepage() and > > shmem_writepage()"), it didn't make sense to call anything other than > > shmem_writeout() as the ttm_backup deals only with shmem folios. > >=20 > > Have DRM_TTM config option select SHMEM to guarantee that > > shmem_writeout() > > is available. > >=20 > > Link: > > https://lore.kernel.org/all/20250602170500.48713a2b@gandalf.local.home/ > >=20 > > Suggested-by: Hugh Dickins > > Fixes: 84798514db50 ("mm: Remove swap_writepage() and > > shmem_writepage()") > > Signed-off-by: Steven Rostedt (Google) > > --- > > Changes since v1: > > https://lore.kernel.org/all/20250602170500.48713a2b@gandalf.local.home/ > >=20 > > - Instead of adding a shmem_writeout() stub, just make CONFIG_DRM_TTM > > =C2=A0 select CONFIG_SHMEM (Hugh Dickins) > >=20 > > =C2=A0drivers/gpu/drm/Kconfig | 1 + > > =C2=A01 file changed, 1 insertion(+) > >=20 > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > > index f094797f3b2b..ded28c71d89c 100644 > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > @@ -188,6 +188,7 @@ source "drivers/gpu/drm/display/Kconfig" > > =C2=A0config DRM_TTM > > =C2=A0=09tristate > > =C2=A0=09depends on DRM && MMU > > +=09select SHMEM > > =C2=A0=09help > > =C2=A0=09=C2=A0 GPU memory management subsystem for devices with multip= le > > =C2=A0=09=C2=A0 GPU memory types. Will be enabled automatically if a > > device driver >=20 > Reviewed-by: Thomas Hellstr=C3=B6m Acked-by: Hugh Dickins Thanks a lot! ---1463770367-1698767313-1749054395=:6218--