From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD6EFC433E0 for ; Tue, 9 Mar 2021 00:42:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 405FE65275 for ; Tue, 9 Mar 2021 00:42:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 405FE65275 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BB5AC8D00A2; Mon, 8 Mar 2021 19:42:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B65928D007F; Mon, 8 Mar 2021 19:42:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A05EC8D00A2; Mon, 8 Mar 2021 19:42:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id 84B638D007F for ; Mon, 8 Mar 2021 19:42:32 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 48F00181AF5EA for ; Tue, 9 Mar 2021 00:42:32 +0000 (UTC) X-FDA: 77898484944.07.D839523 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf21.hostedemail.com (Postfix) with ESMTP id 012F0E0011C4 for ; Tue, 9 Mar 2021 00:42:29 +0000 (UTC) IronPort-SDR: Ca4pfCrSm3nZnv5KQr1rEeQY4kbh28I9herU2IOJjqK7ZrBnsoEaXylwg4RzMOU4pWJIgtlVU/ yS3DXn1Eh1cA== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="184768331" X-IronPort-AV: E=Sophos;i="5.81,233,1610438400"; d="scan'208";a="184768331" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 16:42:29 -0800 IronPort-SDR: StTEf6YiRf8FOCI3WurmyAfyK6jvUGJrlrIAvcdaKRUoGTowH8OTH+tNAMjKKGGnwp/2zbmIm7 6VyEyWuzTKsA== X-IronPort-AV: E=Sophos;i="5.81,233,1610438400"; d="scan'208";a="409512751" Received: from shao2-debian.sh.intel.com (HELO [10.239.13.11]) ([10.239.13.11]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 16:42:26 -0800 Subject: Re: [kbuild-all] Re: [PATCH v2] mm: page_alloc: dump migrate-failed pages To: Minchan Kim , kernel test robot Cc: Andrew Morton , kbuild-all@01.org, Linux Memory Management List , LKML , John Dias , Michal Hocko , David Hildenbrand , Jason Baron References: <20210308202047.1903802-1-minchan@kernel.org> <202103090555.LtLPf1Ho-lkp@intel.com> From: Rong Chen Message-ID: Date: Tue, 9 Mar 2021 08:41:44 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 012F0E0011C4 X-Stat-Signature: ux973xgx6tq3kgsjjyzi3en7irwm7b9i Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf21; identity=mailfrom; envelope-from=""; helo=mga11.intel.com; client-ip=192.55.52.93 X-HE-DKIM-Result: none/none X-HE-Tag: 1615250549-592272 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/9/21 6:29 AM, Minchan Kim wrote: > On Tue, Mar 09, 2021 at 05:29:30AM +0800, kernel test robot wrote: >> Hi Minchan, >> >> I love your patch! Perhaps something to improve: >> >> [auto build test WARNING on hnaz-linux-mm/master] >> >> url: https://github.com/0day-ci/linux/commits/Minchan-Kim/mm-page_alloc-dump-migrate-failed-pages/20210309-042205 >> base: https://github.com/hnaz/linux-mm master >> config: m68k-allmodconfig (attached as .config) >> compiler: m68k-linux-gcc (GCC) 9.3.0 >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # https://github.com/0day-ci/linux/commit/3c635af37b862e9c601ee8d5818f7da9cd3e2e57 >> git remote add linux-review https://github.com/0day-ci/linux >> git fetch --no-tags linux-review Minchan-Kim/mm-page_alloc-dump-migrate-failed-pages/20210309-042205 >> git checkout 3c635af37b862e9c601ee8d5818f7da9cd3e2e57 >> # save the attached .config to linux build tree >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All warnings (new ones prefixed by >>): >> >> arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] >> 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) >> | ^~ >> include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' >> 78 | # define unlikely(x) __builtin_expect(!!(x), 0) >> | ^ >> include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' >> 143 | BUG_ON(!virt_addr_valid(buf)); >> | ^~~~~~ >> include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' >> 143 | BUG_ON(!virt_addr_valid(buf)); >> | ^~~~~~~~~~~~~~~ >> In file included from arch/m68k/include/asm/page.h:60, >> from arch/m68k/include/asm/thread_info.h:6, >> from include/linux/thread_info.h:38, >> from include/asm-generic/preempt.h:5, >> from ./arch/m68k/include/generated/asm/preempt.h:1, >> from include/linux/preempt.h:78, >> from include/linux/spinlock.h:51, >> from include/linux/mmzone.h:8, >> from include/linux/gfp.h:6, >> from include/linux/mm.h:10, >> from mm/page_alloc.c:19: > I am not sure this is triggered by the patch since I could see the > warn with reverting the patch. Hi Minchan, Only the lines prefixed by ">>" are related with the patch: >> mm/page_alloc.c:8348:5: warning: no previous prototype for 'alloc_contig_ratelimit' [-Wmissing-prototypes] 8348 | int alloc_contig_ratelimit(void) | ^~~~~~~~~~~~~~~~~~~~~~ >> mm/page_alloc.c:8353:6: warning: no previous prototype for 'dump_migrate_failure_pages' [-Wmissing-prototypes] 8353 | void dump_migrate_failure_pages(struct list_head *page_list) Best Regards, Rong Chen