From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A2BEC77B7C for ; Tue, 9 May 2023 07:43:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F47228000F; Tue, 9 May 2023 03:43:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A4C1280001; Tue, 9 May 2023 03:43:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76D7128000F; Tue, 9 May 2023 03:43:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 641B9280001 for ; Tue, 9 May 2023 03:43:15 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BDF5D809EE for ; Tue, 9 May 2023 07:43:14 +0000 (UTC) X-FDA: 80769925908.27.C931633 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf02.hostedemail.com (Postfix) with ESMTP id E78A68000A for ; Tue, 9 May 2023 07:43:11 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=hjl2Wdrf; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.46 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683618192; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7TrcVCLLeakLJesFm7MY9BVBUFJFOgospV/GjEA6xZc=; b=eh/L8mAVaQqV/fIx5dr0RAOuHCxWZm9aFBTgcQS+mcGgqHXi5mDdc78BInVEtdoUHW8Fj6 s8wCP76kDH1P+CwDQIz+UBxgswQrbY/WXEmP6ZGir4VtKfjYxA/LkTOHgzPg7SibNX36ZL DtreRXsze+Clu1NOv7TVgfbCA/tXhIU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683618192; a=rsa-sha256; cv=none; b=sgFvXmgd4phCiBKwzXLemADMYxoyYfriKcPLlnoG+S47d30Rw+lOwtbqkj1CWomwLZD7yO wQ44FkcSVklG9qAdEV0P3kQWYc4HfeObXs1QowXfApQHLHoY653wnnqu/yFW/qj2vK7bZ4 ppG9X9LoGyixAQ5RxKlwRvxv9JzjoZQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=hjl2Wdrf; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.46 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-30789a4c537so1843202f8f.0 for ; Tue, 09 May 2023 00:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683618190; x=1686210190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7TrcVCLLeakLJesFm7MY9BVBUFJFOgospV/GjEA6xZc=; b=hjl2Wdrfx/W6pgJ76OORur6lUmD0pBPq+MkK7zPQB07soBsqUFMCkpZtSNvzmAsJfu A9LKDEOFthOIKt6hYU6I5tPHQ1rsOwDcZAWs3sUdOSMFtYvq2Qnm+PwBqLeFMaFGxnzk jMIRT16hEdMPKnkC2HlvvgKwQrrksBtscHLpBCLBGFYuJvUAYr1KJymYf/bspVWAxFKg KSz2nCNmNhkqbST3N+KLxjhUFiazAAcO8VrFQvA66vuKxt42jiKNTfwkOwjcHePnMpnX 68zmbR5v0T6wynYc2eWJlW97rE0qgzdM/frgbJT5RKSVn6Z5RavM9UxF4f/2FEkkLqb0 sOVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683618190; x=1686210190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7TrcVCLLeakLJesFm7MY9BVBUFJFOgospV/GjEA6xZc=; b=BA8SrCB4paAMekvVP4H5/Db2mXKs1XnNr40kR/J2j2AnDN/Om+bbYpine1/bONEsoa MedTgGzGTzMMqwhT/zecGOsx75A3KpgZbG2yWv8aVtGRO980OHVz1+lfYyRTENPtaz3o Xjnvmye9v7C5nXnXzNgvKq7+CPnvV4Rm8n6Z76LS9sZJy0kSbzdi9Yn6ra9KUz3KW28p ZOXTvF0fgLsmioOWARR+BqgozfAtcgsCNAfbuqhjNYqy7m23s8Aq0jQLBxqVQtmOxz7M jiwFOm/IuYbMmSGjcaaZf44EH29kOS/7JQGfkhM3ZIIUs1w1Ytf9RfLaXMzunvV7C0FE fSIQ== X-Gm-Message-State: AC+VfDwCmjkNBFFBg361FR4pO33v3y/EztK9YYlyINK+U5ty1k2f/vWc 31gOCvJqNw1nbOPqXS00a5ZflA== X-Google-Smtp-Source: ACHHUZ7thWP8DO0O78r31AKPH9qWoZ/xHhiRvZurWaKmoSBGyax65xewo4yTwTPIjxY2BmFNOu/+KA== X-Received: by 2002:a5d:43c4:0:b0:2f0:2dfe:e903 with SMTP id v4-20020a5d43c4000000b002f02dfee903mr9646567wrr.69.1683618190399; Tue, 09 May 2023 00:43:10 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id p6-20020adfe606000000b002e5f6f8fc4fsm13500872wrm.100.2023.05.09.00.43.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 00:43:08 -0700 (PDT) Date: Tue, 9 May 2023 10:43:05 +0300 From: Dan Carpenter To: Andrew Morton , "Matthew Wilcox (Oracle)" Cc: Linus Torvalds , Josef Bacik , Johannes Weiner , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, syzbot+48011b86c8ea329af1b9@syzkaller.appspotmail.com, Christoph Hellwig Subject: Re: [PATCH] filemap: Handle error return from __filemap_get_folio() Message-ID: References: <20230506160415.2992089-1-willy@infradead.org> <20230506104122.e9ab27f59fd3d8294cb1356d@linux-foundation.org> <7bd22265-f46c-4347-a856-eecd1429dcce@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7bd22265-f46c-4347-a856-eecd1429dcce@kili.mountain> X-Rspamd-Queue-Id: E78A68000A X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: 9mfw9f6xr5pzt9kome3exjsndifm1jha X-HE-Tag: 1683618191-342534 X-HE-Meta: U2FsdGVkX1+AD20+FxT/auV8hkstWskqBMKxUN4Y6Kl+YcF0pM23FSf5TEPiioBGrzqiqOVr+OdwXqFXCwOv6OD2bhpsrxDWUf33hrM28wtpVvu20D7ofVwigiFvOnn7/FB+7+2nanxSRAWYeD6dIqtmdswAxlB9zBI95Ls9ARjQTX1aG2d+v+oZDr8HXuZjHqeECbOVmXmjQX1XFa7sZgy0ioiRyIMpoPslEkWl1ED6xcCkWXNkPyiD90WWScrLgW+gwvPtjqSK3H4qbADG0d3cKDrG9LV9IP7JP7kkbQrY4hxZJt5coUua4Q/7En5RIbXcoRD2nB/3jcBX8VowRsfOJakhH/hP57+cCs3zRWjQItQpgrJEpsY0IYvYua0UxGpIW13thr2LW5ZBhRFhHNFZOujQPPFba6VLPZ8a76+dkuv1nz/Y73EQ+ImKADDFJxETl35HxRwBgwXKjgQQ3OvSwBeBIfAi3XYs31ijaKWX9tIpKxCusnhUkRmC/X2bNijBTshKHN77OaQzWFSnXxNmsmTx9Q+90hgJeFa7DF+u/3NaDqL+0vQ5P6xr2/6ZtOvFxiBElj2IqKqwQ34uJBsXTKERLsy8m+mIOBCvxm3s2ma37awrSejdjl55iP6zsb2rUq7bESOZGq7n67iv0PkqN/qokVX2t/A4YdPQtRWivpiKWux7grEmF0ajaWzSnBfhqCoRziQb64ZtOguaMTUTdo7Cm4z+cX1PPE0urdlZGYbP+PiAMTycOh8fiNg8sRVSAip0vxK6q/iFSom9gBmn7xGe4Rx5MoNeyRTbWYJ1xgBSecZC3g9sW093uh0cvnYJG6DbR5pxxhScouvcIdCKV3y6FltaXxcO/j9mHmSTuKcPY5GyqsT9uuiT9O84oLy0z5njje7V411C6N209uIFluJQgW5TK8Kkqu40UB6i9SzyKCq2AVuW6SR9FlpnKZo/9cuSDfntK5BIC/S P9T5Kmf8 iAH9vYA+IDbgbwyz+euq/PSZz5MtJJEkdSjUPlggA4V/g6SMral7444/ANIwT5bmgzg7+XntDP9lDXp7T2bDRKgBgm1Dh6uq0q14JyyLx8Uby/ABLQKV+RHcY3lgXcWjGO5KqjDrXyGM3EuGQLiDC+9nSR+4slr56NiZZS8YGluhUwMdWpsbqatpsz6OqqCG7LTnJukpfzGRqs9mXlqYLo7EaqVWIyqaI69MIRtVU0QAJkDmXTC85Frq1ofO9zNF1Cp7SdUhJ6sgAwYd8IbUEEk3FOygfLRT+MPtJvSPlsw0QoTCV5h4ms+UpE+GoKebDLOyALi25OQU6zeN4gmeTdsfFktTAEHj+XTnYrNi3rDSJETaALkm2MRZqW8FjK/OIvAugXuX1OpTXmMWCx613sDA2B6SAOoSOthlTP7jflMyA+PKy9SVZ8TLoLxN30BZ2kIAq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > 1) There is an existing check which complains if you have "if (p) " > where p can be an error pointer, but not NULL. If I revert the fix, > I get the correct warning now. > > fs/afs/dir_edit.c:242 afs_edit_dir_add() > warn: 'folio0' is an error pointer or valid *NEW* I ran the new code last night. There was one more folio bug (but every function in the call tree triggers a warning). fs/nfs/dir.c:405 nfs_readdir_folio_get_locked() warn: 'folio' is an error pointer or valid fs/nfs/dir.c:1000 nfs_readdir_folio_get_cached() warn: 'folio' is an error pointer or valid fs/nfs/dir.c:1019 find_and_lock_cache_page() warn: 'desc->folio' is an error pointer or valid Other new warnings. Mostly harmless checks for NULL. drivers/usb/host/max3421-hcd.c:1913 max3421_probe() warn: 'max3421_hcd->spi_thread' is an error pointer or valid drivers/block/aoe/aoecmd.c:1259 aoe_ktstart() warn: 'task' is an error pointer or valid drivers/target/target_core_fabric_configfs.c:482 target_fabric_make_np() warn: 'se_tpg_np' is an error pointer or valid drivers/media/i2c/rdacm20.c:641 rdacm20_probe() warn: 'dev->sensor' is an error pointer or valid drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c:291 test_vcap_xn_rule_creator() warn: '__right' is an error pointer or valid drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c:1349 vcap_api_encode_rule_test() warn: '__right' is an error pointer or valid fs/configfs/dir.c:1339 configfs_mkdir() warn: 'item' is an error pointer or valid kernel/cgroup/cgroup.c:5542 css_create() warn: 'css' is an error pointer or valid sound/soc/apple/mca.c:955 mca_pcm_new() warn: 'chan' is an error pointer or valid sound/soc/apple/mca.c:961 mca_pcm_new() warn: 'chan' is an error pointer or valid lib/test_kmod.c:320 try_one_request() warn: 'info->task_sync' is an error pointer or valid lib/test_firmware.c:918 trigger_batched_requests_store() warn: 'req->task' is an error pointer or valid False postives based on my .config: fs/ceph/cache.c:100 ceph_fscache_register_fs() warn: 'fsc->fscache' is an error pointer or valid fs/erofs/fscache.c:354 erofs_fscache_register_volume() warn: 'volume' is an error pointer or valid False positive because of a bug in Smatch: fs/overlayfs/readdir.c:906 ovl_dir_fsync() warn: 'realfile' is an error pointer or valid regards, dan carpenter