From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Qian Cai <cai@lca.pw>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Michal Hocko <mhocko@kernel.org>,
akpm@linux-foundation.org, hannes@cmpxchg.org, elver@google.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_counter: fix various data races
Date: Wed, 29 Jan 2020 22:09:29 +0900 [thread overview]
Message-ID: <d98acf1e-ef0a-035f-2d7c-e22bc4c874bd@i-love.sakura.ne.jp> (raw)
In-Reply-To: <2D795DB7-66FE-4F01-872F-F8ACAE9505EF@lca.pw>
On 2020/01/29 21:25, Qian Cai wrote:
>
>
>> On Jan 29, 2020, at 7:13 AM, Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote:
>>
>> By the way, can READ_ONCE()/WRITE_ONCE() really solve this warning?
>> The link above says read/write on the same location ( mm/page_counter.c:129 ).
>> I don't know how READ_ONCE()/WRITE_ONCE() can solve the race.
>
> That looks like a different one where it complains about c->failcnt++. I’ll send a separate patch for that.
>
Ah, then this patch is meant for mm/page_counter.c:138 versus page_counter.c:139 race which was
closed as invalid at https://syzkaller.appspot.com/bug?id=871391ec080746185a2dd437c54d75fcd1ef0ef8 .
next prev parent reply other threads:[~2020-01-29 13:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 10:52 Qian Cai
2020-01-29 10:57 ` David Hildenbrand
2020-01-29 10:58 ` David Hildenbrand
2020-01-29 12:03 ` Michal Hocko
2020-01-29 12:13 ` Tetsuo Handa
2020-01-29 12:21 ` Marco Elver
2020-01-29 13:47 ` Tetsuo Handa
2020-01-29 12:25 ` Qian Cai
2020-01-29 13:09 ` Tetsuo Handa [this message]
2020-02-11 12:14 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d98acf1e-ef0a-035f-2d7c-e22bc4c874bd@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox