From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 562D7C28B28 for ; Tue, 18 Mar 2025 10:30:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71301280003; Tue, 18 Mar 2025 06:30:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C331280001; Tue, 18 Mar 2025 06:30:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56414280003; Tue, 18 Mar 2025 06:30:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 38425280001 for ; Tue, 18 Mar 2025 06:30:05 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2B8AD120DEC for ; Tue, 18 Mar 2025 10:30:06 +0000 (UTC) X-FDA: 83234301612.17.4DF93FA Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf21.hostedemail.com (Postfix) with ESMTP id 220C21C0010 for ; Tue, 18 Mar 2025 10:30:03 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf21.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742293804; a=rsa-sha256; cv=none; b=EKw9aQh4cLcAsgyvNIS+XmxLcj0XuDUgZJmZtFtJ0feyPDyWI4WCgfp5kKllKNmUM9HISm T0yERB2PUTnP9VieBWlMV+d8SMgOsjjPUJ7PAymxpHeqKssrz76+2aMBN0b+57zsiBc58d 5wH/pdyAMF27S7XThdi8XvAAWCLnBPM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf21.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742293804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yqciVy72D8Qj34K7UOqFS1RmZdRxzP57UvR/z4vSVt4=; b=j/gfWl3fHnxJanFAflhKLnrWt+srug0/Zl9suHJhjqkT3XG9lTBrVxg/sgjMWbKrTmSFJd MF6twkfZVUVhmAiI4klJLLj+GB0YR8xzhQUwQlAqlkT1NOkdsIwzZ2gfOY6iTZhn+ASPkj R4B/RTApTYWh/cMKW7Fw4rTt3511DHk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7A20A152B; Tue, 18 Mar 2025 03:30:11 -0700 (PDT) Received: from [10.163.44.33] (unknown [10.163.44.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A8CE93F63F; Tue, 18 Mar 2025 03:30:00 -0700 (PDT) Message-ID: Date: Tue, 18 Mar 2025 15:59:57 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Anshuman Khandual Subject: Re: [Patch v2 1/3] mm/memblock: pass size instead of end to memblock_set_node() To: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org, yajun.deng@linux.dev Cc: linux-mm@kvack.org, stable@vger.kernel.org References: <20250318071948.23854-1-richard.weiyang@gmail.com> <20250318071948.23854-2-richard.weiyang@gmail.com> Content-Language: en-US In-Reply-To: <20250318071948.23854-2-richard.weiyang@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 39qpurrnz9dyp3oiror641maqp6q4fm9 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 220C21C0010 X-Rspam-User: X-HE-Tag: 1742293803-164287 X-HE-Meta: U2FsdGVkX18YNQuA4HDnozGe6T8cHlJe5F/XPACXcXCenNvD+TMyP86DBMT9DrJ+ZvFED1zvDemHf3TzjBnPmqx5eMjm71gsrmcFuFJgOUX9Ncj3/wlyy3Vra0Alx8dzKY7Ymhm9KCd1Xt2XcWKxsy/3HROVdc1d6xjpHiQLPhpT/6xTERrRsRLrKp+9lDgPrV7s78RP+Y4OL4ouGYJ9x/OCfY01RiDi/pkCgB+YN2i3nR+DPW9iPw4pLKH1bA1pln4GUyBbUY1UrCcklOyPAaNiU/vXJSHHNORtkWVPOCOxdLyiWP8mpsaN/amaJN1/6Nj2a1ieapge/paWGw+dyYwgAs72LqmZj3hnAsd94/kFRrKcwxlUEr0/iLxzCPDdw1DP+DPQkhiIKQbAK7Q/IFeY4udXUiN6jBjVdidCTJaWiXSy7vC45XgIEQCcSP3+YQwp2e2PaXuEFuClGYh+IUZsFt4qD7aiWCs/oz89UIzDnDqoAp+ju1ovwaWBhP6Xqq0N2mo0OnGrAlGk9xz8AvePCBsjerAs+/xuEOUvJXDLOeEuXZT2253CHLDRLwgINVUcnNC+fHBowR7auW3Ftg/X6eBup/+YycSXSqPzumDQ2CL0J/KY5trAV8dZtmWn7PNtlisF5gPlIp3oL0ASVrd4M6SAgT0EK18T0mgmx1Jk9h1INGj414SBuspdGM6gIShV9KMbS9WhWS0Yv0IW38GgrBNtuKLOBz4nbKmyAqrbCfCACwkMTGznbDYkeXXhJ49cwl1w378H14M9YJyupFLEfyvzwOXLe9eqiLB0QGM1McyvcHq64aJKj8MWxFi3twsnY/1D1jCJRhnWsCxYkwcz8tYZZSYGVC3kK5gMN9aKb02UeMhaih4/Yxi+vwQGt5nVMiAB9gaiKz0WXxh6agmuDmAb1VGoCgbh6D6F3poluc+ifumewte4fVEZH1wVucXaASOAkgRG8VfpFDW xbODNEzI HuAQlFGPUJSCYpnecIS61yYlwpJFqFI6+lt1L5Da7UBiEVRHftCGzmHIEneQCrrwEQxlfaJaym3XV3i6s6wM0AVGX5L5VsloIMsZ1u7rLb9CeTQkcbVp8ai73fLi9ZtlP0hvhJorsoZ6BatXiKqc5AiFW5+9nT0gQvRxmU4jHXKoD4yttShbGaFGycSb4lD1k3H+OvUHFlGCmb46e1Fk9k5MX1GNXy+zTMx93hgYvnfUc3lthDl/kJQ8ao/e89eRHxYPzaszylE1sLm0Lkga8AfcUZAK8y7UqjBsQThPpE73LbRgKSu48LQoafS5m2GTvN/jRZFvOBUX8JAFuCGTGdGMy1JpqslJBhTI4bV7TnU2G3+A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/18/25 12:49, Wei Yang wrote: > The second parameter of memblock_set_node() is size instead of end. > > Since it iterates from lower address to higher address, finally the node > id is correct. But during the process, some of them are wrong. > > Pass size instead of end. Makes sense. > > Fixes: 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") The commit is correct here which had introduced the problem. > Signed-off-by: Wei Yang > CC: Mike Rapoport > CC: Yajun Deng > CC: > --- > mm/memblock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 64ae678cd1d1..85442f1b7f14 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2192,7 +2192,7 @@ static void __init memmap_init_reserved_pages(void) > if (memblock_is_nomap(region)) > reserve_bootmem_region(start, end, nid); > > - memblock_set_node(start, end, &memblock.reserved, nid); > + memblock_set_node(start, region->size, &memblock.reserved, nid); > } > > /* Reviewed-by: Anshuman Khandual