From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3DAEC83038 for ; Tue, 1 Jul 2025 12:33:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58A7F6B00A4; Tue, 1 Jul 2025 08:33:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 562366B00A6; Tue, 1 Jul 2025 08:33:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 429A66B00AA; Tue, 1 Jul 2025 08:33:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3091E6B00A4 for ; Tue, 1 Jul 2025 08:33:06 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C93571A042A for ; Tue, 1 Jul 2025 12:33:05 +0000 (UTC) X-FDA: 83615635530.24.3294C42 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 63423180012 for ; Tue, 1 Jul 2025 12:33:03 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TIhj+MPG; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751373183; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OR91mEGkMa2yCFrvAiHztYA9Wztvn1Uq6wRsfBUeFUM=; b=Dlq2GPHOun+2cNy43wQvrGdb9SwG1ZNc+PcJX/bacy7crZth0XlCeEQ/Qle2WXS9NO/yZ5 KJLh4EOPOUB/O1MxUyqJyUO/HWy80z2c/eK2AKIc8ApB+tz00Sa9BUX7xAOo5mJssf+xrJ 4+Nj9euZdM0BLF6k4UEMJY5SKa9V6ts= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TIhj+MPG; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751373183; a=rsa-sha256; cv=none; b=vJi4VaqdB4pbdJlfejobLnXafI3ooPy4dm0O/YOAQbGnDi70X97kx8b3AP6/bi4kEA308u yOgcJtt5KQ2XUjlf774fR0s4bEZlItxb0WbVCE4GHZD0U9en/2wKLLUPDENkt3rEICHb9f Jlpg6+mr+JEzkyAD7GvYlkSZvRefnDA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751373182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OR91mEGkMa2yCFrvAiHztYA9Wztvn1Uq6wRsfBUeFUM=; b=TIhj+MPGL4NwUEgUbQaSH/NpVuZwYNMhMMDQSEevTPEr76MthAhKUxypuQMFiDBfJzLqRS lrLi9WKdkRGCgdljlqHjlMsIGwIHmQ/D29v+qhBrNVwZGAJzPGOJ/YLYQYdQhFGCrBJg5y UT25SpbbfIkrMuneY5JyGbLYwZu9D6I= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-223--cCXQSXGPYam2T4lZvRj3g-1; Tue, 01 Jul 2025 08:32:59 -0400 X-MC-Unique: -cCXQSXGPYam2T4lZvRj3g-1 X-Mimecast-MFC-AGG-ID: -cCXQSXGPYam2T4lZvRj3g_1751373178 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a6d90929d6so1262903f8f.2 for ; Tue, 01 Jul 2025 05:32:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751373178; x=1751977978; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=OR91mEGkMa2yCFrvAiHztYA9Wztvn1Uq6wRsfBUeFUM=; b=v+1Go5DjWrasbmzMFYGwFEfeApfEKayX3Nsv2RwjVjAGYdWkRbxvm1j8fRDUG4gBZc lqKQluhC7SvOCzjNEBYsbS8O91Yh3KRPJ3UP4IP6Ofis2Xj9B4uZfutF9s0SaLYeyzJW RcrYNh+6qxLd1uxRmk0UKRYWHrS5U3j5GVmNFYZghhgzEoIlZID2lgbjN6sW9OlZ6Ci4 DEcOrWDbhPZRYgpgwn/vLv3pEjITPjXPRd4fjg+9LVUzKeBMjthM/johwQRRqwiSId9g Xftp6wHBHriErpeXEPFUzx32rrrsAPlFHRzayuLuhyUaeoahFfh12IcU/4QfOH49AE2H WyRA== X-Forwarded-Encrypted: i=1; AJvYcCWD4h+YPz2SYcgOWnMGMlLEy09LcDzDxr/PSNaPY1pPX3IvauQiVLXfZKZAvXJzkZBGiU6hIHBHXA==@kvack.org X-Gm-Message-State: AOJu0YynP9Yz0MHszNNjX8lqKyyLwOn2/yHs+u+gu3oDHh+0XifgH1VS jnxpBaPpqVAvnXFsgpk18GLLCP3WYPddG9gZXaMXku4IaOffMS1offbclJOwSVgx7eD3q3fFhM2 CUGgCYcHrSDzDzJ5rY6oc0A4WskKKUnBw2hOTi5tezpZosHnneHyy X-Gm-Gg: ASbGncummlQaPejB6WELlfmyhA/aaqzodinYmp4+lS3I8q8Mze0wV2M+BeGAKGdirNx Tli9dY8sQ83SgL/YXSSrF1Nk2TQ991QKJh87z6YHhnmV8n9f7+AUlIF7MWjnNPn70mrVALvkmOY YXn0W0yJeG3v7ciCebQHxBkuUZbyjK1DkQaTCi28p/h/tk0HD9shlrGnoXmp2BJtd2TpdHKVkAc wUrghRcCv4/eVchUbAE6UGHY+ObpfYRZnlu1vhDs3E2Gb9wfoqnMwcxCQl+iMqAsWQ3fY9rZ3Fk ebUB2F1p0I3XMvgwM5A01qk0hpKwBy/ZhYYYL8p8csNbZit7CriC3ikTtPEyT8yVdZZ2/e/Iiut N1lAh1GhLT+2vUkeo1G2oBKHQNP5b0xOdBecPswRPBJrU4nnavA== X-Received: by 2002:a05:6000:290d:b0:3a4:e6d7:6160 with SMTP id ffacd0b85a97d-3a8f577fcbfmr16647743f8f.6.1751373178190; Tue, 01 Jul 2025 05:32:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFC873mhnHelwGYjy/m3rNK9Ibu2sC1O12YJHOM/HlS1eRR+SrB1I6GI5EE27+IZq8Evrx0mQ== X-Received: by 2002:a05:6000:290d:b0:3a4:e6d7:6160 with SMTP id ffacd0b85a97d-3a8f577fcbfmr16647677f8f.6.1751373177623; Tue, 01 Jul 2025 05:32:57 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a88c80b5aesm12986831f8f.44.2025.07.01.05.32.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 05:32:57 -0700 (PDT) Message-ID: Date: Tue, 1 Jul 2025 14:32:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 17/29] mm/page_isolation: drop __folio_test_movable() check for large folios To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-18-david@redhat.com> <58b36226-59ff-4d8b-a1f3-71170b42b795@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <58b36226-59ff-4d8b-a1f3-71170b42b795@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4_HFBpqF3c_svtBRHJuAr2Hn0MgSlhllAjJMSheyJtY_1751373178 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 63423180012 X-Stat-Signature: radazr3sfa118zhbc95qs8nasj5go9gk X-HE-Tag: 1751373183-926654 X-HE-Meta: U2FsdGVkX180s7XU/Caazb/1NxoQU0mj3vNo6TJ2JhrHxeRe7npTs1ktbgRUerIZVMp3IhdxrkfLX14DaG68nhwBzUJgJpf1gmKI6j1iOc8OwOtRfkfpUtHvhr4Esa6mi8QWblaw/gr2kT0FzFrP8ae1xonzu4e0GtZCGqbaha81JYlX4Vd0N2IkqzYCRVdvYU5dYSpvN4BroDfyWywOt+G0DED5lc8QivjJCxzc7Iprdb3qSXw7/V9BJNp+iIXZrow7XrDTTP0YI85vmIN1jjj0R/a0O9kKnPbASlcC0bi+Ja0UPmcUXStaakbbIOCoeS6UztRWcXfcymwGRd72XdIxS7gtkLtPt/rEwmSOcKydC1Vr16GfdDUZmm5ugT5cjkFabJm3m8x75sdakZ6ksywfo6TNQVrZJWW0Pe1jTKB1gsjYTnurISBAkjJXqJBhY5Zok07T+tHz6ohixRSHX8Z/Z2Zqg/raG9xhokrM5DmDXrgsty6ut4ykpSLTVg0LYliQWY1MdloArdmkxsYHrnRDdj4uB5jn7wGW+YrS3KVS2eGjNMVEp3BLL54Q2kmluB1xuSI7uma6foeE1uSYRJzEeJCjHNtPKQvDcMtG6gk4UPjN4YGVJoVRelKFqNuo71OZ7eMDuiQvsap8d0U55yMySeRCYnizJGs23lirF+yhlU3uoD2MeayM97L+seG7gPGhMTmySAJiIAvZb3M/zZB+n79AvcikxSz0QwqS583KUscSAIlEut+QoGK+JhxOsnENZ9hpz/DkDkMtl1Gw6kIG7h/p17xM0Vxl0Gy2HR0Owb8NWAx5RGI4gQD2j/YxYJQr3eTef5jLi1zRJ3ObKvNz8d1e0spxyvv5bg+r5ViHPJhENNNg/Cw5bC8K8b0oU3I2Z4IKZD/IQjQ8zEMqv49st/3jrgPJzOTZWnA83XJExT1RFYBqx7H0YzO6eKRnTMQjXfsCrDjmdVhWS/x Sted2ZPF YQMnDqXBLDpiN0ik472xbD+LLR0FkuYrwcl4xYKEkXtLmu+2nrLVrgG+jfIpzYlSj1/CzxRcZI1VALxEBsJvysoNkKSwjRAhOqYMXpCfKqowSNWzTOIDob2Fp9pfYs/aeTgmIjeN1WcEZna2qCVfCmmvVjLMuApS3Mt4yRmRqHgaAt8C3Z0QyJj5jjVr1fUBLLLu+YPh/A878Arh9tWez7N2CxZjXSJLJzp3mTtIjtqB1hTVl/Cw2DanB25Jti/MtlsStognR6VK8VZc2yBmfW0bfuKD5zVgfz0nKY4Yw9SkmEZAf1nWPw39mjb3HtQPP0O2qaRF+Bih5A9po6o8Ls07bGHkx/0A+k0KAayMSyyXXjtu7vAkkjT+pxsAlWpyI0JiX/0sJba4AIumA08i8GDKJqQV/V8JDI+a/QD+JsaMAnEyoxamtGva+4/ayzbQL64FcQyfZYMC6EwnmS5jwykkJjbOwmnU2pzcZ6ZqhEC6FTX5BuJ3sLHX9fHr72hRc3Sv8CSij5yIKp5R0A4DZwm00yZLKndC/5YT1501ZhmJRbjfzMSdwyY38B7XeyBBCDrpxmWV8rUgIbG3TJDtrlNiCZkItlo3y/t3KZzwd/84CGvU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.07.25 13:03, Lorenzo Stoakes wrote: > On Mon, Jun 30, 2025 at 02:59:58PM +0200, David Hildenbrand wrote: >> Currently, we only support migration of individual movable_ops pages, so >> we can not run into that. >> >> Reviewed-by: Zi Yan >> Signed-off-by: David Hildenbrand > > Seems sensible, so: > > Reviewed-by: Lorenzo Stoakes > > Maybe worth adding a VM_WARN_ON_ONCE() just in case? Or do you think not worth it? Not for now I think. Whoever wants to support compound pages has to fixup a bunch of other stuff first, before running into that one here. So a full audit of all paths that handle page_has_movable_ops() is required either way. -- Cheers, David / dhildenb