From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE07CD1292 for ; Thu, 4 Apr 2024 07:39:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A4326B0083; Thu, 4 Apr 2024 03:39:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2550F6B0087; Thu, 4 Apr 2024 03:39:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16AA26B0088; Thu, 4 Apr 2024 03:39:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EBFC26B0083 for ; Thu, 4 Apr 2024 03:39:46 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A071DA153C for ; Thu, 4 Apr 2024 07:39:46 +0000 (UTC) X-FDA: 81971049972.22.9C9BF69 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 1E223A000D for ; Thu, 4 Apr 2024 07:39:43 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf25.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712216384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fIbzfUEWlwfI0WHQfksmB5SjNeuQZ4qrfTbCuQqH7PI=; b=tei3px8pcywcoYe6wIGDRyEwOu4Fzo0jNBopO+sMUstM5UDPh4tKWMgy9C2FbLIHiqQblL w8NF6dBovRqDtlEMRIV4Hyph+qV9ftuvtjYcZnjaJVPnztuHY7v6WrNlzV8+2wG3BI7zYs SQ7vQdnNFoFZtoDzj71LgDi48wA4Kn0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf25.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712216384; a=rsa-sha256; cv=none; b=BzYBLiK4W2clWiPvlfS4quJxZwOAQ9NdPAxm5nl6EFy0cL+jN1hD6x247TFkxY26KNUf1V mvnfp1AyeIeeGeYwflSvqNJke2Kml4dFu8ja69LksCm9bYnENQ3W7i8ottTW2zo101vXBY A1zNoZkaJ22CnRxIeft9tdzoGxA0DOI= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 20CDD1007; Thu, 4 Apr 2024 00:40:14 -0700 (PDT) Received: from [10.57.72.245] (unknown [10.57.72.245]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 49FE73F64C; Thu, 4 Apr 2024 00:39:42 -0700 (PDT) Message-ID: Date: Thu, 4 Apr 2024 08:39:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fixup! selftests/mm: run_vmtests.sh: fix hugetlb mem size calculation Content-Language: en-GB To: peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton , Muhammad Usama Anjum , David Hildenbrand , Muchun Song References: <20240403200324.1603493-1-peterx@redhat.com> From: Ryan Roberts In-Reply-To: <20240403200324.1603493-1-peterx@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1E223A000D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: e1p49dffp3e17pkcu5qpbdn78ijk4iii X-HE-Tag: 1712216383-807461 X-HE-Meta: U2FsdGVkX1+sLPXGXBoGSF7/Rp385hoKG4VNTc85c/8U3lOFAdTVFMoRvRYGYDCia/33tdIu4KqN7EtbzhUbRPZHwQ3eeR9GEpcrERWcioJSOB5L9Hz66IoEQvn0N9qikvzRef8SCHLxCUKZbjzLdr1mmVt1XuuMpZ7SWV3NE+QX8Vcoau5IEZi9mjmS2uBby3AF8QGEJxTLcagDMhnuqJ6pR1kH2onAXG/06ntceJ82YdbAiwSpSDT+CzCTwq20CjzirIdjZF4T1gn6b09+Z3UqT+W7cfUtqheuxamXhN3nFN4r/ah3bEupk088JjroQ5IZ711tcmUz94KQi6l6ookzFa1oMXuLvEeMypoFjSuMzo7pg0rMhkBeGbF9JFSAx2OZUTgNGMmMASvdXTUjOcwByr1iZdbVl9RTXjbKFAmJU0mO4KUfss2B2SneXKGUFX0dm17HJyBwba4EjUU7Bty+aBj0KXoNhSrF0tQbrHZObNdD5fHjMAQA2J1fQRnbOE4ve+hm/GQ3bGatqsQu5SHUbr8llzRUrX9WDKQj4tTKG8pO590appEyC1G0Zk5xrO6w5kZtToiwkvjFaMV5uBQIZN9Szc+4Ynlxmfh0+4vldDzHckSV5cdzqvktQDjBABi8WsfJ4jzK48kNArNrJBBSvK3dkHh/uZI2lZdH6gAiQ4BGzub5VRJDIj8oTu+FbKSN8EhukhV2txyODBLimIFeUBHiy4WqtGlCVLhkPB2UgYxpYRzt92jaLmJ7cjW0ud9j7xoqOupPBmbPkY2jywH7uBuOFNG5fs1TvA+eij/Hj0jO/ldY85RLuHUgXj1R5evcGHwr1G2Wic3+OvE1aTfLsAFKT8zN5Fh8xlE++/2sCIApbQrEfZsugbPioi2nhEIRd2jyoA++HmH3fKmDNWgA2yyycAJ+o74q3SNmqFSBnhwC9773Ig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/04/2024 21:03, peterx@redhat.com wrote: > From: Peter Xu > > Fix up a breakage on uffd hugetlb test due to removal of a temp variable, > as reported by Ryan [1]. > > Instead of using the previous calculation, use the largest we can > have (which is put in freepgs) and cut it into half for userfault tests. > > [1] https://lore.kernel.org/r/1c20b717-c5b5-4bdf-8fcd-d46db135b7fa@arm.com > > Cc: Muhammad Usama Anjum > Cc: David Hildenbrand > Cc: Muchun Song > Reported-by: Ryan Roberts > Signed-off-by: Peter Xu All passing again for me: Tested-by: Ryan Roberts > --- > tools/testing/selftests/mm/run_vmtests.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index b1b78e45d613..223c2304f885 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -298,7 +298,8 @@ CATEGORY="userfaultfd" run_test ./uffd-unit-tests > uffd_stress_bin=./uffd-stress > CATEGORY="userfaultfd" run_test ${uffd_stress_bin} anon 20 16 > # Hugetlb tests require source and destination huge pages. Pass in half > -# the size ($half_ufd_size_MB), which is used for *each*. > +# the size of the free pages we have, which is used for *each*. > +half_ufd_size_MB=$((freepgs / 2)) > CATEGORY="userfaultfd" run_test ${uffd_stress_bin} hugetlb "$half_ufd_size_MB" 32 > CATEGORY="userfaultfd" run_test ${uffd_stress_bin} hugetlb-private "$half_ufd_size_MB" 32 > CATEGORY="userfaultfd" run_test ${uffd_stress_bin} shmem 20 16